WordPress-C
/
WordPress
mirror of https://github.com/WordPress/WordPress.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Sanitize order and orderby in get_terms() 

git-svn-id: http://svn.automattic.com/wordpress/trunk@18344 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commit is contained in:
ryan 2011-06-27 15:45:12 +00:00
parent d3fec0ea9a
commit 581402ae2f
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
wp-includes/taxonomy.php
View File

@ -1229,6 +1229,8 @@ function &get_terms($taxonomies, $args = '') {
$orderby = ''; $orderby = '';
elseif ( empty($_orderby) || 'id' == $_orderby ) elseif ( empty($_orderby) || 'id' == $_orderby )
$orderby = 't.term_id'; $orderby = 't.term_id';
else
$orderby = 't.name';
$orderby = apply_filters( 'get_terms_orderby', $orderby, $args ); $orderby = apply_filters( 'get_terms_orderby', $orderby, $args );
@ -1237,6 +1239,10 @@ function &get_terms($taxonomies, $args = '') {
else else
$order = ''; $order = '';
$order = strtoupper( $order );
if ( '' !== $order && !in_array( $order, array( 'ASC', 'DESC' ) ) )
$order = 'ASC';
$where = "tt.taxonomy IN ('" . implode("', '", $taxonomies) . "')"; $where = "tt.taxonomy IN ('" . implode("', '", $taxonomies) . "')";
$inclusions = ''; $inclusions = '';
if ( !empty($include) ) { if ( !empty($include) ) {