WordPress-C
/
WordPress
mirror of https://github.com/WordPress/WordPress.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Privacy: Ensure that exported user data reports can't be found with directory listings. 

By moving from `.html` to `.php` files, we can prevent directory listings, and ensure that WordPress can load.

Fixes #52299.

Props lucasbustamante, xkon, freewebmentor, SergeyBiryukov, whyisjake. 

Built from https://develop.svn.wordpress.org/trunk@50037


git-svn-id: http://core.svn.wordpress.org/trunk@49738 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commit is contained in:
whyisjake 2021-01-27 23:46:58 +00:00
parent ab6271c0a7
commit 5f532382aa
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
wp-admin/includes/privacy-tools.php
View File

@ -322,13 +322,13 @@ function wp_privacy_generate_personal_data_export_file( $request_id ) {
} }
// Protect export folder from browsing. // Protect export folder from browsing.
$index_pathname = $exports_dir . 'index.html'; $index_pathname = $exports_dir . 'index.php';
if ( ! file_exists( $index_pathname ) ) { if ( ! file_exists( $index_pathname ) ) {
$file = fopen( $index_pathname, 'w' ); $file = fopen( $index_pathname, 'w' );
if ( false === $file ) { if ( false === $file ) {
wp_send_json_error( __( 'Unable to protect personal data export folder from browsing.' ) ); wp_send_json_error( __( 'Unable to protect personal data export folder from browsing.' ) );
} }
fwrite( $file, '<!-- Silence is golden. -->' ); fwrite( $file, '<?php // Silence is golden.' );
fclose( $file ); fclose( $file );
} }

2
wp-includes/functions.php
View File

@ -7398,7 +7398,7 @@ function wp_privacy_delete_old_export_files() {
} }
require_once ABSPATH . 'wp-admin/includes/file.php'; require_once ABSPATH . 'wp-admin/includes/file.php';
$export_files = list_files( $exports_dir, 100, array( 'index.html' ) ); $export_files = list_files( $exports_dir, 100, array( 'index.php' ) );
/** /**
* Filters the lifetime, in seconds, of a personal data export file. * Filters the lifetime, in seconds, of a personal data export file.

2
wp-includes/version.php
View File

@ -13,7 +13,7 @@
* *
* @global string $wp_version * @global string $wp_version
*/ */
$wp_version = '5.7-alpha-50035'; $wp_version = '5.7-alpha-50037';
/** /**
* Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema. * Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.