JShint fixes for inline-edit-post.js.

props dougwollison.
fixes #26001.

Built from https://develop.svn.wordpress.org/trunk@26264


git-svn-id: http://core.svn.wordpress.org/trunk@26170 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commit is contained in:
Andrew Nacin 2013-11-19 04:32:10 +00:00
parent 0fc053528f
commit 6212b30ddd
2 changed files with 57 additions and 33 deletions

View File

@ -1,3 +1,6 @@
/* global inlineEditL10n, ajaxurl, typenow */
var inlineEditPost;
(function($) { (function($) {
inlineEditPost = { inlineEditPost = {
@ -9,12 +12,14 @@ inlineEditPost = {
// prepare the edit rows // prepare the edit rows
qeRow.keyup(function(e){ qeRow.keyup(function(e){
if (e.which == 27) if ( e.which === 27 ) {
return inlineEditPost.revert(); return inlineEditPost.revert();
}
}); });
bulkRow.keyup(function(e){ bulkRow.keyup(function(e){
if (e.which == 27) if ( e.which === 27 ) {
return inlineEditPost.revert(); return inlineEditPost.revert();
}
}); });
$('a.cancel', qeRow).click(function(){ $('a.cancel', qeRow).click(function(){
@ -24,8 +29,9 @@ inlineEditPost = {
return inlineEditPost.save(this); return inlineEditPost.save(this);
}); });
$('td', qeRow).keydown(function(e){ $('td', qeRow).keydown(function(e){
if ( e.which == 13 ) if ( e.which === 13 ) {
return inlineEditPost.save(this); return inlineEditPost.save(this);
}
}); });
$('a.cancel', bulkRow).click(function(){ $('a.cancel', bulkRow).click(function(){
@ -57,7 +63,7 @@ inlineEditPost = {
$('#doaction, #doaction2').click(function(e){ $('#doaction, #doaction2').click(function(e){
var n = $(this).attr('id').substr(2); var n = $(this).attr('id').substr(2);
if ( $('select[name="'+n+'"]').val() == 'edit' ) { if ( 'edit' === $( 'select[name="' + n + '"]' ).val() ) {
e.preventDefault(); e.preventDefault();
t.setBulk(); t.setBulk();
} else if ( $('form#posts-filter tr.inline-editor').length > 0 ) { } else if ( $('form#posts-filter tr.inline-editor').length > 0 ) {
@ -68,7 +74,7 @@ inlineEditPost = {
toggle : function(el){ toggle : function(el){
var t = this; var t = this;
$(t.what+t.getId(el)).css('display') == 'none' ? t.revert() : t.edit(el); $( t.what + t.getId( el ) ).css( 'display' ) === 'none' ? t.revert() : t.edit( el );
}, },
setBulk : function(){ setBulk : function(){
@ -79,7 +85,7 @@ inlineEditPost = {
$('table.widefat tbody').prepend( $('#bulk-edit') ); $('table.widefat tbody').prepend( $('#bulk-edit') );
$('#bulk-edit').addClass('inline-editor').show(); $('#bulk-edit').addClass('inline-editor').show();
$('tbody th.check-column input[type="checkbox"]').each(function(i){ $( 'tbody th.check-column input[type="checkbox"]' ).each( function() {
if ( $(this).prop('checked') ) { if ( $(this).prop('checked') ) {
c = false; c = false;
var id = $(this).val(), theTitle; var id = $(this).val(), theTitle;
@ -88,8 +94,9 @@ inlineEditPost = {
} }
}); });
if ( c ) if ( c ) {
return this.revert(); return this.revert();
}
$('#bulk-titles').html(te); $('#bulk-titles').html(te);
$('#bulk-titles a').click(function(){ $('#bulk-titles a').click(function(){
@ -100,7 +107,7 @@ inlineEditPost = {
}); });
// enable autocomplete for tags // enable autocomplete for tags
if ( 'post' == type ) { if ( 'post' === type ) {
// support multi taxonomies? // support multi taxonomies?
tax = 'post_tag'; tax = 'post_tag';
$('tr.inline-editor textarea[name="tax_input['+tax+']"]').suggest( ajaxurl + '?action=ajax-tag-search&tax=' + tax, { delay: 500, minchars: 2, multiple: true, multipleSep: inlineEditL10n.comma + ' ' } ); $('tr.inline-editor textarea[name="tax_input['+tax+']"]').suggest( ajaxurl + '?action=ajax-tag-search&tax=' + tax, { delay: 500, minchars: 2, multiple: true, multipleSep: inlineEditL10n.comma + ' ' } );
@ -112,19 +119,22 @@ inlineEditPost = {
var t = this, fields, editRow, rowData, status, pageOpt, pageLevel, nextPage, pageLoop = true, nextLevel, cur_format, f; var t = this, fields, editRow, rowData, status, pageOpt, pageLevel, nextPage, pageLoop = true, nextLevel, cur_format, f;
t.revert(); t.revert();
if ( typeof(id) == 'object' ) if ( typeof(id) === 'object' ) {
id = t.getId(id); id = t.getId(id);
}
fields = ['post_title', 'post_name', 'post_author', '_status', 'jj', 'mm', 'aa', 'hh', 'mn', 'ss', 'post_password', 'post_format', 'menu_order']; fields = ['post_title', 'post_name', 'post_author', '_status', 'jj', 'mm', 'aa', 'hh', 'mn', 'ss', 'post_password', 'post_format', 'menu_order'];
if ( t.type == 'page' ) if ( t.type === 'page' ) {
fields.push('post_parent', 'page_template'); fields.push('post_parent', 'page_template');
}
// add the new blank row // add the new blank row
editRow = $('#inline-edit').clone(true); editRow = $('#inline-edit').clone(true);
$('td', editRow).attr('colspan', $('.widefat:first thead th:visible').length); $('td', editRow).attr('colspan', $('.widefat:first thead th:visible').length);
if ( $(t.what+id).hasClass('alternate') ) if ( $( t.what + id ).hasClass( 'alternate' ) ) {
$(editRow).addClass('alternate'); $(editRow).addClass('alternate');
}
$(t.what+id).hide().after(editRow); $(t.what+id).hide().after(editRow);
// populate the data // populate the data
@ -133,7 +143,7 @@ inlineEditPost = {
// author no longer has edit caps, so we need to add them to the list of authors // author no longer has edit caps, so we need to add them to the list of authors
$(':input[name="post_author"]', editRow).prepend('<option value="' + $('.post_author', rowData).text() + '">' + $('#' + t.type + '-' + id + ' .author').text() + '</option>'); $(':input[name="post_author"]', editRow).prepend('<option value="' + $('.post_author', rowData).text() + '">' + $('#' + t.type + '-' + id + ' .author').text() + '</option>');
} }
if ( $(':input[name="post_author"] option', editRow).length == 1 ) { if ( $( ':input[name="post_author"] option', editRow ).length === 1 ) {
$('label.inline-edit-author', editRow).hide(); $('label.inline-edit-author', editRow).hide();
} }
@ -141,24 +151,29 @@ inlineEditPost = {
cur_format = $('.post_format', rowData).text(); cur_format = $('.post_format', rowData).text();
$('option.unsupported', editRow).each(function() { $('option.unsupported', editRow).each(function() {
var $this = $(this); var $this = $(this);
if ( $this.val() != cur_format ) if ( $this.val() !== cur_format ) {
$this.remove(); $this.remove();
}
}); });
for ( f = 0; f < fields.length; f++ ) { for ( f = 0; f < fields.length; f++ ) {
$(':input[name="' + fields[f] + '"]', editRow).val( $('.'+fields[f], rowData).text() ); $(':input[name="' + fields[f] + '"]', editRow).val( $('.'+fields[f], rowData).text() );
} }
if ( $('.comment_status', rowData).text() == 'open' ) if ( $( '.comment_status', rowData ).text() === 'open' ) {
$('input[name="comment_status"]', editRow).prop("checked", true); $( 'input[name="comment_status"]', editRow ).prop( 'checked', true );
if ( $('.ping_status', rowData).text() == 'open' ) }
$('input[name="ping_status"]', editRow).prop("checked", true); if ( $( '.ping_status', rowData ).text() === 'open' ) {
if ( $('.sticky', rowData).text() == 'sticky' ) $( 'input[name="ping_status"]', editRow ).prop( 'checked', true );
$('input[name="sticky"]', editRow).prop("checked", true); }
if ( $( '.sticky', rowData ).text() === 'sticky' ) {
$( 'input[name="sticky"]', editRow ).prop( 'checked', true );
}
// hierarchical taxonomies // hierarchical taxonomies
$('.post_category', rowData).each(function(){ $('.post_category', rowData).each(function(){
var term_ids = $(this).text(); var taxname,
term_ids = $(this).text();
if ( term_ids ) { if ( term_ids ) {
taxname = $(this).attr('id').replace('_'+id, ''); taxname = $(this).attr('id').replace('_'+id, '');
@ -174,8 +189,9 @@ inlineEditPost = {
comma = inlineEditL10n.comma; comma = inlineEditL10n.comma;
if ( terms ) { if ( terms ) {
if ( ',' !== comma ) if ( ',' !== comma ) {
terms = terms.replace(/,/g, comma); terms = terms.replace(/,/g, comma);
}
textarea.val(terms); textarea.val(terms);
} }
@ -184,11 +200,12 @@ inlineEditPost = {
// handle the post status // handle the post status
status = $('._status', rowData).text(); status = $('._status', rowData).text();
if ( 'future' != status ) if ( 'future' !== status ) {
$('select[name="_status"] option[value="future"]', editRow).remove(); $('select[name="_status"] option[value="future"]', editRow).remove();
}
if ( 'private' == status ) { if ( 'private' === status ) {
$('input[name="keep_private"]', editRow).prop("checked", true); $('input[name="keep_private"]', editRow).prop('checked', true);
$('input.inline-edit-password-input').val('').prop('disabled', true); $('input.inline-edit-password-input').val('').prop('disabled', true);
} }
@ -199,8 +216,12 @@ inlineEditPost = {
nextPage = pageOpt; nextPage = pageOpt;
while ( pageLoop ) { while ( pageLoop ) {
nextPage = nextPage.next('option'); nextPage = nextPage.next('option');
if (nextPage.length == 0) break; if ( nextPage.length === 0 ) {
break;
}
nextLevel = nextPage[0].className.split('-')[1]; nextLevel = nextPage[0].className.split('-')[1];
if ( nextLevel <= pageLevel ) { if ( nextLevel <= pageLevel ) {
pageLoop = false; pageLoop = false;
} else { } else {
@ -220,8 +241,9 @@ inlineEditPost = {
save : function(id) { save : function(id) {
var params, fields, page = $('.post_status_page').val() || ''; var params, fields, page = $('.post_status_page').val() || '';
if ( typeof(id) == 'object' ) if ( typeof(id) === 'object' ) {
id = this.getId(id); id = this.getId(id);
}
$('table.widefat .spinner').show(); $('table.widefat .spinner').show();
@ -242,7 +264,7 @@ inlineEditPost = {
$('table.widefat .spinner').hide(); $('table.widefat .spinner').hide();
if (r) { if (r) {
if ( -1 != r.indexOf('<tr') ) { if ( -1 !== r.indexOf( '<tr' ) ) {
$(inlineEditPost.what+id).remove(); $(inlineEditPost.what+id).remove();
$('#edit-'+id).before(r).remove(); $('#edit-'+id).before(r).remove();
$(inlineEditPost.what+id).hide().fadeIn(); $(inlineEditPost.what+id).hide().fadeIn();
@ -257,8 +279,8 @@ inlineEditPost = {
if ( $('#post-'+id).prev().hasClass('alternate') ) { if ( $('#post-'+id).prev().hasClass('alternate') ) {
$('#post-'+id).removeClass('alternate'); $('#post-'+id).removeClass('alternate');
} }
} },
, 'html'); 'html');
return false; return false;
}, },
@ -268,7 +290,7 @@ inlineEditPost = {
if ( id ) { if ( id ) {
$('table.widefat .spinner').hide(); $('table.widefat .spinner').hide();
if ( 'bulk-edit' == id ) { if ( 'bulk-edit' === id ) {
$('table.widefat #bulk-edit').removeClass('inline-editor').hide(); $('table.widefat #bulk-edit').removeClass('inline-editor').hide();
$('#bulk-titles').html(''); $('#bulk-titles').html('');
$('#inlineedit').append( $('#bulk-edit') ); $('#inlineedit').append( $('#bulk-edit') );
@ -319,12 +341,14 @@ $( document ).on( 'heartbeat-tick.wp-check-locked-posts', function( e, data ) {
var check = []; var check = [];
$('#the-list tr').each( function(i, el) { $('#the-list tr').each( function(i, el) {
if ( el.id ) if ( el.id ) {
check.push( el.id ); check.push( el.id );
}
}); });
if ( check.length ) if ( check.length ) {
data['wp-check-locked-posts'] = check; data['wp-check-locked-posts'] = check;
}
}).ready( function() { }).ready( function() {
// Set the heartbeat interval to 15 sec. // Set the heartbeat interval to 15 sec.
if ( typeof wp !== 'undefined' && wp.heartbeat ) { if ( typeof wp !== 'undefined' && wp.heartbeat ) {

File diff suppressed because one or more lines are too long