From 69ca1a8227f56b59e0090a9d1176f53888a898b0 Mon Sep 17 00:00:00 2001 From: Sergey Biryukov Date: Mon, 7 Jan 2019 16:02:44 +0000 Subject: [PATCH] Twenty Nineteen: Remove transparency from submenus. On pages and posts with featured images, the top level menu items have a slight transparency on hover, which was being inherited by their submenus. This update removes that inheritance, improving readability and consistency in the menu's appearance. Props kjellr. Merges [44368] to the 5.0 branch. Fixes #45689. Built from https://develop.svn.wordpress.org/branches/5.0@44427 git-svn-id: http://core.svn.wordpress.org/branches/5.0@44257 1a063a9b-81f0-0310-95a4-ce76da25c4cd --- .../sass/navigation/_menu-main-navigation.scss | 1 + .../sass/site/header/_site-featured-image.scss | 4 ++++ wp-content/themes/twentynineteen/style-rtl.css | 5 +++++ wp-content/themes/twentynineteen/style.css | 5 +++++ wp-includes/version.php | 2 +- 5 files changed, 16 insertions(+), 1 deletion(-) diff --git a/wp-content/themes/twentynineteen/sass/navigation/_menu-main-navigation.scss b/wp-content/themes/twentynineteen/sass/navigation/_menu-main-navigation.scss index e2bc99bb4c..61d943a774 100644 --- a/wp-content/themes/twentynineteen/sass/navigation/_menu-main-navigation.scss +++ b/wp-content/themes/twentynineteen/sass/navigation/_menu-main-navigation.scss @@ -202,6 +202,7 @@ color: $color__background-body; display: block; line-height: $font__line-height-heading; + text-shadow: none; padding: calc( .5 * #{$size__spacing-unit} ) calc( 24px + #{$size__spacing-unit} ) calc( .5 * #{$size__spacing-unit} ) $size__spacing-unit; white-space: nowrap; diff --git a/wp-content/themes/twentynineteen/sass/site/header/_site-featured-image.scss b/wp-content/themes/twentynineteen/sass/site/header/_site-featured-image.scss index 45ed4182c3..125994384c 100644 --- a/wp-content/themes/twentynineteen/sass/site/header/_site-featured-image.scss +++ b/wp-content/themes/twentynineteen/sass/site/header/_site-featured-image.scss @@ -45,6 +45,10 @@ } } + .main-navigation .sub-menu a { + opacity: inherit; + } + /* add focus state to social media icons */ .social-navigation a { &:focus { diff --git a/wp-content/themes/twentynineteen/style-rtl.css b/wp-content/themes/twentynineteen/style-rtl.css index f79315c43b..96b35277d1 100644 --- a/wp-content/themes/twentynineteen/style-rtl.css +++ b/wp-content/themes/twentynineteen/style-rtl.css @@ -1221,6 +1221,7 @@ body.page .main-navigation { color: #fff; display: block; line-height: 1.2; + text-shadow: none; padding: calc( .5 * 1rem) 1rem calc( .5 * 1rem) calc( 24px + 1rem); white-space: nowrap; } @@ -2195,6 +2196,10 @@ body.page .main-navigation { color: #fff; } +.site-header.featured-image .main-navigation .sub-menu a { + opacity: inherit; +} + .site-header.featured-image .social-navigation a:focus { color: #fff; opacity: 1; diff --git a/wp-content/themes/twentynineteen/style.css b/wp-content/themes/twentynineteen/style.css index a803fad401..6dd78f0616 100644 --- a/wp-content/themes/twentynineteen/style.css +++ b/wp-content/themes/twentynineteen/style.css @@ -1221,6 +1221,7 @@ body.page .main-navigation { color: #fff; display: block; line-height: 1.2; + text-shadow: none; padding: calc( .5 * 1rem) calc( 24px + 1rem) calc( .5 * 1rem) 1rem; white-space: nowrap; } @@ -2201,6 +2202,10 @@ body.page .main-navigation { color: #fff; } +.site-header.featured-image .main-navigation .sub-menu a { + opacity: inherit; +} + .site-header.featured-image .social-navigation a:focus { color: #fff; opacity: 1; diff --git a/wp-includes/version.php b/wp-includes/version.php index 802befb767..938ecdf97f 100644 --- a/wp-includes/version.php +++ b/wp-includes/version.php @@ -4,7 +4,7 @@ * * @global string $wp_version */ -$wp_version = '5.0.3-alpha-44426'; +$wp_version = '5.0.3-alpha-44427'; /** * Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.