From 6f44e96d7080b69f7d58c344a45de9efba21c711 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Helen=20Hou-Sand=C3=AD?= <helen.y.hou@gmail.com>
Date: Thu, 24 Jul 2014 18:04:18 +0000
Subject: [PATCH] Set default values for attachment meta and ID3 data when
 preparing for JS to avoid errors in rendering templates. props ericmann for
 the initial patch. fixes #29013.

Built from https://develop.svn.wordpress.org/trunk@29281


git-svn-id: http://core.svn.wordpress.org/trunk@29063 1a063a9b-81f0-0310-95a4-ce76da25c4cd
---
 wp-includes/media-template.php | 2 +-
 wp-includes/media.php          | 3 +++
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/wp-includes/media-template.php b/wp-includes/media-template.php
index c679cc011b..c3f78d780c 100644
--- a/wp-includes/media-template.php
+++ b/wp-includes/media-template.php
@@ -325,7 +325,7 @@ function wp_print_media_templates() {
 					<div class="file-length"><strong><?php _e( 'Length:' ); ?></strong> {{ data.fileLength }}</div>
 				<# } #>
 
-				<# if ( 'audio' === data.type && data.meta && data.meta.bitrate ) { #>
+				<# if ( 'audio' === data.type && data.meta.bitrate ) { #>
 					<div class="bitrate">
 						<strong><?php _e( 'Bitrate:' ); ?></strong> {{ Math.round( data.meta.bitrate / 1000 ) }}kb/s
 						<# if ( data.meta.bitrate_mode ) { #>
diff --git a/wp-includes/media.php b/wp-includes/media.php
index cd32ae1c6c..b4f24e6cf0 100644
--- a/wp-includes/media.php
+++ b/wp-includes/media.php
@@ -2628,6 +2628,7 @@ function wp_prepare_attachment_for_js( $attachment ) {
 			'edit'   => false
 		),
 		'editLink'   => false,
+		'meta'       => false,
 	);
 
 	$author = new WP_User( $attachment->post_author );
@@ -2725,6 +2726,8 @@ function wp_prepare_attachment_for_js( $attachment ) {
 
 		$response['meta'] = array();
 		foreach ( wp_get_attachment_id3_keys( $attachment, 'js' ) as $key => $label ) {
+			$response['meta'][ $key ] = false;
+
 			if ( ! empty( $meta[ $key ] ) ) {
 				$response['meta'][ $key ] = $meta[ $key ];
 			}