WordPress-C/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2025-03-09 07:00:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add extra error checking to the Plugin Browser and Plugin API function. Fixes #11640

Browse Source 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12742 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commit is contained in:
dd32 2010-01-17 03:26:50 +00:00
parent fc2c5fd21b
commit 72ffe9d28b
1 changed files with 13 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
wp-admin/includes/plugin-install.php
View File

@ -24,7 +24,7 @@
* *
* @param string $action * @param string $action
* @param array|object $args Optional. Arguments to serialize for the Plugin Info API. * @param array|object $args Optional. Arguments to serialize for the Plugin Info API.
* @return mixed * @return object plugins_api response object on success, WP_Error on failure.
*/ */
function plugins_api($action, $args = null) { function plugins_api($action, $args = null) {
@ -34,16 +34,19 @@ function plugins_api($action, $args = null) {
if ( !isset($args->per_page) ) if ( !isset($args->per_page) )
$args->per_page = 24; $args->per_page = 24;
$args = apply_filters('plugins_api_args', $args, $action); //NOTE: Ensure that an object is returned via this filter. // Allows a plugin to override the WordPress.org API entirely.
$res = apply_filters('plugins_api', false, $action, $args); //NOTE: Allows a plugin to completely override the builtin WordPress.org API. // Use the filter 'plugins_api_result' to mearly add results.
// Please ensure that a object is returned from the following filters.
$args = apply_filters('plugins_api_args', $args, $action);
$res = apply_filters('plugins_api', false, $action, $args);
if ( ! $res ) { if ( false === $res ) {
$request = wp_remote_post('http://api.wordpress.org/plugins/info/1.0/', array( 'body' => array('action' => $action, 'request' => serialize($args))) ); $request = wp_remote_post('http://api.wordpress.org/plugins/info/1.0/', array( 'timeout' => 15, 'body' => array('action' => $action, 'request' => serialize($args))) );
if ( is_wp_error($request) ) { if ( is_wp_error($request) ) {
$res = new WP_Error('plugins_api_failed', __('An Unexpected HTTP Error occurred during the API request.</p> <p><a href="?" onclick="document.location.reload(); return false;">Try again</a>'), $request->get_error_message() ); $res = new WP_Error('plugins_api_failed', __('An Unexpected HTTP Error occurred during the API request.</p> <p><a href="?" onclick="document.location.reload(); return false;">Try again</a>'), $request->get_error_message() );
} else { } else {
$res = unserialize($request['body']); $res = unserialize($request['body']);
if ( ! $res ) if ( false === $res )
$res = new WP_Error('plugins_api_failed', __('An unknown error occurred'), $request['body']); $res = new WP_Error('plugins_api_failed', __('An unknown error occurred'), $request['body']);
} }
} elseif ( !is_wp_error($res) ) { } elseif ( !is_wp_error($res) ) {
@ -197,6 +200,8 @@ add_action('install_plugins_popular', 'install_popular', 10, 1);
function install_popular($page = 1) { function install_popular($page = 1) {
$args = array('browse' => 'popular', 'page' => $page); $args = array('browse' => 'popular', 'page' => $page);
$api = plugins_api('query_plugins', $args); $api = plugins_api('query_plugins', $args);
if ( is_wp_error($api) )
wp_die($api);
display_plugins_table($api->plugins, $api->info['page'], $api->info['pages']); display_plugins_table($api->plugins, $api->info['page'], $api->info['pages']);
} }
@ -248,6 +253,8 @@ add_action('install_plugins_updated', 'install_updated', 10, 1);
function install_updated($page = 1) { function install_updated($page = 1) {
$args = array('browse' => 'updated', 'page' => $page); $args = array('browse' => 'updated', 'page' => $page);
$api = plugins_api('query_plugins', $args); $api = plugins_api('query_plugins', $args);
if ( is_wp_error($api) )
wp_die($api);
display_plugins_table($api->plugins, $api->info['page'], $api->info['pages']); display_plugins_table($api->plugins, $api->info['page'], $api->info['pages']);
} }