From 76c25aa14bbb5816bc4eeb54faf39c2d625a3fa6 Mon Sep 17 00:00:00 2001 From: Felix Arntz Date: Thu, 28 Jun 2018 02:45:03 +0000 Subject: [PATCH] Multisite: Count users in a more performant way when listing sites in the network admin. Props spacedmonkey. Fixes #44368. Built from https://develop.svn.wordpress.org/trunk@43382 git-svn-id: http://core.svn.wordpress.org/trunk@43210 1a063a9b-81f0-0310-95a4-ce76da25c4cd --- .../includes/class-wp-ms-sites-list-table.php | 15 +++++++-------- wp-includes/version.php | 2 +- 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/wp-admin/includes/class-wp-ms-sites-list-table.php b/wp-admin/includes/class-wp-ms-sites-list-table.php index 5caa62c611..0cfef5b27c 100644 --- a/wp-admin/includes/class-wp-ms-sites-list-table.php +++ b/wp-admin/includes/class-wp-ms-sites-list-table.php @@ -406,14 +406,13 @@ class WP_MS_Sites_List_Table extends WP_List_Table { public function column_users( $blog ) { $user_count = wp_cache_get( $blog['blog_id'] . '_user_count', 'blog-details' ); if ( ! $user_count ) { - $blog_users = get_users( - array( - 'blog_id' => $blog['blog_id'], - 'fields' => 'ID', - ) - ); - $user_count = count( $blog_users ); - unset( $blog_users ); + $blog_users = new WP_User_Query( array( + 'blog_id' => $blog['blog_id'], + 'fields' => 'ID', + 'number' => 1, + 'count_total' => true, + ) ); + $user_count = $blog_users->get_total(); wp_cache_set( $blog['blog_id'] . '_user_count', $user_count, 'blog-details', 12 * HOUR_IN_SECONDS ); } diff --git a/wp-includes/version.php b/wp-includes/version.php index 46d290704b..6629782646 100644 --- a/wp-includes/version.php +++ b/wp-includes/version.php @@ -4,7 +4,7 @@ * * @global string $wp_version */ -$wp_version = '5.0-alpha-43381'; +$wp_version = '5.0-alpha-43382'; /** * Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.