From 86494259065cf9d45eb1db2a76e15140368f8886 Mon Sep 17 00:00:00 2001 From: Andrew Nacin Date: Thu, 1 May 2014 04:43:16 +0000 Subject: [PATCH] TinyMCE: fix the "active" state of the Link button when an image wrapped in a link is selected. Merges [28185] to the 3.9 branch. props azaozz. fixes #27847. Built from https://develop.svn.wordpress.org/branches/3.9@28232 git-svn-id: http://core.svn.wordpress.org/branches/3.9@28060 1a063a9b-81f0-0310-95a4-ce76da25c4cd --- .../js/tinymce/plugins/wplink/plugin.js | 6 ++++-- .../js/tinymce/plugins/wplink/plugin.min.js | 2 +- wp-includes/js/tinymce/wp-tinymce.js.gz | Bin 122922 -> 122927 bytes 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/wp-includes/js/tinymce/plugins/wplink/plugin.js b/wp-includes/js/tinymce/plugins/wplink/plugin.js index 1d6820a12b..d992360b86 100644 --- a/wp-includes/js/tinymce/plugins/wplink/plugin.js +++ b/wp-includes/js/tinymce/plugins/wplink/plugin.js @@ -15,8 +15,10 @@ tinymce.PluginManager.add( 'wplink', function( editor ) { editor.addShortcut( 'ctrl+k', '', 'WP_Link' ); function setState( button, node ) { - button.disabled( editor.selection.isCollapsed() && node.nodeName !== 'A' ); - button.active( node.nodeName === 'A' && ! node.name ); + var parent = editor.dom.getParent( node, 'a' ); + + button.disabled( ( editor.selection.isCollapsed() && ! parent ) || ( parent && ! parent.href ) ); + button.active( parent && parent.href ); } editor.addButton( 'link', { diff --git a/wp-includes/js/tinymce/plugins/wplink/plugin.min.js b/wp-includes/js/tinymce/plugins/wplink/plugin.min.js index af8751d289..dc282b9f3c 100644 --- a/wp-includes/js/tinymce/plugins/wplink/plugin.min.js +++ b/wp-includes/js/tinymce/plugins/wplink/plugin.min.js @@ -1 +1 @@ -tinymce.PluginManager.add("wplink",function(a){function b(b,c){b.disabled(a.selection.isCollapsed()&&"A"!==c.nodeName),b.active("A"===c.nodeName&&!c.name)}var c;a.addCommand("WP_Link",function(){c&&c.disabled()||"undefined"==typeof window.wpLink||window.wpLink.open(a.id)}),a.addShortcut("alt+shift+a","","WP_Link"),a.addShortcut("ctrl+k","","WP_Link"),a.addButton("link",{icon:"link",tooltip:"Insert/edit link",shortcut:"Alt+Shift+A",cmd:"WP_Link",onPostRender:function(){c=this,a.on("nodechange",function(a){b(c,a.element)})}}),a.addButton("unlink",{icon:"unlink",tooltip:"Remove link",cmd:"unlink",onPostRender:function(){var c=this;a.on("nodechange",function(a){b(c,a.element)})}}),a.addMenuItem("link",{icon:"link",text:"Insert link",shortcut:"Alt+Shift+A",cmd:"WP_Link",stateSelector:"a[href]",context:"insert",prependToContext:!0})}); \ No newline at end of file +tinymce.PluginManager.add("wplink",function(a){function b(b,c){var d=a.dom.getParent(c,"a");b.disabled(a.selection.isCollapsed()&&!d||d&&!d.href),b.active(d&&d.href)}var c;a.addCommand("WP_Link",function(){c&&c.disabled()||"undefined"==typeof window.wpLink||window.wpLink.open(a.id)}),a.addShortcut("alt+shift+a","","WP_Link"),a.addShortcut("ctrl+k","","WP_Link"),a.addButton("link",{icon:"link",tooltip:"Insert/edit link",shortcut:"Alt+Shift+A",cmd:"WP_Link",onPostRender:function(){c=this,a.on("nodechange",function(a){b(c,a.element)})}}),a.addButton("unlink",{icon:"unlink",tooltip:"Remove link",cmd:"unlink",onPostRender:function(){var c=this;a.on("nodechange",function(a){b(c,a.element)})}}),a.addMenuItem("link",{icon:"link",text:"Insert link",shortcut:"Alt+Shift+A",cmd:"WP_Link",stateSelector:"a[href]",context:"insert",prependToContext:!0})}); \ No newline at end of file diff --git a/wp-includes/js/tinymce/wp-tinymce.js.gz b/wp-includes/js/tinymce/wp-tinymce.js.gz index 814b05e57f09f6ca02757afb0e4d0ab58c614e02..6b291926366fb7062dedf44c6209e8cc940fc627 100644 GIT binary patch delta 1639 zcmV-t2AKJ(zz46u2Y|Ezc-em+S{ErUM?YkH0q7Tra#P|gg{*j~)EpDI!q`hTn*={C z*ja#qQt0&XYa?N|q9MAq?0$0V7kq~GZCNNRNNbQp3^F{D8~1ebS_AA_M>NF-G3ci{ zyd*&kx~h$&Nh;}EF4ik4}d%T*dG$wp#@4v5}}IkQEac%9?h@ZXgqI~38d zBz$Sh^@Iv2*Z;6r>edeF*nyh&!^xkLP~!%O|7hB1Jf;mT8$Y(b|I&K+RZ69wk8WTe;xM5u>5hLPox3}9LsY$u8{=)& zYHzh%r?AszTd;vE$RARG1*lF{;M;QQl>tXcQa&uG zQ&}0ZKYCl)zVzH6eK%zvPp%GjYr8Y1BJ^#o=UmSLtSU;CZWI2H`Zt(gZ5XO@T;?TX zHnqnLBg#gHmg;{w%u0CwV9bcfR!JB|p0;9OGOOoRj2dXDEi(uY3hK7u9eg&+_A}^@ z&eis_cibH~W_-7XU*%Xme^O@^&Ju zayWS^Y#`DSM{q~M3azB;WVB?;fo36P1q`;$W{*{}0_D2RQpfjG?g-f}*cd-yukp53 zhUiP$GUtEY*Y+da5AIfJ8MvrSf{jsDXKIVbXVJ7OIxVHno6VK|a@6&py;ysxRk@Ng z7j-_604$$w6M8j$A)1&h5dR=C?#!k#*q?%%Pi zV|wY1X{`;3qa4<~cga}OAOaA1$?bP>k+3(mZNxSk>U29G5Y<#8V3(s5paGnT=V<|p zeFHw?j;8q!vDVzpFm$u00Z%!AeXQx@XoP3m;Ow5&DL&;C|M_X9ZEdW^b_b>6z1ldm z8vcKdjlo3FIu!L7rsg79pKgsB-7>A;SgMa15n9?~bCU|~Qz1G}BIx5`N=+buQfqxr zUsSsIW$QdVN2@lNhjxrmd#@CGZ$5TYXS`|Ws=^o)FtT*ZNs&2 zi$yRF*>{wWW4}r!@2G-jA#~8%Z^S(Zv?C%u!$R$VQBMg}H{4QH+08fD(xyvXi{oz{$>TG-WmaDrxyZB{)mvO)1s7N^xvd45>X)Fyj_0ZyV>A65jzR zf55S+(tl;5M9WMV<+!4~I|)a$u`$kj5R|G=#HAXhDX7z2GJ2k=nKZhNJe$OF^dW_r zJj!$l)gLp$^j)QaQKf;9wuHFRhF8-^robDGz lnUOmQoUW-R7bPX-z8B|XCk+ehZ3Hc){~t2iT^xs=1pxUoFZcie delta 1618 zcmV-Y2Cez8zz3?p2Y|Ezc-eoC?Q76d`b&v3+q2@O(qv5F?ZSH@mLf)GL0poCpnp*n zlI#t|_1vwfg>J32pWI3XpJ8%aRs&|EHSi$@4j##kPda(6L36F6lwt!D^iv&3lE4IA z)ke~ElysaNy?`>Lght?LMk1x3+sO<=qxhD(7Qs8yTgBpb0^jaXqZq{ z!cPH0=_>12Q|WiSKdJh1#dMTi^^yh5u6+Jt-AZz>t~+hi)i3DA3i52+htbb@4KgZR z{ZgYow+tv91|pNiV3b$R^>)S`#ka*ulcS-C=aU zzu!I^NZE(i%Xo1%(1w4BmOY%yN*dD0hF^u^hu(cTvqhYEo#Wf^-xVG^WYDmrc4?pW zu$wN4jUgSjI~0FHRK1Pw;%$9uZ?#;f zFwSNJuz@SRA5wsYqE1!dD{|_U0Y^wuK0K)82H)#ubNS67fgGFo(}%{dxhSsFQyH=o zdRxQ3bk`t#H)Y38uHtoTyECRD>20m&T+abaDM~$V6aJ9;H<(Fn7*cXv<|Sh`wZ{x2 z%9e(fzBz13c>jN3poqxULl{M#HeF!as^?WK8EB|2+XoL?>9(~U95u`KGw6@b)%LS@ z+#NW!d$)#38!hcB?FaXI zKcyexpp07Hn&QzAe=u?OtvKcb)E;Vllz)-HoXKA!l$DCN(07HNnz1eCb|S2Dcy=mm z^wAPLa7V!kqNM9&v}DSGW+7z-;I++WkM*zu<*&`s!S_?{2-z*z0zY9_@wO?3C`sCa z=G}MoBV2z9?$%=&xKK<2h*4H&YRklD(X=WrEk(_n&6WLf)b*gUSbLLIxrZ~ib3V-f zEk|w>dNq9^>X$49{~u=k5Aop(<6U@vyf8k5xj(!o;sNB-?6J>dg+d7 zt>K8H5!StT$yn1M0{VE#;&*X-us601!!{f0bUPpreN-b=m!lL&0i22FX{m~R?LFd- zruh$9*4)i7bhD=cPdR`ctLfutglF5z?4H#rj^q^6`DvvMY^=t12c@>X+BmfC{f>>n zM9_bV6ZOEQ=Jr^hZjBm+GOg5D>Wmq=S=wV8lM3xqAv#YYDB)pBO(1nrYkg1OPQg6M zEW4q#>?#7UQVUJQR6VEZN~YD>nMhyeR*bq*)?A_SPVUpQh@SV1IH_abyDKGCv;`+P zH#M-KU*9g%+FMWC(#u6GF_g`sUm@zxVUJxi7yW!|0u3zpU6&4^-Yg5p~dk)-oY_EAV4Y&Y0Fm^~Vmwes<9u^wG zLUCa`u(K6ZYk<2IE8IKUVMr?`m$2ReGc>X7zpo7?Wx!4FRkf9dlf2nz$$%?K^x~<1P)N*~{Uj?|VnM?XSjix?i+oM(!kVx~7_3G?SFiUYw7eG%T#Q Q5mb}@f20ION_?IL0KL68rT_o{