Menus: Prevent display conflicts in the screen options for Menus when a post type and taxonomy share the same slug.

Prior to this change, both taxonomies and post types added meta boxes to the Menus UI (which in-turn registered screen options) using the same ID formula: `add-{$id}`. This caused a conflict between the two elements, resulting in the rendering of a screen option for only the taxonomy or post type but not both. Moving to a new meta box ID for post types, `add-post-type-{$id}`, removes that conflict.

Note: This change in meta box IDs for post types effectively resets current user settings for the visibility of post types in the Menus UI.

Fixes #33925.

Built from https://develop.svn.wordpress.org/trunk@35450


git-svn-id: http://core.svn.wordpress.org/trunk@35414 1a063a9b-81f0-0310-95a4-ce76da25c4cd

wp-admin/includes/nav-menu.php

@@ -202,7 +202,7 @@ function wp_nav_menu_post_type_meta_boxes() {
 			$id = $post_type->name;
 			// Give pages a higher priority.
 			$priority = ( 'page' == $post_type->name ? 'core' : 'default' );
-			add_meta_box( "add-{$id}", $post_type->labels->name, 'wp_nav_menu_item_post_type_meta_box', 'nav-menus', 'side', $priority, $post_type );
+			add_meta_box( "add-post-type-{$id}", $post_type->labels->name, 'wp_nav_menu_item_post_type_meta_box', 'nav-menus', 'side', $priority, $post_type );
 		}
 	}
 }

wp-includes/version.php

@@ -4,7 +4,7 @@
  *
  * @global string $wp_version
  */
-$wp_version = '4.4-beta2-35449';
+$wp_version = '4.4-beta2-35450';
 
 /**
  * Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.