Press This:

- Fix focusing the Standard Editor link after saving draft, if the user has not focused another element.
- Reset the Save Draft button on node change in the editor.
See #31923.
Built from https://develop.svn.wordpress.org/trunk@32098


git-svn-id: http://core.svn.wordpress.org/trunk@32077 1a063a9b-81f0-0310-95a4-ce76da25c4cd

wp-admin/js/press-this.js

@@ -6,6 +6,7 @@
 	var PressThis = function() {
 		var editor, $mediaList, $mediaThumbWrap,
 			saveAlert             = false,
+			editLinkVisible       = false,
 			textarea              = document.createElement( 'textarea' ),
 			sidebarIsOpen         = false,
 			settings              = window.wpPressThisConfig || {},
@@ -102,9 +103,7 @@
 		 */
 		function showSpinner() {
 			$( '.spinner' ).addClass( 'is-active' );
-			$( '.post-actions button' ).each( function() {
+			$( '.post-actions button' ).attr( 'disabled', 'disabled' );
-				$( this ).attr( 'disabled', 'disabled' );
-			} );
 		}
 
 		/**
@@ -112,9 +111,7 @@
 		 */
 		function hideSpinner() {
 			$( '.spinner' ).removeClass( 'is-active' );
-			$( '.post-actions button' ).each( function() {
+			$( '.post-actions button' ).removeAttr( 'disabled' );
-				$( this ).removeAttr( 'disabled' );
-			} );
 		}
 
 		/**
@@ -166,7 +163,8 @@
 		 * @param action string publish|draft
 		 */
 		function submitPost( action ) {
-			var data;
+			var data,
+				keepFocus = $( document.activeElement ).hasClass( 'draft-button' );
 
 			saveAlert = false;
 			showSpinner();
@@ -186,7 +184,7 @@
 				hideSpinner();
 				clearNotices();
 			}).done( function( response ) {
-				var $link, $button, keepFocus;
+				var $link, $button;
 
 				if ( ! response.success ) {
 					renderError( response.data.errorMessage );
@@ -203,19 +201,18 @@
 				} else if ( response.data.postSaved ) {
 					$link = $( '.edit-post-link' );
 					$button = $( '.draft-button' );
-
+					editLinkVisible = true;
-					if ( document.activeElement && document.activeElement.className.indexOf( 'draft-button' ) > -1 ) {
-						keepFocus = true;
-					}
 
 					$button.fadeOut( 200, function() {
 						$button.removeClass( 'is-saving' );
-						$link.fadeIn( 200 );
+						$link.fadeIn( 200, function() {
-
+							var active = document.activeElement;
-						if ( keepFocus ) {
+							// Different browsers move the focus to different places when the button is disabled.
+							if ( keepFocus && ( active === $button[0] || $( active ).hasClass( 'post-actions' ) || active.nodeName === 'BODY' ) ) {
 								$link.focus();
 							}
 						});
+					});
 				}
 			}).fail( function() {
 				renderError( __( 'serverError' ) );
@@ -223,10 +220,14 @@
 		}
 
 		function resetDraftButton() {
+			if ( editLinkVisible ) {
+				editLinkVisible = false;
+
 				$( '.edit-post-link' ).fadeOut( 200, function() {
 					$( '.draft-button' ).removeClass( 'is-saving' ).fadeIn( 200 );
 				});
 			}
+		}
 
 		/**
 		 * Inserts the media a user has selected from the presented list inside the editor, as an image or embed, based on type
@@ -655,16 +656,10 @@
 			$( document ).on( 'tinymce-editor-init', function( event, ed ) {
 				editor = ed;
 
-				function focus() {
+				editor.on( 'nodechange', function() {
 					hasSetFocus = true;
 					resetDraftButton();
-				}
+				} );
-
-				if ( window.tinymce.Env.iOS ) {
-					editor.on( 'click', focus );
-				} else {
-					editor.on( 'focus', focus );
-				}
 			}).on( 'click.press-this keypress.press-this', '.suggested-media-thumbnail', function( event ) {
 				if ( event.type === 'click' || event.keyCode === 13 ) {
 					insertSelectedMedia( $( this ) );

wp-includes/version.php

@@ -4,7 +4,7 @@
  *
  * @global string $wp_version
  */
-$wp_version = '4.2-beta4-32097';
+$wp_version = '4.2-beta4-32098';
 
 /**
  * Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.