WPDB: Make sure we don't run sanity checks on DB dropins.

Previously, we'd run the sanity checks if `is_mysql` was not set to `false`. This caused problems for DB drop-ins that didn't define `is_mysql` at all. Instead, we can just check if `is_mysql` is `empty()`.

Also fix some unit tests that accidently ran correctly because of the strict `false ===` comparison.

Fixes #33501.


Built from https://develop.svn.wordpress.org/trunk@34655


git-svn-id: http://core.svn.wordpress.org/trunk@34619 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commit is contained in:
Gary Pendergast 2015-09-28 01:17:24 +00:00
parent 6b07e4a325
commit 9347f1af71
2 changed files with 3 additions and 3 deletions

View File

@ -4,7 +4,7 @@
*
* @global string $wp_version
*/
$wp_version = '4.4-alpha-34654';
$wp_version = '4.4-alpha-34655';
/**
* Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.

View File

@ -2414,7 +2414,7 @@ class wpdb {
}
// Skip this entirely if this isn't a MySQL database.
if ( false === $this->is_mysql ) {
if ( empty( $this->is_mysql ) ) {
return false;
}
@ -2463,7 +2463,7 @@ class wpdb {
$columnkey = strtolower( $column );
// Skip this entirely if this isn't a MySQL database.
if ( false === $this->is_mysql ) {
if ( empty( $this->is_mysql ) ) {
return false;
}