From 96cd4c4224f30305955c3d564d971809201e0bf4 Mon Sep 17 00:00:00 2001 From: "K. Adam White" Date: Thu, 24 Aug 2023 20:23:16 +0000 Subject: [PATCH] REST API: Remove misleading comment in WP_REST_Blocks_Controller->get_item_schema. In r56093 schema caching was added above a comment instructing developers not to cache that controller's schema. However, there is no obvious penalty for re-caching schema that is partially derived from a parent. Caching schema in the same way in every controller is beneficial consistency, and discussion at WCUS2023 contributor day concluded we could remove this comment. Props ahardyjpl, davidbinda, johnjamesjacoby, TimothyBlynJacobs. Fixes #59193. See #58657. Built from https://develop.svn.wordpress.org/trunk@56459 git-svn-id: http://core.svn.wordpress.org/trunk@55971 1a063a9b-81f0-0310-95a4-ce76da25c4cd --- .../rest-api/endpoints/class-wp-rest-blocks-controller.php | 1 - wp-includes/version.php | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/wp-includes/rest-api/endpoints/class-wp-rest-blocks-controller.php b/wp-includes/rest-api/endpoints/class-wp-rest-blocks-controller.php index 37178bb837..a270e0ff48 100644 --- a/wp-includes/rest-api/endpoints/class-wp-rest-blocks-controller.php +++ b/wp-includes/rest-api/endpoints/class-wp-rest-blocks-controller.php @@ -75,7 +75,6 @@ class WP_REST_Blocks_Controller extends WP_REST_Posts_Controller { return $this->add_additional_fields_schema( $this->schema ); } - // Do not cache this schema because all properties are derived from parent controller. $schema = parent::get_item_schema(); /* diff --git a/wp-includes/version.php b/wp-includes/version.php index 0a1d0f9b55..46ccb1e3ed 100644 --- a/wp-includes/version.php +++ b/wp-includes/version.php @@ -16,7 +16,7 @@ * * @global string $wp_version */ -$wp_version = '6.4-alpha-56458'; +$wp_version = '6.4-alpha-56459'; /** * Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.