diff --git a/wp-admin/js/comment.js b/wp-admin/js/comment.js index 4e4f3c5ed9..188caab2c3 100644 --- a/wp-admin/js/comment.js +++ b/wp-admin/js/comment.js @@ -70,7 +70,7 @@ jQuery( function($) { * @param {Event} event The event object. * @return {void} */ - $timestampdiv.find('.save-timestamp').on( 'click', function( event ) { // Crazyhorse - multiple OK cancels. + $timestampdiv.find('.save-timestamp').on( 'click', function( event ) { // Crazyhorse branch - multiple OK cancels. var aa = $('#aa').val(), mm = $('#mm').val(), jj = $('#jj').val(), hh = $('#hh').val(), mn = $('#mn').val(), newD = new Date( aa, mm - 1, jj, hh, mn ); diff --git a/wp-admin/js/post.js b/wp-admin/js/post.js index bba9c17358..557465bb27 100644 --- a/wp-admin/js/post.js +++ b/wp-admin/js/post.js @@ -889,7 +889,7 @@ jQuery( function($) { }); // Set the selected visibility as current. - $postVisibilitySelect.find('.save-post-visibility').on( 'click', function( event ) { // Crazyhorse - multiple OK cancels. + $postVisibilitySelect.find('.save-post-visibility').on( 'click', function( event ) { // Crazyhorse branch - multiple OK cancels. var visibilityLabel = '', selectedVisibility = $postVisibilitySelect.find('input:radio:checked').val(); $postVisibilitySelect.slideUp('fast'); @@ -945,7 +945,7 @@ jQuery( function($) { }); // Save the changed timestamp. - $timestampdiv.find('.save-timestamp').on( 'click', function( event ) { // Crazyhorse - multiple OK cancels. + $timestampdiv.find('.save-timestamp').on( 'click', function( event ) { // Crazyhorse branch - multiple OK cancels. if ( updateText() ) { $timestampdiv.slideUp('fast'); $timestampdiv.siblings('a.edit-timestamp').show().trigger( 'focus' ); diff --git a/wp-includes/class-simplepie.php b/wp-includes/class-simplepie.php index 2bd27359e6..1dabbbd2c3 100644 --- a/wp-includes/class-simplepie.php +++ b/wp-includes/class-simplepie.php @@ -340,7 +340,7 @@ define('SIMPLEPIE_NAMESPACE_RSS_10_MODULES_CONTENT', 'http://purl.org/rss/1.0/mo /** * RSS 2.0 Namespace - * (Stupid, I know, but I'm certain it will confuse people less with support.) + * (I know, but I'm certain it will confuse people less with support.) */ define('SIMPLEPIE_NAMESPACE_RSS_20', ''); @@ -1208,7 +1208,7 @@ class SimplePie * Set options to make SP as fast as possible * * Forgoes a substantial amount of data sanitization in favor of speed. This - * turns SimplePie into a dumb parser of feeds. + * turns SimplePie into an dumb parser of feeds. * * @param bool $set Whether to set them or not */ diff --git a/wp-includes/class-wp-theme.php b/wp-includes/class-wp-theme.php index 2058a9e557..a664a1ea0b 100644 --- a/wp-includes/class-wp-theme.php +++ b/wp-includes/class-wp-theme.php @@ -507,7 +507,7 @@ final class WP_Theme implements ArrayAccess { } return; } - // Set the parent. Pass the current instance so we can do the crazy checks above and assess errors. + // Set the parent. Pass the current instance so we can do the checks above and assess errors. $this->parent = new WP_Theme( $this->template, isset( $theme_root_template ) ? $theme_root_template : $this->theme_root, $this ); } diff --git a/wp-includes/class-wp-xmlrpc-server.php b/wp-includes/class-wp-xmlrpc-server.php index ae9a658718..2141f21e59 100644 --- a/wp-includes/class-wp-xmlrpc-server.php +++ b/wp-includes/class-wp-xmlrpc-server.php @@ -6939,7 +6939,19 @@ class wp_xmlrpc_server extends IXR_Server { return $this->pingback_error( 48, __( 'The pingback has already been registered.' ) ); } - // Very stupid, but gives time to the 'from' server to publish! + /* + * The remote site may have sent the pingback before it finished publishing its own content + * containing this pingback URL. If that happens then it won't be immediately possible to fetch + * the pinging post; adding a small delay reduces the likelihood of this happening. + * + * While there are more robust methods than calling `sleep()` here (because `sleep()` merely + * mitigates the risk of requesting the remote post before it's available), this is effective + * enough for most cases and avoids introducing more complexity into this code. + * + * One way to improve the reliability of this code might be to add failure-handling to the remote + * fetch and retry up to a set number of times if it receives a 404. This could also handle 401 and + * 403 responses to differentiate the "does not exist" failure from the "may not access" failure. + */ sleep( 1 ); $remote_ip = preg_replace( '/[^0-9a-fA-F:., ]/', '', $_SERVER['REMOTE_ADDR'] ); diff --git a/wp-includes/shortcodes.php b/wp-includes/shortcodes.php index 98cd8f71dd..cf88b2195f 100644 --- a/wp-includes/shortcodes.php +++ b/wp-includes/shortcodes.php @@ -504,7 +504,7 @@ function do_shortcodes_in_html_tags( $content, $ignore_html, $tagnames ) { $element = preg_replace_callback( "/$pattern/", 'do_shortcode_tag', $element ); } - // Looks like we found some crazy unfiltered HTML. Skipping it for confidence. + // Looks like we found some unexpected unfiltered HTML. Skipping it for confidence. $element = strtr( $element, $trans ); continue; } diff --git a/wp-includes/theme.php b/wp-includes/theme.php index 604ae5eb49..0b0df6c7b0 100644 --- a/wp-includes/theme.php +++ b/wp-includes/theme.php @@ -2802,7 +2802,7 @@ function add_theme_support( $feature, ...$args ) { * the constant is always accurate (and is not defined later, overriding our value). * As stated above, the first value wins. * Once we get to wp_loaded (just-in-time), define any constants we haven't already. - * Constants are lame. Don't reference them. This is just for backward compatibility. + * Constants should be avoided. Don't reference them. This is just for backward compatibility. */ if ( defined( 'NO_HEADER_TEXT' ) ) { diff --git a/wp-includes/version.php b/wp-includes/version.php index 740123b492..b13c9a2448 100644 --- a/wp-includes/version.php +++ b/wp-includes/version.php @@ -16,7 +16,7 @@ * * @global string $wp_version */ -$wp_version = '6.5-alpha-57583'; +$wp_version = '6.5-alpha-57584'; /** * Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.