WordPress-C
/
WordPress
mirror of https://github.com/WordPress/WordPress.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Upgrade/Install: Check plugin compatibility during bulk upgrades. 

Previously, bulk upgrades did not verify that a plugin package was compatible with the site's WordPress version or the server's PHP version. This could lead to incompatible updates being installed, causing various compatibility issues and errors.

This change implements the following checks:
- If available, the API response's `requires` and `requires_php` values are checked for compatibility. This saves time, diskspace, memory and file operations by failing the upgrade before the package is downloaded and unpacked.
- If the API check passes, the downloaded and unpacked package is verified using `Plugin_Upgrader::check_package()` to ensure a plugin file is present, and the plugin's "RequiresWP" and "RequiresPHP" headers are compatible, if present. This ensures that a mismatch between the API response and the plugin file's headers does not cause an incompatible plugin to be installed.

Props salcode, afragen, mukesh27, iammehedi1, zunaid321, johnbillion, SergeyBiryukov, costdev.
Fixes #59198.
Built from https://develop.svn.wordpress.org/trunk@56525


git-svn-id: http://core.svn.wordpress.org/trunk@56037 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commit is contained in:
costdev 2023-09-06 18:30:19 +00:00
parent be1b61326b
commit 9ebcbfae5c
2 changed files with 53 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

68
wp-admin/includes/class-plugin-upgrader.php
View File

@ -274,6 +274,8 @@ class Plugin_Upgrader extends WP_Upgrader {
* @since 2.8.0 * @since 2.8.0
* @since 3.7.0 The `$args` parameter was added, making clearing the plugin update cache optional. * @since 3.7.0 The `$args` parameter was added, making clearing the plugin update cache optional.
* *
* @global string $wp_version The WordPress version string.
*
* @param string[] $plugins Array of paths to plugin files relative to the plugins directory. * @param string[] $plugins Array of paths to plugin files relative to the plugins directory.
* @param array $args { * @param array $args {
* Optional. Other arguments for upgrading several plugins at once. * Optional. Other arguments for upgrading several plugins at once.
@ -283,6 +285,8 @@ class Plugin_Upgrader extends WP_Upgrader {
* @return array|false An array of results indexed by plugin file, or false if unable to connect to the filesystem. * @return array|false An array of results indexed by plugin file, or false if unable to connect to the filesystem.
*/ */
public function bulk_upgrade( $plugins, $args = array() ) { public function bulk_upgrade( $plugins, $args = array() ) {
global $wp_version;
$defaults = array( $defaults = array(
'clear_update_cache' => true, 'clear_update_cache' => true,
); );
@ -343,23 +347,55 @@ class Plugin_Upgrader extends WP_Upgrader {
$this->skin->plugin_active = is_plugin_active( $plugin ); $this->skin->plugin_active = is_plugin_active( $plugin );
$result = $this->run( if ( isset( $r->requires ) && ! is_wp_version_compatible( $r->requires ) ) {
array( $result = new WP_Error(
'package' => $r->package, 'incompatible_wp_required_version',
'destination' => WP_PLUGIN_DIR, sprintf(
'clear_destination' => true, /* translators: 1: Current WordPress version, 2: WordPress version required by the new plugin version. */
'clear_working' => true, __( 'Your WordPress version is %1$s, however the new plugin version requires %2$s.' ),
'is_multi' => true, $wp_version,
'hook_extra' => array( $r->requires
'plugin' => $plugin, )
'temp_backup' => array( );
'slug' => dirname( $plugin ),
'src' => WP_PLUGIN_DIR, $this->skin->before( $result );
'dir' => 'plugins', $this->skin->error( $result );
$this->skin->after();
} elseif ( isset( $r->requires_php ) && ! is_php_version_compatible( $r->requires_php ) ) {
$result = new WP_Error(
'incompatible_php_required_version',
sprintf(
/* translators: 1: Current PHP version, 2: PHP version required by the new plugin version. */
__( 'The PHP version on your server is %1$s, however the new plugin version requires %2$s.' ),
PHP_VERSION,
$r->requires_php
)
);
$this->skin->before( $result );
$this->skin->error( $result );
$this->skin->after();
} else {
add_filter( 'upgrader_source_selection', array( $this, 'check_package' ) );
$result = $this->run(
array(
'package' => $r->package,
'destination' => WP_PLUGIN_DIR,
'clear_destination' => true,
'clear_working' => true,
'is_multi' => true,
'hook_extra' => array(
'plugin' => $plugin,
'temp_backup' => array(
'slug' => dirname( $plugin ),
'src' => WP_PLUGIN_DIR,
'dir' => 'plugins',
),
), ),
), )
) );
); remove_filter( 'upgrader_source_selection', array( $this, 'check_package' ) );
}
$results[ $plugin ] = $result; $results[ $plugin ] = $result;

2
wp-includes/version.php
View File

@ -16,7 +16,7 @@
* *
* @global string $wp_version * @global string $wp_version
*/ */
$wp_version = '6.4-alpha-56524'; $wp_version = '6.4-alpha-56525';
/** /**
* Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema. * Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.