Proper permissions for newly created files. Props azaozz. fixes #10170 for 2.8.1

git-svn-id: http://svn.automattic.com/wordpress/branches/2.8@11668 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commit is contained in:
ryan 2009-06-29 20:24:04 +00:00
parent 8a039537be
commit a5902a590b
1 changed files with 15 additions and 8 deletions

View File

@ -20,7 +20,6 @@ class WP_Filesystem_Direct extends WP_Filesystem_Base {
function WP_Filesystem_Direct($arg) { function WP_Filesystem_Direct($arg) {
$this->method = 'direct'; $this->method = 'direct';
$this->errors = new WP_Error(); $this->errors = new WP_Error();
$this->permission = umask();
} }
function connect() { function connect() {
return true; return true;
@ -64,12 +63,22 @@ class WP_Filesystem_Direct extends WP_Filesystem_Base {
return true; return true;
} }
function chmod($file, $mode = false, $recursive = false) { function chmod($file, $mode = false, $recursive = false) {
if ( ! $mode )
$mode = $this->permission;
if ( ! $this->exists($file) ) if ( ! $this->exists($file) )
return false; return false;
if ( ! $mode ) {
if ( $this->permission )
$mode = $this->permission;
elseif ( $this->is_file($file) )
$mode = FS_CHMOD_FILE;
elseif ( $this->is_dir($file) )
$mode = FS_CHMOD_DIR;
else
return false;
}
if ( ! $recursive ) if ( ! $recursive )
return @chmod($file,$mode); return @chmod($file, $mode);
if ( ! $this->is_dir($file) ) if ( ! $this->is_dir($file) )
return @chmod($file, $mode); return @chmod($file, $mode);
//Is a directory, and we want recursive //Is a directory, and we want recursive
@ -197,11 +206,9 @@ class WP_Filesystem_Direct extends WP_Filesystem_Base {
} }
function mkdir($path, $chmod = false, $chown = false, $chgrp = false){ function mkdir($path, $chmod = false, $chown = false, $chgrp = false){
if ( ! $chmod) if ( ! @mkdir($path) )
$chmod = $this->permission;
if ( ! @mkdir($path, $chmod) )
return false; return false;
$this->chmod($path, $chmod);
if ( $chown ) if ( $chown )
$this->chown($path, $chown); $this->chown($path, $chown);
if ( $chgrp ) if ( $chgrp )