Administration: Accessibility: Use the default cursor style for labels and disabled form controls.

The native cursor style for labels and form controls is `default`, which is the platform-dependent default cursor. Typically an arrow. Historically, WordPress always used the `pointer` style for all form controls and labels. While this isn't standard, there is some value in using the `pointer` style for form controls. However, labels should use the default style especially when the associated controls are disabled.
Additionally, makes sure the disabled styling works for form controls with an `aria-disabled="true"` attribute.

Props joedolson, afercia.
Fixes #59733.

Built from https://develop.svn.wordpress.org/trunk@57520


git-svn-id: http://core.svn.wordpress.org/trunk@57021 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commit is contained in:
Andrea Fercia 2024-02-02 09:55:14 +00:00
parent 4c37cdc1a4
commit a9bb1bb5f7
13 changed files with 45 additions and 25 deletions

View File

@ -23,10 +23,6 @@ textarea {
resize: vertical; resize: vertical;
} }
label {
cursor: pointer;
}
input, input,
select { select {
margin: 0 1px; margin: 0 1px;
@ -288,8 +284,10 @@ textarea.disabled {
input[type="file"]:disabled, input[type="file"]:disabled,
input[type="file"].disabled, input[type="file"].disabled,
input[type="file"][aria-disabled="true"],
input[type="range"]:disabled, input[type="range"]:disabled,
input[type="range"].disabled { input[type="range"].disabled,
input[type="range"][aria-disabled="true"] {
background: none; background: none;
box-shadow: none; box-shadow: none;
cursor: default; cursor: default;
@ -297,13 +295,16 @@ input[type="range"].disabled {
input[type="checkbox"]:disabled, input[type="checkbox"]:disabled,
input[type="checkbox"].disabled, input[type="checkbox"].disabled,
input[type="checkbox"][aria-disabled="true"],
input[type="radio"]:disabled, input[type="radio"]:disabled,
input[type="radio"].disabled, input[type="radio"].disabled,
input[type="radio"][aria-disabled="true"],
input[type="checkbox"]:disabled:checked:before, input[type="checkbox"]:disabled:checked:before,
input[type="checkbox"].disabled:checked:before, input[type="checkbox"].disabled:checked:before,
input[type="radio"]:disabled:checked:before, input[type="radio"]:disabled:checked:before,
input[type="radio"].disabled:checked:before { input[type="radio"].disabled:checked:before {
opacity: 0.7; opacity: 0.7;
cursor: default;
} }
/*------------------------------------------------------------------------------ /*------------------------------------------------------------------------------
@ -357,6 +358,10 @@ input[type="radio"].disabled:checked:before {
transform: none; transform: none;
} }
.wp-core-ui select[aria-disabled="true"] {
cursor: default;
}
/* Reset Firefox inner outline that appears on :focus. */ /* Reset Firefox inner outline that appears on :focus. */
/* This ruleset overrides the color change on :focus thus needs to be after select:focus. */ /* This ruleset overrides the color change on :focus thus needs to be after select:focus. */
.wp-core-ui select:-moz-focusring { .wp-core-ui select:-moz-focusring {

File diff suppressed because one or more lines are too long

View File

@ -22,10 +22,6 @@ textarea {
resize: vertical; resize: vertical;
} }
label {
cursor: pointer;
}
input, input,
select { select {
margin: 0 1px; margin: 0 1px;
@ -287,8 +283,10 @@ textarea.disabled {
input[type="file"]:disabled, input[type="file"]:disabled,
input[type="file"].disabled, input[type="file"].disabled,
input[type="file"][aria-disabled="true"],
input[type="range"]:disabled, input[type="range"]:disabled,
input[type="range"].disabled { input[type="range"].disabled,
input[type="range"][aria-disabled="true"] {
background: none; background: none;
box-shadow: none; box-shadow: none;
cursor: default; cursor: default;
@ -296,13 +294,16 @@ input[type="range"].disabled {
input[type="checkbox"]:disabled, input[type="checkbox"]:disabled,
input[type="checkbox"].disabled, input[type="checkbox"].disabled,
input[type="checkbox"][aria-disabled="true"],
input[type="radio"]:disabled, input[type="radio"]:disabled,
input[type="radio"].disabled, input[type="radio"].disabled,
input[type="radio"][aria-disabled="true"],
input[type="checkbox"]:disabled:checked:before, input[type="checkbox"]:disabled:checked:before,
input[type="checkbox"].disabled:checked:before, input[type="checkbox"].disabled:checked:before,
input[type="radio"]:disabled:checked:before, input[type="radio"]:disabled:checked:before,
input[type="radio"].disabled:checked:before { input[type="radio"].disabled:checked:before {
opacity: 0.7; opacity: 0.7;
cursor: default;
} }
/*------------------------------------------------------------------------------ /*------------------------------------------------------------------------------
@ -356,6 +357,10 @@ input[type="radio"].disabled:checked:before {
transform: none; transform: none;
} }
.wp-core-ui select[aria-disabled="true"] {
cursor: default;
}
/* Reset Firefox inner outline that appears on :focus. */ /* Reset Firefox inner outline that appears on :focus. */
/* This ruleset overrides the color change on :focus thus needs to be after select:focus. */ /* This ruleset overrides the color change on :focus thus needs to be after select:focus. */
.wp-core-ui select:-moz-focusring { .wp-core-ui select:-moz-focusring {

File diff suppressed because one or more lines are too long

View File

@ -73,10 +73,6 @@ fieldset {
margin: 0; margin: 0;
} }
label {
cursor: pointer;
}
#logo { #logo {
margin: -130px auto 25px; margin: -130px auto 25px;
padding: 0 0 25px; padding: 0 0 25px;

File diff suppressed because one or more lines are too long

View File

@ -72,10 +72,6 @@ fieldset {
margin: 0; margin: 0;
} }
label {
cursor: pointer;
}
#logo { #logo {
margin: -130px auto 25px; margin: -130px auto 25px;
padding: 0 0 25px; padding: 0 0 25px;

File diff suppressed because one or more lines are too long

View File

@ -186,6 +186,11 @@ TABLE OF CONTENTS:
transform: none !important; transform: none !important;
} }
.wp-core-ui .button[aria-disabled="true"],
.wp-core-ui .button-secondary[aria-disabled="true"] {
cursor: default;
}
/* Buttons that look like links, for a cross of good semantics with the visual */ /* Buttons that look like links, for a cross of good semantics with the visual */
.wp-core-ui .button-link { .wp-core-ui .button-link {
margin: 0; margin: 0;
@ -284,6 +289,10 @@ TABLE OF CONTENTS:
cursor: default; cursor: default;
} }
.wp-core-ui .button-primary[aria-disabled="true"] {
cursor: default;
}
/* ---------------------------------------------------------------------------- /* ----------------------------------------------------------------------------
4.0 - Button Groups 4.0 - Button Groups
---------------------------------------------------------------------------- */ ---------------------------------------------------------------------------- */

File diff suppressed because one or more lines are too long

View File

@ -185,6 +185,11 @@ TABLE OF CONTENTS:
transform: none !important; transform: none !important;
} }
.wp-core-ui .button[aria-disabled="true"],
.wp-core-ui .button-secondary[aria-disabled="true"] {
cursor: default;
}
/* Buttons that look like links, for a cross of good semantics with the visual */ /* Buttons that look like links, for a cross of good semantics with the visual */
.wp-core-ui .button-link { .wp-core-ui .button-link {
margin: 0; margin: 0;
@ -283,6 +288,10 @@ TABLE OF CONTENTS:
cursor: default; cursor: default;
} }
.wp-core-ui .button-primary[aria-disabled="true"] {
cursor: default;
}
/* ---------------------------------------------------------------------------- /* ----------------------------------------------------------------------------
4.0 - Button Groups 4.0 - Button Groups
---------------------------------------------------------------------------- */ ---------------------------------------------------------------------------- */

File diff suppressed because one or more lines are too long

View File

@ -16,7 +16,7 @@
* *
* @global string $wp_version * @global string $wp_version
*/ */
$wp_version = '6.5-alpha-57519'; $wp_version = '6.5-alpha-57520';
/** /**
* Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema. * Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.