WordPress-C
/
WordPress
mirror of https://github.com/WordPress/WordPress.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Widgets: Fix previewing embeds in Text widget by allowing `parse-embed` admin ajax requests with an empty `post_ID` just as `WP_oEmbed_Controller::get_proxy_item_permissions_check()` allows. 

As of #34115 if there is no post context the oEmbed will be cached in an `oembed_cache` custom post type, so having a post as context is no longer a requirement for caching.

Props biskobe, westonruter.
See #34115, #40450.
Fixes #40854.

Built from https://develop.svn.wordpress.org/trunk@41913


git-svn-id: http://core.svn.wordpress.org/trunk@41747 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commit is contained in:
Weston Ruter 2017-10-18 17:40:49 +00:00
parent 548d8c2e0d
commit ae538512c3
2 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
wp-admin/includes/ajax-actions.php
View File

@ -3005,11 +3005,17 @@ function wp_ajax_query_themes() {
function wp_ajax_parse_embed() { function wp_ajax_parse_embed() {
global $post, $wp_embed; global $post, $wp_embed;
if ( ! $post = get_post( (int) $_POST['post_ID'] ) ) { if ( empty( $_POST['shortcode'] ) ) {
wp_send_json_error(); wp_send_json_error();
} }
$post_id = isset( $_POST[ 'post_ID' ] ) ? intval( $_POST[ 'post_ID' ] ) : 0;
if ( empty( $_POST['shortcode'] ) || ! current_user_can( 'edit_post', $post->ID ) ) { if ( $post_id > 0 ) {
$post = get_post( $post_id );
if ( ! $post || ! current_user_can( 'edit_post', $post->ID ) ) {
wp_send_json_error();
}
setup_postdata( $post );
} elseif ( ! current_user_can( 'edit_posts' ) ) { // See WP_oEmbed_Controller::get_proxy_item_permissions_check().
wp_send_json_error(); wp_send_json_error();
} }
@ -3026,8 +3032,6 @@ function wp_ajax_parse_embed() {
} }
$parsed = false; $parsed = false;
setup_postdata( $post );
$wp_embed->return_false_on_fail = true; $wp_embed->return_false_on_fail = true;
if ( is_ssl() && 0 === strpos( $url, 'http://' ) ) { if ( is_ssl() && 0 === strpos( $url, 'http://' ) ) {

2
wp-includes/version.php
View File

@ -4,7 +4,7 @@
* *
* @global string $wp_version * @global string $wp_version
*/ */
$wp_version = '4.9-beta2-41912'; $wp_version = '4.9-beta2-41913';
/** /**
* Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema. * Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.