Only clean up the uploaded files after a successful (or failed) install. Allows files to persist past the FTP credential screen. See #18182

git-svn-id: http://svn.automattic.com/wordpress/trunk@18616 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commit is contained in:
dd32 2011-08-28 05:51:38 +00:00
parent ea3a169b6f
commit b16b6f8a31
2 changed files with 11 additions and 8 deletions

View File

@ -399,9 +399,13 @@ class Plugin_Upgrader extends WP_Upgrader {
'hook_extra' => array() 'hook_extra' => array()
)); ));
if ( ! $this->result || is_wp_error($this->result) )
return $this->result;
// Force refresh of plugin update information // Force refresh of plugin update information
delete_site_transient('update_plugins'); delete_site_transient('update_plugins');
return true;
} }
function upgrade($plugin) { function upgrade($plugin) {
@ -646,10 +650,7 @@ class Theme_Upgrader extends WP_Upgrader {
// Force refresh of theme update information // Force refresh of theme update information
delete_site_transient('update_themes'); delete_site_transient('update_themes');
if ( empty($result['destination_name']) ) return true;
return false;
else
return $result['destination_name'];
} }
function upgrade($theme) { function upgrade($theme) {

View File

@ -138,8 +138,9 @@ if ( isset($_GET['action']) ) {
$type = 'upload'; //Install plugin type, From Web or an Upload. $type = 'upload'; //Install plugin type, From Web or an Upload.
$upgrader = new Plugin_Upgrader( new Plugin_Installer_Skin( compact('type', 'title', 'nonce', 'url') ) ); $upgrader = new Plugin_Upgrader( new Plugin_Installer_Skin( compact('type', 'title', 'nonce', 'url') ) );
$upgrader->install( $file_upload->package ); $result = $upgrader->install( $file_upload->package );
if ( $result || is_wp_error($result) )
$file_upload->cleanup(); $file_upload->cleanup();
include(ABSPATH . 'wp-admin/admin-footer.php'); include(ABSPATH . 'wp-admin/admin-footer.php');
@ -242,8 +243,9 @@ if ( isset($_GET['action']) ) {
$type = 'upload'; //Install plugin type, From Web or an Upload. $type = 'upload'; //Install plugin type, From Web or an Upload.
$upgrader = new Theme_Upgrader( new Theme_Installer_Skin( compact('type', 'title', 'nonce', 'url') ) ); $upgrader = new Theme_Upgrader( new Theme_Installer_Skin( compact('type', 'title', 'nonce', 'url') ) );
$upgrader->install( $file_upload->package ); $result = $upgrader->install( $file_upload->package );
if ( $result || is_wp_error($result) )
$file_upload->cleanup(); $file_upload->cleanup();
include(ABSPATH . 'wp-admin/admin-footer.php'); include(ABSPATH . 'wp-admin/admin-footer.php');