From b45c550376eb83babc01037ef56c2fd60553b6f2 Mon Sep 17 00:00:00 2001 From: Andrew Nacin Date: Sun, 23 Sep 2012 16:57:21 +0000 Subject: [PATCH] Use $gmt_time rather than $local_time in cron, since it uses GMT/UTC and not a local timestamp. see #14391. git-svn-id: http://core.svn.wordpress.org/trunk@21954 1a063a9b-81f0-0310-95a4-ce76da25c4cd --- wp-cron.php | 8 ++++---- wp-includes/cron.php | 24 ++++++++++++------------ 2 files changed, 16 insertions(+), 16 deletions(-) diff --git a/wp-cron.php b/wp-cron.php index f0da6ecc5c..04953c8d73 100644 --- a/wp-cron.php +++ b/wp-cron.php @@ -48,9 +48,9 @@ if ( false === $crons = _get_cron_array() ) die(); $keys = array_keys( $crons ); -$local_time = microtime( true ); +$gmt_time = microtime( true ); -if ( isset($keys[0]) && $keys[0] > $local_time ) +if ( isset($keys[0]) && $keys[0] > $gmt_time ) die(); $doing_cron_transient = get_transient( 'doing_cron'); @@ -59,7 +59,7 @@ $doing_cron_transient = get_transient( 'doing_cron'); if ( empty( $doing_wp_cron ) ) { if ( empty( $_GET[ 'doing_wp_cron' ] ) ) { // Called from external script/job. Try setting a lock. - if ( $doing_cron_transient && ( $doing_cron_transient + WP_CRON_LOCK_TIMEOUT > $local_time ) ) + if ( $doing_cron_transient && ( $doing_cron_transient + WP_CRON_LOCK_TIMEOUT > $gmt_time ) ) return; $doing_cron_transient = $doing_wp_cron = sprintf( '%.22F', microtime( true ) ); set_transient( 'doing_cron', $doing_wp_cron ); @@ -73,7 +73,7 @@ if ( $doing_cron_transient != $doing_wp_cron ) return; foreach ( $crons as $timestamp => $cronhooks ) { - if ( $timestamp > $local_time ) + if ( $timestamp > $gmt_time ) break; foreach ( $cronhooks as $hook => $keys ) { diff --git a/wp-includes/cron.php b/wp-includes/cron.php index 64fab7d3be..31451d6b35 100644 --- a/wp-includes/cron.php +++ b/wp-includes/cron.php @@ -192,10 +192,10 @@ function wp_next_scheduled( $hook, $args = array() ) { * * @return null Cron could not be spawned, because it is not needed to run. */ -function spawn_cron( $local_time = 0 ) { +function spawn_cron( $gmt_time = 0 ) { - if ( ! $local_time ) - $local_time = microtime( true ); + if ( ! $gmt_time ) + $gmt_time = microtime( true ); if ( defined('DOING_CRON') || isset($_GET['doing_wp_cron']) ) return; @@ -206,11 +206,11 @@ function spawn_cron( $local_time = 0 ) { */ $lock = get_transient('doing_cron'); - if ( $lock > $local_time + 10*60 ) + if ( $lock > $gmt_time + 10*60 ) $lock = 0; // don't run if another process is currently running it or more than once every 60 sec. - if ( $lock + WP_CRON_LOCK_TIMEOUT > $local_time ) + if ( $lock + WP_CRON_LOCK_TIMEOUT > $gmt_time ) return; //sanity check @@ -219,14 +219,14 @@ function spawn_cron( $local_time = 0 ) { return; $keys = array_keys( $crons ); - if ( isset($keys[0]) && $keys[0] > $local_time ) + if ( isset($keys[0]) && $keys[0] > $gmt_time ) return; if ( defined('ALTERNATE_WP_CRON') && ALTERNATE_WP_CRON ) { if ( !empty($_POST) || defined('DOING_AJAX') ) return; - $doing_wp_cron = sprintf( '%.22F', $local_time ); + $doing_wp_cron = sprintf( '%.22F', $gmt_time ); set_transient( 'doing_cron', $doing_wp_cron ); ob_start(); @@ -241,7 +241,7 @@ function spawn_cron( $local_time = 0 ) { return; } - $doing_wp_cron = sprintf( '%.22F', $local_time ); + $doing_wp_cron = sprintf( '%.22F', $gmt_time ); set_transient( 'doing_cron', $doing_wp_cron ); $cron_request = apply_filters( 'cron_request', array( @@ -269,18 +269,18 @@ function wp_cron() { if ( false === $crons = _get_cron_array() ) return; - $local_time = microtime( true ); + $gmt_time = microtime( true ); $keys = array_keys( $crons ); - if ( isset($keys[0]) && $keys[0] > $local_time ) + if ( isset($keys[0]) && $keys[0] > $gmt_time ) return; $schedules = wp_get_schedules(); foreach ( $crons as $timestamp => $cronhooks ) { - if ( $timestamp > $local_time ) break; + if ( $timestamp > $gmt_time ) break; foreach ( (array) $cronhooks as $hook => $args ) { if ( isset($schedules[$hook]['callback']) && !call_user_func( $schedules[$hook]['callback'] ) ) continue; - spawn_cron( $local_time ); + spawn_cron( $gmt_time ); break 2; } }