Administration: Restore the correct escaping function for base64-encoded SVG icons in the admin menu.
Add a comment to clarify the `esc_attr()` usage instead of `esc_url()`. Follow-up to [53050]. Props KProvance, kebbet, w33zy, ocean90, mukesh27. Fixes #55539. Built from https://develop.svn.wordpress.org/trunk@53092 git-svn-id: http://core.svn.wordpress.org/trunk@52681 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commit is contained in:
parent
0ae89f5171
commit
ba864b2792
|
@ -128,8 +128,9 @@ function _wp_menu_output( $menu, $submenu, $submenu_as_parent = true ) {
|
|||
if ( 'none' === $item[6] || 'div' === $item[6] ) {
|
||||
$img = '<br />';
|
||||
} elseif ( 0 === strpos( $item[6], 'data:image/svg+xml;base64,' ) ) {
|
||||
$img = '<br />';
|
||||
$img_style = ' style="background-image:url(\'' . esc_url( $item[6] ) . '\')"';
|
||||
$img = '<br />';
|
||||
// The value is base64-encoded data, so esc_attr() is used here instead of esc_url().
|
||||
$img_style = ' style="background-image:url(\'' . esc_attr( $item[6] ) . '\')"';
|
||||
$img_class = ' svg';
|
||||
} elseif ( 0 === strpos( $item[6], 'dashicons-' ) ) {
|
||||
$img = '<br />';
|
||||
|
|
|
@ -16,7 +16,7 @@
|
|||
*
|
||||
* @global string $wp_version
|
||||
*/
|
||||
$wp_version = '6.0-alpha-53091';
|
||||
$wp_version = '6.0-alpha-53092';
|
||||
|
||||
/**
|
||||
* Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.
|
||||
|
|
Loading…
Reference in New Issue