Handle quotes in upload titles. fixes #2198
git-svn-id: http://svn.automattic.com/wordpress/trunk@3398 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commit is contained in:
parent
0275a631e0
commit
c26e1c0cc3
|
@ -232,14 +232,15 @@ srcb[{$ID}] = '{$image['guid']}';
|
||||||
$xpadding = (128 - $image['uwidth']) / 2;
|
$xpadding = (128 - $image['uwidth']) / 2;
|
||||||
$ypadding = (96 - $image['uheight']) / 2;
|
$ypadding = (96 - $image['uheight']) / 2;
|
||||||
$style .= "#target{$ID} img { padding: {$ypadding}px {$xpadding}px; }\n";
|
$style .= "#target{$ID} img { padding: {$ypadding}px {$xpadding}px; }\n";
|
||||||
$script .= "aa[{$ID}] = '<a id=\"p{$ID}\" rel=\"attachment\" class=\"imagelink\" href=\"$href\" onclick=\"doPopup({$ID});return false;\" title=\"{$image['post_title']}\">';
|
$title = htmlentities($image['post_title'], ENT_QUOTES);
|
||||||
ab[{$ID}] = '<a class=\"imagelink\" href=\"{$image['guid']}\" onclick=\"doPopup({$ID});return false;\" title=\"{$image['post_title']}\">';
|
$script .= "aa[{$ID}] = '<a id=\"p{$ID}\" rel=\"attachment\" class=\"imagelink\" href=\"$href\" onclick=\"doPopup({$ID});return false;\" title=\"{$title}\">';
|
||||||
imga[{$ID}] = '<img id=\"image{$ID}\" src=\"$src\" alt=\"{$image['post_title']}\" $height_width />';
|
ab[{$ID}] = '<a class=\"imagelink\" href=\"{$image['guid']}\" onclick=\"doPopup({$ID});return false;\" title=\"{$title}\">';
|
||||||
imgb[{$ID}] = '<img id=\"image{$ID}\" src=\"{$image['guid']}\" alt=\"{$image['post_title']}\" $height_width />';
|
imga[{$ID}] = '<img id=\"image{$ID}\" src=\"$src\" alt=\"{$title}\" $height_width />';
|
||||||
|
imgb[{$ID}] = '<img id=\"image{$ID}\" src=\"{$image['guid']}\" alt=\"{$title}\" $height_width />';
|
||||||
";
|
";
|
||||||
$html .= "<div id='target{$ID}' class='attwrap left'>
|
$html .= "<div id='target{$ID}' class='attwrap left'>
|
||||||
<div id='div{$ID}' class='imagewrap' onclick=\"doPopup({$ID});\">
|
<div id='div{$ID}' class='imagewrap' onclick=\"doPopup({$ID});\">
|
||||||
<img id=\"image{$ID}\" src=\"$src\" alt=\"{$image['post_title']}\" $height_width />
|
<img id=\"image{$ID}\" src=\"$src\" alt=\"{$title}\" $height_width />
|
||||||
</div>
|
</div>
|
||||||
{$noscript}
|
{$noscript}
|
||||||
</div>
|
</div>
|
||||||
|
@ -251,19 +252,19 @@ imgb[{$ID}] = '<img id=\"image{$ID}\" src=\"{$image['guid']}\" alt=\"{$image['po
|
||||||
</div>
|
</div>
|
||||||
";
|
";
|
||||||
} else {
|
} else {
|
||||||
$title = $attachment['post_title'];
|
$title = htmlentities($attachment['post_title'], ENT_QUOTES);
|
||||||
$filename = basename($attachment['guid']);
|
$filename = basename($attachment['guid']);
|
||||||
$icon = get_attachment_icon($ID);
|
$icon = get_attachment_icon($ID);
|
||||||
$toggle_icon = "<a id=\"I{$ID}\" onclick=\"toggleOtherIcon({$ID});return false;\" href=\"javascript:void()\">$__using_title</a>";
|
$toggle_icon = "<a id=\"I{$ID}\" onclick=\"toggleOtherIcon({$ID});return false;\" href=\"javascript:void()\">$__using_title</a>";
|
||||||
$script .= "aa[{$ID}] = '<a id=\"p{$ID}\" rel=\"attachment\" href=\"$href\" onclick=\"doPopup({$ID});return false;\" title=\"{$title}\">{$attachment['post_title']}</a>';
|
$script .= "aa[{$ID}] = '<a id=\"p{$ID}\" rel=\"attachment\" href=\"$href\" onclick=\"doPopup({$ID});return false;\" title=\"{$title}\">{$title}</a>';
|
||||||
ab[{$ID}] = '<a id=\"p{$ID}\" href=\"{$filename}\" onclick=\"doPopup({$ID});return false;\" title=\"{$title}\">{$attachment['post_title']}</a>';
|
ab[{$ID}] = '<a id=\"p{$ID}\" href=\"{$filename}\" onclick=\"doPopup({$ID});return false;\" title=\"{$title}\">{$title}</a>';
|
||||||
title[{$ID}] = '{$attachment['post_title']}';
|
title[{$ID}] = '{$title}';
|
||||||
filename[{$ID}] = '{$filename}';
|
filename[{$ID}] = '{$filename}';
|
||||||
icon[{$ID}] = '{$icon}';
|
icon[{$ID}] = '{$icon}';
|
||||||
";
|
";
|
||||||
$html .= "<div id='target{$ID}' class='attwrap left'>
|
$html .= "<div id='target{$ID}' class='attwrap left'>
|
||||||
<div id='div{$ID}' class='otherwrap usingtext' onmousedown=\"selectLink({$ID})\" onclick=\"doPopup({$ID});return false;\">
|
<div id='div{$ID}' class='otherwrap usingtext' onmousedown=\"selectLink({$ID})\" onclick=\"doPopup({$ID});return false;\">
|
||||||
<a id=\"p{$ID}\" href=\"{$attachment['guid']}\" onmousedown=\"selectLink({$ID});\" onclick=\"return false;\">{$attachment['post_title']}</a>
|
<a id=\"p{$ID}\" href=\"{$attachment['guid']}\" onmousedown=\"selectLink({$ID});\" onclick=\"return false;\">{$title}</a>
|
||||||
</div>
|
</div>
|
||||||
{$noscript}
|
{$noscript}
|
||||||
</div>
|
</div>
|
||||||
|
|
Loading…
Reference in New Issue