Site Health: Correct inverted logic for themes in the test for plugin and theme auto-updates.

Follow-up to [48548], [48558].

See #50662.
Built from https://develop.svn.wordpress.org/trunk@48559


git-svn-id: http://core.svn.wordpress.org/trunk@48321 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commit is contained in:
Sergey Biryukov 2020-07-22 00:15:02 +00:00
parent 93bf0c3b83
commit c6034be779
2 changed files with 10 additions and 6 deletions

View File

@ -2319,9 +2319,9 @@ class WP_Site_Health {
foreach ( $this->crons as $id => $cron ) { foreach ( $this->crons as $id => $cron ) {
$cron_offset = $cron->time - time(); $cron_offset = $cron->time - time();
if ( if (
$cron_offset >= $this->timeout_missed_cron && $cron_offset >= $this->timeout_missed_cron &&
$cron_offset < $this->timeout_late_cron $cron_offset < $this->timeout_late_cron
) { ) {
$this->last_late_cron = $cron->hook; $this->last_late_cron = $cron->hook;
return true; return true;
} }
@ -2349,14 +2349,18 @@ class WP_Site_Health {
$plugin_filter_present = has_filter( 'auto_update_plugin' ); $plugin_filter_present = has_filter( 'auto_update_plugin' );
$theme_filter_present = has_filter( 'auto_update_theme' ); $theme_filter_present = has_filter( 'auto_update_theme' );
if ( ( ! $test_plugins_enabled && $ui_enabled_for_plugins ) || ( $test_themes_enabled && $ui_enabled_for_themes ) ) { if ( ( ! $test_plugins_enabled && $ui_enabled_for_plugins )
|| ( ! $test_themes_enabled && $ui_enabled_for_themes )
) {
return (object) array( return (object) array(
'status' => 'critical', 'status' => 'critical',
'message' => __( 'Auto-updates for plugins and/or themes appear to be disabled, but settings are still set to be displayed. This could cause auto-updates to not work as expected.' ), 'message' => __( 'Auto-updates for plugins and/or themes appear to be disabled, but settings are still set to be displayed. This could cause auto-updates to not work as expected.' ),
); );
} }
if ( ( ! $test_plugins_enabled && $plugin_filter_present ) && ( ! $test_themes_enabled && $theme_filter_present ) ) { if ( ( ! $test_plugins_enabled && $plugin_filter_present )
&& ( ! $test_themes_enabled && $theme_filter_present )
) {
return (object) array( return (object) array(
'status' => 'recommended', 'status' => 'recommended',
'message' => __( 'Auto-updates for plugins and themes appear to be disabled. This will prevent your sites from receiving new versions automatically when available.' ), 'message' => __( 'Auto-updates for plugins and themes appear to be disabled. This will prevent your sites from receiving new versions automatically when available.' ),

View File

@ -13,7 +13,7 @@
* *
* @global string $wp_version * @global string $wp_version
*/ */
$wp_version = '5.5-beta3-48558'; $wp_version = '5.5-beta3-48559';
/** /**
* Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema. * Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.