Users: Remove some links to the dashboard from My Sites for users who cannot access it.

See #41453

Built from https://develop.svn.wordpress.org/trunk@41796


git-svn-id: http://core.svn.wordpress.org/trunk@41630 1a063a9b-81f0-0310-95a4-ce76da25c4cd

wp-admin/my-sites.php

@@ -108,20 +108,33 @@ else :
 	reset( $blogs );
 
 	foreach ( $blogs as $user_blog ) {
+		switch_to_blog( $user_blog->userblog_id );
+
 		echo "<li>";
 		echo "<h3>{$user_blog->blogname}</h3>";
+
+		$actions = "<a href='" . esc_url( home_url() ). "'>" . __( 'Visit' ) . '</a>';
+
+		if ( current_user_can( 'read' ) ) {
+			$actions .= " | <a href='" . esc_url( admin_url() ) . "'>" . __( 'Dashboard' ) . '</a>';
+		}
+
 		/**
 		 * Filters the row links displayed for each site on the My Sites screen.
 		 *
 		 * @since MU (3.0.0)
 		 *
-		 * @param string $string    The HTML site link markup.
+		 * @param string $actions   The HTML site link markup.
 		 * @param object $user_blog An object containing the site data.
 		 */
-		echo "<p class='my-sites-actions'>" . apply_filters( 'myblogs_blog_actions', "<a href='" . esc_url( get_home_url( $user_blog->userblog_id ) ). "'>" . __( 'Visit' ) . "</a> | <a href='" . esc_url( get_admin_url( $user_blog->userblog_id ) ) . "'>" . __( 'Dashboard' ) . "</a>", $user_blog ) . "</p>";
+		$actions = apply_filters( 'myblogs_blog_actions', $actions, $user_blog );
+		echo "<p class='my-sites-actions'>" . $actions . '</p>';
+
 		/** This filter is documented in wp-admin/my-sites.php */
 		echo apply_filters( 'myblogs_options', '', $user_blog );
 		echo "</li>";
+
+		restore_current_blog();
 	}?>
 	</ul>
 	<?php

wp-includes/admin-bar.php

@@ -520,6 +520,7 @@ function wp_admin_bar_my_sites_menu( $wp_admin_bar ) {
 
 		$menu_id  = 'blog-' . $blog->userblog_id;
 
+		if ( current_user_can( 'read' ) ) {
 			$wp_admin_bar->add_menu( array(
 				'parent'    => 'my-sites-list',
 				'id'        => $menu_id,
@@ -533,6 +534,14 @@ function wp_admin_bar_my_sites_menu( $wp_admin_bar ) {
 				'title'  => __( 'Dashboard' ),
 				'href'   => admin_url(),
 			) );
+		} else {
+			$wp_admin_bar->add_menu( array(
+				'parent'    => 'my-sites-list',
+				'id'        => $menu_id,
+				'title'     => $blavatar . $blogname,
+				'href'      => home_url(),
+			) );
+		}
 
 		if ( current_user_can( get_post_type_object( 'post' )->cap->create_posts ) ) {
 			$wp_admin_bar->add_menu( array(

wp-includes/version.php

@@ -4,7 +4,7 @@
  *
  * @global string $wp_version
  */
-$wp_version = '4.9-beta1-41795';
+$wp_version = '4.9-beta1-41796';
 
 /**
  * Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.