From cf3deb2ecbfe3d6bbcaa719f6df7c4bdbebbe717 Mon Sep 17 00:00:00 2001 From: Scott Taylor Date: Wed, 16 Jul 2014 21:52:15 +0000 Subject: [PATCH] Avoid a race condition when multiple windows are open so that orphaned terms cannot be created by accident. Adds a unit test. Props dlh. Fixes #19205. Built from https://develop.svn.wordpress.org/trunk@29196 git-svn-id: http://core.svn.wordpress.org/trunk@28980 1a063a9b-81f0-0310-95a4-ce76da25c4cd --- wp-includes/taxonomy.php | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/wp-includes/taxonomy.php b/wp-includes/taxonomy.php index fb0dcffd42..5c7ce930e1 100644 --- a/wp-includes/taxonomy.php +++ b/wp-includes/taxonomy.php @@ -2418,7 +2418,11 @@ function wp_insert_term( $term, $taxonomy, $args = array() ) { return new WP_Error('empty_term_name', __('A name is required for this term')); } $defaults = array( 'alias_of' => '', 'description' => '', 'parent' => 0, 'slug' => ''); - $args = wp_parse_args($args, $defaults); + $args = wp_parse_args( $args, $defaults ); + + if ( $args['parent'] > 0 && ! term_exists( (int) $args['parent'] ) ) { + return new WP_Error( 'missing_parent', __( 'The selected parent term no longer exists' ) ); + } $args['name'] = $term; $args['taxonomy'] = $taxonomy; $args = sanitize_term($args, $taxonomy, 'db');