Help/About: Fix tab display issues.

This change restores About page tab heights and fixes bugs with the tab bottom border caused by [44905] and [45243].

Reviewed by SergeyBiryukov and desrosj.

Props ixkaito, ianbelanger, afercia, SergeyBiryukov.
See #46901.
Fixes #47075.
Built from https://develop.svn.wordpress.org/trunk@45276


git-svn-id: http://core.svn.wordpress.org/trunk@45085 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commit is contained in:
desrosj 2019-05-02 10:37:51 +00:00
parent 6ac1d4ec1a
commit d53659ed71
38 changed files with 56 additions and 40 deletions

View File

@ -111,6 +111,7 @@
padding-left: 15px; padding-left: 15px;
padding-right: 15px; padding-right: 15px;
font-size: 18px; font-size: 18px;
line-height: 1.33333333;
} }
/* 1.1 - Typography */ /* 1.1 - Typography */

File diff suppressed because one or more lines are too long

View File

@ -111,6 +111,7 @@
padding-right: 15px; padding-right: 15px;
padding-left: 15px; padding-left: 15px;
font-size: 18px; font-size: 18px;
line-height: 1.33333333;
} }
/* 1.1 - Typography */ /* 1.1 - Typography */

File diff suppressed because one or more lines are too long

View File

@ -130,7 +130,7 @@ input[type=radio]:checked:before {
/* Active tabs use a bottom border color that matches the page background color. */ /* Active tabs use a bottom border color that matches the page background color. */
.about-wrap h2 .nav-tab-active, .about-wrap .nav-tab-active,
.nav-tab-active, .nav-tab-active,
.nav-tab-active:hover { .nav-tab-active:hover {
background-color: $body-background; background-color: $body-background;

View File

@ -153,7 +153,7 @@ input[type=radio]:checked:before {
} }
/* Active tabs use a bottom border color that matches the page background color. */ /* Active tabs use a bottom border color that matches the page background color. */
.about-wrap h2 .nav-tab-active, .about-wrap .nav-tab-active,
.nav-tab-active, .nav-tab-active,
.nav-tab-active:hover { .nav-tab-active:hover {
background-color: #f1f1f1; background-color: #f1f1f1;

File diff suppressed because one or more lines are too long

View File

@ -153,7 +153,7 @@ input[type=radio]:checked:before {
} }
/* Active tabs use a bottom border color that matches the page background color. */ /* Active tabs use a bottom border color that matches the page background color. */
.about-wrap h2 .nav-tab-active, .about-wrap .nav-tab-active,
.nav-tab-active, .nav-tab-active,
.nav-tab-active:hover { .nav-tab-active:hover {
background-color: #f1f1f1; background-color: #f1f1f1;

File diff suppressed because one or more lines are too long

View File

@ -153,7 +153,7 @@ input[type=radio]:checked:before {
} }
/* Active tabs use a bottom border color that matches the page background color. */ /* Active tabs use a bottom border color that matches the page background color. */
.about-wrap h2 .nav-tab-active, .about-wrap .nav-tab-active,
.nav-tab-active, .nav-tab-active,
.nav-tab-active:hover { .nav-tab-active:hover {
background-color: #f1f1f1; background-color: #f1f1f1;

File diff suppressed because one or more lines are too long

View File

@ -153,7 +153,7 @@ input[type=radio]:checked:before {
} }
/* Active tabs use a bottom border color that matches the page background color. */ /* Active tabs use a bottom border color that matches the page background color. */
.about-wrap h2 .nav-tab-active, .about-wrap .nav-tab-active,
.nav-tab-active, .nav-tab-active,
.nav-tab-active:hover { .nav-tab-active:hover {
background-color: #f1f1f1; background-color: #f1f1f1;

File diff suppressed because one or more lines are too long

View File

@ -153,7 +153,7 @@ input[type=radio]:checked:before {
} }
/* Active tabs use a bottom border color that matches the page background color. */ /* Active tabs use a bottom border color that matches the page background color. */
.about-wrap h2 .nav-tab-active, .about-wrap .nav-tab-active,
.nav-tab-active, .nav-tab-active,
.nav-tab-active:hover { .nav-tab-active:hover {
background-color: #f1f1f1; background-color: #f1f1f1;

File diff suppressed because one or more lines are too long

View File

@ -153,7 +153,7 @@ input[type=radio]:checked:before {
} }
/* Active tabs use a bottom border color that matches the page background color. */ /* Active tabs use a bottom border color that matches the page background color. */
.about-wrap h2 .nav-tab-active, .about-wrap .nav-tab-active,
.nav-tab-active, .nav-tab-active,
.nav-tab-active:hover { .nav-tab-active:hover {
background-color: #f1f1f1; background-color: #f1f1f1;

File diff suppressed because one or more lines are too long

View File

@ -153,7 +153,7 @@ input[type=radio]:checked:before {
} }
/* Active tabs use a bottom border color that matches the page background color. */ /* Active tabs use a bottom border color that matches the page background color. */
.about-wrap h2 .nav-tab-active, .about-wrap .nav-tab-active,
.nav-tab-active, .nav-tab-active,
.nav-tab-active:hover { .nav-tab-active:hover {
background-color: #f5f5f5; background-color: #f5f5f5;

File diff suppressed because one or more lines are too long

View File

@ -153,7 +153,7 @@ input[type=radio]:checked:before {
} }
/* Active tabs use a bottom border color that matches the page background color. */ /* Active tabs use a bottom border color that matches the page background color. */
.about-wrap h2 .nav-tab-active, .about-wrap .nav-tab-active,
.nav-tab-active, .nav-tab-active,
.nav-tab-active:hover { .nav-tab-active:hover {
background-color: #f5f5f5; background-color: #f5f5f5;

File diff suppressed because one or more lines are too long

View File

@ -153,7 +153,7 @@ input[type=radio]:checked:before {
} }
/* Active tabs use a bottom border color that matches the page background color. */ /* Active tabs use a bottom border color that matches the page background color. */
.about-wrap h2 .nav-tab-active, .about-wrap .nav-tab-active,
.nav-tab-active, .nav-tab-active,
.nav-tab-active:hover { .nav-tab-active:hover {
background-color: #f1f1f1; background-color: #f1f1f1;

File diff suppressed because one or more lines are too long

View File

@ -153,7 +153,7 @@ input[type=radio]:checked:before {
} }
/* Active tabs use a bottom border color that matches the page background color. */ /* Active tabs use a bottom border color that matches the page background color. */
.about-wrap h2 .nav-tab-active, .about-wrap .nav-tab-active,
.nav-tab-active, .nav-tab-active,
.nav-tab-active:hover { .nav-tab-active:hover {
background-color: #f1f1f1; background-color: #f1f1f1;

File diff suppressed because one or more lines are too long

View File

@ -153,7 +153,7 @@ input[type=radio]:checked:before {
} }
/* Active tabs use a bottom border color that matches the page background color. */ /* Active tabs use a bottom border color that matches the page background color. */
.about-wrap h2 .nav-tab-active, .about-wrap .nav-tab-active,
.nav-tab-active, .nav-tab-active,
.nav-tab-active:hover { .nav-tab-active:hover {
background-color: #f1f1f1; background-color: #f1f1f1;

File diff suppressed because one or more lines are too long

View File

@ -153,7 +153,7 @@ input[type=radio]:checked:before {
} }
/* Active tabs use a bottom border color that matches the page background color. */ /* Active tabs use a bottom border color that matches the page background color. */
.about-wrap h2 .nav-tab-active, .about-wrap .nav-tab-active,
.nav-tab-active, .nav-tab-active,
.nav-tab-active:hover { .nav-tab-active:hover {
background-color: #f1f1f1; background-color: #f1f1f1;

File diff suppressed because one or more lines are too long

View File

@ -153,7 +153,7 @@ input[type=radio]:checked:before {
} }
/* Active tabs use a bottom border color that matches the page background color. */ /* Active tabs use a bottom border color that matches the page background color. */
.about-wrap h2 .nav-tab-active, .about-wrap .nav-tab-active,
.nav-tab-active, .nav-tab-active,
.nav-tab-active:hover { .nav-tab-active:hover {
background-color: #f1f1f1; background-color: #f1f1f1;

File diff suppressed because one or more lines are too long

View File

@ -153,7 +153,7 @@ input[type=radio]:checked:before {
} }
/* Active tabs use a bottom border color that matches the page background color. */ /* Active tabs use a bottom border color that matches the page background color. */
.about-wrap h2 .nav-tab-active, .about-wrap .nav-tab-active,
.nav-tab-active, .nav-tab-active,
.nav-tab-active:hover { .nav-tab-active:hover {
background-color: #f1f1f1; background-color: #f1f1f1;

File diff suppressed because one or more lines are too long

View File

@ -2171,7 +2171,7 @@ html.wp-toolbar {
margin-right: 0.5em; /* half the font size so set the font size properly */ margin-right: 0.5em; /* half the font size so set the font size properly */
padding: 5px 10px; padding: 5px 10px;
font-size: 14px; font-size: 14px;
line-height: 1.8; line-height: 1.71428571;
font-weight: 600; font-weight: 600;
background: #e5e5e5; background: #e5e5e5;
color: #555; color: #555;
@ -3999,10 +3999,17 @@ img {
h1 .nav-tab, h1 .nav-tab,
h2 .nav-tab, h2 .nav-tab,
h3 .nav-tab { h3 .nav-tab,
nav .nav-tab {
margin: 10px 0 0 10px; margin: 10px 0 0 10px;
border-bottom: 1px solid #ccc; border-bottom: 1px solid #ccc;
} }
.nav-tab-active:hover,
.nav-tab-active:focus,
.nav-tab-active:focus:active {
border-bottom: 1px solid #ccc;
}
} }
@media screen and (max-width: 320px) { @media screen and (max-width: 320px) {

File diff suppressed because one or more lines are too long

View File

@ -2171,7 +2171,7 @@ html.wp-toolbar {
margin-left: 0.5em; /* half the font size so set the font size properly */ margin-left: 0.5em; /* half the font size so set the font size properly */
padding: 5px 10px; padding: 5px 10px;
font-size: 14px; font-size: 14px;
line-height: 1.8; line-height: 1.71428571;
font-weight: 600; font-weight: 600;
background: #e5e5e5; background: #e5e5e5;
color: #555; color: #555;
@ -3999,10 +3999,17 @@ img {
h1 .nav-tab, h1 .nav-tab,
h2 .nav-tab, h2 .nav-tab,
h3 .nav-tab { h3 .nav-tab,
nav .nav-tab {
margin: 10px 10px 0 0; margin: 10px 10px 0 0;
border-bottom: 1px solid #ccc; border-bottom: 1px solid #ccc;
} }
.nav-tab-active:hover,
.nav-tab-active:focus,
.nav-tab-active:focus:active {
border-bottom: 1px solid #ccc;
}
} }
@media screen and (max-width: 320px) { @media screen and (max-width: 320px) {

File diff suppressed because one or more lines are too long

View File

@ -13,7 +13,7 @@
* *
* @global string $wp_version * @global string $wp_version
*/ */
$wp_version = '5.2-RC1-45275'; $wp_version = '5.2-RC1-45276';
/** /**
* Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema. * Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.