WordPress-C
/
WordPress
mirror of https://github.com/WordPress/WordPress.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Sanity int casts in custom header step_3. props xknown, fixes #17779. 

git-svn-id: http://svn.automattic.com/wordpress/trunk@18298 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commit is contained in:
nacin 2011-06-13 08:50:16 +00:00
parent 9d2edcd9ac
commit e149164921
1 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
wp-admin/custom-header.php
View File

@ -721,21 +721,22 @@ wp_nonce_field( 'custom-header-options', '_wpnonce-custom-header-options' ); ?>
$_POST['height'] = $_POST['height'] * $_POST['oitar']; $_POST['height'] = $_POST['height'] * $_POST['oitar'];
} }
$original = get_attached_file( $_POST['attachment_id'] ); $attachment_id = absint( $_POST['attachment_id'] );
$original = get_attached_file($attachment_id);
$cropped = wp_crop_image($_POST['attachment_id'], $_POST['x1'], $_POST['y1'], $_POST['width'], $_POST['height'], HEADER_IMAGE_WIDTH, HEADER_IMAGE_HEIGHT); $cropped = wp_crop_image( $attachment_id, (int) $_POST['x1'], (int) $_POST['y1'], (int) $_POST['width'], (int) $_POST['height'], HEADER_IMAGE_WIDTH, HEADER_IMAGE_HEIGHT );
if ( is_wp_error( $cropped ) ) if ( is_wp_error( $cropped ) )
wp_die( __( 'Image could not be processed. Please go back and try again.' ), __( 'Image Processing Error' ) ); wp_die( __( 'Image could not be processed. Please go back and try again.' ), __( 'Image Processing Error' ) );
$cropped = apply_filters('wp_create_file_in_uploads', $cropped, $_POST['attachment_id']); // For replication $cropped = apply_filters('wp_create_file_in_uploads', $cropped, $attachment_id); // For replication
$parent = get_post($_POST['attachment_id']); $parent = get_post($attachment_id);
$parent_url = $parent->guid; $parent_url = $parent->guid;
$url = str_replace(basename($parent_url), basename($cropped), $parent_url); $url = str_replace(basename($parent_url), basename($cropped), $parent_url);
// Construct the object array // Construct the object array
$object = array( $object = array(
'ID' => $_POST['attachment_id'], 'ID' => $attachment_id,
'post_title' => basename($cropped), 'post_title' => basename($cropped),
'post_content' => $url, 'post_content' => $url,
'post_mime_type' => 'image/jpeg', 'post_mime_type' => 'image/jpeg',
@ -745,8 +746,8 @@ wp_nonce_field( 'custom-header-options', '_wpnonce-custom-header-options' ); ?>
// Update the attachment // Update the attachment
wp_insert_attachment($object, $cropped); wp_insert_attachment($object, $cropped);
wp_update_attachment_metadata( $_POST['attachment_id'], wp_generate_attachment_metadata( $_POST['attachment_id'], $cropped ) ); wp_update_attachment_metadata( $attachment_id, wp_generate_attachment_metadata( $attachment_id, $cropped ) );
update_post_meta( $_POST['attachment_id'], '_wp_attachment_is_custom_header', get_option('stylesheet' ) ); update_post_meta( $attachment_id, '_wp_attachment_is_custom_header', get_option('stylesheet' ) );
set_theme_mod('header_image', $url); set_theme_mod('header_image', $url);