From e2339bdb1b17dcf2e3ae26695cc62949f61c496d Mon Sep 17 00:00:00 2001 From: Boone Gorges Date: Thu, 20 Nov 2014 01:52:23 +0000 Subject: [PATCH] Return an empty array from `get_approved_comments()` when `$post_id` is empty. This behavior was broken when moving the internals to `WP_Comment_Query` in [30098]. As a result, `get_approved_comments( 0 )` was fetching *all* approved comments, causing performance issues. Props dd32. Fixes #30412. Built from https://develop.svn.wordpress.org/trunk@30402 git-svn-id: http://core.svn.wordpress.org/trunk@30397 1a063a9b-81f0-0310-95a4-ce76da25c4cd --- wp-includes/comment.php | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/wp-includes/comment.php b/wp-includes/comment.php index a3e4ac1b4b..5d5689b9df 100644 --- a/wp-includes/comment.php +++ b/wp-includes/comment.php @@ -136,7 +136,11 @@ function check_comment($author, $email, $url, $comment, $user_ip, $user_agent, $ * @return int|array $comments The approved comments, or number of comments if `$count` * argument is true. */ -function get_approved_comments( $post_id = 0, $args = array() ) { +function get_approved_comments( $post_id, $args = array() ) { + if ( ! $post_id ) { + return array(); + } + $defaults = array( 'status' => 1, 'post_id' => $post_id,