WordPress-C/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2025-02-16 19:46:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

Trigger _doing_it_wrong() if register_sidebar() is not passed an id

Browse Source 
* If you don't pass an `id`, WP sets an auto-increment one for you.
* But this depends on order of sidebar definition.
* Change the order or remove a sidebar? They jumble.

fixes #31675
props tschutter, valendesigns
Built from https://develop.svn.wordpress.org/trunk@31850


git-svn-id: http://core.svn.wordpress.org/trunk@31829 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commit is contained in:
Mark Jaquith 2015-03-20 18:30:27 +00:00
parent a7eedc5f23
commit e2c7f8d96e
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
wp-includes/widgets.php
View File

@ -803,6 +803,10 @@ function register_sidebar($args = array()) {
$i = count($wp_registered_sidebars) + 1; $i = count($wp_registered_sidebars) + 1;
if ( empty( $args['id'] ) ) {
_doing_it_wrong( __FUNCTION__, sprintf( __( 'You should set %s in the arguments array.' ), 'id' ), '4.2.0' );
}
$defaults = array( $defaults = array(
'name' => sprintf(__('Sidebar %d'), $i ), 'name' => sprintf(__('Sidebar %d'), $i ),
'id' => "sidebar-$i", 'id' => "sidebar-$i",