From f7c4398ea9f7ffc3345c468e4a746163299672f7 Mon Sep 17 00:00:00 2001 From: Sergey Biryukov Date: Wed, 17 Jul 2019 18:45:58 +0000 Subject: [PATCH] Menus: Trim whitespace from custom link URLs. Props majemedia, SergeyBiryukov. Fixes #47723. Built from https://develop.svn.wordpress.org/trunk@45655 git-svn-id: http://core.svn.wordpress.org/trunk@45466 1a063a9b-81f0-0310-95a4-ce76da25c4cd --- wp-includes/nav-menu.php | 14 +++++++++----- wp-includes/version.php | 2 +- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/wp-includes/nav-menu.php b/wp-includes/nav-menu.php index 9b6eeba9b3..863183a92b 100644 --- a/wp-includes/nav-menu.php +++ b/wp-includes/nav-menu.php @@ -456,11 +456,15 @@ function wp_update_nav_menu_item( $menu_id = 0, $menu_item_db_id = 0, $menu_item $original_parent = 0 < $menu_item_db_id ? get_post_field( 'post_parent', $menu_item_db_id ) : 0; - if ( 'custom' != $args['menu-item-type'] ) { - /* if non-custom menu item, then: - * use original object's URL - * blank default title to sync with original object's - */ + if ( 'custom' === $args['menu-item-type'] ) { + // If custom menu item, trim the URL. + $args[ 'menu-item-url' ] = trim( $args[ 'menu-item-url' ] ); + } else { + /* + * If non-custom menu item, then: + * - use the original object's URL. + * - blank default title to sync with the original object's title. + */ $args['menu-item-url'] = ''; diff --git a/wp-includes/version.php b/wp-includes/version.php index dff026e394..7c55ae5df1 100644 --- a/wp-includes/version.php +++ b/wp-includes/version.php @@ -13,7 +13,7 @@ * * @global string $wp_version */ -$wp_version = '5.3-alpha-45654'; +$wp_version = '5.3-alpha-45655'; /** * Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.