WordPress-C
/
WordPress
mirror of https://github.com/WordPress/WordPress.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Accessibility: Remove title attributes from the Plugin details modal. 

Also, improves accessibility of the star rating reviews links.

Fixes #35111.
Built from https://develop.svn.wordpress.org/trunk@36618


git-svn-id: http://core.svn.wordpress.org/trunk@36585 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commit is contained in:
Andrea Fercia 2016-02-22 23:18:29 +00:00
parent 7ebe2c1e7a
commit f96653c2b5
6 changed files with 26 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
wp-admin/css/common-rtl.css
View File

@ -2521,6 +2521,10 @@ div.action-links {
margin: 0 0 10px; margin: 0 0 10px;
} }
#plugin-information .fyi-description {
margin-top: 0;
}
#plugin-information .counter-container { #plugin-information .counter-container {
margin: 3px 0; margin: 3px 0;
} }

2
wp-admin/css/common-rtl.min.css vendored
View File

File diff suppressed because one or more lines are too long

4
wp-admin/css/common.css
View File

@ -2521,6 +2521,10 @@ div.action-links {
margin: 0 0 10px; margin: 0 0 10px;
} }
#plugin-information .fyi-description {
margin-top: 0;
}
#plugin-information .counter-container { #plugin-information .counter-container {
margin: 3px 0; margin: 3px 0;
} }

2
wp-admin/css/common.min.css vendored
View File

File diff suppressed because one or more lines are too long

29
wp-admin/includes/plugin-install.php
View File

@ -537,12 +537,6 @@ function install_plugin_information() {
echo "</div>\n"; echo "</div>\n";
$date_format = __( 'M j, Y @ H:i' );
if ( ! empty( $api->last_updated ) ) {
$last_updated_timestamp = strtotime( $api->last_updated );
}
?> ?>
<div id="<?php echo $_tab; ?>-content" class='<?php echo $_with_banner; ?>'> <div id="<?php echo $_tab; ?>-content" class='<?php echo $_with_banner; ?>'>
<div class="fyi"> <div class="fyi">
@ -552,9 +546,9 @@ function install_plugin_information() {
<?php } if ( ! empty( $api->author ) ) { ?> <?php } if ( ! empty( $api->author ) ) { ?>
<li><strong><?php _e( 'Author:' ); ?></strong> <?php echo links_add_target( $api->author, '_blank' ); ?></li> <li><strong><?php _e( 'Author:' ); ?></strong> <?php echo links_add_target( $api->author, '_blank' ); ?></li>
<?php } if ( ! empty( $api->last_updated ) ) { ?> <?php } if ( ! empty( $api->last_updated ) ) { ?>
<li><strong><?php _e( 'Last Updated:' ); ?></strong> <span title="<?php echo esc_attr( date_i18n( $date_format, $last_updated_timestamp ) ); ?>"> <li><strong><?php _e( 'Last Updated:' ); ?></strong>
<?php printf( __( '%s ago' ), human_time_diff( $last_updated_timestamp ) ); ?> <?php printf( __( '%s ago' ), human_time_diff( strtotime( $api->last_updated ) ) ); ?>
</span></li> </li>
<?php } if ( ! empty( $api->requires ) ) { ?> <?php } if ( ! empty( $api->requires ) ) { ?>
<li><strong><?php _e( 'Requires WordPress Version:' ); ?></strong> <?php printf( __( '%s or higher' ), $api->requires ); ?></li> <li><strong><?php _e( 'Requires WordPress Version:' ); ?></strong> <?php printf( __( '%s or higher' ), $api->requires ); ?></li>
<?php } if ( ! empty( $api->tested ) ) { ?> <?php } if ( ! empty( $api->tested ) ) { ?>
@ -578,22 +572,29 @@ function install_plugin_information() {
<?php if ( ! empty( $api->rating ) ) { ?> <?php if ( ! empty( $api->rating ) ) { ?>
<h3><?php _e( 'Average Rating' ); ?></h3> <h3><?php _e( 'Average Rating' ); ?></h3>
<?php wp_star_rating( array( 'rating' => $api->rating, 'type' => 'percent', 'number' => $api->num_ratings ) ); ?> <?php wp_star_rating( array( 'rating' => $api->rating, 'type' => 'percent', 'number' => $api->num_ratings ) ); ?>
<small aria-hidden="true"><?php printf( _n( '(based on %s rating)', '(based on %s ratings)', $api->num_ratings ), number_format_i18n( $api->num_ratings ) ); ?></small> <p aria-hidden="true" class="fyi-description"><?php printf( _n( '(based on %s rating)', '(based on %s ratings)', $api->num_ratings ), number_format_i18n( $api->num_ratings ) ); ?></p>
<?php } <?php }
if ( ! empty( $api->ratings ) && array_sum( (array) $api->ratings ) > 0 ) { if ( ! empty( $api->ratings ) && array_sum( (array) $api->ratings ) > 0 ) { ?>
<h3><?php _e( 'Reviews' ); ?></h3>
<p class="fyi-description"><?php _e( 'Read all reviews on WordPress.org or write your own!' ); ?></p>
<?php
foreach ( $api->ratings as $key => $ratecount ) { foreach ( $api->ratings as $key => $ratecount ) {
// Avoid div-by-zero. // Avoid div-by-zero.
$_rating = $api->num_ratings ? ( $ratecount / $api->num_ratings ) : 0; $_rating = $api->num_ratings ? ( $ratecount / $api->num_ratings ) : 0;
/* translators: 1: number of stars, 2: number of reviews */
$aria_label = esc_attr( sprintf( _n( 'Reviews with %1$d star: %2$d. Opens in a new window.', 'Reviews with %1$d stars: %2$d. Opens in a new window.', $key ),
$key,
number_format_i18n( $ratecount )
) );
?> ?>
<div class="counter-container"> <div class="counter-container">
<span class="counter-label"><a href="https://wordpress.org/support/view/plugin-reviews/<?php echo $api->slug; ?>?filter=<?php echo $key; ?>" <span class="counter-label"><a href="https://wordpress.org/support/view/plugin-reviews/<?php echo $api->slug; ?>?filter=<?php echo $key; ?>"
target="_blank" target="_blank" aria-label="<?php echo $aria_label; ?>"><?php printf( _n( '%d star', '%d stars', $key ), $key ); ?></a></span>
title="<?php echo esc_attr( sprintf( _n( 'Click to see reviews that provided a rating of %d star', 'Click to see reviews that provided a rating of %d stars', $key ), $key ) ); ?>"><?php printf( _n( '%d star', '%d stars', $key ), $key ); ?></a></span>
<span class="counter-back"> <span class="counter-back">
<span class="counter-bar" style="width: <?php echo 92 * $_rating; ?>px;"></span> <span class="counter-bar" style="width: <?php echo 92 * $_rating; ?>px;"></span>
</span> </span>
<span class="counter-count"><?php echo number_format_i18n( $ratecount ); ?></span> <span class="counter-count" aria-hidden="true"><?php echo number_format_i18n( $ratecount ); ?></span>
</div> </div>
<?php <?php
} }

2
wp-includes/version.php
View File

@ -4,7 +4,7 @@
* *
* @global string $wp_version * @global string $wp_version
*/ */
$wp_version = '4.5-alpha-36617'; $wp_version = '4.5-alpha-36618';
/** /**
* Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema. * Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.