From f996e163b852e4fade9ee91c7962fecf53aee3d5 Mon Sep 17 00:00:00 2001 From: Jeremy Felt Date: Sun, 14 Jun 2015 05:01:28 +0000 Subject: [PATCH] Improve code readability in site-info.php In advance of some other work here, clean up some braces and spaces. See #22383. Built from https://develop.svn.wordpress.org/trunk@32758 git-svn-id: http://core.svn.wordpress.org/trunk@32729 1a063a9b-81f0-0310-95a4-ce76da25c4cd --- wp-admin/network/site-info.php | 55 +++++++++++++++++++--------------- wp-includes/version.php | 2 +- 2 files changed, 32 insertions(+), 25 deletions(-) diff --git a/wp-admin/network/site-info.php b/wp-admin/network/site-info.php index 87ca256378..a7c2a14a6c 100644 --- a/wp-admin/network/site-info.php +++ b/wp-admin/network/site-info.php @@ -10,42 +10,46 @@ /** Load WordPress Administration Bootstrap */ require_once( dirname( __FILE__ ) . '/admin.php' ); -if ( ! is_multisite() ) +if ( ! is_multisite() ) { wp_die( __( 'Multisite support is not enabled.' ) ); +} -if ( ! current_user_can( 'manage_sites' ) ) +if ( ! current_user_can( 'manage_sites' ) ) { wp_die( __( 'You do not have sufficient permissions to edit this site.' ) ); +} - get_current_screen()->add_help_tab( array( - 'id' => 'overview', - 'title' => __('Overview'), - 'content' => - '

' . __('The menu is for editing information specific to individual sites, particularly if the admin area of a site is unavailable.') . '

' . - '

' . __('Info - The domain and path are rarely edited as this can cause the site to not work properly. The Registered date and Last Updated date are displayed. Network admins can mark a site as archived, spam, deleted and mature, to remove from public listings or disable.') . '

' . - '

' . __('Users - This displays the users associated with this site. You can also change their role, reset their password, or remove them from the site. Removing the user from the site does not remove the user from the network.') . '

' . - '

' . sprintf( __('Themes - This area shows themes that are not already enabled across the network. Enabling a theme in this menu makes it accessible to this site. It does not activate the theme, but allows it to show in the site’s Appearance menu. To enable a theme for the entire network, see the Network Themes screen.' ), network_admin_url( 'themes.php' ) ) . '

' . - '

' . __('Settings - This page shows a list of all settings associated with this site. Some are created by WordPress and others are created by plugins you activate. Note that some fields are grayed out and say Serialized Data. You cannot modify these values due to the way the setting is stored in the database.') . '

' +get_current_screen()->add_help_tab( array( + 'id' => 'overview', + 'title' => __( 'Overview' ), + 'content' => + '

' . __( 'The menu is for editing information specific to individual sites, particularly if the admin area of a site is unavailable.' ) . '

' . + '

' . __( 'Info - The domain and path are rarely edited as this can cause the site to not work properly. The Registered date and Last Updated date are displayed. Network admins can mark a site as archived, spam, deleted and mature, to remove from public listings or disable.' ) . '

' . + '

' . __( 'Users - This displays the users associated with this site. You can also change their role, reset their password, or remove them from the site. Removing the user from the site does not remove the user from the network.' ) . '

' . + '

' . sprintf( __( 'Themes - This area shows themes that are not already enabled across the network. Enabling a theme in this menu makes it accessible to this site. It does not activate the theme, but allows it to show in the site’s Appearance menu. To enable a theme for the entire network, see the Network Themes screen.' ), network_admin_url( 'themes.php' ) ) . '

' . + '

' . __( 'Settings - This page shows a list of all settings associated with this site. Some are created by WordPress and others are created by plugins you activate. Note that some fields are grayed out and say Serialized Data. You cannot modify these values due to the way the setting is stored in the database.' ) . '

' ) ); get_current_screen()->set_help_sidebar( - '

' . __('For more information:') . '

' . - '

' . __('Documentation on Site Management') . '

' . - '

' . __('Support Forums') . '

' + '

' . __( 'For more information:' ) . '

' . + '

' . __( 'Documentation on Site Management' ) . '

' . + '

' . __( 'Support Forums' ) . '

' ); $id = isset( $_REQUEST['id'] ) ? intval( $_REQUEST['id'] ) : 0; -if ( ! $id ) +if ( ! $id ) { wp_die( __('Invalid site ID.') ); +} $details = get_blog_details( $id ); -if ( !can_edit_network( $details->site_id ) ) +if ( ! can_edit_network( $details->site_id ) ) { wp_die( __( 'You do not have permission to access this page.' ), 403 ); +} $parsed = parse_url( $details->siteurl ); $is_main_site = is_main_site( $id ); -if ( isset($_REQUEST['action']) && 'update-site' == $_REQUEST['action'] ) { +if ( isset( $_REQUEST['action'] ) && 'update-site' == $_REQUEST['action'] ) { check_admin_referer( 'edit-site' ); switch_to_blog( $id ); @@ -58,10 +62,11 @@ if ( isset($_REQUEST['action']) && 'update-site' == $_REQUEST['action'] ) { $existing_details = get_blog_details( $id, false ); $blog_data_checkboxes = array( 'public', 'archived', 'spam', 'mature', 'deleted' ); foreach ( $blog_data_checkboxes as $c ) { - if ( ! in_array( $existing_details->$c, array( 0, 1 ) ) ) + if ( ! in_array( $existing_details->$c, array( 0, 1 ) ) ) { $blog_data[ $c ] = $existing_details->$c; - else + } else { $blog_data[ $c ] = isset( $_POST['blog'][ $c ] ) ? 1 : 0; + } } update_blog_details( $id, $blog_data ); @@ -77,14 +82,15 @@ if ( isset($_REQUEST['action']) && 'update-site' == $_REQUEST['action'] ) { } restore_current_blog(); - wp_redirect( add_query_arg( array( 'update' => 'updated', 'id' => $id ), 'site-info.php') ); + wp_redirect( add_query_arg( array( 'update' => 'updated', 'id' => $id ), 'site-info.php' ) ); exit; } -if ( isset($_GET['update']) ) { +if ( isset( $_GET['update'] ) ) { $messages = array(); - if ( 'updated' == $_GET['update'] ) - $messages[] = __('Site info updated.'); + if ( 'updated' == $_GET['update'] ) { + $messages[] = __( 'Site info updated.' ); + } } $site_url_no_http = preg_replace( '#^http(s)?://#', '', get_blogaddress_by_id( $id ) ); @@ -116,8 +122,9 @@ foreach ( $tabs as $tab_id => $tab ) {

' . $msg . '

'; + } } ?>
diff --git a/wp-includes/version.php b/wp-includes/version.php index 06f95499b0..1706d7ecb1 100644 --- a/wp-includes/version.php +++ b/wp-includes/version.php @@ -4,7 +4,7 @@ * * @global string $wp_version */ -$wp_version = '4.3-alpha-32757'; +$wp_version = '4.3-alpha-32758'; /** * Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.