Robots: Remove contradictory directive check in `wp_robots()`.

Removes the mutually exclusive directives check in `wp_robots()`, ie allow both `follow` and `nofollow` to be specified and for `archive` and `noarchive` to be specified.

This fixes a bug in which WordPress would defer to the most permissive over the least permissive. When contradictory instructions are included, WordPress will defer to the search engine's or archivist's resolution policy: generally this is to observe the least, not most permissive.

Props Cybr, flixos90.
Fixes #52713.


Built from https://develop.svn.wordpress.org/trunk@50566


git-svn-id: http://core.svn.wordpress.org/trunk@50179 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commit is contained in:
Peter Wilson 2021-03-23 23:02:05 +00:00
parent d5a6a1ab44
commit fedd1d2b63
2 changed files with 2 additions and 15 deletions

View File

@ -15,6 +15,7 @@
* robots meta tag is output if there is at least one relevant directive. * robots meta tag is output if there is at least one relevant directive.
* *
* @since 5.7.0 * @since 5.7.0
* @since 5.7.1 No longer prevents specific directives to occur together.
*/ */
function wp_robots() { function wp_robots() {
/** /**
@ -30,20 +31,6 @@ function wp_robots() {
*/ */
$robots = apply_filters( 'wp_robots', array() ); $robots = apply_filters( 'wp_robots', array() );
// Don't allow mutually exclusive directives.
if ( ! empty( $robots['follow'] ) ) {
unset( $robots['nofollow'] );
}
if ( ! empty( $robots['nofollow'] ) ) {
unset( $robots['follow'] );
}
if ( ! empty( $robots['archive'] ) ) {
unset( $robots['noarchive'] );
}
if ( ! empty( $robots['noarchive'] ) ) {
unset( $robots['archive'] );
}
$robots_strings = array(); $robots_strings = array();
foreach ( $robots as $directive => $value ) { foreach ( $robots as $directive => $value ) {
if ( is_string( $value ) ) { if ( is_string( $value ) ) {

View File

@ -13,7 +13,7 @@
* *
* @global string $wp_version * @global string $wp_version
*/ */
$wp_version = '5.8-alpha-50565'; $wp_version = '5.8-alpha-50566';
/** /**
* Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema. * Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.