Joe McGill
7d43d71800
Media: Ensure WP_Screen sets post type on wp-admin/upload.php.
...
The post type property is set to 'attachment' when on the upload screen.
Props postpostmodern.
Fixes #39509 .
Built from https://develop.svn.wordpress.org/trunk@40800
git-svn-id: http://core.svn.wordpress.org/trunk@40658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-19 18:29:42 +00:00
Andrea Fercia
1a8f7ab144
Dashboard: Don't trigger an Events search when the search field is empty.
...
Fixes #40816 .
Built from https://develop.svn.wordpress.org/trunk@40799
git-svn-id: http://core.svn.wordpress.org/trunk@40657 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-19 17:27:43 +00:00
Konstantin Obenland
92642624fd
About: Optimize strings for l10n
...
Uses html entities for quotes and adds translator comment for event links.
Props ocean90.
See #40721 .
Built from https://develop.svn.wordpress.org/trunk@40798
git-svn-id: http://core.svn.wordpress.org/trunk@40656 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-19 16:45:44 +00:00
Andrea Fercia
e008a5c7db
Themes: Improve the theme installer Favorites and Feature Filter tabs alignment.
...
Props nitin kevadiya, darshan02, mp518.
Fixes #40315 .
Built from https://develop.svn.wordpress.org/trunk@40797
git-svn-id: http://core.svn.wordpress.org/trunk@40655 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-19 16:18:41 +00:00
Konstantin Obenland
359cc45e08
Docs: Improve inline docs for inlineEditPost.
...
Props jjcomack, rensw90.
Fixes #39823 .
Built from https://develop.svn.wordpress.org/trunk@40796
git-svn-id: http://core.svn.wordpress.org/trunk@40654 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-19 15:45:42 +00:00
Konstantin Obenland
14d0491fbf
Twenty Seventeen: Remove uneccessary return statement
...
Props truongwp.
Fixes #40516 .
Built from https://develop.svn.wordpress.org/trunk@40795
git-svn-id: http://core.svn.wordpress.org/trunk@40653 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-19 15:19:41 +00:00
Andrea Fercia
36d25d3960
Dashboard: Improve the Events widget spinner position after [40789].
...
Props iandunn.
Fixes #40735 .
Built from https://develop.svn.wordpress.org/trunk@40794
git-svn-id: http://core.svn.wordpress.org/trunk@40652 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-19 14:44:41 +00:00
Dominik Schilling
97e98a80f6
Dashboard: Use `get_user_locale()` for the news feed cache key.
...
Since the feed URL can be localized the cache key has to be built with the same locale as the current user is using.
Props iandunn.
Fixes #40417 .
Built from https://develop.svn.wordpress.org/trunk@40793
git-svn-id: http://core.svn.wordpress.org/trunk@40651 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-19 14:36:42 +00:00
Adam Silverstein
5ddd3f92e8
Media: make search input full width on mobile.
...
Props abhishekfdd.
Fixes #40130 .
Built from https://develop.svn.wordpress.org/trunk@40792
git-svn-id: http://core.svn.wordpress.org/trunk@40650 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-19 13:45:42 +00:00
Konstantin Obenland
34e2a6110e
About: Let's get a headstart on 4.8 about strings
...
Strings have been reviewed and are ready for translation—design will come soon.
Props bridgetwillard, jenblogs4u, michelleweber, ryelle, melchoyce.
See #40721 .
Built from https://develop.svn.wordpress.org/trunk@40791
git-svn-id: http://core.svn.wordpress.org/trunk@40649 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-19 11:55:44 +00:00
Andrew Ozz
7a9ce6d03f
Dashboard: Improve the handling of locations determined by geolocating the IP address and by entering a city name. Fix couple of edge cases, and some names.
...
Props iandunn coreymckrill.
Fixes #40702 .
Built from https://develop.svn.wordpress.org/trunk@40790
git-svn-id: http://core.svn.wordpress.org/trunk@40648 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-19 05:48:42 +00:00
Andrew Ozz
daab579a88
Dashboard:
...
- Close the form after obtaining a valid location.
- Fix focusing the toggle button after closing the form.
- Fix aria attribute values.
- Fix positions in IE11.
- Some JS and CSS cleanup.
Props afercia, coreymckrill.
Fixes #40735 .
Built from https://develop.svn.wordpress.org/trunk@40789
git-svn-id: http://core.svn.wordpress.org/trunk@40647 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-19 04:01:41 +00:00
Weston Ruter
bd990d7c4e
Docs: Add missing `@since` tags and phpdoc descriptions to the `Custom_Image_Header` class.
...
Amends [27497].
Props tejas5989, riddhiehta02, westonruter.
See #21785 .
Fixes #40231 .
Built from https://develop.svn.wordpress.org/trunk@40788
git-svn-id: http://core.svn.wordpress.org/trunk@40646 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-19 03:53:43 +00:00
Andrew Ozz
d7c37de2de
Editor: When stripping paragraph tags, and there is a <br> at the beginning or the end, merge them and keep the paragraph, not the <br>.
...
Props rellect.
Fixes #37066 .
Built from https://develop.svn.wordpress.org/trunk@40787
git-svn-id: http://core.svn.wordpress.org/trunk@40645 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-18 22:55:42 +00:00
Andrew Ozz
b398ccf2a1
TinyMCE: fix pasting while an image with caption is selected. The image and the caption should be replaced with the pasted content.
...
Fixes #40809 .
Built from https://develop.svn.wordpress.org/trunk@40786
git-svn-id: http://core.svn.wordpress.org/trunk@40644 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-18 22:25:41 +00:00
Weston Ruter
e62f6ac8fe
Widgets: Ensure title field for media widget will update with sanitized value after `change` event in addition to `input` event.
...
Aligns behavior of field with Text widget and other widgets whereby the server-sanitized title (via the `widget-update` request) is supplied into the field after the `change` event.
See #32417 .
Fixes #40805 .
Built from https://develop.svn.wordpress.org/trunk@40785
git-svn-id: http://core.svn.wordpress.org/trunk@40643 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-18 21:04:41 +00:00
Weston Ruter
698c6de4da
Widgets: Use "Add Audio" for button in Audio widget instead of generic "Add File".
...
Props juhise.
See #39995 .
Fixes #40797 .
Built from https://develop.svn.wordpress.org/trunk@40784
git-svn-id: http://core.svn.wordpress.org/trunk@40642 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-18 18:34:42 +00:00
Matias Ventura
aee7e6a1bf
TinyMCE: Provide styles for link and code boundaries.
...
The new version of TinyMCE introduces a cursor-boundary feature for some formatting elements but, by default, it does not provide much in the way of styles. This tweaks their appearance in the WordPress custom skin to match the intended design of the feature.
Props joen.
Fixes #40767 .
Built from https://develop.svn.wordpress.org/trunk@40783
git-svn-id: http://core.svn.wordpress.org/trunk@40641 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-18 17:52:42 +00:00
James Nylen
21b1135b1c
REST API: Do not set `X-WP-Deprecated*` headers as often.
...
Only set these headers if (1) `WP_DEBUG` is enabled and (2) headers have not already been sent.
Previously, this code could generate warnings by trying to set a header after response data has already been sent. This happens when code attached to the `shutdown` filter calls a deprecated function, for example.
Also, these headers are unlikely to be useful in the majority of cases; let's only send them if `WP_DEBUG` is enabled.
Props kraftbj, jnylen0, ocean90, rmccue.
Fixes #40787 .
Built from https://develop.svn.wordpress.org/trunk@40782
git-svn-id: http://core.svn.wordpress.org/trunk@40640 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-18 17:49:42 +00:00
Konstantin Obenland
8ef02e5ec7
Dashboard: Combine methods to retreive IP
...
They're only used in one place, no reason to be so verbose about it.
See #40702 .
Built from https://develop.svn.wordpress.org/trunk@40781
git-svn-id: http://core.svn.wordpress.org/trunk@40639 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-18 17:34:42 +00:00
Jeremy Felt
fd63ede892
Multisite: Handle both role change selections in `site-users.php`.
...
Previously, a role selected below the list table would not apply on save. This aligns the behavior with `wp-admin/users.php` and allows role changes from both selections, deferring to the bottom selection when both are populated.
Props desrosj.
Fixes #40113 .
Built from https://develop.svn.wordpress.org/trunk@40780
git-svn-id: http://core.svn.wordpress.org/trunk@40638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-18 17:08:43 +00:00
Andrea Fercia
591f423132
Administration: Use consistent spacing for form elements in the Discussion Settings screen.
...
Props sagarjadhav.
Fixes #31594 .
Built from https://develop.svn.wordpress.org/trunk@40779
git-svn-id: http://core.svn.wordpress.org/trunk@40637 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-18 15:55:44 +00:00
John Blackbourn
64d65f007d
Login and Registration: Add some margin to notices on the login screen so multiple notices remain separated.
...
Fixes #39971
Built from https://develop.svn.wordpress.org/trunk@40778
git-svn-id: http://core.svn.wordpress.org/trunk@40636 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-18 15:40:41 +00:00
Konstantin Obenland
83187e8ea0
Dashboard: Document request proxy for events.
...
Documents the reason why the request is proxied through WP, instead of being
made directly to api.wordpress.org.
Props iandunn, michelleweber.
See #40702 .
Built from https://develop.svn.wordpress.org/trunk@40777
git-svn-id: http://core.svn.wordpress.org/trunk@40635 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-18 14:44:43 +00:00
Konstantin Obenland
9bbbc719d4
Dashboard: Properly localize data for events
...
Moves localization to script-loader and removes dependency for two strings.
Props dd32, iandunn.
See #40702 .
Built from https://develop.svn.wordpress.org/trunk@40776
git-svn-id: http://core.svn.wordpress.org/trunk@40634 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-18 14:34:43 +00:00
Pascal Birchler
bb1207cf5a
Media: Correct a translatable string for MediaElement.js.
...
Adds the needed context to the string "None". Introduced in [38089].
Props leewillis77.
See #37394 .
Fixes #40800 .
Built from https://develop.svn.wordpress.org/trunk@40775
git-svn-id: http://core.svn.wordpress.org/trunk@40633 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-18 11:06:44 +00:00
Konstantin Obenland
7cae389acc
Dashboard: Always pass the IP when getting events
...
Allows the API to determine event locations more accurately.
Props iandunn.
See #40702 .
Built from https://develop.svn.wordpress.org/trunk@40774
git-svn-id: http://core.svn.wordpress.org/trunk@40632 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-18 07:31:43 +00:00
Konstantin Obenland
71adf97a35
Upgrade: Use correct commit no. to trigger upgrade
...
Props iandunn.
See [40607], #40702 .
Built from https://develop.svn.wordpress.org/trunk@40773
git-svn-id: http://core.svn.wordpress.org/trunk@40631 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-17 22:03:46 +00:00
Weston Ruter
764d8b521f
Media: Trim whitespace in URLs provided for external embeds.
...
Also avoid showing error notice in media widget when URL field is empty.
Props timmydcrawford, westonruter.
Fixes #40771 .
Built from https://develop.svn.wordpress.org/trunk@40772
git-svn-id: http://core.svn.wordpress.org/trunk@40630 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-17 01:59:42 +00:00
Weston Ruter
509e706c13
Customize: Run a partial's fallback behavior (full refresh) when selective refresh fails due to a script error.
...
This ensures that 3rd-party scripts that users paste into Text widgets will gracefully recover and result in the expected preview.
See #27355 .
Fixes #40658 .
Built from https://develop.svn.wordpress.org/trunk@40771
git-svn-id: http://core.svn.wordpress.org/trunk@40629 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-17 00:01:40 +00:00
Pascal Birchler
8c7ea71edb
Media: Simplify upload error message construction.
...
Built from https://develop.svn.wordpress.org/trunk@40736
git-svn-id: http://core.svn.wordpress.org/trunk@40594 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-16 17:58:41 +00:00
Aaron Campbell
38347d7c58
Add nonce for updating file system credentials.
...
Built from https://develop.svn.wordpress.org/trunk@40723
git-svn-id: http://core.svn.wordpress.org/trunk@40581 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-16 14:48:44 +00:00
Weston Ruter
4eb107cd52
Customize: Fix phpunit tests after [40704] due to logic inversion error.
...
Built from https://develop.svn.wordpress.org/trunk@40716
git-svn-id: http://core.svn.wordpress.org/trunk@40579 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-16 14:34:42 +00:00
Dominik Schilling
3d10fef22d
Customize: Igore invalid customization sessions.
...
Built from https://develop.svn.wordpress.org/trunk@40704
git-svn-id: http://core.svn.wordpress.org/trunk@40567 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-16 12:07:43 +00:00
Pascal Birchler
3d95e3ae81
Adjust post meta checks
...
Built from https://develop.svn.wordpress.org/trunk@40692
git-svn-id: http://core.svn.wordpress.org/trunk@40555 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-16 08:46:42 +00:00
Pascal Birchler
76d77e927b
Improve redirect handling
...
Built from https://develop.svn.wordpress.org/trunk@40689
git-svn-id: http://core.svn.wordpress.org/trunk@40552 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-16 08:38:42 +00:00
Pascal Birchler
e88a48a066
Whitelist post arguments in XML-RPC
...
Built from https://develop.svn.wordpress.org/trunk@40677
git-svn-id: http://core.svn.wordpress.org/trunk@40540 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-16 08:09:42 +00:00
Weston Ruter
d8f94986b2
Customize: Keep alive auto-drafts created for page/post stubs when parent changeset is updated, and delete when changeset is garbage-collected.
...
Props utkarshpatel, westonruter.
See #31089 .
Fixes #39715 .
Built from https://develop.svn.wordpress.org/trunk@40676
git-svn-id: http://core.svn.wordpress.org/trunk@40539 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-16 05:37:44 +00:00
Weston Ruter
7f008a21de
Widgets: Add missing `wp-editor-area` CSS class for `textarea` in the TinyMCE-extended Text widget to ensure proper styles are applied.
...
Removes extra border around TinyMCE-wrapped `textarea` and removes gap at bottom due to lack of `display:block`.
Props johnjamesjacoby, westonruter.
See #35243 .
Fixes #40755 .
Built from https://develop.svn.wordpress.org/trunk@40675
git-svn-id: http://core.svn.wordpress.org/trunk@40538 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-16 00:11:41 +00:00
Weston Ruter
5e67d6d81f
Widgets: Remove image sizes generated during media widget phpunit tests from being version controlled.
...
Amends [40640].
See #32417 .
Built from https://develop.svn.wordpress.org/trunk@40674
git-svn-id: http://core.svn.wordpress.org/trunk@40537 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-15 22:59:42 +00:00
Weston Ruter
97e376ca39
Widgets: Ensure return value of `widget_text` filter is not dropped but passed into `widget_text_content` filter for rendering.
...
Amends [40631].
Props vijustin, swissspidy, westonruter.
See #35243 .
Fixes #40772 .
Built from https://develop.svn.wordpress.org/trunk@40673
git-svn-id: http://core.svn.wordpress.org/trunk@40536 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-15 22:36:41 +00:00
Mel Choyce
66d3a486f6
Plugins: Fix plugin name display on Chrome 58 and above.
...
On Chrome 58 and above, plugin names within the plugin details modal were collapsed down into an ellipsis. This fix rewrites the CSS to make sure the titles are always shown.
Props mrwweb, afercia, Presskopp.
Fixes #40579 .
Built from https://develop.svn.wordpress.org/trunk@40672
git-svn-id: http://core.svn.wordpress.org/trunk@40535 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-15 20:13:42 +00:00
Weston Ruter
9cb2cbc26f
Customize: Fix alignment of natural-width media buttons in site icon control.
...
Amends [40653].
Props afercia.
Fixes #40220 .
Built from https://develop.svn.wordpress.org/trunk@40671
git-svn-id: http://core.svn.wordpress.org/trunk@40534 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-15 18:51:41 +00:00
Weston Ruter
8a29b28a98
Widgets: Prevent image `title` attribute from being populated from attachment `title` by default upon selection.
...
Props westonruter, timmydcrawford.
See #39993 .
Built from https://develop.svn.wordpress.org/trunk@40670
git-svn-id: http://core.svn.wordpress.org/trunk@40533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-15 18:42:44 +00:00
Konstantin Obenland
68588821c3
Dashboard: Community events formatting improvements
...
Props Soean.
See #40702 .
Built from https://develop.svn.wordpress.org/trunk@40669
git-svn-id: http://core.svn.wordpress.org/trunk@40532 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-15 09:44:43 +00:00
Rachel Baker
580cf33c81
Taxonomy: Remove extraneous `'` included in Term delete markup.
...
Unmatched single quotation mark after the delete link href was introduced in r40655.
Props Chouby.
Fixes #9777 .
Built from https://develop.svn.wordpress.org/trunk@40668
git-svn-id: http://core.svn.wordpress.org/trunk@40531 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-14 19:50:44 +00:00
Rachel Baker
195b227357
Formatting: Increase minimum characters allowed in `is_email()` to 6.
...
Brings the minimum characters expected for a valid email address to six, which matches the expectations in `wp_handle_comment_submission()` and REST API email arguments.
Props rmccue, lukecavanagh, rachelbaker, desrosj, sudar.
Fixes #38708 .
Built from https://develop.svn.wordpress.org/trunk@40667
git-svn-id: http://core.svn.wordpress.org/trunk@40530 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-14 04:20:43 +00:00
Rachel Baker
9c2f5c18ce
Comments: Correct the $post_id parameter passed to the 'comments_open' and 'pings_open' filters.
...
Fixes bug where previously the `$post_id` function argument was passed to the '_open' filters, instead of the result of the `get_post()` call. If the current post is not found, the `$post_id` filter parameter will be 0.
Props johnbillion, shulard, rachelbaker.
Fixes #40286 .
Built from https://develop.svn.wordpress.org/trunk@40666
git-svn-id: http://core.svn.wordpress.org/trunk@40529 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-14 03:50:42 +00:00
Peter Wilson
62de6cc7ec
Menus: Prevent empty class attribute following [40537].
...
Prevents an empty class attribute, `class=""`, from appearing in the HTML if a developer removes all classes using the `nav_menu_submenu_css_class` filter.
Props Kopepasah.
Fixes #36163 .
Built from https://develop.svn.wordpress.org/trunk@40665
git-svn-id: http://core.svn.wordpress.org/trunk@40528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-14 03:38:48 +00:00
Rachel Baker
868312d995
Comments: Update arguments passed to the 'comment_text' filter in `check_comment()`.
...
Pass null or empty values for the missing $comment and $args parameters of the 'check_comment' filter in `check_comment()`.
Props boonebgorges, vaishu.agola27, SergeyBiryukov.
Fixes #38314 .
Built from https://develop.svn.wordpress.org/trunk@40664
git-svn-id: http://core.svn.wordpress.org/trunk@40527 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-14 03:06:45 +00:00