Sergey Biryukov
641c632b0c
Coding Standards: Use Yoda conditions where appropriate.
...
See #49222 .
Built from https://develop.svn.wordpress.org/trunk@47219
git-svn-id: http://core.svn.wordpress.org/trunk@47019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-09 16:55:09 +00:00
Sergey Biryukov
001ffe81fb
Docs: Improve inline comments per the documentation standards.
...
Includes minor code layout fixes for better readability.
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@47122
git-svn-id: http://core.svn.wordpress.org/trunk@46922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-29 00:45:18 +00:00
Gary Pendergast
56c162fbc9
Coding Standards: Upgrade WPCS to 1.0.0
...
WPCS 1.0.0 includes a bunch of new auto-fixers, which drops the number of coding standards issues across WordPress significantly. Prior to running the auto-fixers, there were 15,312 issues detected. With this commit, we now drop to 4,769 issues.
This change includes three notable additions:
- Multiline function calls must now put each parameter on a new line.
- Auto-formatting files is now part of the `grunt precommit` script.
- Auto-fixable coding standards issues will now cause Travis failures.
Fixes #44600 .
Built from https://develop.svn.wordpress.org/trunk@43571
git-svn-id: http://core.svn.wordpress.org/trunk@43400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-17 01:51:36 +00:00
Gary Pendergast
aaf99e6913
Code is Poetry.
...
WordPress' code just... wasn't.
This is now dealt with.
Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057 .
Built from https://develop.svn.wordpress.org/trunk@42343
git-svn-id: http://core.svn.wordpress.org/trunk@42172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-30 23:11:00 +00:00
Dominik Schilling
e5ea82d81a
Spelling: Standardize on "front end"/"back end" (noun) and "front-end"/"back-end" (adjective).
...
Props obrienlabs, thewanderingbrit.
Fixes #34887 .
Built from https://develop.svn.wordpress.org/trunk@36709
git-svn-id: http://core.svn.wordpress.org/trunk@36676 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-25 12:53:27 +00:00
Dominik Schilling
64fc7294b6
Use HTTPS URLs for codex.wordpress.org.
...
see #27115 .
Built from https://develop.svn.wordpress.org/trunk@32116
git-svn-id: http://core.svn.wordpress.org/trunk@32095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-12 21:29:32 +00:00
Lance Willett
d9cda71f18
Twenty Twelve: more fixes for escaping and minor code style issues. See #29127 .
...
Built from https://develop.svn.wordpress.org/trunk@31262
git-svn-id: http://core.svn.wordpress.org/trunk@31243 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-21 21:06:23 +00:00
Dominik Schilling
120cb5e6ef
Improve keyboard accessibility on Custom Header and Custom Background screen.
...
props florianziegler.
fixes #29289 .
Built from https://develop.svn.wordpress.org/trunk@30327
git-svn-id: http://core.svn.wordpress.org/trunk@30326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-13 12:00:57 +00:00
Lance Willett
bba0e99688
Twenty Twelve: remove doc block comments for `@return void`. See #27098 .
...
Built from https://develop.svn.wordpress.org/trunk@27599
git-svn-id: http://core.svn.wordpress.org/trunk@27442 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-18 22:49:15 +00:00
Lance Willett
4a9b21226c
Twenty Twelve: update code comments to reflect WP inline docs standards. Props DrewAPicture, see #25256 .
...
Built from https://develop.svn.wordpress.org/trunk@25521
git-svn-id: http://core.svn.wordpress.org/trunk@25441 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-20 19:24:09 +00:00
Andrew Nacin
1f64b5abd0
Add .displaying-header-text to the default themes, as the Custom Header page toggles this class. props obenland, fixes #24113 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24050 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-22 19:40:28 +00:00
Lance Willett
ba20ddbcc0
Twenty Twelve: fix style element ID attribute value, props SergeyBiryukov. Closes #24033 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24016 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-17 17:50:04 +00:00
Lance Willett
7dd27586af
Twenty Twelve: add back missing space in CSS value, removed in r24013. See #23790 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24014 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-17 17:48:09 +00:00
Lance Willett
3f4edaca26
Twenty Twelve: remove zero-width spaces in CSS value, props SergeyBiryukov. Closes #23790 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24013 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-17 17:46:58 +00:00
Lance Willett
245c2111f0
Bundled themes: add identifier to `style` elements added by the theme. Fixes #24033 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24001 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-16 17:18:30 +00:00
Lance Willett
87f4924dc9
Twenty Twelve: improve Appearance > Header styles to match front end view better -- including loading special Google Font there. Props obenland, fixes #23790 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23717 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-15 18:03:43 +00:00
Lance Willett
f41b21f4f6
Twenty Twelve: fix regression introduced in r23572, allow hide/show of Header Text in Customizer. Fixes #23600 .
...
Also remove another `!important` -- and there was much rejoicing.
Props SergeyBiryukov and obenland.
git-svn-id: http://core.svn.wordpress.org/trunk@23711 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-15 16:42:10 +00:00
Lance Willett
76e80eaa86
Twenty Twelve: enable live preview for Header Text Color in Theme Customizer. Change also removes an `!important` declaration (yay) in Custom Header CSS rules.
...
Props SriniG, fixes #23600 .
git-svn-id: http://core.svn.wordpress.org/trunk@23572 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-01 17:45:59 +00:00
Lance Willett
b59a52a77c
Twenty Twelve: fix text color contrast, props jorbin. See #22087 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22573 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-14 20:13:04 +00:00
Lance Willett
b5853fcd19
Twenty Twelve: fix comments in two files, for accuracy.
...
git-svn-id: http://core.svn.wordpress.org/trunk@22059 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-27 15:23:15 +00:00
Lance Willett
5beee34612
Twenty Twelve: simplify custom font loading behavior, see #21694 .
...
* Remove theme options code and support from theme.
* Keep Open Sans font first in the stack and make it always loaded.
* Move Customizer pieces from Theme Options out of class structure and into functions.php.
git-svn-id: http://core.svn.wordpress.org/trunk@21639 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-28 02:18:43 +00:00
Lance Willett
719e80e8cd
Twenty Twelve: theme-options.php fixes from obenland, see #21685 .
...
* Capability is already set to 'edit_theme_options' by default
* Simplify logic for form input validation
git-svn-id: http://core.svn.wordpress.org/trunk@21623 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-25 17:51:21 +00:00
Lance Willett
3ec703a6d1
Twenty Twelve: review and clarify code commenting and documentation. Props jorbin and obenland. See #21675 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@21617 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-25 16:53:32 +00:00
lancewillett
bbd8dfb103
Twenty Twelve: standardize label used for Web Fonts option. Props jkudish, fixes #21487 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@21448 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-05 23:58:12 +00:00
lancewillett
3a0841fee7
Twenty Twelve: bump theme-customizer JS version. See #21443 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@21412 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-02 22:17:06 +00:00
lancewillett
ffc2e121fc
Twenty Twelve: Add postMessage support in Customizer for fonts, site title and description, and background color body_class value updates.
...
Props obenland for first patch and testing. Fixes #21443 .
git-svn-id: http://core.svn.wordpress.org/trunk@21411 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-02 22:10:03 +00:00
lancewillett
8b283073d0
Twenty Twelve: remove unneeded filter (props nacin) and fix up PHP comment blocks in custom-header.php file for s/@package/@since/ on individual functions. See #21231 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@21329 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-25 17:30:19 +00:00
lancewillett
cb4f0bf507
Twenty Twelve: remove back compat for custom header image, installs prior to 3.4 will not see it as an option. Props obenland, closes #21231 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@21328 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-25 17:12:40 +00:00
lancewillett
d74e83ec52
Twenty Twelve: update theme options file to use PHP5 constructor and visibility keywords, and also minor DocBlock cleanup. Props Mamaduka and obenland, closes #21297 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@21280 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-18 18:41:17 +00:00
lancewillett
f7cf67d3f0
Twenty Twelve: fix @package documentation, props obenland. Fixes #21232 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@21262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-12 23:28:33 +00:00
nacin
741876a148
The Twenty Twelve for WordPress.
...
props drewstrojny, lancewillett.
also props corvannoorloos, jeffsebring, kobenland, iandstewart, mfields,
mtdesign, op12no2, philiparthurmoore, sixhours, mamaduka.
see #19978 .
git-svn-id: http://core.svn.wordpress.org/trunk@21261 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-12 04:20:46 +00:00