WordPress-C
/
WordPress
mirror of https://github.com/WordPress/WordPress.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
50,367 Commits 50 Branches 749 Tags 981 MiB
Commit Graph

72 Commits

Author SHA1 Message Date
Pascal Birchler d2fb0bd81e General: Remove any usage of `wp_reset_vars()`. 
The way `wp_reset_vars()` sets global variables based on `$_POST` and `$_GET` values makes code hard to understand and maintain. It also makes it easy to forget to sanitize input.

This change removes the few places where `wp_reset_vars()` is used in the admin to explicitly use `$_REQUEST` and sanitize any input.

Props swissspidy, audrasjb, davideferre, killua99, weijland, voldemortensen.
Fixes #38073.
Built from https://develop.svn.wordpress.org/trunk@58069


git-svn-id: http://core.svn.wordpress.org/trunk@57534 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2024-05-01 18:01:12 +00:00
Sergey Biryukov 8a90b8691f Docs: Add a comment about the `$title` global usage in various admin files. 
This should make it clear that the variable is used as part of the HTML `<title>` tag on admin screens.

Props ravipatel, hellofromTonya, sabernhardt, audrasjb, SergeyBiryukov.
Fixes #53729.
Built from https://develop.svn.wordpress.org/trunk@51475


git-svn-id: http://core.svn.wordpress.org/trunk@51086 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2021-07-22 13:53:00 +00:00
Sergey Biryukov 47ed56f38f Code Modernization: Replace `dirname( __FILE__ )` calls with `__DIR__` magic constant. 
This avoids the performance overhead of the function call every time `dirname( __FILE__ )` was used instead of `__DIR__`.

This commit also includes:

* Removing unnecessary parentheses from `include`/`require` statements. These are language constructs, not function calls.
* Replacing `include` statements for several files with `require_once`, for consistency:
 * `wp-admin/admin-header.php`
 * `wp-admin/admin-footer.php`
 * `wp-includes/version.php`

Props ayeshrajans, desrosj, valentinbora, jrf, joostdevalk, netweb.
Fixes #48082.
Built from https://develop.svn.wordpress.org/trunk@47198


git-svn-id: http://core.svn.wordpress.org/trunk@46998 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-02-06 06:33:11 +00:00
Gary Pendergast aaf99e6913 Code is Poetry. 
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.


Built from https://develop.svn.wordpress.org/trunk@42343


git-svn-id: http://core.svn.wordpress.org/trunk@42172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-30 23:11:00 +00:00
Dominik Schilling 25e66e4f1e Text Changes: Unify permission error messages. 
The new format looks like "Sorry, you are not allowed to <action>.". This provides a consistent experience for all error messages related to missing permissions. It also reduces the number of similar strings and allows translators to provide a consistent style in their language.

Props ramiy, Presskopp.
Fixes #34521.
Built from https://develop.svn.wordpress.org/trunk@37914


git-svn-id: http://core.svn.wordpress.org/trunk@37855 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-06-29 15:16:29 +00:00
Andrew Nacin fd57b239d2 Don't rely on include_path to include files. 
Always use dirname() or, once available, ABSPATH.

props ketwaroo, hakre.
fixes #17092.

Built from https://develop.svn.wordpress.org/trunk@25616


git-svn-id: http://core.svn.wordpress.org/trunk@25533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-25 00:18:11 +00:00
Andrew Nacin 83e0ce2ac1 Remove unused variables reset by wp_reset_vars(). Many of these haven't been used since b2. see #21767. 
git-svn-id: http://core.svn.wordpress.org/trunk@23445 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-02-16 18:28:41 +00:00
azaozz 6aaf0dad43 Add the jQuery UI Touch Punch plugin to handle dragging on mobile devices, props georgestephanis, see #20014 
git-svn-id: http://svn.automattic.com/wordpress/trunk@20433 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-04-11 02:20:51 +00:00
ryan e3b46b25d3 Lose EOF ?>. Clean up EOF newlines. fixes #12307 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-01-08 17:01:11 +00:00
nacin 9cb6e158fc Switch from Panel/SubPanel to Screen in inline documentation and Codex links. props michaelh, fixes #17265. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17748 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-04-28 15:24:49 +00:00
nacin f9df8a36ae s/blog/site/ in more places. props PeteMall, see #11644. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14313 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-04-30 01:54:32 +00:00
nacin 6ec7cb4540 Use relative paths when including files, avoiding include_path. fixes #12594, props sorich87. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14139 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-04-18 06:14:45 +00:00
azaozz 3d7a5dce98 More cap checks, for trunk 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11764 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-08-02 02:23:54 +00:00
ryan cc7c443f62 Move screen_meta() to admin header. Add all meta boxes before requiring admin-header. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@9620 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-11-11 22:40:16 +00:00
markjaquith 61f911c42e Bring back the H2s. Rough draft. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@9232 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-10-17 20:02:03 +00:00
ryan de958f418e Menu reorg 
git-svn-id: http://svn.automattic.com/wordpress/trunk@8977 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-09-25 19:33:53 +00:00
azaozz 39e0608b33 Some css cleanup and fixes after the merge, see #7552 
git-svn-id: http://svn.automattic.com/wordpress/trunk@8697 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-08-21 02:25:14 +00:00
ryan d3b414932c Collapse crazyhorse to trunk. Incoming! see #7552 
git-svn-id: http://svn.automattic.com/wordpress/trunk@8691 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-08-20 21:42:31 +00:00
westi 7f894ae416 phpdoc for wp-admin. See #7496 props santosj. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@8645 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-08-14 06:30:38 +00:00
westi b3cb14fb80 Lots of fixes for Notices when WP_DEBUG is set. See #6669 props santosj. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@8589 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-08-08 17:05:10 +00:00
ryan bc07ef1efe Theme preview and thickbox CSS cleanup. Props azaozz. see #5486 
git-svn-id: http://svn.automattic.com/wordpress/trunk@7961 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-05-20 17:19:33 +00:00
ryan a1449b1ebc Enqueue XFN for link pages. Props mdawaffe. fixes #6217 
git-svn-id: http://svn.automattic.com/wordpress/trunk@7196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-03-10 05:44:56 +00:00
ryan 8137e045da Remove add link bookmarlet from write link page. Relocating it. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@7014 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-02-25 06:30:38 +00:00
ryan 1266b9c53f Update edit link pages. Link categories need work. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@6695 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-01-31 20:04:54 +00:00
matt c397ae61cc Some link manager juggling, still need to have submenu highlight when on sub-sub pages. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@6555 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-01-04 20:18:55 +00:00
matt 2073c22bbd Post screen improvements^H^H^H, er, changes. Will file tickets for todos. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@6544 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-01-03 08:03:29 +00:00
ryan f8afc0b75d jquery for list manipulation. Round one, fight. Props mdawaffe. fixes #4805 
git-svn-id: http://svn.automattic.com/wordpress/trunk@6213 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2007-10-09 22:49:42 +00:00
ryan 4214428322 Separate AJAX cat adder into post and link flavors. see #4189 
git-svn-id: http://svn.automattic.com/wordpress/trunk@5637 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2007-06-02 02:53:09 +00:00
ryan ad1ee85dc5 Remove old notice. Props johnbillion. fixes #2576 
git-svn-id: http://svn.automattic.com/wordpress/trunk@4999 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2007-03-07 17:07:33 +00:00
ryan ce655b96b8 Typo fixes from mdawaffe. fixes #3474 
git-svn-id: http://svn.automattic.com/wordpress/trunk@4664 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2006-12-27 00:51:00 +00:00
markjaquith 8a678f3841 i18n fixes, logic cleanup, wording clarifications, and more from nbachiyski. fixes #3474 
git-svn-id: http://svn.automattic.com/wordpress/trunk@4658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2006-12-21 23:06:18 +00:00
markjaquith 90220dbeca Fix parse error in wp-admin/link-add.php. Props mByte in wp-testers list. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@4539 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2006-11-29 09:17:01 +00:00
ryan cc44db510d Use js_escape. Props nbachiyski. fixes #3399 
git-svn-id: http://svn.automattic.com/wordpress/trunk@4535 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2006-11-28 21:51:13 +00:00
ryan ca40a96b1f Standardize on Links instead of Bookmarks until we change our minds again. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@4499 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2006-11-20 02:17:07 +00:00
ryan 9f534ebae6 Remove trailing spaces and convert spaces to tabs. Props Nazgul. fixes #986 
git-svn-id: http://svn.automattic.com/wordpress/trunk@4495 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2006-11-19 07:56:05 +00:00
ryan eda9021317 Hold off on menu cleanup until next release. There be dragons. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@4480 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2006-11-18 07:31:29 +00:00
matt 07126127e6 Admin functions cleanup, and change how we do titles and parents in the backend 
git-svn-id: http://svn.automattic.com/wordpress/trunk@4478 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2006-11-18 06:09:48 +00:00
markjaquith 92d006dac0 Suppress "Link added" message when it has not been added. Props Nazgul. fixes #3200 
git-svn-id: http://svn.automattic.com/wordpress/trunk@4448 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2006-11-04 07:00:29 +00:00
markjaquith bc0594c5cb Bookmarklet consistency patch by foolswisdom. fixes #3168 
git-svn-id: http://svn.automattic.com/wordpress/trunk@4429 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2006-10-27 22:15:38 +00:00
ryan 849a0d29d7 Use get_option instead of get_settings. Just 'cause. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@4144 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2006-08-30 21:46:31 +00:00
matt 157786ecaa Some renames 
git-svn-id: http://svn.automattic.com/wordpress/trunk@3999 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2006-07-06 04:27:45 +00:00
ryan 55af15d623 wp_reset_vars() from Sewar. fixes #2888 
git-svn-id: http://svn.automattic.com/wordpress/trunk@3946 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2006-07-03 19:03:37 +00:00
ryan a481db2b6a Script loader fixes from mdawaffe. fixes #2765 
git-svn-id: http://svn.automattic.com/wordpress/trunk@3830 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2006-06-01 21:51:20 +00:00
ryan 4d49e98fe4 Script loader from mdawaffe. #2701 
git-svn-id: http://svn.automattic.com/wordpress/trunk@3788 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2006-05-22 17:16:05 +00:00
ryan e9c75f4bd2 Bookmark/link rework. #2499 
git-svn-id: http://svn.automattic.com/wordpress/trunk@3570 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2006-02-27 04:57:30 +00:00
matt 759faa6b9a HTML and JS cleanup 
git-svn-id: http://svn.automattic.com/wordpress/trunk@3422 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2006-01-10 05:16:17 +00:00
ryan 047531792a Re-add xfn flag. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@2893 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2005-09-19 02:50:42 +00:00
ryan ad3e2f6dba Consolidate link forms into edit-link-form 
git-svn-id: http://svn.automattic.com/wordpress/trunk@2890 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2005-09-19 00:47:58 +00:00
ryan cd0db4edfa Link love. Add get_link(), get_link_to_edit(), add_link(), edit_link(), wp_insert_link(), wp_update_link(), wp_delete_link() 
git-svn-id: http://svn.automattic.com/wordpress/trunk@2889 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2005-09-18 19:44:14 +00:00
matt 65546ba7a5 Draw more attention to the messages, which now blend in a little with the header. TODO: Put all messages in an array, abstract out HTML 
git-svn-id: http://svn.automattic.com/wordpress/trunk@2762 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2005-08-08 01:13:22 +00:00