Pascal Birchler
d2fb0bd81e
General: Remove any usage of `wp_reset_vars()`.
...
The way `wp_reset_vars()` sets global variables based on `$_POST` and `$_GET` values makes code hard to understand and maintain. It also makes it easy to forget to sanitize input.
This change removes the few places where `wp_reset_vars()` is used in the admin to explicitly use `$_REQUEST` and sanitize any input.
Props swissspidy, audrasjb, davideferre, killua99, weijland, voldemortensen.
Fixes #38073 .
Built from https://develop.svn.wordpress.org/trunk@58069
git-svn-id: http://core.svn.wordpress.org/trunk@57534 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-05-01 18:01:12 +00:00
Sergey Biryukov
be6bbe4b5d
Administration: Replace legacy `updated` message type in `add_settings_error()` calls with `success`.
...
See #44640 .
Built from https://develop.svn.wordpress.org/trunk@45818
git-svn-id: http://core.svn.wordpress.org/trunk@45629 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-16 00:39:55 +00:00
Gary Pendergast
aaf99e6913
Code is Poetry.
...
WordPress' code just... wasn't.
This is now dealt with.
Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057 .
Built from https://develop.svn.wordpress.org/trunk@42343
git-svn-id: http://core.svn.wordpress.org/trunk@42172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-30 23:11:00 +00:00
Drew Jaynes
b1804afeaf
Docs: Standardize on 'backward compatibility/compatible' nomenclature in core inline docs.
...
Also use 'back-compat' in some inline comments where backward compatibility is the subject and shorthand feels more natural.
Note: 'backwards compatibility/compatibile' can also be considered correct, though it's primary seen in regular use in British English.
Props ocean90.
Fixes #36835 .
Built from https://develop.svn.wordpress.org/trunk@37431
git-svn-id: http://core.svn.wordpress.org/trunk@37397 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-13 18:41:31 +00:00
Ryan Boren
f3a83744e9
Use wp_unslash() instead of stripslashes() and stripslashes_deep(). Use wp_slash() instead of add_magic_quotes().
...
git-svn-id: http://core.svn.wordpress.org/trunk@23567 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-01 17:14:09 +00:00
Ryan Boren
43a7e695e9
Revert 23416, 23419, 23445 except for wp_reset_vars() changes. We are going a different direction with the slashing cleanup, so resetting to a clean slate. see #21767
...
git-svn-id: http://core.svn.wordpress.org/trunk@23554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-01 16:28:40 +00:00
Andrew Nacin
83e0ce2ac1
Remove unused variables reset by wp_reset_vars(). Many of these haven't been used since b2. see #21767 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23445 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-16 18:28:41 +00:00
ryan
e3b46b25d3
Lose EOF ?>. Clean up EOF newlines. fixes #12307
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-08 17:01:11 +00:00
markjaquith
7aa5cb911e
Backwards compat for plugin use of updated=1. fixes #15660
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@16706 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-03 10:59:20 +00:00
ryan
08bb3568c6
Option validation error reporting. Props jeremyclarke. see #11474
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@13177 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-17 17:50:42 +00:00
azaozz
4134133d53
Remove unused .fade CSS class, props nacin, fixes #11628
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@12546 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-12-26 09:00:58 +00:00
westi
7f894ae416
phpdoc for wp-admin. See #7496 props santosj.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@8645 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-08-14 06:30:38 +00:00
ryan
968682dea6
Options are called Settings now. Props hansengel. see #5850
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@6833 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-02-14 00:39:38 +00:00
markjaquith
e43516e5f6
Removing superfluous <br /> from Options-General. Props johnbillion. fixes #3929 for trunk.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@5048 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-03-16 08:10:02 +00:00
ryan
55af15d623
wp_reset_vars() from Sewar. fixes #2888
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@3946 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-07-03 19:03:37 +00:00
matt
65546ba7a5
Draw more attention to the messages, which now blend in a little with the header. TODO: Put all messages in an array, abstract out HTML
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@2762 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2005-08-08 01:13:22 +00:00
rboren
04786f267d
Split admin-header.php into admin.php and admin-header.php. Split menu.php into menu-header.php and menu.php. Add plugin admin page support.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@1818 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2004-10-19 03:03:06 +00:00
rboren
4568e83625
Do not stomp permalink setting. Bug 372.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@1810 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2004-10-18 04:50:08 +00:00
saxmatt
6b43f65c25
Remove optiongroups table.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@1596 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2004-09-04 22:09:21 +00:00
saxmatt
77706cc025
New submenu system.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@1551 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2004-08-22 23:24:50 +00:00
saxmatt
25ae03ee65
Giant commit, sorry mailing list people. Move all table names to new $wpdb versions. Works but the whole app needs thorough testing now.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@1355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2004-05-24 08:22:18 +00:00
saxmatt
5c2eb8a666
Not highlighting on double update.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@1272 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2004-05-14 06:21:24 +00:00
saxmatt
ba407ff5b3
E_ALL fixes and cleanups.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@1239 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2004-05-07 23:56:33 +00:00
saxmatt
e0afc4abcb
Wrong highlighting.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@1193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2004-04-28 00:12:59 +00:00
rboren
1890dffb57
Mark strings for translation.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@1162 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2004-04-25 02:03:32 +00:00
saxmatt
5cc3f8d3e1
Massive admin tweak commit. Improved consistency, numerous bug fixes, redesigned link forms, tweaked options more, left the ugly grey bar I didn't mean to add in the first place but tweaked it too.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@1100 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2004-04-19 08:09:27 +00:00
saxmatt
4f909d4cc5
The great option REMIX.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@1074 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2004-04-15 07:53:45 +00:00
saxmatt
5a49a4d411
More options work. Bug fixes for advanced_edit not being boolean type, clean up of options code and update feedback (still needs work there), first bit of miscellaneous screen.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@1058 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2004-04-11 08:15:10 +00:00