Commit Graph

435 Commits

Author SHA1 Message Date
nacin 64b9b4f940 Do not specify background-image: none when a user removes a custom background
on a theme that has a default background image.

The onus is on the theme to omit the default background-image from style.css,
to allow the user to remove the default background image. Or, the theme can
specify a background-image for the body selector, as long as they then zero
it out for body.custom-background, like so:

{{{
body {
	background-image: url( ... );
}
body.custom-background {
	background-image: none;
}
}}}

This allows the theme to be compatible with the custom background feature
but also gracefully degrade if the background feature is disabled.

This is the same behavior as 3.3; setting a default image has simply been
made more prominent in 3.4. Reverts [21013], also parts of [21001].
see #20448 for change and discussion history.

see #20132, which will now be marked as invalid.

Also, per previous changes in #20448, the custom-background class should not
be shown when only a default color is in use.

fixes #20448.



git-svn-id: http://core.svn.wordpress.org/trunk@21054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-11 21:25:05 +00:00
ryan 07140847b2 Namespace the customize request arg to prevent collision with plugins and themes. Props nacin. fixes #20862
git-svn-id: http://core.svn.wordpress.org/trunk@21016 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-07 01:29:57 +00:00
koopersmith 14f04132af Theme Customizer: Fix scrolling on iOS and Kindle Fire. props azaozz, helenyhou. fixes #20805.
Also fixes uploader UIs on iOS and Kindle Fire by improving wp.Uploader.
Adds mobile viewport specifications.
Moves scrollbar back to fixed positioning.


git-svn-id: http://core.svn.wordpress.org/trunk@21014 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-06 21:45:17 +00:00
nacin 5cba80ee25 Add some comments to _custom_background_cb() to explain the logic. see #20448.
git-svn-id: http://core.svn.wordpress.org/trunk@21002 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-05 18:44:31 +00:00
ryan 64e6663569 Fix removing the default background image for themes that hard-code the default in css. Honor the default background image for themes that do not provide a fallback in css.
* <style> will appear if there is a default image registered. This is the same as 3.3.
* If only a default color is registered, it still assumes it is in the stylesheet, and no <style> will appear. This is a change from 3.3.
* <style> will continue to appear as before if there is a custom background color or image. This is the same as 3.3.
* This then allows for a default background image with background-image: none, overriding style.css. This is new.

Props nacin
see #20448


git-svn-id: http://core.svn.wordpress.org/trunk@21001 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-05 18:35:31 +00:00
ryan 0f1f59b092 Custom background fixes:
* Specify default background colors for the bundled themes.
* Change the default custom background callback to only operate on saved values, rather than default values.
* Prevent an unsaved default value from overriding a manually modified style.css file.

Props nacin, kobenland
fixes #20448


git-svn-id: http://core.svn.wordpress.org/trunk@20973 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-01 20:31:50 +00:00
nacin 26e0d68be0 Theme Customizer: As customize.php without a theme parameter defaults to the current theme, update wp_customize_url() to make $stylesheet optional and update references for the current theme.
see #19910, #20751, #20575.



git-svn-id: http://core.svn.wordpress.org/trunk@20934 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-26 15:32:05 +00:00
koopersmith 69c970a4a1 Hide 'Customize' toolbar item when customizer is not supported. fixes #20751, see #19910.
Removes script queue check for 'customize-loader' from wp_customize_support_script(), because we may want to check for customize-support on a page without the loader.


git-svn-id: http://core.svn.wordpress.org/trunk@20918 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-25 22:26:00 +00:00
koopersmith a5ee470df7 Theme Customizer: Improve default background property handling. see #20600, #19910.
If the custom background default wp-head-callback (_custom_background_cb) is used, we use postMessage for all custom background properties. Otherwise, we use full refreshes.

When using postMessage, the preview recalculates the custom background CSS block, allowing it to omit CSS values when they are not present and fall back on the original CSS.


git-svn-id: http://core.svn.wordpress.org/trunk@20908 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-25 18:41:22 +00:00
nacin afad27974e Preview by default the registered default image for custom backgrounds. props mfields, billerickson.
If there is a default color registered, show a 'Default' action rather than a 'Clear' action, as clearing the value would simply return to the default.

Make current_theme_supports() accept a second argument for 'custom-background' requests, the same as get_theme_support(). Missed in earlier changes, see #20249.

fixes #20734, fixes #18041.



git-svn-id: http://core.svn.wordpress.org/trunk@20901 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-25 17:58:57 +00:00
koopersmith d8abece877 Theme Customizer: Add CORS checks to the initial check for customize support. Prevents flash of customize links on large pages. see #20582, #19910.
Add wp_customize_support_script(), to quickly alter the body class based on whether customize is supported.


git-svn-id: http://core.svn.wordpress.org/trunk@20893 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-25 00:15:12 +00:00
koopersmith 2f09b8d0a6 Theme Customizer: Fix hash-based loader fallbacks. see #20736, #19910, [20886].
git-svn-id: http://core.svn.wordpress.org/trunk@20890 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-24 22:45:27 +00:00
koopersmith c3e7ce5320 Theme Customizer: Check for CORS support when the preview and admin urls are cross-domain. Add a fallback to the customize control frame, and check support there as well. see #20582, #19910.
git-svn-id: http://core.svn.wordpress.org/trunk@20886 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-24 21:13:21 +00:00
koopersmith 4973f92107 Theme Customizer: Change 'Return to...' link to 'Cancel' and move 'Save' button to header. props helenyhou, fixes #20692, see #19910.
git-svn-id: http://core.svn.wordpress.org/trunk@20864 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-24 03:29:51 +00:00
nacin 95e1c32720 Customize API shuffling.
* Rename WP_Customize to WP_Customize_Manager.
 * Move customize-controls.php to wp-admin/customize.php.
 * Make customize.php the formal entry point, rather than admin.php?customize=on.
 * Rename is_current_theme_active() to is_theme_active().
 * Add getters for the theme, settings, controls, and sections properties.
 * Allow customize.php (no ?theme=) to load the active theme. Not used yet.
see #20736.



git-svn-id: http://core.svn.wordpress.org/trunk@20852 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-23 17:56:42 +00:00
koopersmith bc99ad372e Theme Customizer: Properly change state when theme is switched. fixes #20610, see #19910.
* Causes the Manage Themes page to refresh if the customizer is closed after the active theme is switched.
* Changes the text of the 'Save and Activate' button once the theme has been activated.
* Improves the naming of the customize control settings.
* Add events to customize.Loader and make callbacks more flexible.
* Makes the customize-loader l10n compatible with non-admin settings.
* Adds WP_Customize->is_current_theme_active().
* Minor style corrections, including jQuery.attr/prop changes.



git-svn-id: http://core.svn.wordpress.org/trunk@20802 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-16 05:55:54 +00:00
nacin eff63ef3f0 display_header_text() should only return true if the theme mod value is not 'blank'. An empty string is valid -- there is no requirement for it to be truthy. see #18887. see #20600.
git-svn-id: http://core.svn.wordpress.org/trunk@20772 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-11 19:55:07 +00:00
nacin 15b661ecab Make admin-head-callback optional for custom headers. Reverts part of [20684]. fixes #20603.
git-svn-id: http://core.svn.wordpress.org/trunk@20712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-03 13:30:55 +00:00
nacin a5a40528c2 Require both wp-head-callback and admin-head-callback for custom header theme support. fixes #20603.
git-svn-id: http://core.svn.wordpress.org/trunk@20684 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-02 15:16:48 +00:00
nacin 7ae297b910 Undeprecate require_if_theme_supports() for themes using it for legitimate reasons. see [20610]. props scribu, jkudish. fixes #20556.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20642 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-30 02:02:11 +00:00
nacin ace51e5f6d Deprecate require_if_theme_supports(). Always require post-thumbnail-template.php. fixes #20556. fixes #20409.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20610 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-27 04:54:36 +00:00
nacin 981a426119 Initialize the WP_Customize class in a prefixed global. props mattonomics. fixes #20465.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20600 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-25 21:30:02 +00:00
nacin fe63ec5dec If a cached theme root is no longer registered, skip it. Assume the cache is out of date. see #20103.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20551 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-20 13:22:54 +00:00
nacin abd8d6a4c2 Always return a WP_Theme object from wp_get_theme(). If we can't find the theme root, assume the default theme root. (Which will probably result in a WP_Theme object that returns false for the exists() method, which is fine.) see #20361.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20524 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-19 03:33:42 +00:00
koopersmith 73246fa076 Theme Customizer: Remove unused 'template' argument from wp_customize_url. see #19910.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20520 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-18 20:57:06 +00:00
nacin 9df0620d89 Move to admin.php?customize=on&theme=$stylesheet, rather than juggling both template and stylesheet values. see #19910.
Combine the setup_theme() and customize_previewing() methods. Remove the set_template() and set_stylesheet() methods. Add set_theme() method to WP_Customize to store the working WP_Theme object. We will use this for the stylesheet and template.

Use the WP_Theme display() method when preparing headers for display, not get() or the deprecate properties.



git-svn-id: http://svn.automattic.com/wordpress/trunk@20496 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-17 21:43:47 +00:00
koopersmith e11cc3ec4f Theme Customizer: Integrate with browser history. Use window.history by default, with window.onhashchange as a fallback. fixes #20337, see #19910.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20488 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-16 23:07:23 +00:00
nacin aab399efbc Theme Customizer: Stick to wp_customize_url() instead of wp_customize_href(). Switch argument order so it is stylesheet-template. (Template is hypothetically optional, but the function will not support that.) see #19910.
Move to ->display('Name'), as ->get('Name') is a raw, untranslated version of the header.



git-svn-id: http://svn.automattic.com/wordpress/trunk@20477 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-16 14:36:47 +00:00
koopersmith a5dacf7da5 Theme Customizer: Allow the customize iframe to be accessed directly (with full feature support). see #19910.
* Move the 'Return to Manage Themes' and 'Collapse Sidebar' actions from themes.php to customize-controls.php.
* Create a postMessage connection between themes.php and customize-controls.php.
* Allow the theme customizer to be accessed directly (independent of themes.php and the customize loader).
* Add wp_customize_href() and wp_customize_url().
* Remove wp_customize_loader(). To include the loader, use wp_enqueue_script( 'customize-loader' ).
* The theme customizer now requires postMessage browser support.
* Add .hide-if-customize and .hide-if-no-customize CSS classes.
* Clean up customize-preview.js.

git-svn-id: http://svn.automattic.com/wordpress/trunk@20476 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-16 14:02:28 +00:00
koopersmith c2fb0c425b Replace all instances of thickbox theme preview with the theme customizer. fixes #20404.
* Use theme customizer in theme install/update screens.
* Separate the customize loader from the customizer. Use wp_customize_loader() to include the loader script and markup.
* Deprecated: wp-admin/js/theme-preview.js is now no longer used by core.

git-svn-id: http://svn.automattic.com/wordpress/trunk@20419 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-10 02:25:03 +00:00
nacin a64c918e67 Internally cache themes inside wp_get_themes() by theme_root as well as stylesheet, to avoid conflicts with future calls to wp_get_themes(). Always return only the last stylesheet found, as before. see #20103.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20375 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-05 20:38:42 +00:00
nacin a54b4f9c9e Always return a WP_Theme object from wp_get_theme(). Check \$theme->exists() or \$theme->errors() to confirm the requested theme actually exists. see #20361.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20363 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-05 01:05:49 +00:00
westi fba41a5b3a Avoid fatal errors in check_theme_switched() if we fail to get a WP_Theme object for the old theme. Fixes #20334.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20330 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-30 15:13:12 +00:00
nacin 70aa7f9607 Clear theme cache after editing. Reduce default cache persistence to 1800. (Could go lower.) see #20331.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20328 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-30 14:39:05 +00:00
nacin bb4cca4c55 Introduce WP_Theme->exists() to check if the queried theme actually exists. WP_Theme->exists() is a subset of errors() -- a theme with errors may still exist, but a theme that does not exist has an error of theme_not_found. wp_get_theme() now returns false if the theme does not exist. Improve scandir() and get_files() logic. see #20103.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-29 02:59:48 +00:00
nacin 2c016a5a1c Deprecate get_theme_data(). Use wp_get_theme() instead. see #20103.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20269 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-23 10:21:24 +00:00
nacin f60b0a2af3 Introduce display_header_text(). props chipbennett for initial patch. see #18887.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-21 18:48:57 +00:00
nacin f248632c42 WP_Theme::get_allowed_on_network() doesn't take a blog_id argument. props duck_. Restore static declaration accidentally removed in [20193]. see #20103.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20238 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-21 17:32:28 +00:00
nacin 359ed454b7 Callbacks for custom headers and custom backgrounds registered through add_theme_support() are now wp-head-callback, admin-head-callback, and admin-preview-callback. see #19910.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-21 03:36:17 +00:00
nacin 369fca1509 In new add_theme_support() logic, fix logic inversion, define HEADER_IMAGE in a simpler way, and force args to be an array. see #20249.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20221 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-20 20:34:49 +00:00
nacin 4d3e562dd4 Deprecate add_custom_image_header(), remove_custom_image_header(), add_custom_background(), remove_custom_background(). Replacements are add_theme_support() and remove_theme_support(). see #20249.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20218 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-19 21:14:41 +00:00
nacin 127632b10d The word 'support' does not have a overly long 'p'. see #20249.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-19 18:00:27 +00:00
nacin 3c2a88d91e Fix copy-paste issue. see #20249.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20213 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-19 17:15:30 +00:00
nacin 6593186cb7 Introduce new registration methods for custom headers and custom backgrounds. Backwards compatible, but old methods will be deprecated. see #20249. see #17242.
Custom header: Use add_theme_support('custom-header', $args) instead of add_custom_image_header(). Deprecates all use of constants.
 * HEADER_TEXTCOLOR is now (string) 'default-text-color'.
 * NO_HEADER_TEXT is nowi ! (bool) 'header-text'.
 * HEADER_IMAGE_WIDTH (and _HEIGHT) are now (int) 'width' and 'height'.
 * HEADER_IMAGE is now (string) 'default-image'.
 * The 3.4 arguments 'suggested-width' and 'suggested-height' are now just 'width' and 'height' (they are "suggested" when flex-width and flex-height are set).
 * Callback arguments for add_custom_image_header() can now be passed to add_theme_support().

Custom background: Use add_theme_support('custom-background, $args) instead of add_custom_background(). Deprecates all use of constants.
 * BACKGROUND_COLOR is now (string) 'default-color'.
 * BACKGROUND_IMAGE is now (string) 'default-image'.
 * Callback arguments for add_custom_background() can now be passed to add_theme_support().

Inheritance: add_theme_support() arguments for custom headers and custom backgrounds is a first-one-wins situation. This is not an unusual paradigm for theming as a child theme (which is included first) overrides a parent theme.
 * Once an argument is explicitly set, it cannot be overridden. You must hook in earlier and set it first.
 * Any argument that is not explicitly set before WP is loaded will inherit the default value for that argument.
 * It is therefore possible for a child theme to pass minimal arguments as long as the parent theme specifies others that may be necessary.
 * Allows for a child theme to alter callbacks for <head> and preview (previously, calling add_custom_image_header more than once broke things).
 * The just-in-time bits ensure that arguments fall back to default values, that the values of all constants are considered (such as one defined after an old add_custom_image_header call), and that all constants are defined (so as to be backwards compatible).

get_theme_support(): Introduce new second argument, which headers and backgrounds leverage to return an argument. current_theme_supports() already supported checking the truthiness of the argument.
 * For example, get_theme_support( 'custom-header', 'width' ) will return the width specified during registration.
 * If you had wanted the default image, use get_theme_support( 'custom-header', 'default-image' ) instead of HEADER_IMAGE. 

Deprecate remove_custom_image_header(), remove_custom_background(). Use remove_theme_support('custom-header'), 'custom-background'.

Deprecate short-lived custom-header-uploads internal support; this is now (bool) 'uploads' for add_theme_support().

New 3.4 functions renamed or removed: Rename get_current_header_data() to get_custom_header(). Remove get_header_image_width() and _height() in favor of get_custom_header()->width and height.



git-svn-id: http://svn.automattic.com/wordpress/trunk@20212 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-19 17:12:44 +00:00
nacin 962fae26f4 Updates to WP_Theme, wp_get_themes(), and related deprecated functions, after [UT570] [UT578] [UT579]. see #20103.
* ['Template Files'] and ['Stylesheet Files'] need to return files from the parent theme as well.
 * Don't strip links from the Author header. Some themes rely on the previous behavior, such as to link multiple authors (Sandbox, for example.) Don't restore links to the Name, that's just a bad idea.
 * Ensure we are always passing around arrays in get_files/scandir.
 * Better inline doc for wp_get_themes() arguments.
 * Introduce a 'force' flag for search_theme_directories() to re-scan, rather than return the cache. We will use this to re-build the theme_roots transient in get_theme_roots(), but it is more helpful for unit tests. Since search_theme_directories() is cached, don't cache again in wp_get_themes(). (Again benefits testing.)
 * Handle duplicate theme names in the old get_themes() when two themes match (and neither are a default theme, which is already handled). wp_get_themes() will consider both names to be the same; this is just for back compat since get_themes() is keyed by name.
 * Include an old array key in wp_broken_themes().



git-svn-id: http://svn.automattic.com/wordpress/trunk@20193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-15 15:39:21 +00:00
nacin 69447d2e89 Store stylesheet rather than theme name in the theme_switched option. see #20103.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20163 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-08 21:22:24 +00:00
nacin ead3f2f435 Pass WP_Theme->get_theme_root_uri() to get_theme_root_uri(), thereby always triggering the theme_root_uri filter. see #20103.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20162 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-08 18:18:10 +00:00
nacin c5d5d2f13f Use correct variable. see #20103.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20161 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-08 18:00:11 +00:00
nacin d3487222d5 In wp_get_themes() under multisite, filter out allowed themes before creating WP_Theme objects, rather than after. search_theme_directories() provides us the stylesheet of each theme which is all we need to do the proper intersection. This results in major performance gains on sites that have large numbers of themes unavailable to them. see #20103.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20152 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-08 07:46:39 +00:00
nacin 282deeec22 Store relative-to-wp-content theme roots, as that is what get_theme_roots() should be receiving. see #20103.
Since search_theme_directories() now generates this and leverages this as a cache, convert absolute to relative on cache storage, and relative to absolute on cache retrieval.



git-svn-id: http://svn.automattic.com/wordpress/trunk@20118 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-06 01:50:54 +00:00
nacin b53c996068 Cast $wp_theme_directories to array. This had been done in get_themes(). A must-loaded plugin could call these functions before the first theme root is ever added. see #20103.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20116 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-05 17:30:09 +00:00
azaozz dd45b9c2ca Don't pass non-existing rtl stylesheet to TinyMCE, update phpdoc for add_editor_style(), see #19437
git-svn-id: http://svn.automattic.com/wordpress/trunk@20059 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-01 00:18:26 +00:00
nacin 71aa5ca72a Strict comparisons for the $allowed arg for wp_get_themes(). Otherwise 'network' does == true. see #20103.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20053 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-29 23:04:25 +00:00
nacin a8d45a288f Deprecate get_current_theme(). Use (string) wp_get_theme() to get the translated name of the theme. Keep the current_theme option for now. see #20103, see #20138.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20040 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-29 20:07:22 +00:00
nacin b599bef67a Update switch_theme() to use wp_get_theme(). see #20103, #20138.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20033 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-29 05:09:29 +00:00
nacin d130a63e25 Introduce WP_Theme, wp_get_themes(), and wp_get_theme() to replace get_themes(), get_theme(), get_theme_data(), current_theme_info(), and others.
* Getters and Helpers: Introduces a series of methods to allow for easy generation of headers for display, and other theme metadata, including page templates.
 * Screenshots: Handles support for multiple screenshots. (see # Additional screenshots must be PNG and start with screenshot-2.png, and be sequential to be counted. see #19816.
 * Error Handling: Broken themes have a WP_Error object attached to them.
 * Caching: Introduces a wp_cache_themes_persistently filter (also in [20020]) to enable persistent caching of all filesystem and sanitization operations normally handled by WP_Theme (and formerly get_file_data() and get_themes()). Themes are cached individually and across five different cache keys for different data pieces.
 * Compatibility: A WP_Theme object is backwards compatible with a theme's array formerly returned by get_themes() and get_theme(), and an stdClass object formerly returned by current_theme_info().
 * i18n/L10n: Theme headers are now localizable with proper Text Domain and Domain Path headers, like plugins. (Language packs may remove the requirement for headers.) For page templates, see #6007 (not fixed yet, but will be easy now). For headers, fixes #15858.
 * PHP and CSS files: New methods that fetch a list of theme files (for the theme editor) only on demand, rather than only loading them into memory. fixes #11214.

Functions deprecated:
 * get_themes(), get_allowed_themes() and get_broken_themes() -- use wp_get_themes()
 * get_theme() and current_theme_info() -- use wp_get_theme()
 * get_site_allowed_themes() -- use WP_Theme::get_allowed_on_network()
 * wpmu_get_blog_allowedthemes() -- use WP_theme::get_allowed_on_site()

see also [20016], [20018], [20019], [20020], [20021], [20022], [20025], [20026], [20027]. also fixes #19244.

see #20103.



git-svn-id: http://svn.automattic.com/wordpress/trunk@20029 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-28 21:24:44 +00:00
nacin 0cb8aed823 Theme root transient caching is now in search_theme_directories(), not get_themes(). see #20103.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20021 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-28 20:08:08 +00:00
nacin c77de588d4 Rewrite search_theme_directories() -- better performance and allow for caching.
* Update it to use PHP5 scandir().
 * Don't scan individual theme dirs -- we only need to check for style.css. (Solid performance gains.)
 * Improve and simplify branching.
 * Introduce wp_cache_themes_persistently filter to enable persistent caching of the return value, based on the theme_roots transient.

see #20103.


git-svn-id: http://svn.automattic.com/wordpress/trunk@20020 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-28 20:05:00 +00:00
nacin 7df034983a Clarify second argument for get_raw_theme_root() as the multiple negatives can get confusing. see #20103.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20018 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-28 19:59:53 +00:00
nacin d131a8951a Fix the return value of get_theme_root() when the theme root is outside of WP_CONTENT_DIR, thus making it absolute rather than the typical relative theme root.
Make get_theme_root_uri() tolerate an absolute path for a theme root. It will now make an attempt to find a corresponding URL for absolute paths as well.

see #17597.



git-svn-id: http://svn.automattic.com/wordpress/trunk@20016 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-28 18:02:21 +00:00
nacin 53022ddbfb Revert [20001]. Theme roots that are passed around, stored, and cached can be valid as absolute paths or paths relative to wp-content. We'll have to patch this elsewhere. see #17597.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20015 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-28 16:22:26 +00:00
nacin e4bfd6ecc1 Move the template loading functions from wp-includes/theme.php to wp-includes/template.php. This includes get_query_template(), locate_template(), and friends. see #20103.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20002 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-28 01:49:49 +00:00
nacin 08e57bfca5 Always return an absolute path in get_raw_theme_root() and get_theme_roots().
These functions were changed in [15641] to avoid any calculations when only one theme directory is registered. However, the short-circuit ended up being relative to WP_CONTENT_DIR, rather than absolute. This broke situations where theme roots are outside the content directory (technically allowed), and made return values inconsistent, as when multiple roots were registered, absolute paths were always returned.

fixes #17597. see #20103. see #14911.



git-svn-id: http://svn.automattic.com/wordpress/trunk@20001 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-28 01:28:56 +00:00
koopersmith c832f904ae Introduce new theme customizer to replace theme preview. Rough first pass. props koopersmith, ocean90. see #19910.
Merges in http://plugins.svn.wordpress.org/gandalf/branches/dev/ rev 510148.

git-svn-id: http://svn.automattic.com/wordpress/trunk@19995 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-25 04:12:43 +00:00
nacin 206bd59baa Twenty Twelve always trumps its pretenders. see #19978.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19969 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-21 17:39:05 +00:00
nacin 0acbde2f56 Return an empty object properly. see #17242.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19821 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-03 13:38:03 +00:00
ryan c43ddd7284 Allow flexible sizes for custom header uploads. Round 1. Props aaroncampbell, sabreuse. see #17242
git-svn-id: http://svn.automattic.com/wordpress/trunk@19815 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-02 23:35:37 +00:00
ryan 83b131f8e3 User lowercase true, false, null instead of uppercase. Props c3mdigital, mfields. fixes #16302
git-svn-id: http://svn.automattic.com/wordpress/trunk@19687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-05 20:50:54 +00:00
ryan f809fda4e7 Allow pluggable arg checking in current_theme_supports. Props dd32. fixes #11611
git-svn-id: http://svn.automattic.com/wordpress/trunk@19682 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-05 18:29:40 +00:00
ryan d1ba11c7d1 Update some @since. Props dgwyer. fixes #19638
git-svn-id: http://svn.automattic.com/wordpress/trunk@19673 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-04 19:03:33 +00:00
nacin 3f890507d4 Hide the toolbar on all subsequent links in the theme preview. props linuxologos, fixes #19610.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19617 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-20 22:10:47 +00:00
ryan 07ff8b216b Use one space, not two, after trailing punctuation. fixes #19537
git-svn-id: http://svn.automattic.com/wordpress/trunk@19593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-13 23:45:31 +00:00
nacin e78ef2fc43 Check is_array() against get_themes() in get_theme(). props cgrymala, see #19244.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19287 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-14 23:56:18 +00:00
ryan 6bbc8d4ce4 Avoid notice when themes dir is empty or missing. Don't reset current theme in current_theme_info() if there are no themes. Show warning in Right Now if there are no themes. Props azaozz. fixes #19089
git-svn-id: http://svn.automattic.com/wordpress/trunk@19251 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-11 14:10:54 +00:00
nacin 89c0895887 new does not require by reference.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18995 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-18 20:20:59 +00:00
markjaquith 37aae9f46f Give custom background CSS more specificity. props GaryJ. fixes #18698
git-svn-id: http://svn.automattic.com/wordpress/trunk@18886 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-05 17:20:43 +00:00
ryan 2edc82cd61 * Move the old sidebars_widgets array upgrade code to wp-admin/includes/upgrade.php
* Avoid infinite loop with wp_get_sidebars_widgets()
* Remove two unneeded wp_get_sidebars_widgets() calls
* Remove unused $wp_registered_sidebars variable from wp_get_sidebars_widgets().
* Combine  a couple of !empty( $sidebars_widgets ) checks in retrieve_widgets()
Props SergeyBiryukov, lancewillett. fixes #17979 #18598


git-svn-id: http://svn.automattic.com/wordpress/trunk@18821 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-29 21:41:22 +00:00
duck_ 6e2ffdc289 Allow current_theme_supports() to be used to check for specific post formats. Props ericmann. Fixes #18691.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18720 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-19 16:29:03 +00:00
azaozz dc936c54c1 Rename the newly added action 'after_theme_change' to 'after_switch_theme' so it matches the 'switch_theme' action, props scribu, see #17979
git-svn-id: http://svn.automattic.com/wordpress/trunk@18656 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-08 20:59:41 +00:00
azaozz c00346820f Make check_theme_switched() run an action so this enhancement is available to plugins and themes too, see #17979
git-svn-id: http://svn.automattic.com/wordpress/trunk@18655 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-08 20:07:15 +00:00
azaozz b79223097c Use theme mods instead of transients for storing the previous theme's widgets config, props aaroncampbell, see #17979
git-svn-id: http://svn.automattic.com/wordpress/trunk@18654 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-08 19:25:20 +00:00
duck_ 2f51b9be0d Fix typos in documentation (wp-includes/[i-z]). See #18560.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18639 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-05 19:08:15 +00:00
azaozz 4852c5887f Avoid losing widgets when switching themes - take one, props aaroncampbell, see #17979
git-svn-id: http://svn.automattic.com/wordpress/trunk@18630 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-02 22:13:55 +00:00
ryan 9907923011 Add theme support option for turning on random default headers. fixes #17832
git-svn-id: http://svn.automattic.com/wordpress/trunk@18325 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-22 19:09:23 +00:00
dd32 2de2e62337 Twenty Eleven trumps it's pretenders. Fixes #17841
git-svn-id: http://svn.automattic.com/wordpress/trunk@18322 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-20 03:07:24 +00:00
nacin 2571545ec0 @since s/3.2/3.2.0/
git-svn-id: http://svn.automattic.com/wordpress/trunk@18268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-11 04:40:18 +00:00
ryan 81a5f821fb Sanitize guid on save and display. Sanitize mime type on save. Don't allow changing mime type via edit form handlers. Protect hidden meta.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-22 23:19:42 +00:00
nacin fad60afa23 Code readability improvements. props niallkennedy, fixes #17166, #17182, #17231, #16474.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17989 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-22 22:30:05 +00:00
ryan e0ffff9fb5 Fix hiding of header image. Fix radio selection when falling back to randomized default headers. Props lancewillett, kawauso. see #17240
git-svn-id: http://svn.automattic.com/wordpress/trunk@17770 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-29 19:45:30 +00:00
ryan 67d53316e0 Allow selecting previously uploader headers and randomly serving previously uploaded or default headers. Props lancewillett. see #17240
git-svn-id: http://svn.automattic.com/wordpress/trunk@17757 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-28 23:02:16 +00:00
westi 42f57d4798 Remove this new filter as it didn't get enough discussion prior to addition.
Revisit later. See #14310.

git-svn-id: http://svn.automattic.com/wordpress/trunk@17316 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-01-15 23:44:06 +00:00
ryan 85f1feed84 Bring out the shears.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17228 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-01-06 04:11:14 +00:00
markjaquith 3509f37ac1 I bungled [17214]. Reverting the revert, so it can be reverted properly! see #14310
git-svn-id: http://svn.automattic.com/wordpress/trunk@17220 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-01-04 20:55:59 +00:00
markjaquith 6fc301a723 Revert [15611] for 3.1. Needs more time for peer review and iteration. see #14310
git-svn-id: http://svn.automattic.com/wordpress/trunk@17214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-01-04 07:23:41 +00:00
ryan 2de6f5ba96 Ignore unsupported post types in add_theme_support(). Props garyc40. fixes #16073
git-svn-id: http://svn.automattic.com/wordpress/trunk@17213 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-01-03 23:56:42 +00:00
nacin 8a6ec685fb Revert [16915]. Don't honor the page template for the posts page. Deal with this with a better UX in 3.2. see #15513, fixes #15945.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-23 17:05:47 +00:00
ryan 587ea006b5 Translations in title attributes require esc_attr().
git-svn-id: http://svn.automattic.com/wordpress/trunk@17102 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-21 17:17:58 +00:00
westi 8a261e59e2 -- bad white space part deux
git-svn-id: http://svn.automattic.com/wordpress/trunk@17023 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-17 08:42:37 +00:00
westi c1b7a3ef59 If we are previewing don't show the admin bar. See #15856
git-svn-id: http://svn.automattic.com/wordpress/trunk@17020 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-17 08:32:53 +00:00
nacin 4cc8f440e4 Add theme_mods option if is_admin. props MarkJaquith, fixes #14828.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16958 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-15 17:39:00 +00:00
nacin e4698ba1be Revert to WP_DEFAULT_THEME if a child theme is in use and no style.css is present. fixes #15712, props greuben.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16925 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-14 19:19:47 +00:00
nacin 3efc0738b6 Revert to WP_DEFAULT_THEME if a child theme is in use and no style.css is present. fixes #15712.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16924 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-14 19:17:49 +00:00
ryan 14b8509961 Honor the page template when a page is the home page but not also the front page. Props filosofo. fixes #15513
git-svn-id: http://svn.automattic.com/wordpress/trunk@16915 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-14 15:45:19 +00:00
ryan 3949ce12d0 Pink trailing whites.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16900 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-13 21:21:50 +00:00
nacin 0036c52101 Make get_header_image() ssl-aware. fixes #14835.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16846 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-09 17:59:35 +00:00
nacin 4e2fb85913 Introduce remove_editor_styles(). fixes #14903.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16721 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-04 10:09:00 +00:00
nacin 373a66db0f Introduce remove_custom_background(). see #14903.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16720 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-04 09:59:35 +00:00
nacin 72958d1c53 Make sure get_themes() returns the proper template and stylesheet directory paths. Use the correct variables. fixes #15671.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16711 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-03 22:53:01 +00:00
markjaquith 74f17e9850 Fix typo in PHPdoc. props PeteMall.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16697 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-02 22:56:55 +00:00
nacin 831ffc5483 Return true if not is_admin. Tidy. see #14903.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16677 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-02 00:50:23 +00:00
nacin efe850aa42 Introduce remove_custom_image_header(). see #14903.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16674 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-02 00:16:35 +00:00
ryan 3f72e340d6 Update since phpdoc. Props demetris. fixes #15445
git-svn-id: http://svn.automattic.com/wordpress/trunk@16660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-01 19:24:38 +00:00
ryan a6cdc2dea4 Register the default theme dir in wp-settings.php so that it is registered even when get_themes() doesn't run. Fix counting of theme dirs. Add option to get_raw_theme_root() to disregard the current theme root cache. see #14911
git-svn-id: http://svn.automattic.com/wordpress/trunk@16424 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-17 16:11:44 +00:00
nacin 81a8f2d3ce Use square brackets instead of braces for string access. props hakre, fixes #13900.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16340 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-13 09:53:55 +00:00
markjaquith 17fbb0e123 add_theme_support( 'post-formats', array( 'aside', 'image', 'etc' ) ); Add UI for choosing a post format, and save the choice. see #14746
git-svn-id: http://svn.automattic.com/wordpress/trunk@16174 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-04 07:41:07 +00:00
scribu b890848aaa Use get_queried_object() in more get_*_template() functions. Fixes #15263
git-svn-id: http://svn.automattic.com/wordpress/trunk@16115 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-31 11:23:10 +00:00
scribu e2efa78154 use get_queried_object() wrappers throughout. See #14015
git-svn-id: http://svn.automattic.com/wordpress/trunk@16114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-31 11:02:17 +00:00
nacin 16d0878544 Remove unnecessary wp_cache_delete calls. props shidouhikari, fixes #14080.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16029 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-28 05:22:45 +00:00
nacin d91842f870 Allow disabling of custom header uploads via remove_theme_support. props jorbin, fixes #14837.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15828 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-17 07:12:34 +00:00
nacin eb8762d626 Custom post type archives. see #13818.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15803 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-14 10:39:47 +00:00
scribu f0d8d094e2 Allow string as first parameter to locate_template(). Props chrisbliss18 for initial patch. Fixes #15061
git-svn-id: http://svn.automattic.com/wordpress/trunk@15771 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-10 22:10:36 +00:00
nacin 5f0bc55c0b Some doc updates. see #15048.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15739 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-07 05:59:50 +00:00
nacin 50120d23da Shift theme mods to be reliant on the theme slug instead of name. fixes #15048.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15736 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-06 21:00:17 +00:00
nacin 7ee6aecd1b Account for Twenty Ten in theme name collisions and properly fall back to TT in get_current_theme(). fixes #15719, props tonyf12.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15720 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-04 19:50:13 +00:00
ryan f3d45472d2 Don't fetch theme_roots transient on every page load. Avoid it altogether if there is only one theme dir. fixes #14911
git-svn-id: http://svn.automattic.com/wordpress/trunk@15641 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-09-21 19:41:35 +00:00
scribu 2030231f66 Clean up taxonomy queries in WP_Query. See #12891
git-svn-id: http://svn.automattic.com/wordpress/trunk@15613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-09-13 16:44:14 +00:00
scribu 4c7deb41e7 Apply filters consistently in get_*_template() functions. Fixes #14310
git-svn-id: http://svn.automattic.com/wordpress/trunk@15611 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-09-12 18:46:18 +00:00
nacin 5a20c05d27 Phpdoc argument/@param cleanups. props duck_, see #14783.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-09-07 11:21:11 +00:00
westi 4a037313e3 Remove debug cruft. See #14315 props scribu.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15435 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-07-17 11:13:35 +00:00
westi 64100e8783 Fix the theme compat file require paths to be fully absolute so they don't rely on a particular php path to work. Fixes #14315 for trunk props dougal.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15433 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-07-16 09:40:09 +00:00
nacin 194181c6e5 Blacklist remove_theme_support('menus'), used internally. fixes #13935 for trunk.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15277 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-06-18 05:37:45 +00:00
ryan 5ecd1f31f2 Trim trailing whitespace.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-06-11 20:19:35 +00:00
nacin 69164abe07 Improve the custom background front-end callback. Also, background-attachment should default to scroll, not fixed. fixes #13751.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-06-10 18:28:25 +00:00
dd32 ebe57d5b69 Use the correct variable name. See #13778
git-svn-id: http://svn.automattic.com/wordpress/trunk@15167 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-06-08 11:04:51 +00:00
dd32 a0729014b8 Use the correct variable name. Props ScottMac. Fixes #13778
git-svn-id: http://svn.automattic.com/wordpress/trunk@15166 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-06-08 11:02:17 +00:00
ryan 1a552dd029 Strip trailing whitespace
git-svn-id: http://svn.automattic.com/wordpress/trunk@14924 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-26 02:42:15 +00:00
westi b5820d2934 phpDoc updates.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14858 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-24 21:26:49 +00:00
nacin 64601e97ae Invalidate header/background images for the current theme when the attachment is deleted. props ocean90, fixes #12467.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14850 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-24 19:42:43 +00:00
nacin d6e2ef4dbf Custom background UI updates. props ocean90 for initial patch, see #12186.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14684 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-16 05:17:57 +00:00
nacin a2a0b6041b Also return raw author name and URI from get_theme_data and get_themes. props blepoxp, fixes #12275.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-15 06:28:35 +00:00
westi 83ae6a51ea Introduce __return_empty_array() and use it instead of create_function in the theme preview.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14641 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-14 16:55:26 +00:00
nacin b38af2d56d Check if HEADER_ constants are defined before continuing. props ocean90, fixes #13367.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14610 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-13 21:44:37 +00:00
nacin e88d9914de Remove unused global var. props filosofo, fixes #13316.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14536 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-10 06:06:37 +00:00
nacin fa23d1edf0 Remove WP_FALLBACK_THEME, use WP_DEFAULT_THEME instead. We now only fall back to the default theme if the theme is broken. Incomplete themes that need to inherit templates will inherit them from wp-includes/theme-compat -- this behavior is deprecated. fixes #12846.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14485 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-06 19:53:40 +00:00
westi 1afa45d117 Add is_child_theme(). Fixes #12998 props ptahdunbar.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14409 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-03 20:56:57 +00:00
ryan 7b7243d94a Strip trailing whites.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14404 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-03 20:26:11 +00:00
westi ae468d52ac First pass of compatibility code for old themes which relied on using templates from the default theme without expressly identifying it as the parent theme.
Fixes #12425 and #13009.
The fallback to these template files is now depreceated and will be removed in a future version.


git-svn-id: http://svn.automattic.com/wordpress/trunk@14365 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-03 09:57:24 +00:00
nacin 4d7c88f4a4 Introduce is_rtl(). Use it in core. It only becomes defined when locale is loaded, so it's impossible to use it too early. Deprecate the get_bloginfo('text_direction') call. fixes #13206.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14360 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-03 05:49:19 +00:00
westi 033aac697c Introduce a template file for the Front Page of a site. Has priority over every other template which applies and falls back to the standard template flow for the page / list of posts.
Fixes #6801

git-svn-id: http://svn.automattic.com/wordpress/trunk@14276 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-28 07:48:09 +00:00
ryan 0d703dc2c0 Add RTL support to add_editor_style(). Props yoavf. fixes #13120
git-svn-id: http://svn.automattic.com/wordpress/trunk@14240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-26 14:56:57 +00:00
westi 8ce9670189 Improve documentation of validate_current_theme()
git-svn-id: http://svn.automattic.com/wordpress/trunk@14175 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-21 17:14:25 +00:00
dd32 66a9d58336 Fix page-<pageslug>.php templates for static front pages. See #12907
git-svn-id: http://svn.automattic.com/wordpress/trunk@14152 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-18 11:50:48 +00:00
nacin 3c5115f15f Don't use require_once for get_template_part(). fixes #12958.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14075 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-11 17:26:03 +00:00
nacin 1c9c709e8a Child theme support for theme header registrations. Second call to register_theme_headers() should add more headers, not replace existing headers. add unregister_theme_headers(). props jorbin. see #12343
git-svn-id: http://svn.automattic.com/wordpress/trunk@13928 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-02 03:15:18 +00:00
markjaquith 9817fca789 Fix PHP notice
git-svn-id: http://svn.automattic.com/wordpress/trunk@13908 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-01 07:43:04 +00:00
nacin 370f6a43b9 Add blacklist to remove_theme_support(). fixes #12739.
git-svn-id: http://svn.automattic.com/wordpress/trunk@13902 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-31 09:06:11 +00:00
wpmuguru 175c104baa add remove_theme_support(), props nathanrice, fixes #12739
git-svn-id: http://svn.automattic.com/wordpress/trunk@13877 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-29 16:26:54 +00:00
dd32 f0088e38eb Add Repeat-x/repeat-y support to Custom Backgrounds, Add Live preview of Repeat option, Use Thumbnail of background for Background Preview. Props jshreve. See #12186
git-svn-id: http://svn.automattic.com/wordpress/trunk@13856 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-28 02:53:04 +00:00
nacin 3918b75cbe Change @since 2.9 to @since 2.9.0.
git-svn-id: http://svn.automattic.com/wordpress/trunk@13829 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-26 19:23:39 +00:00
nacin 1eabd22805 Introduce get_index_template(). Allows child themes to override a parent theme's index.php. Props koopersmith, fixes #12635
git-svn-id: http://svn.automattic.com/wordpress/trunk@13819 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-26 13:52:43 +00:00
ryan f91e95f100 make *_option(), *_transient() functions consistently expect unslashed data. Props Denis-de-Bernardy. see #12416
git-svn-id: http://svn.automattic.com/wordpress/trunk@13673 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-11 21:49:56 +00:00
ryan 59873d0b4f Custom background color fixes. see #12186
git-svn-id: http://svn.automattic.com/wordpress/trunk@13668 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-11 20:21:58 +00:00
ryan 4b766eb312 Background color selection. Props lancewillett. see #12186
git-svn-id: http://svn.automattic.com/wordpress/trunk@13574 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-03 17:10:43 +00:00
nacin 6df81f3d95 Escape mod_$theme option name. see #9015
git-svn-id: http://svn.automattic.com/wordpress/trunk@13469 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-27 20:26:37 +00:00
nacin 9797dacaa0 add_editor_style() third pass. better performance and better child theme support. see #11512
git-svn-id: http://svn.automattic.com/wordpress/trunk@13453 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-27 07:36:35 +00:00
nacin 59b2461dcf add_editor_style(), second pass. Accept an array of stylesheets, also allow multiple calls to the function. Support child themes. See #9015 see #11512
git-svn-id: http://svn.automattic.com/wordpress/trunk@13444 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-26 21:07:41 +00:00
nacin 45748141c0 Introduce add_editor_style() to easily register a stylesheet for the visual editor. see #11512 see #9015
git-svn-id: http://svn.automattic.com/wordpress/trunk@13441 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-26 20:12:06 +00:00
ryan a3ae373902 Note theme support for custom background, header, and menus. see #11817
git-svn-id: http://svn.automattic.com/wordpress/trunk@13417 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-25 22:04:59 +00:00
ryan a8a6d742e1 Default header selector, first pass. see #12343
git-svn-id: http://svn.automattic.com/wordpress/trunk@13403 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-25 19:18:44 +00:00
ryan 9ab7306993 Remove author tags. fixes #12366
git-svn-id: http://svn.automattic.com/wordpress/trunk@13377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-24 19:07:21 +00:00
nacin b8ecd8058f Fix potential notice. props hakre, see #12283
git-svn-id: http://svn.automattic.com/wordpress/trunk@13225 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-19 15:04:46 +00:00
westi aa5f4d55b7 Move more references from default to WP_FALLBACK_THEME. To make 'default' theme transition smoother in the future.
git-svn-id: http://svn.automattic.com/wordpress/trunk@13202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-18 22:09:06 +00:00
nacin 63af26e0cd Use background-position, as background-position-x has incomplete browser support (Webkit and IE6+ only, no Firefox or Opera). See #12186
git-svn-id: http://svn.automattic.com/wordpress/trunk@13190 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-18 04:46:40 +00:00
ryan f35b2128ae Add defaults for background option radios. see #12186
git-svn-id: http://svn.automattic.com/wordpress/trunk@13189 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-18 03:12:05 +00:00
ryan 447b0a50da Use background-position-x. Props iammattthomas. see #12186
git-svn-id: http://svn.automattic.com/wordpress/trunk@13188 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-18 03:01:45 +00:00
ryan d472b153ca Add some options to custom background admin. Needs styling. see #12186
git-svn-id: http://svn.automattic.com/wordpress/trunk@13186 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-18 00:14:56 +00:00
ryan 61859c5f5e First pass at custom background support. Needs UI love. see #12186
git-svn-id: http://svn.automattic.com/wordpress/trunk@13041 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-09 20:37:12 +00:00
ryan 4ddde1ab9d Look for single-.php templates. Add single- class to get_body_class(). Props ptahdunbar. see #12105
git-svn-id: http://svn.automattic.com/wordpress/trunk@13032 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-08 22:05:05 +00:00
ryan 4b2651d1e6 Slightly more informative error message for themes missing their parent theme. Need to offer to install the parent if it is in the themes directory.
git-svn-id: http://svn.automattic.com/wordpress/trunk@13020 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-07 23:19:39 +00:00
westi 333f5b0cfa Switch to a constant for the fallback theme. See #9015.
git-svn-id: http://svn.automattic.com/wordpress/trunk@13019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-07 22:36:37 +00:00
ryan 8e1a363a8d Make twentyten the fallback theme. see #9015
git-svn-id: http://svn.automattic.com/wordpress/trunk@13018 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-07 22:27:51 +00:00
westi f65140c7b3 Ensure we are PHP4 compat. Fixes #12167 props blepoxp.
git-svn-id: http://svn.automattic.com/wordpress/trunk@13014 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-07 21:07:35 +00:00
westi e1ec3c052e Support specific author templates by id or user_nicename. Fixes #12064 props nacin.
git-svn-id: http://svn.automattic.com/wordpress/trunk@12915 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-01-31 21:32:39 +00:00
ryan bdfb0460da Send user back to main custom header page after cropping and setting image. Add support for a custom image div callback for greather theme flexibility. Props dphiffer. see #11855
git-svn-id: http://svn.automattic.com/wordpress/trunk@12890 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-01-28 19:00:16 +00:00
ryan 6da55f7792 Trailing whitespace cleanup
git-svn-id: http://svn.automattic.com/wordpress/trunk@12733 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-01-15 22:11:12 +00:00
ryan ec8e347792 Introduce home_url(). Props Denis-de-Bernardy, hakre. see #9008
git-svn-id: http://svn.automattic.com/wordpress/trunk@12598 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-01-04 17:23:29 +00:00
ryan 98d62f55bb Make sure dir() returned a dir object.
git-svn-id: http://svn.automattic.com/wordpress/trunk@12434 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-12-17 19:56:05 +00:00
markjaquith bf264bb66d Post/Page Image was too generic a name. Post/Page Thumbnail is more clear, even if you can create very large thumbnail images if you so choose.
git-svn-id: http://svn.automattic.com/wordpress/trunk@12351 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-12-10 06:14:36 +00:00
ryan 1c90385918 Allow registering post image support per post type. fixes #11364
git-svn-id: http://svn.automattic.com/wordpress/trunk@12350 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-12-09 15:39:20 +00:00
markjaquith f2df3f3751 Revision 12345. Nothing but whitespace fixes. That's how I roll.
git-svn-id: http://svn.automattic.com/wordpress/trunk@12345 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-12-08 21:29:12 +00:00
markjaquith 0415ab7b42 Standardize around "post image" instead of "post thumbnail"
git-svn-id: http://svn.automattic.com/wordpress/trunk@12339 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-12-08 16:34:04 +00:00
westi c616c60c0d Reduce the size of the data returned by get_themes() by ~30% by reducing duplication.
git-svn-id: http://svn.automattic.com/wordpress/trunk@12226 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-11-19 20:45:37 +00:00
ryan f0f570d098 Avoid warning when parent template does not exist.
git-svn-id: http://svn.automattic.com/wordpress/trunk@12216 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-11-19 16:35:17 +00:00
westi a980ec773a Improve get_page_template() to search based on slug and id as well. Fixes #11055 props aaroncampbell.
git-svn-id: http://svn.automattic.com/wordpress/trunk@12135 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-11-01 10:18:34 +00:00
westi 7251aff3f3 Introduce require_if_theme_supports(), move post thumbnails functions to there own include and only included them if the theme supports them. See #10928 and [12132]
git-svn-id: http://svn.automattic.com/wordpress/trunk@12134 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-11-01 10:10:06 +00:00
markjaquith a8c96db902 Introducing add_theme_support(feature) and current_theme_supports(feature) for announcing and checking theme support for various features. Implement it for post/page thumbanils, hiding UI if not supported.
git-svn-id: http://svn.automattic.com/wordpress/trunk@12132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-11-01 05:27:39 +00:00
ryan 7578a5b511 get_themes() and theme root fixes. see #10467
git-svn-id: http://svn.automattic.com/wordpress/trunk@12129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-10-30 00:18:15 +00:00
ryan 9ee06eaec7 Introduce get/set/delete_site_transient(). Make theme_roots a site transient.
git-svn-id: http://svn.automattic.com/wordpress/trunk@12128 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-10-29 21:53:57 +00:00
ryan f089f96723 Theme roots are prefixed with a slash. No need to add another. Props hakre. fixes #11036
git-svn-id: http://svn.automattic.com/wordpress/trunk@12124 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-10-28 21:58:15 +00:00
ryan 1ada1c60de Theme subdirs that contain themes are not broken if missing a stylesheet. see #10467
git-svn-id: http://svn.automattic.com/wordpress/trunk@12119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-10-27 17:32:12 +00:00