Commit Graph

49 Commits

Author SHA1 Message Date
Sergey Biryukov 8cdec43675 Coding Standards: Use `esc_url()` instead of `esc_attr()` for some URLs.
Follow-up to [2063], [2182], [4656], [6952], [9098], [11109], [11204], [17887], [22505], 

Props kebbet.
See #54728.
Built from https://develop.svn.wordpress.org/trunk@52957


git-svn-id: http://core.svn.wordpress.org/trunk@52546 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2022-03-19 20:31:12 +00:00
Sergey Biryukov 47ed56f38f Code Modernization: Replace `dirname( __FILE__ )` calls with `__DIR__` magic constant.
This avoids the performance overhead of the function call every time `dirname( __FILE__ )` was used instead of `__DIR__`.

This commit also includes:

* Removing unnecessary parentheses from `include`/`require` statements. These are language constructs, not function calls.
* Replacing `include` statements for several files with `require_once`, for consistency:
 * `wp-admin/admin-header.php`
 * `wp-admin/admin-footer.php`
 * `wp-includes/version.php`

Props ayeshrajans, desrosj, valentinbora, jrf, joostdevalk, netweb.
Fixes #48082.
Built from https://develop.svn.wordpress.org/trunk@47198


git-svn-id: http://core.svn.wordpress.org/trunk@46998 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-06 06:33:11 +00:00
Sergey Biryukov d784ebbcb4 Coding Standards: Use strict comparison and Yoda conditions in the root directory files.
Props pikamander2.
Fixes #48965.
Built from https://develop.svn.wordpress.org/trunk@47054


git-svn-id: http://core.svn.wordpress.org/trunk@46854 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-09 00:55:05 +00:00
Sergey Biryukov ba033e96ef Link Manager: Use a strict `in_array()` check in `wp-links-opml.php`.
Props dkarfa.
Fixes #49106.
Built from https://develop.svn.wordpress.org/trunk@47033


git-svn-id: http://core.svn.wordpress.org/trunk@46833 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-03 01:14:02 +00:00
Sergey Biryukov e199663322 I18N: Capitalize translator comments consistently, add trailing punctuation.
Includes minor code layout fixes.

See #44360.
Built from https://develop.svn.wordpress.org/trunk@45932


git-svn-id: http://core.svn.wordpress.org/trunk@45743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-03 00:41:05 +00:00
Gary Pendergast 97aef0e336 Docs: Remove duplicate docblocks for the `pre_user_login` and `link_category` filters.
Props coffee2code.
Fixes #45308.


Built from https://develop.svn.wordpress.org/trunk@44612


git-svn-id: http://core.svn.wordpress.org/trunk@44443 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-16 05:29:49 +00:00
Gary Pendergast 56c162fbc9 Coding Standards: Upgrade WPCS to 1.0.0
WPCS 1.0.0 includes a bunch of new auto-fixers, which drops the number of coding standards issues across WordPress significantly. Prior to running the auto-fixers, there were 15,312 issues detected. With this commit, we now drop to 4,769 issues.

This change includes three notable additions:
- Multiline function calls must now put each parameter on a new line.
- Auto-formatting files is now part of the `grunt precommit` script. 
- Auto-fixable coding standards issues will now cause Travis failures.

Fixes #44600.


Built from https://develop.svn.wordpress.org/trunk@43571


git-svn-id: http://core.svn.wordpress.org/trunk@43400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-17 01:51:36 +00:00
Sergey Biryukov 4848a09b35 I18N: Use the actual placeholder instead of a number in translator comments if the corresponding string does not use numbered placeholders.
Add missing translator comments in `WP_Theme_Install_List_Table` and `wp_notify_postauthor()`.
Add missing commas in some translator comments.

Fixes #43523.
Built from https://develop.svn.wordpress.org/trunk@42827


git-svn-id: http://core.svn.wordpress.org/trunk@42657 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-11 16:44:34 +00:00
Gary Pendergast aaf99e6913 Code is Poetry.
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.


Built from https://develop.svn.wordpress.org/trunk@42343


git-svn-id: http://core.svn.wordpress.org/trunk@42172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-30 23:11:00 +00:00
John Blackbourn c2d709e9d6 I18n: Introduce more translator comments for strings that contain placeholders but don't have an accompanying translator comment.
See #38882

Built from https://develop.svn.wordpress.org/trunk@39326


git-svn-id: http://core.svn.wordpress.org/trunk@39266 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-11-21 02:46:30 +00:00
Drew Jaynes f82641ad0e Docs: Standardize filter docs in root folder files to use third-person singular verbs per the inline documentation standards for PHP.
Fixes #36913.

Built from https://develop.svn.wordpress.org/trunk@37535


git-svn-id: http://core.svn.wordpress.org/trunk@37503 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-23 16:44:27 +00:00
Andrew Nacin de7977d66c Move upgrader_process_complete for core to its proper place in Core_Upgrader.
This means it will be firing as a JS redirect is taking place if the update is from pre-3.4. Acceptable.

props dd32.
fixes #25659.

Built from https://develop.svn.wordpress.org/trunk@25861


git-svn-id: http://core.svn.wordpress.org/trunk@25861 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:58:23 +00:00
Drew Jaynes 4d1482cd0d Inline documentation for the `WP_Date_Query` class in wp-includes/date.php.
- Adds a complete hash notation for the `WP_Date_Query` arguments array.
- Adds missing documentation for the `date_query_valid_columns` and `get_date_sql` filter hooks.

Props aeg0125 for the incremental patches.
Fixes #25552.

Built from https://develop.svn.wordpress.org/trunk@25860


git-svn-id: http://core.svn.wordpress.org/trunk@25860 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:58:12 +00:00
Andrew Nacin fd57b239d2 Don't rely on include_path to include files.
Always use dirname() or, once available, ABSPATH.

props ketwaroo, hakre.
fixes #17092.

Built from https://develop.svn.wordpress.org/trunk@25616


git-svn-id: http://core.svn.wordpress.org/trunk@25533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-25 00:18:11 +00:00
Sergey Biryukov ccc0719f03 Inline documentation for hooks in wp-links-opml.php.
props netweb.
see #25229.
Built from https://develop.svn.wordpress.org/trunk@25480


git-svn-id: http://core.svn.wordpress.org/trunk@25401 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-18 17:31:08 +00:00
dd32 fa9f9ed688 Do not Query for posts on OPML exports, Fixes OPML export script 404'ing due to no pages matching 'wp-links-opml.php'. Fixes #15195
git-svn-id: http://svn.automattic.com/wordpress/trunk@15928 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-23 12:17:33 +00:00
dd32 a3df4e07a5 Do not use deprecated argument in wp-links-opml.php. See #15195
git-svn-id: http://svn.automattic.com/wordpress/trunk@15926 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-23 12:03:54 +00:00
dd32 973c124105 Clean up OPML link export script.
git-svn-id: http://svn.automattic.com/wordpress/trunk@13747 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-18 08:39:01 +00:00
westi d8490aeea2 Add the generator element in feeds through the {rss2|atom|rdf|rss|opml}_head hooks. Fixes #6947 props sivel.
git-svn-id: http://svn.automattic.com/wordpress/trunk@13113 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-13 16:45:16 +00:00
ryan cedfa0181b Use array calling style. Props Denis-de-Bernardy. see #6647
git-svn-id: http://svn.automattic.com/wordpress/trunk@12515 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-12-23 15:31:02 +00:00
markjaquith 6c2ffddf31 _a(), _ea(), _xa(), attr() are now esc_attr__(), esc_attr_e(), esc_attr_x(), esc_attr() -- still short, but less cryptic. see #9650
git-svn-id: http://svn.automattic.com/wordpress/trunk@11204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-05-05 19:43:53 +00:00
ryan 2d489767bb s/attribute_escape/attr/. see #9650
git-svn-id: http://svn.automattic.com/wordpress/trunk@11109 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-04-28 05:58:45 +00:00
ryan a6a1522a8d File file level phpdoc from jacobsantos. see #7037
git-svn-id: http://svn.automattic.com/wordpress/trunk@7991 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-05-25 15:50:15 +00:00
ryan 5b8113578d Allow wp-config.php to exist one level up from WordPress root directory. Props sambauers. fixes #6933
git-svn-id: http://svn.automattic.com/wordpress/trunk@7971 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-05-21 05:59:27 +00:00
westi cc83c30953 Allow wp-links-opml.php to return the links for just one category. Fixes #5295 props vrypan.
git-svn-id: http://svn.automattic.com/wordpress/trunk@6308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-11-03 16:09:30 +00:00
westi e9cfb43133 Centralise generator generation, move theme generator generation to wp-head hook. Fixes #5085, #4803. props docwhat, Viper007Bond.
git-svn-id: http://svn.automattic.com/wordpress/trunk@6195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-10-06 06:55:24 +00:00
ryan 8d349aa85c Add some filtering. Props jhodgdon. fixes #3595
git-svn-id: http://svn.automattic.com/wordpress/trunk@6160 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-09-23 19:25:15 +00:00
ryan 3dc720588b Change cat_name, cat_ID to name, term_id.
git-svn-id: http://svn.automattic.com/wordpress/trunk@5759 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-06-25 21:37:47 +00:00
rob1n 9ce729e656 Content-Type, not Content-type, as headers are case sensitive. Props foolswisdom and Nazgul. fixes #3545
git-svn-id: http://svn.automattic.com/wordpress/trunk@5640 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-06-02 05:21:18 +00:00
rob1n 83be93d229 attribute_escape() the OPML feed's title. fixes #4061
git-svn-id: http://svn.automattic.com/wordpress/trunk@5155 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-03-31 20:15:10 +00:00
ryan 328afedc07 Link filters from jhodgdon. fixes #3595
git-svn-id: http://svn.automattic.com/wordpress/trunk@5011 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-03-10 01:13:49 +00:00
markjaquith 5a76c03203 new function for escaping within attributes: attribute_escape()
git-svn-id: http://svn.automattic.com/wordpress/trunk@4656 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-12-21 10:10:04 +00:00
ryan 9f534ebae6 Remove trailing spaces and convert spaces to tabs. Props Nazgul. fixes #986
git-svn-id: http://svn.automattic.com/wordpress/trunk@4495 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-11-19 07:56:05 +00:00
ryan 849a0d29d7 Use get_option instead of get_settings. Just 'cause.
git-svn-id: http://svn.automattic.com/wordpress/trunk@4144 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-08-30 21:46:31 +00:00
ryan 1cdc6a5cd3 Update opml.
git-svn-id: http://svn.automattic.com/wordpress/trunk@3875 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-06-15 08:18:04 +00:00
matt 51944d9f2c Link OPML changes, fixes #2325
git-svn-id: http://svn.automattic.com/wordpress/trunk@3470 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-01-23 23:10:08 +00:00
matt 79f393ea94 Making our OPML compliant
git-svn-id: http://svn.automattic.com/wordpress/trunk@2962 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2005-10-23 17:00:13 +00:00
matt e27d276710 Left join causes weird problems. Hat tip: John Potter.
git-svn-id: http://svn.automattic.com/wordpress/trunk@2473 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2005-03-22 21:56:59 +00:00
saxmatt 9c87de2edc Updating OPML feed.
git-svn-id: http://svn.automattic.com/wordpress/trunk@2182 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2005-02-01 02:03:21 +00:00
saxmatt 46fa15f8d1 http://mosquito.wordpress.org/view.php?id=624
git-svn-id: http://svn.automattic.com/wordpress/trunk@2063 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2005-01-07 01:17:42 +00:00
saxmatt c3e1d51c20 Axing htmlspecialchars because it double-encodes-encodes. Better error handling around queries.
git-svn-id: http://svn.automattic.com/wordpress/trunk@1940 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2004-12-12 20:41:19 +00:00
saxmatt 2d78e31a7d Vanquishing the terror of iso-8859-1.
git-svn-id: http://svn.automattic.com/wordpress/trunk@1575 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2004-08-30 07:16:40 +00:00
saxmatt 25ae03ee65 Giant commit, sorry mailing list people. Move all table names to new $wpdb versions. Works but the whole app needs thorough testing now.
git-svn-id: http://svn.automattic.com/wordpress/trunk@1355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2004-05-24 08:22:18 +00:00
saxmatt 9439a575f6 Removing some old functions. Cleaning up remaining places where we exposed emails. Consolidated ampersand fixing. Fixed pasting from Word.
git-svn-id: http://svn.automattic.com/wordpress/trunk@1121 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2004-04-22 07:41:57 +00:00
saxmatt 10c6b7ea9c Changed to superglobals, and eliminated $use_cache (since we always do).
git-svn-id: http://svn.automattic.com/wordpress/trunk@1108 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2004-04-20 22:56:47 +00:00
saxmatt 15311feec8 Changed to more closely emulate Bloglines OPML, which seems to be the best guide I can find to how people are actually using OPML.
git-svn-id: http://svn.automattic.com/wordpress/trunk@953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2004-02-29 02:12:55 +00:00
saxmatt db9aece49a Show RSS URIs in OPML file.
git-svn-id: http://svn.automattic.com/wordpress/trunk@871 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2004-02-13 13:30:31 +00:00
mikelittle d0c32fcced Task ID 73
Added htmlspecialchars and stripslashes where appropriate


git-svn-id: http://svn.automattic.com/wordpress/trunk@817 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2004-02-01 02:30:37 +00:00
mikelittle 5ad9e0c4e6 First pass at OPML export of links.
Task ID 73


git-svn-id: http://svn.automattic.com/wordpress/trunk@816 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2004-02-01 02:13:11 +00:00