WordPress-C
/
WordPress
mirror of https://github.com/WordPress/WordPress.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
26,453 Commits 50 Branches 749 Tags 981 MiB
Commit Graph

4720 Commits

Author SHA1 Message Date
Scott Taylor fd9abeb0f9 Eliminate use of `extract()` in `post_tags_meta_box()` and `post_categories_meta_box()`. 
Both functions only need to read `taxonomy`, yet they extract every available variable from `$box['args']`. Even if those variables were useful, there is no attempt to pass them to anything, and scope in PHP does not allow them to be scooped up by inner functions without being passed directly.
	
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28391


git-svn-id: http://core.svn.wordpress.org/trunk@28219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 05:48:17 +00:00
Scott Taylor 9476cd33a3 Eliminate use of `extract()` in `WP_Terms_List_Table::display_rows_or_placeholder()`: 
* Set variables for `$page` and `$number`
* `list(...) = $this->get_column_info()` can be removed, as none of the variables returned are used.
* `orderby` and `search` can be checked from `$args`, leaving no reason to extract		

See #22400.

Built from https://develop.svn.wordpress.org/trunk@28390


git-svn-id: http://core.svn.wordpress.org/trunk@28218 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 05:37:14 +00:00
Scott Taylor aef35fe6a2 Eliminate use of `extract()` in `WP_List_Table::pagination()`: 
* Set variables instead of extracting `$this->_pagination_args`
* Weird: `$infinite_scroll` is only presently set in subclasses of `WP_List_Table` and never initialized otherwise. 		

See #22400.

Built from https://develop.svn.wordpress.org/trunk@28389


git-svn-id: http://core.svn.wordpress.org/trunk@28217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 05:27:14 +00:00
Scott Taylor 530a107ec9 Eliminate use of `extract()` in `WP_Plugin_Install_List_Table::get_table_classes()`. It only needs to read `plural`, no need to extract. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28388


git-svn-id: http://core.svn.wordpress.org/trunk@28216 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 05:17:14 +00:00
Scott Taylor 192e235672 Eliminate use of `extract()` in `WP_List_Table::ajax_response()`: 
* Extracting `$this->_args` is unnecessary since none of the variables produced are present in the method.
* `total_items` and `total_pages` can be read directly from `$this->_pagination_args`

See #22400.

Built from https://develop.svn.wordpress.org/trunk@28387


git-svn-id: http://core.svn.wordpress.org/trunk@28215 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 05:14:14 +00:00
Scott Taylor 08d73b9e23 Eliminate use of `extract()` in `WP_List_Table::display()`. The method only needs to read `singular` from `$this->_args`. Extraction is unnecessary. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28386


git-svn-id: http://core.svn.wordpress.org/trunk@28214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 05:08:13 +00:00
Scott Taylor f617b8669a Eliminate use of `extract()` in `WP_Post_Comments_List_Table::display()`. The method only needs to read `singular` from `$this->_args`. Extraction is unnecessary. 
Eliminate use of `extract()` in `WP_Comments_List_Table::display()`. The method uses no variables. Extraction can be completely removed.

See #22400.

Built from https://develop.svn.wordpress.org/trunk@28385


git-svn-id: http://core.svn.wordpress.org/trunk@28213 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 05:04:14 +00:00
Scott Taylor 6bbc5b570c Eliminate use of `extract()` in `wp_insert_category()`. Adds unit tests. All unit tests pass. 
Props MikeHansenMe.
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28374


git-svn-id: http://core.svn.wordpress.org/trunk@28202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 03:27:13 +00:00
Scott Taylor 2bea9fcc0b In `media_upload_gallery_form()`'s inline JavaScript, remove unnecessary comment tags. 
Fixes #25637.


Built from https://develop.svn.wordpress.org/trunk@28368


git-svn-id: http://core.svn.wordpress.org/trunk@28196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-11 06:12:15 +00:00
Scott Taylor 88b96dc036 In `wp_read_image_metadata()`, the values from `exif_read_data()` should only override values from `iptcparse()` that are empty. 
Props SergeyBiryukov.
Fixes #23706.

Built from https://develop.svn.wordpress.org/trunk@28367


git-svn-id: http://core.svn.wordpress.org/trunk@28195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-11 05:54:15 +00:00
Scott Taylor e9f87b2688 Avoid a notice in `wp_save_image()` by checking `$meta['sizes']['thumbnail']` for `! empty()` before setting a variable to it. 
Props MikeHansenMe.
Fixes #17736.


Built from https://develop.svn.wordpress.org/trunk@28366


git-svn-id: http://core.svn.wordpress.org/trunk@28194 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-11 03:42:14 +00:00
Scott Taylor 0b6729c3f9 In `WP_Terms_List_Table::single_row()`, call `sanitize_term()` on the passed term (`$tag`). 
Props oso96_2000, c3mdigital, scribu. 
It takes a village.
Fixes #16864.

Built from https://develop.svn.wordpress.org/trunk@28360


git-svn-id: http://core.svn.wordpress.org/trunk@28188 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-11 00:05:15 +00:00
Scott Taylor f22beb987c First pass at `wpview` logic for the `[embed]` shortcode. URLs on a their own line are parsed as well. The toolbar will appear with the "remove" button when the view is clicked. Edit has not been implemented yet. 
Props avryl, wonderboymusic.
See #28195.


Built from https://develop.svn.wordpress.org/trunk@28358


git-svn-id: http://core.svn.wordpress.org/trunk@28186 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-10 23:36:18 +00:00
Drew Jaynes 81cfb9427a Fix mid-file section header style in wp-admin/includes/ajax-actions.php. 
See #28200.

Built from https://develop.svn.wordpress.org/trunk@28356


git-svn-id: http://core.svn.wordpress.org/trunk@28184 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-10 05:02:13 +00:00
Drew Jaynes 0ef7244ce7 Add baseline doc blocks for all ajax handlers in ajax-actions.php. 
Fixes #28200.

Built from https://develop.svn.wordpress.org/trunk@28355


git-svn-id: http://core.svn.wordpress.org/trunk@28183 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-10 05:00:19 +00:00
Drew Jaynes f609524261 Minor phpDoc fixes for the `got_rewrite`, `got_url_rewrite`, and `documentation_ignore_functions` hooks. 
Props GaryJ.
See #26869.

Built from https://develop.svn.wordpress.org/trunk@28352


git-svn-id: http://core.svn.wordpress.org/trunk@28180 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-08 11:13:14 +00:00
Drew Jaynes 32e674f44e Use interpolation instead of concatenation for the `manage_{$screen->id}_columns` hook name. 
Props Otto42.
See #26869.

Built from https://develop.svn.wordpress.org/trunk@28348


git-svn-id: http://core.svn.wordpress.org/trunk@28176 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-08 09:58:14 +00:00
Drew Jaynes 8906f83802 Use an interpolated hook name for `edit_{$post_type}_per_page` instead of `$per_page` and adjust docs accordingly. 
Also references the correct variable for the `$posts_per_page` parameter in the `edit_posts_per_page` hook doc.

Props Otto42 for the initial patch.
See #26869.

Built from https://develop.svn.wordpress.org/trunk@28347


git-svn-id: http://core.svn.wordpress.org/trunk@28175 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-08 08:16:15 +00:00
Scott Taylor 1daa7d6723 Leverage `size_format()` when displaying `max_upload_size`: 
* In `media_upload_form()` 
* The `uploader-inline` Underscore template in the media modal. 

Replaces 2 buggy inline implementations that could display size units off by one, or size values off by one.

Fixes #25643.


Built from https://develop.svn.wordpress.org/trunk@28343


git-svn-id: http://core.svn.wordpress.org/trunk@28171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-07 18:25:14 +00:00
Scott Taylor c2d44c5736 In `wp-admin/includes/upgrade.php`, remove dead code: 
* In `maybe_create_table()` and `maybe_add_column()`, the response of `$wpdb->query()` is set to a variable that is never used.
* In `make_db_current_silent()`, which is a wrapper for `dbDelta`, a variable is set that is not used. This function appears to be a copy-paste of `make_db_current()`'s `dbDelta()` call but is meant to return nothing, and still does not.  

See #27882.

Built from https://develop.svn.wordpress.org/trunk@28305


git-svn-id: http://core.svn.wordpress.org/trunk@28133 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 17:27:15 +00:00
Scott Taylor aaa3eb07ad In `wp-admin/includes/update.php`, remove dead code: 
* In `get_core_checksums()`, `$return` is set and never used.
* In `core_update_footer()`, `break` is unnecessary and unreachable after `return`.
* In `get_theme_updates()`, `$themes` is set and never used.
* In `wp_theme_update_row()`, `$theme_name` is the only user of `$themes_allowedtags`... neither are used. 	

See #27882.

Built from https://develop.svn.wordpress.org/trunk@28304


git-svn-id: http://core.svn.wordpress.org/trunk@28132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 17:21:14 +00:00
Scott Taylor b80cda5d17 In `WP_Screen::render_screen_options()`, remove dead code: 
* `$wp_list_table` does not need to be imported.
* `$post` is set and never used.

See #27882.

Built from https://develop.svn.wordpress.org/trunk@28303


git-svn-id: http://core.svn.wordpress.org/trunk@28131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 17:14:15 +00:00
Scott Taylor 2e417f0ca4 In `get_sample_permalink_html()`, `$view_link` is set and never used. 
See #27882.


Built from https://develop.svn.wordpress.org/trunk@28302


git-svn-id: http://core.svn.wordpress.org/trunk@28130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 17:11:14 +00:00
Scott Taylor 44e2d48a3c In `install_plugin_information()`, `$title` is set in a `foreach` loop and never used. This appears to be due to copy-pasting a previous `foreach` loop and not discarding these bits. 
See #27882.


Built from https://develop.svn.wordpress.org/trunk@28301


git-svn-id: http://core.svn.wordpress.org/trunk@28129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 17:00:18 +00:00
Scott Taylor e57fa7300d In `wp-admin/includes/nav-menu.php`, remove dead code: 
* In `_wp_ajax_menu_quick_search()`, in an `else` block, `$post_obj` was set and not used. Another block sets it again and does use it. 
* In `wp_nav_menu_item_post_type_meta_box()`, `$post_type_object` was set and, sadly, never used. `$error` was set and not used. 

See #27882.


Built from https://develop.svn.wordpress.org/trunk@28300


git-svn-id: http://core.svn.wordpress.org/trunk@28128 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 16:55:14 +00:00
Scott Taylor 85bdc64173 In `update_option_new_admin_email()`, `$email` is set and never used. 
See #27882.


Built from https://develop.svn.wordpress.org/trunk@28299


git-svn-id: http://core.svn.wordpress.org/trunk@28127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 16:48:14 +00:00
Scott Taylor 6066f85853 In `attachment_submit_meta_box()`, remove dead code: 
* `$action` doesn't need to be imported.
* `$can_publish` is set and never used, which means it doesn't need...
* `$post_type_object` or `$post_type`, which only served `$can_publish`.

See #27882.

Built from https://develop.svn.wordpress.org/trunk@28298


git-svn-id: http://core.svn.wordpress.org/trunk@28126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 16:45:14 +00:00
Scott Taylor 71ac0f21c2 In `get_media_item()`, `$tags` and `$_tags` are set and never used. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28297


git-svn-id: http://core.svn.wordpress.org/trunk@28125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 16:41:17 +00:00
Scott Taylor 3054b924a3 In `WP_Users_List_Table::get_views()`, `$current_role` is set and never used. 
See #27882.


Built from https://develop.svn.wordpress.org/trunk@28296


git-svn-id: http://core.svn.wordpress.org/trunk@28124 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 15:33:15 +00:00
Scott Taylor 209f008d77 In `WP_MS_Users_List_Table::get_views()`, remove dead code: 
* `$wp_roles` doesn't need to be imported.
* `$current_role` is set and never used.

See #27882.


Built from https://develop.svn.wordpress.org/trunk@28295


git-svn-id: http://core.svn.wordpress.org/trunk@28123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 15:30:14 +00:00
Scott Taylor 970477d25e In `WP_Media_List_Table`, remove dead code: 
* In `->prepare_items()`, importing `$wpdb` is unnecessary.
* In `->get_columns()`, `$taxonomies` is set twice before it is used.
* In `->display_rows()`, `$taxonomy_object` is set and never used.

See #27882.


Built from https://develop.svn.wordpress.org/trunk@28293


git-svn-id: http://core.svn.wordpress.org/trunk@28121 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 15:27:33 +00:00
Scott Taylor 28d98a89f3 In `ajax-actions.php`, remove dead code: 
* In `wp_ajax_add_tag()`, `$post_type` is set and never used.
* In `wp_ajax_hidden_columns()`, `$hidden` is set twice, but only checks for the existence of `$_POST['hidden']` the first time. The two lines can be combined and work together.
* In `wp_ajax_inline_save()`, `$mode` is set and never used.
* In `wp_ajax_find_posts()`, `$searchand = $search = '';` is leftover cruft, neither variable is used. `$wpdb` does not need to be imported, it is never used.
* In `wp_ajax_wp_fullscreen_save_post()`, `$post_type` is set and never used.
* In `wp_ajax_save_attachment_order()`, `$post` is set and never used.
* In `wp_ajax_send_attachment_to_editor()`, `$title` is set and never used. 

See #27882.

Built from https://develop.svn.wordpress.org/trunk@28292


git-svn-id: http://core.svn.wordpress.org/trunk@28120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 15:19:14 +00:00
Sergey Biryukov 527a1ea6e3 Use a consistent context to remove duplicate strings. 
props pavelevap.
fixes #28123.
Built from https://develop.svn.wordpress.org/trunk@28287


git-svn-id: http://core.svn.wordpress.org/trunk@28115 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 12:34:14 +00:00
Scott Taylor ded4871368 In `WP_List_Table::display_rows_or_placeholder()`, the call to `get_column_info()` in unnecessary and unused. The call to `get_column_count()` immediately after makes the same call internally. 
See #27882.


Built from https://develop.svn.wordpress.org/trunk@28279


git-svn-id: http://core.svn.wordpress.org/trunk@28107 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 05:32:15 +00:00
Scott Taylor dd73ad4299 In `edit_form_image_editor()`, `$filename` and `$title` are set and then unused. They shall be removed. 
See #27882.


Built from https://develop.svn.wordpress.org/trunk@28271


git-svn-id: http://core.svn.wordpress.org/trunk@28099 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 04:45:16 +00:00
Scott Taylor 644024dfc4 Dead code in `wp-admin/includes/file.php`: 
* In `wp_handle_upload()` and `wp_handle_sideload()`, `$ext` gets conditionally reset... and then is never used.
* In `request_filesystem_credentials()`, `$password` is initialized as an empty string. The variable is never used.

See #27882.


Built from https://develop.svn.wordpress.org/trunk@28268


git-svn-id: http://core.svn.wordpress.org/trunk@28096 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 04:22:14 +00:00
Scott Taylor 3d7a4e6798 Remove unused variable setting for `$revisions` in `wp_prepare_revisions_for_js()`. 
See #27882.


Built from https://develop.svn.wordpress.org/trunk@28264


git-svn-id: http://core.svn.wordpress.org/trunk@28092 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 03:45:14 +00:00
Scott Taylor 21379dcde0 Remove a dead variable, `$start`, from `wp_dashboard_recent_comments()`. 
See #27882.


Built from https://develop.svn.wordpress.org/trunk@28263


git-svn-id: http://core.svn.wordpress.org/trunk@28091 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 03:35:14 +00:00
Andrew Nacin f44e4226fa Move 'home' option to the top of populate_options(). 
fixes #28141.

Built from https://develop.svn.wordpress.org/trunk@28260


git-svn-id: http://core.svn.wordpress.org/trunk@28088 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-05 21:57:14 +00:00
Sergey Biryukov 751e624ff7 Deprecate unused argument of delete_plugins(). Clarify @return value. 
props jdgrimes for initial patch.
fixes #28111.
Built from https://develop.svn.wordpress.org/trunk@28256


git-svn-id: http://core.svn.wordpress.org/trunk@28084 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-05 10:24:15 +00:00
Sergey Biryukov 997cbaa03c Use a time constant in get_theme_feature_list() and File_Upload_Upgrader. 
props GaVrA.
fixes #28124.
Built from https://develop.svn.wordpress.org/trunk@28253


git-svn-id: http://core.svn.wordpress.org/trunk@28081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-05 08:26:24 +00:00
Drew Jaynes d77e78d685 Clean up duplicate hook notations and adjacency for calls to the `wp_signup_location` filter. 
Also adds braces missed in [25535].

See #26869.

Built from https://develop.svn.wordpress.org/trunk@28215


git-svn-id: http://core.svn.wordpress.org/trunk@28045 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-25 07:12:14 +00:00
Drew Jaynes 029dd247be Ensure the `wp_edit_nav_menu_walker` filter is only documented once. 
See #26869.

Built from https://develop.svn.wordpress.org/trunk@28213


git-svn-id: http://core.svn.wordpress.org/trunk@28043 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-25 06:50:15 +00:00
Drew Jaynes a9b74e2088 Ensure the `nav_menu_meta_box_object` filter hook is only documented once. 
See #26869.

Built from https://develop.svn.wordpress.org/trunk@28207


git-svn-id: http://core.svn.wordpress.org/trunk@28037 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-25 06:14:15 +00:00
Andrew Nacin b89775445e Theme Installer: Proper redirection and action links post-install in multisite. 
fixes #27869.

Built from https://develop.svn.wordpress.org/trunk@28163


git-svn-id: http://core.svn.wordpress.org/trunk@27994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-19 18:18:16 +00:00
Andrew Nacin 2bc282957c Translate a string added in 3.7.1 but never translated previously. 
props SergeyBiryukov.
fixes #27819.

Built from https://develop.svn.wordpress.org/trunk@28145


git-svn-id: http://core.svn.wordpress.org/trunk@27976 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-16 00:38:14 +00:00
Dion Hulse ca0b5c9859 Background Updates: Avoid a PHP warning during theme update checks when there are multiple theme directories registered. Fixes #27815 
Built from https://develop.svn.wordpress.org/trunk@28137


git-svn-id: http://core.svn.wordpress.org/trunk@27968 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-15 10:57:14 +00:00
Andrew Nacin fa3900168e Allow the API to add text to auto update emails. 
fixes #27812.

Built from https://develop.svn.wordpress.org/trunk@28134


git-svn-id: http://core.svn.wordpress.org/trunk@27965 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-15 08:52:15 +00:00
Andrew Nacin 9f81d0526e Theme Installer: Revert to proxying through PHP for WordPress.org API requests. 
This is to ensure we have valid installation nonces, though we've run into this as a problem previously (see #27639, #27581, #27055).

A tad slower, but we gained speed in 3.9 by simplifying the request made to the API.

props ocean90.
fixes #27798.

Built from https://develop.svn.wordpress.org/trunk@28126


git-svn-id: http://core.svn.wordpress.org/trunk@27957 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-15 01:16:14 +00:00
Andrew Nacin cb4eb9c13f Avoid stomping of bulk postdata inside the bulk_edit_posts() loop. 
Reverts [27990] which did not fix it for authors and comment/ping status.

props dd32, DrewAPicture.
fixes #27792.

Built from https://develop.svn.wordpress.org/trunk@28113


git-svn-id: http://core.svn.wordpress.org/trunk@27944 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-14 07:48:14 +00:00
Andrew Ozz c9f5ed0801 Plupload: restore the settings in media_upload_form(), see #27763 
Built from https://develop.svn.wordpress.org/trunk@28110


git-svn-id: http://core.svn.wordpress.org/trunk@27941 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-14 00:41:15 +00:00
Andrew Nacin 55b0cd935e Fix feature pointer RTL placement. 
props SergeyBiryukov, ocean90.
fixes #27778.

Built from https://develop.svn.wordpress.org/trunk@28107


git-svn-id: http://core.svn.wordpress.org/trunk@27938 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-14 00:00:14 +00:00
Andrew Nacin eca26bc5ae The widgets pointer requires the edit_theme_options capability. 
(It's hypothetically possible to have only switch_themes.)

see #27777.

Built from https://develop.svn.wordpress.org/trunk@28093


git-svn-id: http://core.svn.wordpress.org/trunk@27924 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-12 20:53:15 +00:00
Andrew Nacin 497b0df4a5 Add a feature pointer for widgets in the customizer in 3.9. Remove older pointers from 3.3 and 3.4. 
see #27777.

Built from https://develop.svn.wordpress.org/trunk@28090


git-svn-id: http://core.svn.wordpress.org/trunk@27921 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-12 20:48:15 +00:00
Andrew Nacin c87ac82d7b Update $_old_files for 3.9. see #27775. 
Built from https://develop.svn.wordpress.org/trunk@28085


git-svn-id: http://core.svn.wordpress.org/trunk@27916 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-12 18:27:17 +00:00
Drew Jaynes 5e51ea9940 Priority fixes for various existing hook documentation. 
Props kpdesign.
See #26869

Built from https://develop.svn.wordpress.org/trunk@28083


git-svn-id: http://core.svn.wordpress.org/trunk@27914 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-12 00:01:15 +00:00
Andrew Nacin 51412f2e9b Account for new cropping settings in the image editor. 
props Otto42, SergeyBiryukov.
fixes #19393.

Built from https://develop.svn.wordpress.org/trunk@28072


git-svn-id: http://core.svn.wordpress.org/trunk@27903 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-11 03:10:14 +00:00
Drew Jaynes 252a5434ff Inline documentation for hooks in wp-admin/includes/class-wp-upgrader-skins.php. 
Fixes #27711.

Built from https://develop.svn.wordpress.org/trunk@28040


git-svn-id: http://core.svn.wordpress.org/trunk@27870 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-08 06:26:16 +00:00
Andrew Nacin e7fc009f7c Theme Installer: Combine 'Layout' and 'Columns' filters so 'Features' can span two columns. 
see #27055.

Built from https://develop.svn.wordpress.org/trunk@28037


git-svn-id: http://core.svn.wordpress.org/trunk@27867 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-08 04:30:15 +00:00
Drew Jaynes f6df2c6921 Use the correct parameter variables in the hook docs for `wp_upgrade`. 
See #27700.

Built from https://develop.svn.wordpress.org/trunk@27998


git-svn-id: http://core.svn.wordpress.org/trunk@27828 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-07 20:13:15 +00:00
Drew Jaynes 181fe84d47 Align parameters in the hook docs for the `attachment_thumbnail_args` filter. 
See #27700.

Built from https://develop.svn.wordpress.org/trunk@27997


git-svn-id: http://core.svn.wordpress.org/trunk@27827 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-07 20:10:16 +00:00
Drew Jaynes bf75eebfa7 Add missing parameter descriptions to the PHPDocs for `WP_Upgrader_Skin::decrement_update_count()` and `Bulk_Upgrader_Skin::decrement_update_count()`. 
See #27700.

Built from https://develop.svn.wordpress.org/trunk@27996


git-svn-id: http://core.svn.wordpress.org/trunk@27826 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-07 20:02:15 +00:00
Andrew Nacin 2d710c6fad Avoid stomping of bulk postdata inside the bulk_edit_posts() loop. 
props kovshenin.
see [27964], see #27452.

Built from https://develop.svn.wordpress.org/trunk@27990


git-svn-id: http://core.svn.wordpress.org/trunk@27820 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-07 17:59:14 +00:00
Andrew Nacin 2f80a1c72f Apply checks in [27964] to wp_write_post(), which is unused and due for dismantling and deprecation. 
see #27452.

Built from https://develop.svn.wordpress.org/trunk@27975


git-svn-id: http://core.svn.wordpress.org/trunk@27805 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-06 22:08:15 +00:00
Drew Jaynes a11553eafe Inline documentation for remaining hooks in wp-admin/includes/upgrade.php. 
Props jackreichert, vancoder.
Fixes #27646.

Built from https://develop.svn.wordpress.org/trunk@27965


git-svn-id: http://core.svn.wordpress.org/trunk@27795 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-05 22:30:14 +00:00
Andrew Nacin 1ec9b44673 Better checks for contributors when saving posts. 
props dd32, kovshenin, plocha.
see #27452.

Built from https://develop.svn.wordpress.org/trunk@27964


git-svn-id: http://core.svn.wordpress.org/trunk@27794 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-05 21:19:14 +00:00
Sergey Biryukov b48021f65f Clarify tooltips on Edit Image screen. 
props siobhan.
fixes #27651.
Built from https://develop.svn.wordpress.org/trunk@27939


git-svn-id: http://core.svn.wordpress.org/trunk@27769 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-04 00:03:28 +00:00
Sergey Biryukov 2cb849fc52 Fix typo in verify_file_md5() description. see [25541]. 
props siobhan.
see #27651.
Built from https://develop.svn.wordpress.org/trunk@27938


git-svn-id: http://core.svn.wordpress.org/trunk@27768 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-04 00:03:14 +00:00
Sergey Biryukov f8c39d6186 Use multiplication sign instead of a colon for selection size when editing an image. 
props siobhan.
fixes #27652.
Built from https://develop.svn.wordpress.org/trunk@27931


git-svn-id: http://core.svn.wordpress.org/trunk@27761 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-03 09:46:17 +00:00
Andrew Nacin 803d4ff54d Remove old links_recently_updated_* DB options that never had a UI. 
fixes #27649.

Built from https://develop.svn.wordpress.org/trunk@27916


git-svn-id: http://core.svn.wordpress.org/trunk@27746 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-03 03:10:15 +00:00
Dion Hulse 50a7503c2e Background Updates: Record Plugin & Theme update statistics like we for for Core updates, Pass Plugin/Theme update objects into the Background updater for consistency with Core & Translations. See #27633 
Built from https://develop.svn.wordpress.org/trunk@27905


git-svn-id: http://core.svn.wordpress.org/trunk@27736 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-02 13:05:15 +00:00
Drew Jaynes 4af2840a47 Clarify PHPDoc return description for `media_handle_upload()`. 
Props jdgrimes.
Fixes #27519.

Built from https://develop.svn.wordpress.org/trunk@27880


git-svn-id: http://core.svn.wordpress.org/trunk@27711 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-31 22:33:15 +00:00
Scott Taylor 01d2062af3 Cleanup up the display, escaping, and handling of ID3 data for media. Rename `wp_get_relevant_id3_keys()` to `wp_get_attachment_id3_keys()`. 
Props nacin.
See #27574.


Built from https://develop.svn.wordpress.org/trunk@27869


git-svn-id: http://core.svn.wordpress.org/trunk@27700 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-31 05:16:16 +00:00
Andrew Nacin 8acf74fe7b Use correct formatting function. see [27864], see #27574. 
Built from https://develop.svn.wordpress.org/trunk@27866


git-svn-id: http://core.svn.wordpress.org/trunk@27697 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-30 22:12:29 +00:00
Andrew Nacin c95f232727 Cleanups for audio/video metadata, see [27862]. 
see #27574.

Built from https://develop.svn.wordpress.org/trunk@27864


git-svn-id: http://core.svn.wordpress.org/trunk@27695 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-30 21:08:14 +00:00
Scott Taylor 7eb24edf4e In `wp_generate_attachment_metadata()`, when an audio or video files contains upload-able image bits in its ID3 tags, only upload it if the image has not already been uploaded. Determine this by checking for a `_cover_hash` value in post meta that matches the `md5` representation of the bits. 
This prevents uploading an album of 10 songs and subsequently uploading 10 copies of the same album cover.

Props GregLone for the new filter/filter docs: `'attachment_thumbnail_args'`.
Fixes #27573.
 

Built from https://develop.svn.wordpress.org/trunk@27863


git-svn-id: http://core.svn.wordpress.org/trunk@27694 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-30 20:54:15 +00:00
Scott Taylor d947a55495 Metadata for audio and video files: 
* Make attachment metadata for audio files editable by providing a metabox on the Edit Media page
* Standardize on using the attachment title everywhere
* Label the Caption and Description fields for audio and video appropriately
* Make the playlist Underscore templates more straightforward

See #27574.


Built from https://develop.svn.wordpress.org/trunk@27862


git-svn-id: http://core.svn.wordpress.org/trunk@27693 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-30 19:28:16 +00:00
Andrew Nacin 3c1cdaa362 Restyle the image editor so it looks way less hideous. 
props avryl.
see #27544.

Built from https://develop.svn.wordpress.org/trunk@27842


git-svn-id: http://core.svn.wordpress.org/trunk@27676 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-29 08:51:14 +00:00
Drew Jaynes 5613b40981 The `sidebar_admin_setup` hook should only be documented once in wp-admin/widgets.php. All others are duplicates. 
See #25374, #25501, #27531.

Built from https://develop.svn.wordpress.org/trunk@27823


git-svn-id: http://core.svn.wordpress.org/trunk@27657 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-28 19:47:15 +00:00
Dominik Schilling c707faa639 Widget Customizer: Convert static WP_Customize_Widgets class into instantiated class and merge Options_Transaction into WP_Customize_Widgets. 
see #27504.
props westonruter.

Built from https://develop.svn.wordpress.org/trunk@27816


git-svn-id: http://core.svn.wordpress.org/trunk@27650 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-28 14:07:14 +00:00
Andrew Nacin c3ca81ba94 Always decode special characters for email subjects. 
props tlovett1, jeremyfelt.
fixes #25346.

Built from https://develop.svn.wordpress.org/trunk@27801


git-svn-id: http://core.svn.wordpress.org/trunk@27636 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-28 02:44:15 +00:00
Andrew Nacin bec78b5e11 Proper IDs for the custom fields box. 
props SergeyBiryukov.
fixes #14376.

Built from https://develop.svn.wordpress.org/trunk@27776


git-svn-id: http://core.svn.wordpress.org/trunk@27613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-27 06:56:14 +00:00
Andrew Nacin f9964e361c Fix docs for hooks in deactivate_plugins() and activate_plugin(). see #27189, #27188. 
Built from https://develop.svn.wordpress.org/trunk@27769


git-svn-id: http://core.svn.wordpress.org/trunk@27606 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-27 02:02:14 +00:00
Scott Taylor fd0e34ec9f The bulk editor and post format meta box should use the same checks for available post formats. 
Props eightface.
Fixes #27187.


Built from https://develop.svn.wordpress.org/trunk@27762


git-svn-id: http://core.svn.wordpress.org/trunk@27599 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-27 00:06:15 +00:00
Andrew Nacin b5d0471fef Merge some theme update strings. 
props pavelevap, yoavf.
fixes #25083.

Built from https://develop.svn.wordpress.org/trunk@27748


git-svn-id: http://core.svn.wordpress.org/trunk@27585 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-26 20:08:15 +00:00
Andrew Nacin 2fd8b60c22 Avoid JS errors before the commentReply script loads. Let's make this unobtrusive soon. 
props aubreypwd.
fixes #24741.

Built from https://develop.svn.wordpress.org/trunk@27747


git-svn-id: http://core.svn.wordpress.org/trunk@27584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-26 18:53:15 +00:00
Andrew Nacin 8c3925760f Upgrader skins: Strip tags before displaying error data. 
fixes #25394.

Built from https://develop.svn.wordpress.org/trunk@27737


git-svn-id: http://core.svn.wordpress.org/trunk@27574 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-26 14:39:16 +00:00
Andrew Nacin dd70d0e30b Don't allow the image editor thumbnail to be dragged. see #21811. 
Built from https://develop.svn.wordpress.org/trunk@27712


git-svn-id: http://core.svn.wordpress.org/trunk@27551 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-25 16:21:16 +00:00
Andrew Nacin fbd1443a0b Restore the update message in the dashboard, removed in 3.8. 
props obenland.
fixes #26664.

Built from https://develop.svn.wordpress.org/trunk@27711


git-svn-id: http://core.svn.wordpress.org/trunk@27550 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-25 14:36:15 +00:00
Andrew Nacin 156a5a234f Multisite: Don't set the $super_admins global in grant_super_admin(), revoke_super_admin(). 
Adds tests and docs.

props jdgrimes.
see #27205.

Built from https://develop.svn.wordpress.org/trunk@27706


git-svn-id: http://core.svn.wordpress.org/trunk@27545 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-25 12:14:14 +00:00
Drew Jaynes 7dc9b02577 Correct misleading verbiage in 'print' hook docs. 
Standardizes 'print' hook docs on the concept that hooks are fired when scripts and styles are printed.

Props ericlewis for the initial patch.
Fixes #26924.

Built from https://develop.svn.wordpress.org/trunk@27695


git-svn-id: http://core.svn.wordpress.org/trunk@27534 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-25 08:05:15 +00:00
Scott Taylor 4eadc109f8 In `wp_create_post_autosave()`, intersect the `$new_autosave`'s keys with the keys from `_wp_post_revision_fields()` to ensure that all expected fields are present. 
Props kovshenin.
Fixes #25416.


Built from https://develop.svn.wordpress.org/trunk@27690


git-svn-id: http://core.svn.wordpress.org/trunk@27529 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-24 20:32:14 +00:00
Andrew Nacin c08ff58b13 Plugin Installer: Disable 'Latest Version Installed' buttons. 
props paulwilde.
see #26952.

Built from https://develop.svn.wordpress.org/trunk@27677


git-svn-id: http://core.svn.wordpress.org/trunk@27520 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-24 03:41:15 +00:00
Andrew Nacin 9babc32900 Use correct variable. see [27373]. 
props TobiasBg.
fixes #14424.

Built from https://develop.svn.wordpress.org/trunk@27675


git-svn-id: http://core.svn.wordpress.org/trunk@27518 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-24 03:25:16 +00:00
Drew Jaynes cb58f19135 Inline documentation for hooks in wp-admin/includes/taxonomy.php. 
Props kpdesign for the initial patch.
Fixes #27433.

Built from https://develop.svn.wordpress.org/trunk@27674


git-svn-id: http://core.svn.wordpress.org/trunk@27517 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-24 03:14:15 +00:00
Drew Jaynes 0cee31065e Inline documentation for wp-admin/includes/class-wp-upgrader.php. 
Props kpdesign for some minor cleanup.
Fixes #27436.

Built from https://develop.svn.wordpress.org/trunk@27673


git-svn-id: http://core.svn.wordpress.org/trunk@27516 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-24 03:00:15 +00:00
Drew Jaynes 8efd225e4d Inline documentation for hooks in wp-admin/includes/file.php. 
Fixes #27429.

Built from https://develop.svn.wordpress.org/trunk@27672


git-svn-id: http://core.svn.wordpress.org/trunk@27515 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-24 02:45:15 +00:00
Drew Jaynes b4903834cf Remove some debug cruft accidentally committed in [27670]. 
See #27430.

Built from https://develop.svn.wordpress.org/trunk@27671


git-svn-id: http://core.svn.wordpress.org/trunk@27514 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-24 02:38:17 +00:00
Drew Jaynes 1a0881f341 Inline documentation for hooks in wp-admin/includes/menu.php. 
Also fixes syntax for a few unrelated multi-line comments in the file.

Props kpdesign for some minor cleanup.
Fixes #27430.

Built from https://develop.svn.wordpress.org/trunk@27670


git-svn-id: http://core.svn.wordpress.org/trunk@27513 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-24 02:35:14 +00:00
Drew Jaynes 0b8798684b Inline documentation for hooks in wp-admin/includes/dashboard.php. 
Props mauryaratan. Props kpdesign for some minor cleanup.
Fixes #25752.

Built from https://develop.svn.wordpress.org/trunk@27669


git-svn-id: http://core.svn.wordpress.org/trunk@27512 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-24 02:21:15 +00:00
Drew Jaynes 155746131f Inline documentation for hooks in wp-admin/includes/post.php. 
Also moves the primary PHPDoc for the `edit_posts_per_page` hook to wp-admin/includes/post.php.

Props kpdesign for some cleanup.
Fixes #27431.

Built from https://develop.svn.wordpress.org/trunk@27667


git-svn-id: http://core.svn.wordpress.org/trunk@27510 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-24 01:49:14 +00:00
Andrew Ozz 69b74a75cd Plupload: switch to urlstream upload method when the 'flash' runtime is used in non IE browsers. This ensures cookies are sent but limits the maximum file size that flash can handle. 
By default only IE9 and older use flash so this change is mostly for completeness. It would affect only the (extremely rare) cases where a plugin disables the html5 runtime.
Built from https://develop.svn.wordpress.org/trunk@27662


git-svn-id: http://core.svn.wordpress.org/trunk@27505 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-23 23:45:19 +00:00
Scott Taylor 38d1fb971f Turn on thumbnail support for `attachment:audio` and `attachment:video`. Change conditionals to check for theme OR post type support when determining whether to turn on the Featured Image UI pieces in the admin. 
Fixes #27460.


Built from https://develop.svn.wordpress.org/trunk@27657


git-svn-id: http://core.svn.wordpress.org/trunk@27500 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-23 02:35:14 +00:00
Dominik Schilling d1f3abe55c Remove "Show" prefix from filter dropdowns, see #26743. 
Built from https://develop.svn.wordpress.org/trunk@27626


git-svn-id: http://core.svn.wordpress.org/trunk@27469 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-19 22:13:14 +00:00
Andrew Nacin 111e6a73be Skipping placeholders in a string will only catch translators off guard. 
see #27453, #27132.

Built from https://develop.svn.wordpress.org/trunk@27613


git-svn-id: http://core.svn.wordpress.org/trunk@27456 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-19 05:53:14 +00:00
Andrew Nacin ecab3c3535 Remove two new strings from post_preview(). 
see #25272, #27453.

Built from https://develop.svn.wordpress.org/trunk@27612


git-svn-id: http://core.svn.wordpress.org/trunk@27455 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-19 05:49:14 +00:00
Andrew Nacin 064f3d7191 Improve the autosave error message on nonce failure. 
see #27453, #25272.

Built from https://develop.svn.wordpress.org/trunk@27611


git-svn-id: http://core.svn.wordpress.org/trunk@27454 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-19 05:47:22 +00:00
John Blackbourn 80fe1b0e79 Introduce permission checks for post queries and edit links in the At a Glance dashboard widget. Fixes #27132. Props mattheu. 
Built from https://develop.svn.wordpress.org/trunk@27596


git-svn-id: http://core.svn.wordpress.org/trunk@27439 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-18 22:44:27 +00:00
John Blackbourn 181c2d091e Remove the "See more" toggle from the At a Glance dashboard widget. Fixes #26614. 
Built from https://develop.svn.wordpress.org/trunk@27583


git-svn-id: http://core.svn.wordpress.org/trunk@27426 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-18 12:56:14 +00:00
Andrew Nacin b0188044a2 Heartbeat: Hooks should always receive unslashed data. 
This affects the privileged hooks; the unprivileged hooks already received unslashed data.

props johnbillion, TobiasBg.
fixes #27260.

Built from https://develop.svn.wordpress.org/trunk@27576


git-svn-id: http://core.svn.wordpress.org/trunk@27419 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-18 00:15:15 +00:00
Andrew Nacin 3c3e9a530b Filesystem: Fix getchmod() for direct and ssh2 transports, for directories. 
props DavidAnderson.
fixes #26598.

Built from https://develop.svn.wordpress.org/trunk@27566


git-svn-id: http://core.svn.wordpress.org/trunk@27409 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-17 20:17:15 +00:00
Andrew Nacin 6c03a28512 Cap and theme support checks for the welcome panel. 
props MikeHansenMe.
fixes #26276.

Built from https://develop.svn.wordpress.org/trunk@27563


git-svn-id: http://core.svn.wordpress.org/trunk@27406 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-17 19:47:15 +00:00
Sergey Biryukov bfef727df3 Avoid PHP notices in Media Library if an attachment parent post type no longer exists. 
props wpsmith.
fixes #27439.
Built from https://develop.svn.wordpress.org/trunk@27560


git-svn-id: http://core.svn.wordpress.org/trunk@27403 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-17 15:33:15 +00:00
Andrew Ozz 513b6992e5 Restyle the plugin install details modal to match the rest of the admin. Props avryl and paulwilde for initial mockup, see #26952 
Built from https://develop.svn.wordpress.org/trunk@27559


git-svn-id: http://core.svn.wordpress.org/trunk@27402 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-16 18:28:17 +00:00
Sergey Biryukov ab03c0db64 Fix .comment-grey-bubble markup and remove a stray </h5> tag. 
props avryl.
fixes #27408.
Built from https://develop.svn.wordpress.org/trunk@27548


git-svn-id: http://core.svn.wordpress.org/trunk@27391 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-15 04:32:15 +00:00
Dion Hulse 87c6791a41 WP_Filesystem: Update request_filesystem_credentials() to handle the correct ssh value of FS_METHOD. Props jnielsendotnet. Fixes #27265 
Built from https://develop.svn.wordpress.org/trunk@27546


git-svn-id: http://core.svn.wordpress.org/trunk@27389 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-15 03:09:16 +00:00
Dominik Schilling f46a085f7c Widget Customizer: Use ?wp_customize=on. 
Let _wp_customize_include() handle customizer initialisation.
Sets also the priority for the Add Widget and Reorder buttons and removes debug cruft.

props westonruter.
fixes #27291.
Built from https://develop.svn.wordpress.org/trunk@27524


git-svn-id: http://core.svn.wordpress.org/trunk@27367 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-13 18:38:14 +00:00
Scott Taylor 00e63d2d2c The Image Editor should apply changes to custom image sizes by checking `$_wp_additional_image_sizes` for `$size` in `wp_save_image()` before arbitrarily going to the options table. 
Props Otto42, SergeyBiryukov.
Fixes #19889.


Built from https://develop.svn.wordpress.org/trunk@27522


git-svn-id: http://core.svn.wordpress.org/trunk@27365 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-13 04:18:14 +00:00
John Blackbourn cc7f0b61ec Correct the "View Post" button link when changing a post slug. Fixes #16477. Props aubreypwd. 
Built from https://develop.svn.wordpress.org/trunk@27508


git-svn-id: http://core.svn.wordpress.org/trunk@27351 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-11 23:00:16 +00:00
John Blackbourn 75b86ecfb0 Avoid searching HTML tags when searching plugins and themes. Fixes #27136. Props enej. 
Built from https://develop.svn.wordpress.org/trunk@27507


git-svn-id: http://core.svn.wordpress.org/trunk@27350 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-11 22:24:15 +00:00
Sergey Biryukov f29df4f74c Remove duplicate description of WP_List_Table class. 
props bravokeyl.
fixes #27346.
Built from https://develop.svn.wordpress.org/trunk@27502


git-svn-id: http://core.svn.wordpress.org/trunk@27345 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-11 16:23:15 +00:00
Andrew Nacin fe260c6a15 Assign correct variable. 
props nendeb55.
fixes #27351. see #14424, [27373].

Built from https://develop.svn.wordpress.org/trunk@27501


git-svn-id: http://core.svn.wordpress.org/trunk@27344 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-11 13:24:14 +00:00
Andrew Nacin 9aca2a65f8 Bring the theme browsing experience from 3.8 to the theme installer. First pass. 
props matveb with assists from me and gcorne.
see #27055.

Built from https://develop.svn.wordpress.org/trunk@27499


git-svn-id: http://core.svn.wordpress.org/trunk@27341 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-11 07:47:15 +00:00
Drew Jaynes a271ca696b Fix docs for the `deactivate_$plugin` and `deactivated_plugin` hooks. 
Props wpsmith for the original patch.
Fixes #27189

Built from https://develop.svn.wordpress.org/trunk@27491


git-svn-id: http://core.svn.wordpress.org/trunk@27335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-10 21:34:17 +00:00
Andrew Nacin de769c267f Editor: Show 'View Post' for any post the author can read. 
This expands it to private posts and matches the logic in the toolbar.

props mordauk, SergeyBiryukov.
fixes #27059.

Built from https://develop.svn.wordpress.org/trunk@27483


git-svn-id: http://core.svn.wordpress.org/trunk@27327 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-09 13:53:14 +00:00
Dominik Schilling 3e356d7bdf Admin Menu: Set default value of `$icon_url` in `add_menu_page()` to `dashicons-admin-generic`, fixes #26630. 
Built from https://develop.svn.wordpress.org/trunk@27482


git-svn-id: http://core.svn.wordpress.org/trunk@27326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-09 11:13:13 +00:00
Andrew Nacin fabb6d4898 Allow $crop in add_image_size() to receive crop anchors (top, left, right, bottom, center). 
This also applies to set_post_thumbnail_size() and image_resize_dimensions().

props bradt, wonderboymusic, DH-Shredder.
fixes #19393.

Built from https://develop.svn.wordpress.org/trunk@27472


git-svn-id: http://core.svn.wordpress.org/trunk@27317 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-08 06:14:15 +00:00
Andrew Nacin 17ccbc86c9 Rename the new page_templates filter to theme_page_templates, and pass it a post object for proper context. 
see #13265.

Built from https://develop.svn.wordpress.org/trunk@27470


git-svn-id: http://core.svn.wordpress.org/trunk@27315 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-08 04:19:16 +00:00
Andrew Nacin edfe443afc Remove lame debugging. see #23057. 
Built from https://develop.svn.wordpress.org/trunk@27467


git-svn-id: http://core.svn.wordpress.org/trunk@27312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-08 03:16:27 +00:00
Andrew Nacin 60953e88fd Normalize $reassign in wp_delete_user() to ensure the hooks receive consistent values. 
fixes #23057.

Built from https://develop.svn.wordpress.org/trunk@27466


git-svn-id: http://core.svn.wordpress.org/trunk@27311 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-08 03:16:14 +00:00
Sergey Biryukov 0a0589414e Fix docblock formatting in [27462]. see #23057. 
Built from https://develop.svn.wordpress.org/trunk@27463


git-svn-id: http://core.svn.wordpress.org/trunk@27308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-08 01:26:13 +00:00
Sergey Biryukov 9c6504120f Pass $reassign parameter to 'delete_user' and 'deleted_user' actions. 
props genkisan.
fixes #23057.
Built from https://develop.svn.wordpress.org/trunk@27462


git-svn-id: http://core.svn.wordpress.org/trunk@27307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-08 01:23:15 +00:00
Andrew Nacin 449ffedfb9 maybe_regenerate_attachment_metadata() is now wp_maybe_generate_attachment_metadata(). 
props kovshenin.
fixes #26825.

Built from https://develop.svn.wordpress.org/trunk@27441


git-svn-id: http://core.svn.wordpress.org/trunk@27288 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-06 19:34:14 +00:00
Drew Jaynes c64dc20146 Inline documentation for hooks in wp-admin/includes/class-wp-theme-install-list-table.php. 
Props kpdesign for the cleanup.
Fixes #27293.

Built from https://develop.svn.wordpress.org/trunk@27430


git-svn-id: http://core.svn.wordpress.org/trunk@27277 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-06 13:44:14 +00:00
Andrew Nacin e853a9cc57 Add widget management to the customizer. 
This brings in the Widget Customizer plugin: https://wordpress.org/plugins/widget-customizer/.

props westonruter, shaunandrews, michael-arestad, johnregan3, akeda, topher1kenobe, topquarky, bobbravo2, ricardocorreia. And for good measure, props westonruter.
see #27112.

Built from https://develop.svn.wordpress.org/trunk@27419


git-svn-id: http://core.svn.wordpress.org/trunk@27266 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-05 20:41:14 +00:00
Andrew Nacin 39fcb291fe Always convert auto-drafts to drafts in edit_draft() and _wp_translate_postdata(). 
This regressed due to refactoring in [26995]. This commit fixes Quick Draft.

see #25272.

Built from https://develop.svn.wordpress.org/trunk@27405


git-svn-id: http://core.svn.wordpress.org/trunk@27252 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-05 06:26:14 +00:00
Andrew Ozz 7121bb490d Restyles the modal for attaching media to posts, take II (also some autoprefixer and imagemin). Props avryl, see #26952. 
Built from https://develop.svn.wordpress.org/trunk@27403


git-svn-id: http://core.svn.wordpress.org/trunk@27250 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-05 03:54:15 +00:00
Andrew Ozz 19efb78b48 Restyles the modal for attaching media to posts, props avryl, see #26952 
Built from https://develop.svn.wordpress.org/trunk@27401


git-svn-id: http://core.svn.wordpress.org/trunk@27248 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-04 23:11:13 +00:00
Andrew Nacin 2c68373c83 Convert the post lock icon to a dashicon. 
props melchoyce, DH-Shredder.
fixes #26796.

Built from https://develop.svn.wordpress.org/trunk@27392


git-svn-id: http://core.svn.wordpress.org/trunk@27240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-04 06:53:14 +00:00
Dominik Schilling 00f224624e "At a Glance" widget: Move `get_avatar()` line out of if-block. 
This allows you to show avatars for custom comment types via the `get_avatar_comment_types` filter.

props zodiac1978.
fixes #26944.
Built from https://develop.svn.wordpress.org/trunk@27384


git-svn-id: http://core.svn.wordpress.org/trunk@27232 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-03 20:14:14 +00:00
Drew Jaynes 690481f8e8 Generalize the hook documentation for the `set-screen-option` filter. 
The filter covers more than [items]_per_page screen options.

Fixes #26186.

Built from https://develop.svn.wordpress.org/trunk@27379


git-svn-id: http://core.svn.wordpress.org/trunk@27228 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-03 17:51:14 +00:00
Drew Jaynes 849ce35cb9 Inline documentation for hooks in wp-admin/includes/misc.php. 
Props JoshuaAbenazer.
Fixes #26186

Built from https://develop.svn.wordpress.org/trunk@27375


git-svn-id: http://core.svn.wordpress.org/trunk@27224 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-03 17:20:16 +00:00
Andrew Nacin cc7a2e29f5 Slight renaming in our callback in [27373]. see #14424. 
Built from https://develop.svn.wordpress.org/trunk@27374


git-svn-id: http://core.svn.wordpress.org/trunk@27223 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-03 17:09:14 +00:00
Mark Jaquith fb56a9942b Eliminate some of our last remaining `create_function()` instances 
* Moved some into private function callbacks
* Eliminated some that weren't necessary anymore

props obenland, markjaquith, nacin. fixes #14424
Built from https://develop.svn.wordpress.org/trunk@27373


git-svn-id: http://core.svn.wordpress.org/trunk@27222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-03 16:21:16 +00:00
Andrew Nacin 0c16c0477b Reference https://wordpress.org rather than http://wordpress.org in strings, links, comments, etc. 
props Ipstenu, markjaquith.
see #27115.

Built from https://develop.svn.wordpress.org/trunk@27369


git-svn-id: http://core.svn.wordpress.org/trunk@27219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-03 02:34:27 +00:00
Andrew Nacin ffc4ca7b01 Introduce get_site_by_path() and further rewrite the site detection process for multisite. 
This is the first big step to supporting arbitrary domains and paths. In this new approach, sites are detected first where possible, then the network is inferred. Allows filtering for arbitrary path segments, smooths out some weirdness, and removes various restrictions. A sunrise plugin could do much of its work by adding filters, if those are even needed.

see #27003.

Built from https://develop.svn.wordpress.org/trunk@27359


git-svn-id: http://core.svn.wordpress.org/trunk@27209 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-02 22:25:14 +00:00
Drew Jaynes c0e436d3d3 Inline documentation for hooks in wp-admin/includes/image-edit.php. 
Props theorboman. Props kpdesign for the cleanup.
Fixes #26149.

Built from https://develop.svn.wordpress.org/trunk@27357


git-svn-id: http://core.svn.wordpress.org/trunk@27208 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-02 20:56:15 +00:00
Drew Jaynes 5da89414a8 Inline documentation for hooks in wp-admin/includes/class-wp-plugins-list-table.php. 
Props nicolealleyinteractivecom, kpdesign.
Fixes #26957.

Built from https://develop.svn.wordpress.org/trunk@27356


git-svn-id: http://core.svn.wordpress.org/trunk@27207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-02 20:48:14 +00:00
Drew Jaynes 16941beac1 Tweak inline documentation for hooks in wp-admin/includes/class-wp-users-list-table.php. 
Props kpdesign.
Fixes #26203.

Built from https://develop.svn.wordpress.org/trunk@27355


git-svn-id: http://core.svn.wordpress.org/trunk@27206 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-02 20:32:15 +00:00
Drew Jaynes 15068e1cd4 Inline documentation for hooks in wp-admin/includes/class-wp-users-list-table.php. 
Props leewillis77.
Fixes #26203.

Built from https://develop.svn.wordpress.org/trunk@27342


git-svn-id: http://core.svn.wordpress.org/trunk@27194 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-01 15:00:15 +00:00