Dominik Schilling
bcdad0aa12
Tests: Don't preserve the global state for Ajax tests when using an external object cache.
...
Most of the Ajax tests are running in a separate PHP process, and thus PHPUnit attempts to preserve the global state from the parent process by serializing all globals. But this doesn't work for external object caches so we have to disable this "feature".
See #31491 .
Built from https://develop.svn.wordpress.org/trunk@35209
git-svn-id: http://core.svn.wordpress.org/trunk@35175 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 20:35:23 +00:00
Aaron Jorbin
41b21cf23b
Add Twenty Sixteen to travis builds
...
This allows the automated tests to include Twenty Sixteen.
Fixes #34315 . See #34306 .
Built from https://develop.svn.wordpress.org/trunk@35208
git-svn-id: http://core.svn.wordpress.org/trunk@35174 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 19:06:25 +00:00
Helen Hou-Sandí
7aabfdaca4
Circular focus styling for widgets and menus in the customizer.
...
see #33808 .
Built from https://develop.svn.wordpress.org/trunk@35207
git-svn-id: http://core.svn.wordpress.org/trunk@35173 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 18:53:25 +00:00
Boone Gorges
76a89d95c3
Fix incorrect variable name introduced in [35197].
...
See #30017 , #33968 .
Built from https://develop.svn.wordpress.org/trunk@35206
git-svn-id: http://core.svn.wordpress.org/trunk@35172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 18:48:24 +00:00
Sergey Biryukov
2d540d0280
In `WP::parse_request()` and `url_to_postid()`, don't skip objects that have a post status with `'exclude_from_search' => false`, e.g. `inherit`.
...
This fixes pretty permalinks for attachments, broken in [35195].
Fixes #21970 .
Built from https://develop.svn.wordpress.org/trunk@35205
git-svn-id: http://core.svn.wordpress.org/trunk@35171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 17:53:24 +00:00
Helen Hou-Sandí
395258bcaa
Make the database update button primary.
...
see #23738 .
Built from https://develop.svn.wordpress.org/trunk@35204
git-svn-id: http://core.svn.wordpress.org/trunk@35170 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 17:35:24 +00:00
Sergey Biryukov
de730d605f
Twenty Sixteen: Update `Gruntfile.js` to ignore the html5 shiv for JSHint.
...
See #34306 , #34315 .
Built from https://develop.svn.wordpress.org/trunk@35203
git-svn-id: http://core.svn.wordpress.org/trunk@35169 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 17:27:24 +00:00
Drew Jaynes
0905e847ae
Docs: `Walker_Nav_Menu_Checklist` and `Walker_Nav_Menu_Edit` are part of the Navigation Menu API, but intended for use in the scope of administration.
...
See #33701 .
Built from https://develop.svn.wordpress.org/trunk@35202
git-svn-id: http://core.svn.wordpress.org/trunk@35168 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 17:26:24 +00:00
Helen Hou-Sandí
12290303a8
Box shadows still need `-webkit-`, turns out.
...
see #33808 , [35200].
Built from https://develop.svn.wordpress.org/trunk@35201
git-svn-id: http://core.svn.wordpress.org/trunk@35167 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 17:09:26 +00:00
Helen Hou-Sandí
50288dea5a
Circular focus styling for expand/collapse arrows.
...
Affects postboxes, widgets, and nav menus, all in the admin.
props grvrulz for the initial patch.
see #33808 .
Built from https://develop.svn.wordpress.org/trunk@35200
git-svn-id: http://core.svn.wordpress.org/trunk@35166 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 16:47:25 +00:00
Ella Iseulde Van Dorpe
3eb4a57c27
TinyMCE: make captioned images draggable
...
See #28003 .
Built from https://develop.svn.wordpress.org/trunk@35199
git-svn-id: http://core.svn.wordpress.org/trunk@35165 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 15:20:25 +00:00
Ella Iseulde Van Dorpe
3babb1682a
Fix close button plugin modal after [18590]
...
See #18590 .
Built from https://develop.svn.wordpress.org/trunk@35198
git-svn-id: http://core.svn.wordpress.org/trunk@35164 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 14:52:26 +00:00
Scott Taylor
9d4069e5d9
Unit Tests: add/upgrade the fixtures in `Tests_User_Query`.
...
See #30017 , #33968 .
Built from https://develop.svn.wordpress.org/trunk@35197
git-svn-id: http://core.svn.wordpress.org/trunk@35163 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 07:29:24 +00:00
Scott Taylor
1603ccad71
Unit Tests: create fewer terms in `Tests_Term_getTerms::test_get_terms_parent_zero()`
...
See #30017 , #33968 .
Built from https://develop.svn.wordpress.org/trunk@35196
git-svn-id: http://core.svn.wordpress.org/trunk@35162 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 06:53:24 +00:00
Sergey Biryukov
8a6d07f596
In `WP::parse_request()` and `url_to_postid()`, if a post slug clashes with a trashed page, return the post instead of the page.
...
Props kovshenin, SergeyBiryukov, igmoweb.
Fixes #21970 .
Built from https://develop.svn.wordpress.org/trunk@35195
git-svn-id: http://core.svn.wordpress.org/trunk@35161 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 06:49:25 +00:00
Scott Taylor
3bf9aa75a4
Unit Tests: upgrade the fixtures in `Tests_Post_Thumbnail_Template`.
...
See #30017 , #33968 .
Built from https://develop.svn.wordpress.org/trunk@35194
git-svn-id: http://core.svn.wordpress.org/trunk@35160 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 06:40:24 +00:00
Scott Taylor
274d7f5bb0
Unit Tests: upgrade the fixtures in `Tests_Post_Revisions`.
...
See #30017 , #33968 .
Built from https://develop.svn.wordpress.org/trunk@35193
git-svn-id: http://core.svn.wordpress.org/trunk@35159 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 06:32:25 +00:00
Scott Taylor
5b49ff3a48
Unit Tests: in `Tests_Comment_Query::test_get_comments_for_post()`, create fewer comments (5, instead of 10).
...
See #30017 , #33968 .
Built from https://develop.svn.wordpress.org/trunk@35192
git-svn-id: http://core.svn.wordpress.org/trunk@35158 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 05:57:25 +00:00
Scott Taylor
53ef754260
Unit Tests: after [35186], "upgrade" the Canonical fixtures.
...
See #30017 , #33968 .
Built from https://develop.svn.wordpress.org/trunk@35191
git-svn-id: http://core.svn.wordpress.org/trunk@35157 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 05:51:24 +00:00
Sergey Biryukov
8aa7fb88f0
Remove a one-time variable from `edit_user()` added in [35189].
...
See #27317 .
Built from https://develop.svn.wordpress.org/trunk@35190
git-svn-id: http://core.svn.wordpress.org/trunk@35156 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 05:46:24 +00:00
Sergey Biryukov
7f08716c16
Users: Add `'illegal_user_logins'` filter to allow certain usernames to be blacklisted.
...
Props danielbachhuber, chriscct7, crazycoolcam, SergeyBiryukov.
Fixes #27317 .
Built from https://develop.svn.wordpress.org/trunk@35189
git-svn-id: http://core.svn.wordpress.org/trunk@35155 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 05:43:26 +00:00
Scott Taylor
b6b2baccbd
Unit Tests: create more fixtures for `Tests_User`. When using a factory to create ad hoc users, use the inherited static prop `$static_factory` instead of the instance prop, `$factory`. If 2 factories are used out of sync, the generator sequences diverge and dupes can be created, causing an untold number of unforeseen errors. Yay.
...
See #30017 , #33968 .
Built from https://develop.svn.wordpress.org/trunk@35188
git-svn-id: http://core.svn.wordpress.org/trunk@35154 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 05:30:25 +00:00
Sergey Biryukov
09ee95ea49
Themes: Add Install Parent Theme button for child themes that are missing a parent theme.
...
Props rabmalin for initial patch.
Fixes #32668 .
Built from https://develop.svn.wordpress.org/trunk@35187
git-svn-id: http://core.svn.wordpress.org/trunk@35153 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 05:11:24 +00:00
Scott Taylor
5cebd10ced
Unit Tests: implement `setUpBeforeClass()` and `tearDownAfterClass()` on `WP_UnitTestCase`. Use late static binding (plus a gross fallback for PHP 5.2) to check if `wpSetUpBeforeClass()` or `wpTearDownAfterClass()` exist on the called class, and then call it and pass a static `WP_UnitTest_Factory` instance via Dependency Injection, if it exists.
...
This makes it way easier to add fixtures, and tear them down, without needing to instantiate `WP_UnitTest_Factory` in every class - removes the need to call `commit_transaction()` in each individual class.
See #30017 , #33968 .
Built from https://develop.svn.wordpress.org/trunk@35186
git-svn-id: http://core.svn.wordpress.org/trunk@35152 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 04:44:25 +00:00
Scott Taylor
e62864ce46
Unit Tests: in `Tests_Term`, create fixtures for posts.
...
See #30017 , #33968 .
Built from https://develop.svn.wordpress.org/trunk@35185
git-svn-id: http://core.svn.wordpress.org/trunk@35151 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 03:48:25 +00:00
Sergey Biryukov
e63ba31f93
Acessibility: Add back-compat styles for plugins that use `h3` inside the `.metabox-holder` container.
...
Props afercia.
Fixes #33557 .
Built from https://develop.svn.wordpress.org/trunk@35184
git-svn-id: http://core.svn.wordpress.org/trunk@35150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 03:38:25 +00:00
Scott Taylor
ad90d33285
Unit Tests: in `Tests_Post`, create fixtures for users.
...
See #30017 , #33968 .
Built from https://develop.svn.wordpress.org/trunk@35183
git-svn-id: http://core.svn.wordpress.org/trunk@35149 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 03:31:24 +00:00
Helen Hou-Sandí
f3107e5842
Make some primary action buttons look primary.
...
* User deletion/removal
* Site status change (multisite)
* Network upgrade
* Import file upload
* Media browser upload
props Dezzy for the initial patch.
fixes #23738 .
Built from https://develop.svn.wordpress.org/trunk@35182
git-svn-id: http://core.svn.wordpress.org/trunk@35148 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 03:08:24 +00:00
Scott Taylor
2c46a4dcba
Unit Tests: in `Tests_Media::test_wp_get_attachment_image_srcset_array_no_width()`, just toggle metadata, instead of creating a new attachment. Shaves 75ms off the test.
...
See #30017 , #33968 .
Built from https://develop.svn.wordpress.org/trunk@35181
git-svn-id: http://core.svn.wordpress.org/trunk@35147 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 02:55:24 +00:00
Sergey Biryukov
6d91caa931
Theme Editor: Repurpose the `'wp_theme_editor_filetypes'` filter added in [35134] to actually filter file types instead of files.
...
Default types include 'php' and 'css' and cannot be removed, only new types can be added.
Props DrewAPicture, SergeyBiryukov.
Fixes #22924 .
Built from https://develop.svn.wordpress.org/trunk@35180
git-svn-id: http://core.svn.wordpress.org/trunk@35146 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 02:20:24 +00:00
Scott Taylor
317d62bfad
Unit Tests: make a fixture in `Tests_Media` to represent the large image, instead of creating it 10 times.
...
See #30017 , #33968 .
Built from https://develop.svn.wordpress.org/trunk@35179
git-svn-id: http://core.svn.wordpress.org/trunk@35145 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 01:43:24 +00:00
Scott Taylor
60ad26b4fd
Unit Tests: move some oEmbed tests that can trigger HTTP calls to `Tests_External_HTTP_OEmbed`.
...
See #30017 , #33968 .
Built from https://develop.svn.wordpress.org/trunk@35178
git-svn-id: http://core.svn.wordpress.org/trunk@35144 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 01:29:24 +00:00
Scott Taylor
f19e4c9b46
Unit Tests: `Tests_Canonical` doesn't need to call `wp_set_current_user()` or implement `tearDown` because its grandparent calls `wp_set_current_user( 0 )` in `tearDown()`.
...
See #30017 , #33968 .
Built from https://develop.svn.wordpress.org/trunk@35177
git-svn-id: http://core.svn.wordpress.org/trunk@35143 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 01:18:24 +00:00
Scott Taylor
972e76991f
Unit Tests: `Tests_Comment` needs a `tearDownAfterClass` impl to avoid spillage.
...
See #30017 , #33968 .
Built from https://develop.svn.wordpress.org/trunk@35176
git-svn-id: http://core.svn.wordpress.org/trunk@35142 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 01:06:24 +00:00
Scott Taylor
083537d213
Unit Tests: `Tests_Auth` needs a `tearDownAfterClass` impl to avoid spillage.
...
See #30017 , #33968 .
Built from https://develop.svn.wordpress.org/trunk@35175
git-svn-id: http://core.svn.wordpress.org/trunk@35141 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 01:04:24 +00:00
Scott Taylor
b7e9b93be3
Unit Tests: call `commit_transaction()` in `Tests_Auth` set up.
...
See #30017 , #33968 .
Built from https://develop.svn.wordpress.org/trunk@35174
git-svn-id: http://core.svn.wordpress.org/trunk@35140 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 00:49:24 +00:00
Scott Taylor
b1a39f1a6a
Unit Tests: reuse fixtures in `Tests_Comment`.
...
See #30017 , #33968 .
Built from https://develop.svn.wordpress.org/trunk@35173
git-svn-id: http://core.svn.wordpress.org/trunk@35139 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 00:39:23 +00:00
Scott Taylor
e9db7c15fd
Unit Tests: move `->test_readme()` out of `Tests_Basic` and into `Tests_External_HTTP_Basic` in `tests/external-http/`.
...
I intend to move other `wp_remote_get()` tests into similar classes.
See #30017 , #33968 .
Built from https://develop.svn.wordpress.org/trunk@35172
git-svn-id: http://core.svn.wordpress.org/trunk@35138 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 00:23:24 +00:00
Scott Taylor
351d78fbac
Unit Tests: wrestle performance out of `Tests_Auth` by cloning the same user for a majority of the tests.
...
See #30017 , #33968 .
Built from https://develop.svn.wordpress.org/trunk@35171
git-svn-id: http://core.svn.wordpress.org/trunk@35137 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 00:11:24 +00:00
Drew Jaynes
217b661703
Docs: Add missing descriptions for the `$wpdb` global in DocBlocks all the places.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35170
git-svn-id: http://core.svn.wordpress.org/trunk@35136 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-14 23:44:25 +00:00
Drew Jaynes
43c10f7d35
Docs: Fix third-person singular verbs for summaries in wp-admin/includes/bookmarks.php.
...
Also adds some missing parameter, return, and global descriptions, and one missing summary.
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35169
git-svn-id: http://core.svn.wordpress.org/trunk@35135 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-14 23:25:25 +00:00
Drew Jaynes
c78ee60edd
Docs: Standardize file header summary for wp-admin/includes/ajax-actions.php.
...
See #33701 .
[ci skip]
Built from https://develop.svn.wordpress.org/trunk@35168
git-svn-id: http://core.svn.wordpress.org/trunk@35134 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-14 22:49:24 +00:00
Drew Jaynes
c3ee28ea06
Docs: wp-admin/includes/admin-filters.php is part of the Administration subpackage, update the summary.
...
See #33701 .
Built from https://develop.svn.wordpress.org/trunk@35167
git-svn-id: http://core.svn.wordpress.org/trunk@35133 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-14 22:35:24 +00:00
Drew Jaynes
2e2e898802
Docs: Add a version and standardize the file header summary for wp-admin/includes/admin.php.
...
See #33701 .
Built from https://develop.svn.wordpress.org/trunk@35166
git-svn-id: http://core.svn.wordpress.org/trunk@35132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-14 22:32:24 +00:00
Boone Gorges
a53fe085aa
Fix incorrect variable names from [35164].
...
Cool story - the tests appeared to pass with the typos.
See #30017 , #33968 .
Built from https://develop.svn.wordpress.org/trunk@35165
git-svn-id: http://core.svn.wordpress.org/trunk@35131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-14 22:00:26 +00:00
Boone Gorges
ba37dc9123
Share fixtures in `Tests_Admin_includesListTable` tests.
...
See #30017 , #33968 .
Built from https://develop.svn.wordpress.org/trunk@35164
git-svn-id: http://core.svn.wordpress.org/trunk@35130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-14 21:41:24 +00:00
Boone Gorges
cb8a2f2e47
Share fixtures in `Tests_Get_Archives`.
...
See #30017 , #33968 .
Built from https://develop.svn.wordpress.org/trunk@35163
git-svn-id: http://core.svn.wordpress.org/trunk@35129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-14 21:30:25 +00:00
Boone Gorges
530111994d
Create fewer fixtures in some tests.
...
See #30017 , #33968 .
Built from https://develop.svn.wordpress.org/trunk@35162
git-svn-id: http://core.svn.wordpress.org/trunk@35128 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-14 21:24:24 +00:00
Helen Hou-Sandí
6820130e33
Screen options: Improve the "Apply" button
...
Previously the button was output as a part of the per-page option rendering, inline with that input. While this was appropriate for core's usage, the `screen_settings` filter has allowed plugins to place additional items at the bottom of the panel, which a number take advantage of. This leads to confusing situations where plugins that don't save settings via Ajax either have to add their own button or piggyback onto the existing button, which doesn't make any sense in the flow of additional options. It also hinders core from adding any other options that need to be submitted.
Also, when the screen options panel is open, a submit button there is the primary action at that moment. The "Apply" button also does a full page load, which a primary button indicates better.
fixes #34295 . see #22222 , #23738 .
Built from https://develop.svn.wordpress.org/trunk@35161
git-svn-id: http://core.svn.wordpress.org/trunk@35127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-14 18:58:25 +00:00
Andrea Fercia
f1787056de
Bump the "Status" H3 heading to H2 on the Edit Comment screen for better accessibility.
...
Fixes #34286 .
Built from https://develop.svn.wordpress.org/trunk@35160
git-svn-id: http://core.svn.wordpress.org/trunk@35126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-14 17:44:24 +00:00