WordPress-C
/
WordPress
mirror of https://github.com/WordPress/WordPress.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
26,365 Commits 50 Branches 749 Tags 982 MiB
Commit Graph

26365 Commits

Author SHA1 Message Date
Scott Taylor 5f06d0f50a Eliminate use of `extract()` in `wp_insert_link()`. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28406


git-svn-id: http://core.svn.wordpress.org/trunk@28233 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 02:28:14 +00:00
Scott Taylor 9d6eeca015 Eliminate use of `extract()` in `wp_list_bookmarks()`. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28405


git-svn-id: http://core.svn.wordpress.org/trunk@28232 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 02:18:16 +00:00
Scott Taylor 748765c5ad Eliminate use of `extract()` in `_walk_bookmarks()`. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28404


git-svn-id: http://core.svn.wordpress.org/trunk@28231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 02:05:15 +00:00
Scott Taylor 12a5b389ab Eliminate use of `extract()` in `get_bookmarks()`. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28403


git-svn-id: http://core.svn.wordpress.org/trunk@28230 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 01:58:15 +00:00
Scott Taylor a4a5560b22 Eliminate use of `extract()` in `Walker_Page::start_el()`. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28402


git-svn-id: http://core.svn.wordpress.org/trunk@28229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 01:41:15 +00:00
Scott Taylor 7b8d797355 Eliminate use of `extract()` in `wp_list_pages()` which, surprisingly, didn't even use any of the extracted variables. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28401


git-svn-id: http://core.svn.wordpress.org/trunk@28228 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 01:22:15 +00:00
Scott Taylor 29d8832625 Eliminate use of `extract()` in `wp_dropdown_pages()`. 
Adds unit tests to: `tests/post/template.php`. 
There was previously only one wimpy assertion for `wp_dropdown_pages()`.
	
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28399


git-svn-id: http://core.svn.wordpress.org/trunk@28227 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 01:12:13 +00:00
Scott Taylor fe2d90ab4f Eliminate use of `extract()` in `wp_link_pages()`. 
Adds unit tests to a new file: `tests/post/template.php`. 
There were previously no unit tests for `wp_link_pages()`.
	
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28398


git-svn-id: http://core.svn.wordpress.org/trunk@28226 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 00:44:14 +00:00
Scott Taylor d5acdd82c8 Eliminate use of `extract()` in `paginate_links()`. Adds unit tests. Moves `tests/general/template.php` (which only had one method) to `tests/general/paginateLinks.php`. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28397


git-svn-id: http://core.svn.wordpress.org/trunk@28225 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-14 22:29:14 +00:00
Scott Taylor 1121efb54c Eliminate use of `extract()` in `display_setup_form()`. Only needs to read `password` and `password_message`. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28396


git-svn-id: http://core.svn.wordpress.org/trunk@28224 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-14 16:43:15 +00:00
Lance Willett 8f61b31b4d Twenty Thirteen: add `accessibility-ready` tag. Fixes #28225, props BODA1982. 
Built from https://develop.svn.wordpress.org/trunk@28395


git-svn-id: http://core.svn.wordpress.org/trunk@28223 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 23:10:16 +00:00
Drew Jaynes a23cc5634f Properly split and document the `admin_post*` actions into the following four hooks: 
* `admin_post_nopriv` – for logged-out requests lacking a supplied action
* `admin_post_nopriv_$action – for logged-out requests with a supplied action
* `admin_post` – for logged-in requests lacking a supplied action
* `admin_post_$action` – for logged-in requests with a supplied action

See [28349], [28350], [28351].
See #26869.

Built from https://develop.svn.wordpress.org/trunk@28394


git-svn-id: http://core.svn.wordpress.org/trunk@28222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 07:24:15 +00:00
Drew Jaynes 40a738c21c Clarify inline documentation for back-compat `load-*` action hooks. 
See #26869.

Built from https://develop.svn.wordpress.org/trunk@28393


git-svn-id: http://core.svn.wordpress.org/trunk@28221 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 06:28:15 +00:00
Scott Taylor e866b5fb82 Eliminate use of `extract()` in `wp_list_authors()`. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28392


git-svn-id: http://core.svn.wordpress.org/trunk@28220 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 06:02:14 +00:00
Scott Taylor fd9abeb0f9 Eliminate use of `extract()` in `post_tags_meta_box()` and `post_categories_meta_box()`. 
Both functions only need to read `taxonomy`, yet they extract every available variable from `$box['args']`. Even if those variables were useful, there is no attempt to pass them to anything, and scope in PHP does not allow them to be scooped up by inner functions without being passed directly.
	
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28391


git-svn-id: http://core.svn.wordpress.org/trunk@28219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 05:48:17 +00:00
Scott Taylor 9476cd33a3 Eliminate use of `extract()` in `WP_Terms_List_Table::display_rows_or_placeholder()`: 
* Set variables for `$page` and `$number`
* `list(...) = $this->get_column_info()` can be removed, as none of the variables returned are used.
* `orderby` and `search` can be checked from `$args`, leaving no reason to extract		

See #22400.

Built from https://develop.svn.wordpress.org/trunk@28390


git-svn-id: http://core.svn.wordpress.org/trunk@28218 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 05:37:14 +00:00
Scott Taylor aef35fe6a2 Eliminate use of `extract()` in `WP_List_Table::pagination()`: 
* Set variables instead of extracting `$this->_pagination_args`
* Weird: `$infinite_scroll` is only presently set in subclasses of `WP_List_Table` and never initialized otherwise. 		

See #22400.

Built from https://develop.svn.wordpress.org/trunk@28389


git-svn-id: http://core.svn.wordpress.org/trunk@28217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 05:27:14 +00:00
Scott Taylor 530a107ec9 Eliminate use of `extract()` in `WP_Plugin_Install_List_Table::get_table_classes()`. It only needs to read `plural`, no need to extract. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28388


git-svn-id: http://core.svn.wordpress.org/trunk@28216 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 05:17:14 +00:00
Scott Taylor 192e235672 Eliminate use of `extract()` in `WP_List_Table::ajax_response()`: 
* Extracting `$this->_args` is unnecessary since none of the variables produced are present in the method.
* `total_items` and `total_pages` can be read directly from `$this->_pagination_args`

See #22400.

Built from https://develop.svn.wordpress.org/trunk@28387


git-svn-id: http://core.svn.wordpress.org/trunk@28215 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 05:14:14 +00:00
Scott Taylor 08d73b9e23 Eliminate use of `extract()` in `WP_List_Table::display()`. The method only needs to read `singular` from `$this->_args`. Extraction is unnecessary. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28386


git-svn-id: http://core.svn.wordpress.org/trunk@28214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 05:08:13 +00:00
Scott Taylor f617b8669a Eliminate use of `extract()` in `WP_Post_Comments_List_Table::display()`. The method only needs to read `singular` from `$this->_args`. Extraction is unnecessary. 
Eliminate use of `extract()` in `WP_Comments_List_Table::display()`. The method uses no variables. Extraction can be completely removed.

See #22400.

Built from https://develop.svn.wordpress.org/trunk@28385


git-svn-id: http://core.svn.wordpress.org/trunk@28213 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 05:04:14 +00:00
Scott Taylor 4c60b2e207 Eliminate use of `extract()` in `Custom_Image_Header::step_2()`. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28384


git-svn-id: http://core.svn.wordpress.org/trunk@28212 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 04:54:14 +00:00
Scott Taylor 92d2c60a65 Eliminate use of `extract()` in `the_title_attribute()`. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28383


git-svn-id: http://core.svn.wordpress.org/trunk@28211 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 04:48:15 +00:00
Scott Taylor ef8b813682 Eliminate use of `extract()` in `trackback_url_list()`. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28382


git-svn-id: http://core.svn.wordpress.org/trunk@28210 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 04:44:15 +00:00
Scott Taylor bee6492b9b Eliminate use of `extract()` in `wp-includes/theme-compat/comments-popup.php`. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28381


git-svn-id: http://core.svn.wordpress.org/trunk@28209 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 04:40:16 +00:00
Drew Jaynes f9f55011ba Fix a phpdoc typo and multi-line comment syntax in wp-cron.php. 
Props rclations.
Fixes #28231.

Built from https://develop.svn.wordpress.org/trunk@28380


git-svn-id: http://core.svn.wordpress.org/trunk@28208 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 04:39:14 +00:00
Scott Taylor b110c7f887 Eliminate use of `extract()` in `wp_get_archives()`. 
Adds unit tests: `tests/functions/getArchives.php`. 
All other unit tests pass.

Props MikeHansenMe, wonderboymusic.
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28379


git-svn-id: http://core.svn.wordpress.org/trunk@28207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 04:29:26 +00:00
Drew Jaynes 62b6306739 Use a proper docs-specific variable for the first parameter passed to the `embed_oembed_discover` filter. 
See #26869.

Built from https://develop.svn.wordpress.org/trunk@28378


git-svn-id: http://core.svn.wordpress.org/trunk@28206 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 04:29:14 +00:00
Drew Jaynes 08824b6529 Add a complete short description to the `get_attached_media` filter documentation. 
See #26869.

Built from https://develop.svn.wordpress.org/trunk@28377


git-svn-id: http://core.svn.wordpress.org/trunk@28205 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 04:21:14 +00:00
Drew Jaynes ec88da1ee3 Clarify documentation for *what* gets "automatically fired" when the `do_mu_upgrade` filter evaluates to true in Multisite. 
See #26869.

Built from https://develop.svn.wordpress.org/trunk@28376


git-svn-id: http://core.svn.wordpress.org/trunk@28204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 04:18:14 +00:00
Drew Jaynes b4ca72583a Fix incomplete inline documentation for the `wp_header_image_attachment_metadata` filter. 
See #26869.

Built from https://develop.svn.wordpress.org/trunk@28375


git-svn-id: http://core.svn.wordpress.org/trunk@28203 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 04:13:15 +00:00
Scott Taylor 6bbc5b570c Eliminate use of `extract()` in `wp_insert_category()`. Adds unit tests. All unit tests pass. 
Props MikeHansenMe.
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28374


git-svn-id: http://core.svn.wordpress.org/trunk@28202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 03:27:13 +00:00
Scott Taylor 8af6a4230e Eliminate use of `extract()` in `wp-activate.php`. 
Props jeremyfelt, MikeHansenMe.
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28373


git-svn-id: http://core.svn.wordpress.org/trunk@28201 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 03:14:16 +00:00
Scott Taylor f32dbfe62c Add `xps` and `oxps` extensions to list of supported document types. 
More: http://en.wikipedia.org/wiki/Open_XML_Paper_Specification

Fixes #15697.


Built from https://develop.svn.wordpress.org/trunk@28372


git-svn-id: http://core.svn.wordpress.org/trunk@28200 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-11 07:19:13 +00:00
Scott Taylor 5682d30b6e In `wp.media.view.Settings::update()`, when handling checkboxes, check for a value of `'false'` in addition to casting `value` to boolean. `!! 'false'` evaluates to `true`. 
Props adamsilverstein.
Fixes #23954.


Built from https://develop.svn.wordpress.org/trunk@28371


git-svn-id: http://core.svn.wordpress.org/trunk@28199 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-11 07:03:15 +00:00
Scott Taylor aeadf0c7cf Allow users to set overrides for MediaElement instances by always passing `_wpmejsSettings` instead of just `_wpmejsSettings.pluginPath`. 
Props Otto42 for the initial patch.
Fixes #25243.


Built from https://develop.svn.wordpress.org/trunk@28370


git-svn-id: http://core.svn.wordpress.org/trunk@28198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-11 06:25:15 +00:00
Scott Taylor 558cf6f86d In the `Attachment Details` section of the media modal, only add `box-shadow` to images. Other mime-type icons look strange with an arbitrary border. 
Props avryl.
Fixes #27949.


Built from https://develop.svn.wordpress.org/trunk@28369


git-svn-id: http://core.svn.wordpress.org/trunk@28197 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-11 06:19:14 +00:00
Scott Taylor 2bea9fcc0b In `media_upload_gallery_form()`'s inline JavaScript, remove unnecessary comment tags. 
Fixes #25637.


Built from https://develop.svn.wordpress.org/trunk@28368


git-svn-id: http://core.svn.wordpress.org/trunk@28196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-11 06:12:15 +00:00
Scott Taylor 88b96dc036 In `wp_read_image_metadata()`, the values from `exif_read_data()` should only override values from `iptcparse()` that are empty. 
Props SergeyBiryukov.
Fixes #23706.

Built from https://develop.svn.wordpress.org/trunk@28367


git-svn-id: http://core.svn.wordpress.org/trunk@28195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-11 05:54:15 +00:00
Scott Taylor e9f87b2688 Avoid a notice in `wp_save_image()` by checking `$meta['sizes']['thumbnail']` for `! empty()` before setting a variable to it. 
Props MikeHansenMe.
Fixes #17736.


Built from https://develop.svn.wordpress.org/trunk@28366


git-svn-id: http://core.svn.wordpress.org/trunk@28194 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-11 03:42:14 +00:00
Scott Taylor 60f395e4c2 Update the default (WP-defined) styles for MediaElement players to be more in-line with our flat aesthetic. Use the new official colors. 
Props celloexpressions.
Fixes #27516.


Built from https://develop.svn.wordpress.org/trunk@28365


git-svn-id: http://core.svn.wordpress.org/trunk@28193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-11 02:23:14 +00:00
Scott Taylor 37b7f39e95 When pausing "all" players attached to MCE views, don't reach into global scope and pause "every" player. Only pause the players bound to MCE views. 
Fixes #27971.


Built from https://develop.svn.wordpress.org/trunk@28364


git-svn-id: http://core.svn.wordpress.org/trunk@28192 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-11 02:07:14 +00:00
Scott Taylor fb1aab6520 Support `loop` for `[audio]` and `[video]` shortcodes that specify files that are played using MediaElement's Flash plugin bridge. 
Fixes #27368.


Built from https://develop.svn.wordpress.org/trunk@28363


git-svn-id: http://core.svn.wordpress.org/trunk@28191 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-11 01:28:15 +00:00
Scott Taylor 5df38694e9 In `get_the_author_posts()`, if there is no current `$post`, return `0` and bail. 
Props krogsgard, aaroncampbell.
Fixes #27998.


Built from https://develop.svn.wordpress.org/trunk@28362


git-svn-id: http://core.svn.wordpress.org/trunk@28190 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-11 00:26:14 +00:00
Scott Taylor d06c353995 MediaElement players need `clear: both` to play nice with adjacent floated elements. 
Fixes #27385.


Built from https://develop.svn.wordpress.org/trunk@28361


git-svn-id: http://core.svn.wordpress.org/trunk@28189 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-11 00:14:14 +00:00
Scott Taylor 0b6729c3f9 In `WP_Terms_List_Table::single_row()`, call `sanitize_term()` on the passed term (`$tag`). 
Props oso96_2000, c3mdigital, scribu. 
It takes a village.
Fixes #16864.

Built from https://develop.svn.wordpress.org/trunk@28360


git-svn-id: http://core.svn.wordpress.org/trunk@28188 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-11 00:05:15 +00:00
Scott Taylor 9daf458ff0 Remove the `title` attribute from markup generated in `wp-includes/category-template.php`: 
* `get_category_parents()`
* `get_the_category_list()`
* `wp_generate_tag_cloud()`
* `Walker_Category::start_el()`	

Props joedolson.
Fixes #26557.	


Built from https://develop.svn.wordpress.org/trunk@28359


git-svn-id: http://core.svn.wordpress.org/trunk@28187 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-10 23:57:16 +00:00
Scott Taylor f22beb987c First pass at `wpview` logic for the `[embed]` shortcode. URLs on a their own line are parsed as well. The toolbar will appear with the "remove" button when the view is clicked. Edit has not been implemented yet. 
Props avryl, wonderboymusic.
See #28195.


Built from https://develop.svn.wordpress.org/trunk@28358


git-svn-id: http://core.svn.wordpress.org/trunk@28186 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-10 23:36:18 +00:00
Drew Jaynes 9098b45e53 Add inline documentation of the default arguments for `wp_list_pages()`. 
Props garza for the initial patches.
Fixes #11338.

Built from https://develop.svn.wordpress.org/trunk@28357


git-svn-id: http://core.svn.wordpress.org/trunk@28185 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-10 08:02:14 +00:00
Drew Jaynes 81cfb9427a Fix mid-file section header style in wp-admin/includes/ajax-actions.php. 
See #28200.

Built from https://develop.svn.wordpress.org/trunk@28356


git-svn-id: http://core.svn.wordpress.org/trunk@28184 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-10 05:02:13 +00:00