a1e92cae9d
Fix typo in a comment, props SergeyBiryukov, fixes #20506
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20591 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-25 17:49:48 +00:00
df7bd632f2
Clean out layout columns API in WP_Screen.
...
* Move layout column setup into render_screen_meta() so that the number of columns is available earlier.
* Store the user provisioned number of columns in an instance var.
* Access the var with get_columns()
* Move all templates away from the screen_layout_columns global to the get_columns() method.
* Deprecate the global
* Remove the no longer needed check for 'auto' in the user option.
* Cast the user option to an int.
Props griffinjt
fixes #20506
git-svn-id: http://svn.automattic.com/wordpress/trunk@20579 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-24 20:46:04 +00:00
bba9c91990
Responsive columns on the dashboard and write screens, first run, see #20015
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20272 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-23 21:41:00 +00:00
f3b63e4537
Set proper HTML5 input types in the admin, props georgestephanis, fixes #17863
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20168 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-10 01:23:48 +00:00
69f037f8cc
Remove out-of-place double quote. props niallkennedy. fixes #20113 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19987 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-24 20:49:54 +00:00
cbbef554e9
Add an @return. fixes #19974 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19950 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-18 21:59:47 +00:00
fe96801c4b
Add WP_Screen methods get_help_tabs(), get_help_tab( $id ), get_help_sidebar(). Store help tabs by tab ID, not numeric key; allows proper removal with remove_help_tab( $id ). props BenChapman, npetetin for initial getter patch. fixes #19974 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19944 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-17 23:40:02 +00:00
bc73871a55
Only show 'Show on screen' once in screen options. fixes #17431 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19943 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-17 23:19:52 +00:00
a40a97dbc9
Use class name for @return. props markuak, fixes #20063 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19942 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-17 23:15:05 +00:00
c1b4310367
Provide contexts for a 'Welcome' string. Sometimes we're saying hello, other times referring to the welcome panel. props pavelevap, fixes #19698 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19807 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-01 14:47:49 +00:00
65b840b565
Fix mistakes in parameter documentation and add some missing param docs. See #19756 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19702 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-06 18:31:43 +00:00
d5d55f62a7
Fix typo in [19052]. Believe it or not, it worked as is. props TobiasBg.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19680 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-04 23:06:49 +00:00
340e93324c
Remove extraneous spaces. Props kenan3008, dimadin. fixes #19501 #19433
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19596 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-14 17:36:38 +00:00
07ff8b216b
Use one space, not two, after trailing punctuation. fixes #19537
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-13 23:45:31 +00:00
c6fcc03bcf
Contextual help: Remove dead overview code. Prepend old- to back compat ID. Props nacin. see #18785
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-07 00:13:52 +00:00
2c789f296a
Make current_screen an action, not a filter. see #18785 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19521 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-01 03:34:55 +00:00
a16fe7f86f
Deprecate add_contextual_help() for get_current_screen()->add_help_tab(). fixes #19020 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19520 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-01 03:29:55 +00:00
02dfdbbbf4
s/Screen Info/Overview/g, see #19020 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19503 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-01 00:34:31 +00:00
5b248a72c8
'Overview' for old-style help tabs, not 'Screen Info.' props jane. see #19020 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19493 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-30 20:58:39 +00:00
65fde75e85
WP_Screen: Whitelist -new and -add screens, and prevent edit-comments and edit-tags from being mashed on. fixes #19353 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19471 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-28 22:58:51 +00:00
f9ee8ccfd2
Use a scalpel to dissect names passed to convert_to_screen(). Carefully watch for post type names, suffixes we need to detect and remove, and when we need to remove 'edit-' from the start of a hookname. see #19353 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19468 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-28 18:33:40 +00:00
5ff76fd777
Remove help sidebar background when no sidebar exists. props chrisbliss18, see #18197 , [19361].
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19430 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-23 22:14:03 +00:00
ff358379c9
Move convert_to_screen() back to template.php to avoid fatal errors with plugins and themes that direct include template.php into the front end. Flag this bad behavior with _doing_it_wrong(). Props nacin. fixes #19342
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19428 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-23 21:29:33 +00:00
dd697967bf
Change show/hide storage mechanism for show_welcome_panel. 0 = hide, 1 = show, 2 = show if the multisite owner. Make welcome panel dismissable without JS (openable too via the URL). fixes #19338 , fixes #19127 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19418 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-23 18:30:45 +00:00
5f60ab4076
Remove $post_type global usage from media list table. Correct $post_type to 'attachment' for upload screens. see #18722 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19385 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-21 20:48:57 +00:00
c65d96de08
Help tabs: remove scrollbar and max-height. see #19155 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19361 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-20 01:03:17 +00:00
66388c185e
Don't fallback to default post type or taxonomy if given an invalid post type or taxonomy. Use typenow as the canonical post type. Props nacin. see #19131
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19321 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-17 18:01:08 +00:00
ab5f3aa79c
Remove default help text. Keep the default_help filter in place for plugins. fixes #19154 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19185 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-06 18:13:06 +00:00
31c84c9d7b
Use call_user_func_array() as call_user_func() cannot pass by reference. see #18785 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19155 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-04 15:06:11 +00:00
0a825c74be
Pass $tab array to callback execution for help tabs. see #18785 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19154 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-04 15:04:58 +00:00
9741ce2773
Allow is_network and is_user to work for all screen instances. see #18785 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-03 23:00:46 +00:00
8454367edf
Revert the look and functionality of Screen Options ans Help links/tabs, see #18197 , see #18785
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-03 20:26:09 +00:00
f73e6b3228
Revert placement of Help and Screen Options to under the admin bar on the right, see #18197 , see #18785
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-03 17:08:12 +00:00
bfb98c193e
s/add_help_sidebar/set_help_sidebar/g and introduce screen->remove_help_tab($id) and screen->remove_help_tabs(). see #19020 , #18785 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-02 20:14:10 +00:00
3932addc50
Reverse variable assignment order. D'oh. see #19108 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19113 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-02 04:24:17 +00:00
6c9e82de0a
Use more obvious variables in WP_Screen. see #18785 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19108 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-01 21:36:04 +00:00
13db43d2d3
Always run the old contextual_help filter. see #18785 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19098 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-31 21:37:43 +00:00
29e469f151
Consistently set taxnow/typenow and the current screen's post_type/taxnomy, whenever it can be detected. Allow WP_Screen::get() to accept a post type as a hook_name. Fixes issues with the meta box $page/$screen argument. fixes #19080 . see #18785 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19097 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-31 21:28:17 +00:00
aa6eb9729a
Fix copypasta in in WP_Screen. see #19095 , props SergeyBiryukov.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19092 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-31 16:57:29 +00:00
1e6e52e1c1
Add missing keyword. fixes #19046 , see #18785 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19064 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-25 16:05:39 +00:00
68225fdf13
Make convert_to_screen() more resilient. see #18785 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19063 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-25 06:54:23 +00:00
62afab8db3
Pinking shears
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-24 19:13:23 +00:00
ad3eb8f7ab
Fallback to the default post type only if it is registed for the taxonomy. Props nacin. see #18785
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19053 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-24 19:10:56 +00:00
12de7d1e2d
Move WP_Screen to a full registry. Have convert_to_screen() return a WP_Screen object. Improve and verify values for post_type and taxonomy. see #18785 . also fixes #14886 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-24 18:34:08 +00:00
29f6c203cd
screen.php tidying. Doc fixes and improvements. Improve logic in ::show_screen_options(). Remove regex in ::set_parentage(). Better variable names. Streamline get_screen_icon(). Whitespace. see #18785 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19051 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-24 06:40:15 +00:00
a4a58839d0
Deprecate favorite_actions(). see #18785 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19050 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-24 06:10:36 +00:00
c62a9fe508
Rework get_hidden_meta_boxes() to leverage a full WP_Screen object. Prevents custom post types from having their explicity supported meta boxes being hidden by default. see #18958 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19049 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-23 19:22:27 +00:00
11a800a3d9
Move welcome panel link to a 'Show on screen' checkbox. see #11651 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19014 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-19 21:43:21 +00:00
936107846c
Restore object handling in add_contextual_help(). see #18785 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18950 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-12 16:24:55 +00:00
aa06a7de9f
Don't instantiate WP_Screen in convert_to_screen() for now. see #18785 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18949 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-12 16:22:50 +00:00
07a664da92
Restore $screen argument for contextual_help* filters. see #18785 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18945 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-11 21:45:28 +00:00
7bf1ec1a01
Store screen help and options as static data against WP_Screen. Individual screen objects no longer hold data it can't re-generate on construction or otherwise fetch. convert_to_screen() now returns a WP_Screen object. Various globals are gone. Introduces WP_Screen::get_option(). Allows for a formal factory to be introduced later. see #18785 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18943 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-11 21:32:16 +00:00
35dd66044a
Enforce IDs for add_help_tab(). props mbijon. Restore default_contextual_help, for now. see #18785 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18941 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-11 19:29:09 +00:00
50078431dc
Use local method when handling back compat screen layout column filter. The function serves as a wrapper for but one object. see #18785 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18915 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-07 05:26:44 +00:00
850ea83baf
Move the Screen Options tab to the top and introduce a new 'overview' screen option, which accepts content for the top of this tab. see #18785 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18914 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-07 05:23:33 +00:00
cc199b6358
Remove redundant help tab title from the tab body. see #18785 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18913 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-07 05:00:38 +00:00
795ca8d394
Revert [18861], [18862], [18864], [18874], [18879], and [18880]. see #18785 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18911 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-07 04:57:12 +00:00
fb31c6f302
Refine new help styles. see #18690 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18896 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-05 23:15:19 +00:00
f9ebf31d4a
Revert 'auto' column setting, props markjaquith, see #18863
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18889 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-05 18:46:21 +00:00
d0ceca2496
Make $current_screen->add_option() easier to use, see #18690
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18879 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-04 17:21:59 +00:00
bc6411bb52
Deprecate favorite_actions(), add_contextual_help(), add_screen_option(), move meta_box_prefs() and get_screen_icon() in WP_Screen, see #18690
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18874 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-04 03:32:12 +00:00
bbafdfa0e5
Use add_option() method, introduce add_option_context() method for adding specific text above the screen options, see #18690
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18867 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-03 04:00:57 +00:00
dbd18bea3d
Help style refresh, part 1. A few elements left to add/tweak. see #18690 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18866 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-02 18:19:49 +00:00
3575537e5f
Add screen_options with contextual content, see #18690
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18864 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-02 06:59:36 +00:00
f626113f33
Add phpdoc for two WP_Screen methods. props jorbin, see #18785 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18863 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-02 00:04:30 +00:00
9662f2f87e
Add phpdoc for the section title, see #18690
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18862 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-01 22:22:33 +00:00
0df31fc3c4
Separate the tab title from the help section title, see #18690
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18861 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-01 21:18:04 +00:00
fcba7735c0
Deprecate screen_meta(). see #18785 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18859 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-01 18:13:27 +00:00
e635d0befc
Deprecate secreen_options(), screen_layout(). see #18785 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18858 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-01 18:07:41 +00:00
5522818ed3
Move all new WP_Screen properties to private. We should introduce getters. Correct legacy (and ideally read-only) properties to @access public. see #18785 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18857 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-01 17:59:46 +00:00
322c2bde5e
Properly print per-page options. see #18690 , [18853].
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18854 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-01 03:21:36 +00:00
2d3fa6fcb8
Make screen options a help tab. Move screen option functions into WP_Screen. see #18690 , #18785 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18853 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-01 00:24:44 +00:00
8c731f1cb2
Space out and capitalize 'Auto' in screen options.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18808 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-29 05:28:00 +00:00
8c1bc6831a
Add dashboard help tabs, revise help tab layout and code. see #18690 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18797 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-28 00:57:56 +00:00
6c1f1b642a
Revert fat fingers in [18793]. see #18690
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18794 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-27 14:33:51 +00:00
022dcf68c0
First pass of WP_Screen phpdoc. see #18690
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18793 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-27 14:30:56 +00:00
30c473c4e0
Make WP_Screen final until we know which direction we want to go with it. Other keyword decorations. see #18785 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18784 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-26 23:31:54 +00:00
49fae8d60b
Move WP_Screen and friends (15 functions) into admin/includes/screen.php. see #18690 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18782 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-26 21:32:10 +00:00
azaozz
ryan
nacin
duck_
koopersmith