Commit Graph

98 Commits

Author SHA1 Message Date
Andrew Ozz bc7ea33113 Editor: when TinyMCE is used, add `autocomplete="off"` to the textarea to prevent problems with missing <p> tags when the user reloads the page or uses Go Back/Go Forward buttons, and when editing the same post from two different windows. The autocomplete can be removed with the `the_editor` filter. Part props xsonic, fixes #27251.
Built from https://develop.svn.wordpress.org/trunk@27366


git-svn-id: http://core.svn.wordpress.org/trunk@27216 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-03 01:15:13 +00:00
Andrew Ozz ce7191d2f9 Editor: look at the class of the wrapper element instead of `getUserSetting('editor')` to determine the default editor, fixes #27257
Built from https://develop.svn.wordpress.org/trunk@27364


git-svn-id: http://core.svn.wordpress.org/trunk@27214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-02 23:26:13 +00:00
Andrew Ozz 65fac9e55a Set wpActiveEditor to the id of the first instance on init, props kovshenin, fixes #27210.
Built from https://develop.svn.wordpress.org/trunk@27270


git-svn-id: http://core.svn.wordpress.org/trunk@27126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-25 19:31:14 +00:00
Andrew Ozz 9c77339681 TinyMCE: revert style for the blocks drop-down in the toolbar, limit the styles imported for the same drop-down, make the menu highlight color grey. Part props avryl, see #26952
Built from https://develop.svn.wordpress.org/trunk@27193


git-svn-id: http://core.svn.wordpress.org/trunk@27052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-19 03:51:15 +00:00
Andrew Ozz c908c8f708 Edit image in TinyMCE:
- Add a "toolbar" at the top of the image with two buttons: Edit and Delete.
- Don't open the edit modal on second click on the image. Makes the "edit" button somewhat pointless and can sometimes trigger after resizing the image.
- When the image has caption: attempt to prevent IE11 from making the caption element resizable and wrapping it in thick border.
- When the caret is inside a caption next to the image, pressing Enter will create a new <p> tag above the caption.
- Hide the image toolbar on drag, cut, align.
Props gcorne, see #24409.
Built from https://develop.svn.wordpress.org/trunk@27159


git-svn-id: http://core.svn.wordpress.org/trunk@27025 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-10 23:48:12 +00:00
Andrew Ozz 5ce168941a When using wp_editor(), make it easier to specify which editor is shown first, fixes #20822
Built from https://develop.svn.wordpress.org/trunk@27093


git-svn-id: http://core.svn.wordpress.org/trunk@26965 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-05 00:34:12 +00:00
Andrew Ozz 314f9569e5 TinyMCE: update to 4.0.14. Remove the fix for using init.setup in old plugins, now fixed upstream. See #24067.
Built from https://develop.svn.wordpress.org/trunk@27060


git-svn-id: http://core.svn.wordpress.org/trunk@26933 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-31 00:06:12 +00:00
Andrew Ozz 33eedc570b Introduce Edit Image (single mode) in the media modal and use it to edit images inserted in the editor. Adds new feature: replace an image in the editor. Props gcorne, see #24409.
Built from https://develop.svn.wordpress.org/trunk@27050


git-svn-id: http://core.svn.wordpress.org/trunk@26924 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-28 21:17:12 +00:00
Andrew Ozz ed3145ec3d TinyMCE: fix the compat3x plugin appending 'en.' to button titles. Set charset to UTF-8 in html_entity_decode() for translated strings. See #24067, see #26875.
Built from https://develop.svn.wordpress.org/trunk@27030


git-svn-id: http://core.svn.wordpress.org/trunk@26906 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-25 01:21:13 +00:00
Andrew Ozz 167235a602 TinyMCE: fix initializing TinyMCE when the default editor in getUserSetting() is overridden from PHP by using the 'wp_default_editor' filter. See #24067.
Built from https://develop.svn.wordpress.org/trunk@27004


git-svn-id: http://core.svn.wordpress.org/trunk@26881 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-22 18:17:12 +00:00
Andrew Ozz ec5288d405 TinyMCE: fix 3.x callbacks added with init.setup as they run before the compat3x plugin is loaded. Ideally this will be fixed internally in TinyMCE, see #24067.
Built from https://develop.svn.wordpress.org/trunk@26982


git-svn-id: http://core.svn.wordpress.org/trunk@26859 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-18 22:20:12 +00:00
Andrew Ozz 5d92ed5632 TinyMCE: remove the 'spellchecker' plugin. It has been disabled for a while and the back-end currently doesn't work. See #24067.
Built from https://develop.svn.wordpress.org/trunk@26958


git-svn-id: http://core.svn.wordpress.org/trunk@26837 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-15 19:07:11 +00:00
Andrew Ozz 6c0fe71d05 TinyMCE: re-enable soft resizing of images inside the editor. See #24067.
Built from https://develop.svn.wordpress.org/trunk@26934


git-svn-id: http://core.svn.wordpress.org/trunk@26815 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-13 01:13:10 +00:00
Andrew Ozz b7999f453a TinyMCE: back-compat, refresh and re-enable the 'wpdialogs' plugin, and mark it as deprecated. See #24067.
Built from https://develop.svn.wordpress.org/trunk@26899


git-svn-id: http://core.svn.wordpress.org/trunk@26782 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-03 02:33:10 +00:00
Andrew Ozz 915607ca0d Thickbox is needed for the media modal back-compat. Are there plugins that still use this? Also needed for PressThis. See #24067.
Built from https://develop.svn.wordpress.org/trunk@26898


git-svn-id: http://core.svn.wordpress.org/trunk@26781 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-02 22:49:09 +00:00
Andrew Ozz 87c75ab93a DFW: fix buttons and the title width, make the fade out/in when opening and closing a bit faster. See #24067.
Built from https://develop.svn.wordpress.org/trunk@26896


git-svn-id: http://core.svn.wordpress.org/trunk@26779 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-02 04:18:10 +00:00
Andrew Ozz 0226a93d0a Set wpActiveEditor as soon as any editor associated button is clicked, including Add Media, switching Text to Visual, etc. Fixes #26747.
Built from https://develop.svn.wordpress.org/trunk@26881


git-svn-id: http://core.svn.wordpress.org/trunk@26764 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-30 19:17:11 +00:00
Andrew Ozz 855889f7aa TinyMCE 4.0.12, first run.
- Removes wp-tinymce-schema.js and mark-loaded.js, no longer needed.
- Removes the inlinepopups and most of the wpdialogs plugins; wpdialog.js is moved to wp-includes/js.
- Adds charmap, compat3x, image, link and textcolor plugins, previously contained in /themes/advanced.
- Updates the wordpress, wpeditimage, wpfullscreen, wpgallery and wplink plugins.
- Updates DFW, wp-admin/js/wp-fullscreen.js.
See #24067.
Built from https://develop.svn.wordpress.org/trunk@26876


git-svn-id: http://core.svn.wordpress.org/trunk@26759 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-28 23:53:15 +00:00
Andrew Ozz 7efd903498 Fix the editor switching tabs position on small screens, props ryelle, fixes #26151.
Built from https://develop.svn.wordpress.org/trunk@26315


git-svn-id: http://core.svn.wordpress.org/trunk@26219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-22 02:23:09 +00:00
Andrew Nacin d0cfa40983 Add jshintrc to qunit.
props jorbin.
see #25187.

Built from https://develop.svn.wordpress.org/trunk@25992


git-svn-id: http://core.svn.wordpress.org/trunk@25925 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-30 14:39:10 +00:00
Sergey Biryukov 6e5a5d21e0 Document 'wp_link_query_args' and 'wp_link_query' filters. props DrewAPicture. fixes #18042.
Built from https://develop.svn.wordpress.org/trunk@25299


git-svn-id: http://core.svn.wordpress.org/trunk@25262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-07 19:47:10 +00:00
Sergey Biryukov b2ce0b4f93 Add 'wp_link_query_args' and 'wp_link_query' filters to allow for customizing the internal linking dialog. props CoenJacobs, goldenapples. fixes #18042.
Built from https://develop.svn.wordpress.org/trunk@25293


git-svn-id: http://core.svn.wordpress.org/trunk@25257 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-07 12:21:12 +00:00
Andrew Nacin bd5554f06a Remove the Spellchecker button from TinyMCE.
It appears Google has finally shut off the old private API it used. Spellcheckers built-in to browsers (and operating systems) seem to be the best alternative.

A WordPress plugin could still re-enable this TinyMCE plugin if they wanted.

props ryanduff for initial patch.
fixes #24789.



git-svn-id: http://core.svn.wordpress.org/trunk@24745 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-18 22:44:40 +00:00
Ryan Boren 44fca1dc57 Allow absolute URLs in editor styles.
Props nacin, obenland
fixes #24787


git-svn-id: http://core.svn.wordpress.org/trunk@24735 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-18 18:11:43 +00:00
Andrew Ozz 2c93798e2b TinyMCE: normalize font size for H1 - H6 submenu, fixes #24586.
git-svn-id: http://core.svn.wordpress.org/trunk@24545 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-03 02:03:19 +00:00
Andrew Ozz 0e0bbd38a2 TinyMCE: don't import color and background-color from the content when creating menus that have preview capabilities.
Fixes a visual glitch: when post formats styling is added in editor-styles.css, it is applied to the menus and not reset after changing format. See #24308.

git-svn-id: http://core.svn.wordpress.org/trunk@24341 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-23 22:49:06 +00:00
Andrew Nacin 00b7fa589a Remove ancient 'lookup' quicktag from the text editor. This had called up answers.com.
props mboynes, jonbishop, SergeyBiryukov.
fixes #23322.



git-svn-id: http://core.svn.wordpress.org/trunk@24052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-22 20:17:25 +00:00
Andrew Ozz 2c5ad0030f Pass post format as a class to TinyMCE's body, props adamsilverstein, fixes #23198
git-svn-id: http://core.svn.wordpress.org/trunk@23730 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-16 05:57:54 +00:00
Andrew Nacin a4242198ed Ensure [23122] gets parsed as context. props TobiasBg. fixes #22808.
git-svn-id: http://core.svn.wordpress.org/trunk@23123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-07 18:50:16 +00:00
Andrew Nacin fe2e8c6101 Update fullscreen/DFW's "Text" tab to match the string context used for the editor Text tab. Not a string change. props pavelevap, fixes #22808.
git-svn-id: http://core.svn.wordpress.org/trunk@23122 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-07 18:36:15 +00:00
Andrew Nacin 45e3d73a05 Add a sane, inclusive HTML element/attribute schema to TinyMCE.
TinyMCE 3.4.x (shipped with WordPress 3.4.x) had an HTML4-based schema definition, with HTML5 elements added to it. TinyMCE 3.5.x (shipping, again coincidentally, with WordPress 3.5) allows for HTML5 schema support, which also provides for full HTML5 attribute support. The problem is its HTML5 schema excludes all HTML4 elements and attributes that were dropped in the HTML5 spec, which is unacceptable behavior.

This "duck punch" of TinyMCE's Schema.js file creates a new, sane schema. It is TinyMCE's HTML4 and HTML5 schema definitions recursively merged.

Objects are not whitelisted in either schema to allow for embed elements as child nodes, so object, param, and embed remain separately whitelisted in the WordPress TinyMCE plugin. Our attempts to add other attributes in said plugin is now superceded.

props koopersmith, azaozz.
fixes #22790.



git-svn-id: http://core.svn.wordpress.org/trunk@23120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-07 11:26:25 +00:00
Andrew Ozz debfe1021f 5000, not 3000, see #22708
git-svn-id: http://core.svn.wordpress.org/trunk@23017 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 06:05:08 +00:00
Andrew Ozz f803bad096 Editor: add sanity limit for editor height of 5000px, save only when resizing the Visual or the Text editor, fixes #22708
git-svn-id: http://core.svn.wordpress.org/trunk@23016 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 06:01:47 +00:00
Ryan Boren d4abd95449 Scope button classes so they can be used on the frontend without interfering with theme styles.
Props helenyhou, koopersmith
fixes #22644


git-svn-id: http://core.svn.wordpress.org/trunk@22948 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-30 13:40:59 +00:00
Andrew Nacin 7e0061375a No-JS fixes.
* Hide QuickPress.
 * Hide the gap between the title and content editor.
 * Hide 'select all' checkboxes in list tables.
 * Hide a non-functioning link in the custom fields metabox.
 * Hide non-functioning buttons in the featured image box (same as in 3.4).
 * RTL and miscellany.

props TobiasBg, lessbloat, ocean90. fixes #22456.



git-svn-id: http://core.svn.wordpress.org/trunk@22719 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 18:20:14 +00:00
Daryl Koopersmith b2db6270ee Media: Restore 3.4 editor behavior and remove TinyMCE views.
* Reactivates the `wpgallery` and `wpeditimage` TinyMCE plugins. Deactivates the `wpviews` TinyMCE plugin.
* Moves still-relevant logic from `mce-views.js` to `media-upload.js` and `shortcode.js`.
* No longer include `wp-includes/js/mce-views.js`. This code will not be used in 3.5, and should be considered unstable.
* Currently, this is the real 3.4 experience; as such, editing triggers the old modals. Changing this is the next major step.

When reassessing views, we should look over all of these tickets and anticipate these bugs accordingly.

fixes #21813, #22123, #22155, #22161, #22257, #22266, #22318, #22407, see #21390.


git-svn-id: http://core.svn.wordpress.org/trunk@22567 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-14 07:17:22 +00:00
Andrew Nacin 17a387ccb8 Use correct variable name in code comment. props SergeyBiryukov, fixes #21962.
git-svn-id: http://core.svn.wordpress.org/trunk@22416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 08:57:49 +00:00
Andrew Ozz baeab0b474 Editor: fix setting wpActiveEditor when TinyMCE is not used, see #21718
git-svn-id: http://core.svn.wordpress.org/trunk@22251 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-16 22:01:30 +00:00
Andrew Ozz e6fe8c83a3 Tab indexes: when tabbing out of the editors make sure the next focused element is the expected/default action, fix focusing the next field when picking a date for future post, props lessbloat, fixes #21340
git-svn-id: http://core.svn.wordpress.org/trunk@22250 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-16 21:38:35 +00:00
Daryl Koopersmith 1deab58658 Use the new media modal to insert galleries into TinyMCE and the text editor.
'''Galleries'''

* Gallery insertion from the new media modal (into TinyMCE, the text editor, etc).
* Gallery previews in TinyMCE now use the `wp.mce.views` API.
* Disables the TinyMCE `wpgallery` plugin.
* Gallery previews consist of the first image of the gallery and the appearance of a stack. This will later be fleshed out to include more images/functionality (including editing the gallery, gallery properties, and showing the number of images in the gallery).
* Multiple galleries can be added to a single post.
* The gallery MCE view provides a bridge between the `wp.shortcode` and `Attachments` representation of a gallery, which allows the existing collection to persist when a gallery is initially created (preventing a request to the server for the query).


'''Shortcodes'''

* Renames `wp.shortcode.Match` to `wp.shortcode` to better expose the shortcode constructor.
* The `wp.shortcode` constructor now accepts an object of options instead of a `wp.shortcode.regexp()` match.
* A `wp.shortcode` instance can be created from a `wp.shortcode.regexp()` match by calling `wp.shortcode.fromMatch( match )`.
* Adds `wp.shortcode.string()`, which takes a set of shortcode parameters and converts them into a string.* Renames `wp.shortcode.prototype.text()` to `wp.shortcode.prototype.string()`.
* Adds an additional capture group to `wp.shortcode.regexp()` that records whether or not the shortcode has a closing tag. This allows us to improve the accuracy of the syntax used when transforming a shortcode object back into a string.

'''Media Models'''

* Prevents media `Query` models from observing the central `Attachments.all` object when query args without corresponding filters are set (otherwise, queries quickly amass false positives).
* Adds `post__in`, `post__not_in`, and `post_parent` as acceptable JS attachment `Query` args.
* `Attachments.more()` always returns a `$.promise` object.

see #21390, #21809, #21812, #21815, #21817.


git-svn-id: http://core.svn.wordpress.org/trunk@22120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-05 04:23:59 +00:00
Andrew Ozz 3c6ef163d6 Fix background on split buttons, remove redundant !important, remove spacers, a little css cleanup, see #18141
git-svn-id: http://core.svn.wordpress.org/trunk@22025 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-27 00:41:49 +00:00
Andrew Nacin 1acd8b556f New HiDPI spinner. Uses clean <span class="spinner"></span> markup.
Be on the lookout for weirdness.
props lessbloat. see #21456.



git-svn-id: http://core.svn.wordpress.org/trunk@22019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-26 19:57:44 +00:00
Daryl Koopersmith 67708a3d8b First pass on TinyMCE attachment in-editor UI.
* Adds in-editor UI for image attachments. Most of this UI should be able to migrate to all images in a future commit.
* Removes the wpeditimage TinyMCE plugin from the default plugins array.
* Add `wp.media.fit`, a helper method to constrain dimensions based upon a maximum width and/or height.
* Add html attribute parsing and string generation utilities (currently stored in mce-views).
* Calling `remove` on a TinyMCE views now ensures that the the parent and references are removed as well.
* Fixes a bug where we weren't sending the full array of results to matches in wp.mce.view.

see #21390, #21812, #21813.



git-svn-id: http://core.svn.wordpress.org/trunk@22012 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-26 14:12:54 +00:00
Andrew Ozz 563c7caac5 Main editor: maintain the height when switching Visual to Text and back, save the height when resizing as user state, output the height in the textarea tag when loading, (thanks @nacin for the help), fixes #21718
git-svn-id: http://core.svn.wordpress.org/trunk@22007 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-26 03:30:21 +00:00
Daryl Koopersmith cd5f64584e Makes custom TinyMCE views easier to implement.
For details and examples, see the ticket.

props azaozz, fixes #21812.


git-svn-id: http://core.svn.wordpress.org/trunk@21961 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-24 00:13:18 +00:00
Andrew Ozz b9d4bd8382 Switch TinyMCE's schema to 'html5', add 'autofocus' to the attributes map for <input>, part props SergeyBiryukov, fixes #13314
git-svn-id: http://core.svn.wordpress.org/trunk@21875 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-16 21:20:35 +00:00
Ryan Boren cfb35a9d85 Use get_post() instead of global $post.
Make the $post argument to get_post() optional, defaulting to the current post in The Loop.

Props nacin
see #21309


git-svn-id: http://core.svn.wordpress.org/trunk@21735 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-04 16:29:28 +00:00
Ryan Boren c55cf716da Use set_url_scheme(). Props johnbillion, MarcusPope. see #19037 #20759
git-svn-id: http://core.svn.wordpress.org/trunk@21664 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-30 13:33:00 +00:00
Andrew Ozz d2f6b4559f Disable the (fake) image resizing in WebKit and Opera in TinyMCE 3.5.6, fix dragging image with caption in Firefox, see #21173
git-svn-id: http://core.svn.wordpress.org/trunk@21576 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-22 01:47:53 +00:00
azaozz 49c29501ef Add translation context for the Text editor tab name, props obenland, fixes #20993
git-svn-id: http://core.svn.wordpress.org/trunk@21417 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-03 21:08:52 +00:00