Andrew Ozz
cefaaa0b51
Privacy: add `esc_html` to assertion in test_wp_comments_personal_data_exporter.
...
Props mermel, 1naveengiri.
Fixes #44113 .
Built from https://develop.svn.wordpress.org/trunk@43371
git-svn-id: http://core.svn.wordpress.org/trunk@43199 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:40:21 +00:00
Andrew Ozz
b363ace996
Privacy: do not show the comment cookies opt-in checkbox (on the front-end comments form) when comment cookies are disabled.
...
Props felipeelia, johnbillion.
Fixes #44342 .
Built from https://develop.svn.wordpress.org/trunk@43370
git-svn-id: http://core.svn.wordpress.org/trunk@43198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:39:57 +00:00
John Blackbourn
ef97b99f66
Build/Test Tools: Introduce support for a `WP_TESTS_CONFIG_FILE_PATH` constant to override the test suite config file location.
...
This can be used in phpunit.xml:
{{{
<php>
<const name="WP_TESTS_CONFIG_FILE_PATH" value="/path/to/wp-tests-config.php" />
</php>
}}}
Props clarinetlord
Fixes #39734
Built from https://develop.svn.wordpress.org/trunk@43369
git-svn-id: http://core.svn.wordpress.org/trunk@43197 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:39:31 +00:00
John Blackbourn
0aa2902436
Security: Harden the random aspect of the hash used for user profile and admin email address changes.
...
Props BjornW
Fixes #43771
Built from https://develop.svn.wordpress.org/trunk@43367
git-svn-id: http://core.svn.wordpress.org/trunk@43195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:38:43 +00:00
John Blackbourn
35ca5f61f8
Options, Meta APIs: Use the correct escaping function when outputting the meta box context.
...
Props khaihong, abdullahramzan, leanderiversen, aryamaaru, lbenicio, palmiak
Fixes #44274
Built from https://develop.svn.wordpress.org/trunk@43365
git-svn-id: http://core.svn.wordpress.org/trunk@43193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:37:51 +00:00
Sergey Biryukov
593848e9dc
Docs: Correct inline comment added in [43361] for consistency with other comments.
...
See #44142 .
Built from https://develop.svn.wordpress.org/trunk@43363
git-svn-id: http://core.svn.wordpress.org/trunk@43191 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:37:00 +00:00
Sergey Biryukov
d35f9813f1
Docs: Add missing `@return` value for `save_mod_rewrite_rules()` and `iis7_save_url_rewrite_rules()`.
...
See #44142 .
Built from https://develop.svn.wordpress.org/trunk@43362
git-svn-id: http://core.svn.wordpress.org/trunk@43190 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:36:35 +00:00
Sergey Biryukov
40cfcfc222
Privacy: Make sure `wp_add_privacy_policy_content()` does not cause a fatal error by unintentionally flushing rewrite rules outside of the admin context.
...
Add a `_doing_it_wrong()` message describing the correct usage of the function.
Props kraftbj, azaozz, SergeyBiryukov, YuriV.
Fixes #44142 .
Built from https://develop.svn.wordpress.org/trunk@43361
git-svn-id: http://core.svn.wordpress.org/trunk@43189 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:36:09 +00:00
atimmer
96bfb67e79
Docs: Improve JSDoc for `emoji.js`.
...
Props lisannekluitmans, hansjovisyoast, igorsch, nicollle.
Fixes #44367 .
Built from https://develop.svn.wordpress.org/trunk@43360
git-svn-id: http://core.svn.wordpress.org/trunk@43188 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:35:44 +00:00
John Blackbourn
649a95f840
I18N: Introduce unit tests for the Japanese language in order to facilitate future improvements.
...
Props ryotsun
Fixes #43829
Built from https://develop.svn.wordpress.org/trunk@43359
git-svn-id: http://core.svn.wordpress.org/trunk@43187 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:35:20 +00:00
Sergey Biryukov
66fa722850
Docs: Update `@since` versions in Community Events class added in [42726].
...
See #41112 .
Built from https://develop.svn.wordpress.org/trunk@43356
git-svn-id: http://core.svn.wordpress.org/trunk@43184 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:34:04 +00:00
atimmer
d9df5dec11
Docs: Improve JSDoc for `auth-check.js`.
...
Props pskli.
Fixes #44364 .
Built from https://develop.svn.wordpress.org/trunk@43355
git-svn-id: http://core.svn.wordpress.org/trunk@43183 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:33:38 +00:00
Sergey Biryukov
33c708feca
Privacy: Remove unnecessary `This email has been sent to ###EMAIL###` from privacy emails.
...
The line was copied from the emails that get sent when an email address changes, without considering if it made sense in the new context.
Props iandunn, ianbelanger, desrosj.
Fixes #44030 .
Built from https://develop.svn.wordpress.org/trunk@43353
git-svn-id: http://core.svn.wordpress.org/trunk@43181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:32:48 +00:00
atimmer
f74a52b0f2
Docs: Improve JSDoc for `admin/link.js`.
...
Props andg.
Fixes #44362 .
Built from https://develop.svn.wordpress.org/trunk@43352
git-svn-id: http://core.svn.wordpress.org/trunk@43180 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:32:22 +00:00
Sergey Biryukov
947a12f2b2
Privacy: Fix typo in default privacy policy text.
...
Props garetharnold, abdullahramzan.
Fixes #44166 .
Built from https://develop.svn.wordpress.org/trunk@43350
git-svn-id: http://core.svn.wordpress.org/trunk@43178 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:31:31 +00:00
jrf
a4f7f70c9d
Build/Tools: Update PHPCS ruleset for WP Core and related Composer setup.
...
`.gitignore` + `svn:ignore`:
* Add the typical filenames of overloaded PHPCS configs to `.gitignore`.
Composer:
* Use the `develop` (Packagist `dev-master`) version of WPCS as it contains lots of bugfixes.
* Remove the PHPCS dependency. This is a dependency of WPCS, not of WP Core itself. This will also make sure that the PHPCS version used is always one which is supported by WPCS.
* Refreshed the `composer.lock` file.
PHPCS ruleset:
* Removed a reference to a sniff which doesn't exist in WPCS yet.
* Use the PHPCS 3.x `basepath` option to clean up the file paths PHPCS shows in the reports.
* Use the PHPCS 3.x `parallel` option to enable parallel scanning whenever possible to speed up the scans.
* Whitelist the `wp-includes/l10n.php` file from issues being reported by the `WordPress.WP.I18n` sniff.
Fixes #44366 .
Built from https://develop.svn.wordpress.org/trunk@43348
git-svn-id: http://core.svn.wordpress.org/trunk@43176 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:30:40 +00:00
atimmer
bde558be2f
Docs: Add file doc `@output` annotations.
...
These annotations make it clear to the reader of a JavaScript source
where the build process outputs to. These annotations can later be
integrated in a webpack configuration. This way there is one source of
truth.
The `build` folder is omitted from the paths, because a single JS file
shouldn't not be responsible of knowing where outputs in general will
end up at. A file only knows its output location relative to the
project.
Props adamsilverstein, herregroen, omarreiss, pento.
Fixes #44361 .
Built from https://develop.svn.wordpress.org/trunk@43347
git-svn-id: http://core.svn.wordpress.org/trunk@43175 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:30:15 +00:00
atimmer
6a9a5e123c
Docs: Improve JSDoc for `pointer.js`.
...
Props maartenleenders, dfangstrom.
Fixes #44325 .
Built from https://develop.svn.wordpress.org/trunk@43346
git-svn-id: http://core.svn.wordpress.org/trunk@43174 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:29:48 +00:00
Sergey Biryukov
6172dab7c1
I18N: Remove unused MediaElement.js strings.
...
Props metodiew.
See #42139 . Fixes #37453 .
Built from https://develop.svn.wordpress.org/trunk@43345
git-svn-id: http://core.svn.wordpress.org/trunk@43173 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:29:24 +00:00
atimmer
dbf155d93b
Build Tools: Fix JSDoc configuration include paths.
...
After [43309] the JSDoc configuration was broken, this fixes that.
Props herregroen.
Built from https://develop.svn.wordpress.org/trunk@43344
git-svn-id: http://core.svn.wordpress.org/trunk@43172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:28:58 +00:00
Weston Ruter
8f21b4c607
Privacy: Only link to menus panel in Customizer if selected privacy page can be accessed there.
...
Props dlh.
Fixes #44117 .
Built from https://develop.svn.wordpress.org/trunk@43343
git-svn-id: http://core.svn.wordpress.org/trunk@43171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:28:33 +00:00
atimmer
ba9e0ac030
Docs: Improve JSDoc for `admin-bar.js`.
...
Change an incorrect type and description after [43332].
Props afercia.
See #43871 .
Built from https://develop.svn.wordpress.org/trunk@43341
git-svn-id: http://core.svn.wordpress.org/trunk@43169 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:27:38 +00:00
Felix Arntz
a449ac386e
REST API: Improve test coverage by providing tests for term meta.
...
See #38323 .
Built from https://develop.svn.wordpress.org/trunk@43340
git-svn-id: http://core.svn.wordpress.org/trunk@43168 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:27:12 +00:00
Felix Arntz
07e121126d
Tests: Improve performance of post meta tests.
...
See #38323 .
Built from https://develop.svn.wordpress.org/trunk@43339
git-svn-id: http://core.svn.wordpress.org/trunk@43167 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:26:48 +00:00
Andrew Ozz
06725cf28d
Move scheduling of old `auto-draft` posts deletion to `get_default_post_to_edit()` (where auto-drafts are created).
...
Fixes #44337 .
Built from https://develop.svn.wordpress.org/trunk@43338
git-svn-id: http://core.svn.wordpress.org/trunk@43166 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:26:22 +00:00
Andrew Ozz
679f442285
TinyMCE: do not force-load external plugins, not needed any more and may cause issues.
...
Fixes #44330 .
Built from https://develop.svn.wordpress.org/trunk@43337
git-svn-id: http://core.svn.wordpress.org/trunk@43165 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:25:57 +00:00
Andrew Ozz
62bb0dcafd
TinyMCE: prevent creation of paragraphs from multiple HTML comments when `wpautop` is disabled.
...
Fixes #44308 .
Built from https://develop.svn.wordpress.org/trunk@43336
git-svn-id: http://core.svn.wordpress.org/trunk@43164 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:25:32 +00:00
Jeremy Felt
1b263de2d6
Build/Test Tools: Avoid running full PHPUnit test suite for every PHP file change.
...
Use `grunt watch --phpunit --group={testgroup}` to start `grunt watch` with a specific test group so that PHP file changes trigger a limited number of tests.
Props jeremyfelt, birgire for testing.
Fixes #44240 .
Built from https://develop.svn.wordpress.org/trunk@43335
git-svn-id: http://core.svn.wordpress.org/trunk@43163 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:25:08 +00:00
atimmer
8a9dc11590
Docs: Improve JSDoc for `language-chooser.js`.
...
Props ireneyoast, manuelaugustin.
Fixes #43950 .
Built from https://develop.svn.wordpress.org/trunk@43334
git-svn-id: http://core.svn.wordpress.org/trunk@43162 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:24:43 +00:00
atimmer
7c410b8d37
Docs: Improve JSDoc for `zxcvbn-async.js`.
...
Props manuelaugustin, igorsch, LisanneKluitmans.
Fixes 43948.
Built from https://develop.svn.wordpress.org/trunk@43333
git-svn-id: http://core.svn.wordpress.org/trunk@43161 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:24:18 +00:00
atimmer
e6c02f874c
Docs: Improve JSDoc for `admin-bar.js`.
...
Props manuelaugustin, terwdan, sjardo, LisanneKluitmans.
Fixes #43871 .
Built from https://develop.svn.wordpress.org/trunk@43332
git-svn-id: http://core.svn.wordpress.org/trunk@43160 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:23:53 +00:00
Sergey Biryukov
e0e564d84b
Users: In `wp_validate_user_request_key()`, properly return the `WP_Error` object in case the confirmation email has expired.
...
Props itowhid06.
Fixes #44298 .
Built from https://develop.svn.wordpress.org/trunk@43331
git-svn-id: http://core.svn.wordpress.org/trunk@43159 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:23:27 +00:00
Sergey Biryukov
9ba957770e
Docs: Remove obsolete `$wpdb` global references in `WP_User::__construct()` and `WP_User::for_blog()`.
...
Props mt8.biz.
Fixes #44295 .
Built from https://develop.svn.wordpress.org/trunk@43330
git-svn-id: http://core.svn.wordpress.org/trunk@43158 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:23:02 +00:00
Gary Pendergast
fa5cf0a7d6
Build Tools: `grunt build` should only copy Core files.
...
Historically, `grunt build` has copied all files from the `src` directory to the `build` directory. This is usually fine, but can be super slow when there are lots of custom plugins or themes in the `src` directory.
To rectify this, we now only copy Core plugins and themes to `build`.
Props adamsilverstein, pento, johnbillion.
Fixes #44256 .
Built from https://develop.svn.wordpress.org/trunk@43329
git-svn-id: http://core.svn.wordpress.org/trunk@43157 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:22:36 +00:00
Sergey Biryukov
9115444ee7
Build/Test Tools: Replace Codex home page link in "Read more about setting up your local development environment" with a more specific handbook link.
...
Props abdullahramzan, johnbillion.
Fixes #44228 .
Built from https://develop.svn.wordpress.org/trunk@43328
git-svn-id: http://core.svn.wordpress.org/trunk@43156 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:22:11 +00:00
Andrew Ozz
ab65b61da9
Build tools: Grunt:
...
- Normalize `filepath` in the the `watch` event.
- Throw a warning when `watch` fails to process a file because the destination path cannot be determined.
Fixes #44262 .
Built from https://develop.svn.wordpress.org/trunk@43327
git-svn-id: http://core.svn.wordpress.org/trunk@43155 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:21:45 +00:00
Jeremy Felt
3ab90ab858
Docs: Document globals in validate_another_blog_signup().
...
Props mukesh27.
Fixes #43594 .
Built from https://develop.svn.wordpress.org/trunk@43326
git-svn-id: http://core.svn.wordpress.org/trunk@43154 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:21:21 +00:00
Sergey Biryukov
dde7843f7e
Docs: Fix typo in `Services_JSON` DocBlocks.
...
Props sagarnasit.
Fixes #44244 .
Built from https://develop.svn.wordpress.org/trunk@43325
git-svn-id: http://core.svn.wordpress.org/trunk@43153 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:20:54 +00:00
Jeremy Felt
c3b788a205
Built/Test Tools: Increase grunt watch interval on all files.
...
Significantly reduces Grunt's CPU usage when `grunt watch` is in an idle/watching state.
Props netweb.
Fixes #44241 .
Built from https://develop.svn.wordpress.org/trunk@43324
git-svn-id: http://core.svn.wordpress.org/trunk@43152 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:20:23 +00:00
Andrew Ozz
facf027fe7
Build tools: Update Grunt to version 1.0.2.
...
Props iandunn, netweb.
Fixes #42308 .
Built from https://develop.svn.wordpress.org/trunk@43323
git-svn-id: http://core.svn.wordpress.org/trunk@43151 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:19:59 +00:00
Andrew Ozz
87d1a3222b
Build tools:
...
- Remove `check-node-version` from package.json for now. Throws errors.
- Minor fixes to package-lock.json, `http` => `https`.
See #44246 .
Built from https://develop.svn.wordpress.org/trunk@43322
git-svn-id: http://core.svn.wordpress.org/trunk@43150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:19:33 +00:00
Andrew Ozz
6fd8080e7e
Build tools: Use npm v6.1.0.
...
Props netweb.
Fixes #44245 .
Built from https://develop.svn.wordpress.org/trunk@43320
git-svn-id: http://core.svn.wordpress.org/trunk@43149 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-27 16:01:23 +00:00
Sergey Biryukov
dd185824cd
Docs: Fix typo in `_walk_bookmarks()` DocBlock.
...
Props abhijitrakas.
Fixes #44242 .
Built from https://develop.svn.wordpress.org/trunk@43319
git-svn-id: http://core.svn.wordpress.org/trunk@43148 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-27 08:36:23 +00:00
Sergey Biryukov
0ff5536bac
Posts, Post Types: Use `COOKIEPATH` when clearing post password cookie, as that's the path it's created with.
...
See #44089 .
Built from https://develop.svn.wordpress.org/trunk@43318
git-svn-id: http://core.svn.wordpress.org/trunk@43147 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-27 01:33:22 +00:00
Sergey Biryukov
a724d77a4e
Posts, Post Types: Clear post password cookie when logging out.
...
Props skoldin, subrataemfluence, ianbelanger, johnbillion.
Fixes #44089 .
Built from https://develop.svn.wordpress.org/trunk@43317
git-svn-id: http://core.svn.wordpress.org/trunk@43146 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-26 12:43:23 +00:00
John Blackbourn
e4b0a8d511
Build/Test Tools: Allow the unit test framework to be used without the data directory in place.
...
Fixes #43982
Built from https://develop.svn.wordpress.org/trunk@43315
git-svn-id: http://core.svn.wordpress.org/trunk@43144 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-25 22:43:26 +00:00
Boone Gorges
ecb4491670
Taxonomy: Improve cache handling when querying for terms using `all_with_object_id`.
...
When a term query using `fields=all_with_object_id` hits the cache, the
cached `stdClass` objects must be converted to `WP_Term` objects. This
was overlooked when `WP_Term_Query` was refactored to support object
queries in [38667].
Props dlh.
Fixes #44221 .
Built from https://develop.svn.wordpress.org/trunk@43313
git-svn-id: http://core.svn.wordpress.org/trunk@43142 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-25 01:23:23 +00:00
Gary Pendergast
c5d5629471
Tools: Update `wp-cli.yml` to point to the `build` directory.
...
After [43309], WP-CLI should be running against the `build` directory, not the `src` directory.
Props jpry.
Fixes #44214 .
Built from https://develop.svn.wordpress.org/trunk@43312
git-svn-id: http://core.svn.wordpress.org/trunk@43141 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-25 00:15:23 +00:00
John Blackbourn
f57e182c87
Build/Test Tools: Roses are red, this fixes stuff.
...
Update the test infrastructure so that third party plugins, themes, and projects that use the core testing framework continue to operate from the `src` directory and do not require a build step.
Props mboynes, danielbachhuber, schlessera
See #43055
Built from https://develop.svn.wordpress.org/trunk@43311
git-svn-id: http://core.svn.wordpress.org/trunk@43140 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-23 17:55:22 +00:00
Gary Pendergast
54f004e184
Following [43309], I need to change one little line,
...
And delete some left over cruft, only then shall we prevail.
There are some things easily missed, when using Git, which does not persist—
Empty directories, though that didn't derail—
Our Travis-based tests, which now must prevail.
Quoth Travis CI, “Build did fail.”
See #43055 .
Built from https://develop.svn.wordpress.org/trunk@43310
git-svn-id: http://core.svn.wordpress.org/trunk@43139 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-23 11:03:24 +00:00