Commit Graph

360 Commits

Author SHA1 Message Date
Scott Taylor 0ba605c55c Ensure that a `has_children` parameter is given to `Walker::start_el()`.
Adds unit tests.

Props scribu, obenland.
Fixes #14041.

Built from https://develop.svn.wordpress.org/trunk@28824


git-svn-id: http://core.svn.wordpress.org/trunk@28628 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-24 17:06:14 +00:00
Scott Taylor 919ff69120 In `comment_form()`, allow `name_submit` to be passed to change the `name` attribute of the submit button.
Props obenland.
Fixes #22792.

Built from https://develop.svn.wordpress.org/trunk@28813


git-svn-id: http://core.svn.wordpress.org/trunk@28620 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-24 00:10:15 +00:00
Drew Jaynes 3724252959 Ensure `$post_id` is documented as optional where applicable.
See #28388.

Built from https://develop.svn.wordpress.org/trunk@28654


git-svn-id: http://core.svn.wordpress.org/trunk@28472 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-03 04:44:16 +00:00
Scott Taylor 2d6721dbc9 Fix an error caused by [28604] in `get_comments_number()` unit tests.
Props SergeyBiryukov.
Fixes #26240.


Built from https://develop.svn.wordpress.org/trunk@28638


git-svn-id: http://core.svn.wordpress.org/trunk@28456 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-30 19:47:14 +00:00
Dominik Schilling d40280d0db Pass `$post->ID` to `get_comments_number` filter.
Also fixes indentation and a typo in corresponding filter docs.

see #26240.
Built from https://develop.svn.wordpress.org/trunk@28604


git-svn-id: http://core.svn.wordpress.org/trunk@28428 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-28 22:36:15 +00:00
Drew Jaynes 6989c5ab46 Fix parameter description for the `$post_id` argument in `get_comments_number()` to note that it is optional.
Also fixes the corresponding filter docs, as `$post_id`, not `$post` is passed to the filter.

See [27156]. Fixes #26240.

Built from https://develop.svn.wordpress.org/trunk@28602


git-svn-id: http://core.svn.wordpress.org/trunk@28427 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-28 22:05:18 +00:00
Scott Taylor b75c79500b Replaces all uses of `TEMPLATEPATH` and `STYLESHEETPATH` in core with `get_template_directory()` and `get_stylesheet_directory()`.
Add `@deprecated` annotations to `TEMPLATEPATH` and `STYLESHEETPATH` definitions.

Props obenland, aaroncampbell. 
Fixes #18298.

Built from https://develop.svn.wordpress.org/trunk@28563


git-svn-id: http://core.svn.wordpress.org/trunk@28389 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-23 20:12:15 +00:00
Scott Taylor e8181b0934 Allow `get_comments_number()` to officially accept `$post` or `$post_id`. Adds unit tests.
Props coffee2code, JanHenkG.
Fixes #26240.

Built from https://develop.svn.wordpress.org/trunk@28558


git-svn-id: http://core.svn.wordpress.org/trunk@28384 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-23 17:44:14 +00:00
Scott Taylor dfa4de15fa Add missing access modifiers to methods/members in `Walker` and subclasses. Add a magic `__get()` method.
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28514


git-svn-id: http://core.svn.wordpress.org/trunk@28340 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 06:00:15 +00:00
Scott Taylor 78b6f2761d Eliminate use of `extract()` in `get_comment_reply_link()`.
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28431


git-svn-id: http://core.svn.wordpress.org/trunk@28258 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 15:35:15 +00:00
Scott Taylor 7943f4715a Eliminate the use of `extract()` in `get_post_reply_link()`.
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28429


git-svn-id: http://core.svn.wordpress.org/trunk@28256 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 06:49:14 +00:00
Scott Taylor 0e2909ce89 Eliminate the use of `extract()` in `wp_list_comments()`. All unit tests pass.
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28428


git-svn-id: http://core.svn.wordpress.org/trunk@28255 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 06:43:15 +00:00
Scott Taylor de262f553c In `wp-includes/comment-template.php`, remove dead code:
* In `get_comment_reply_link()`, `$link` is set twice before it is used.
* In `Walker_Comment::start_lvl()`, `case 'ul':` is unreachable unless placed before `default:`. 
* In `Walker_Comment::end_lvl()`, `case 'ul':` is unreachable unless placed before `default:`.
* In `comment_form()`, `$id` is conditionally set and never used. 

See #27882.


Built from https://develop.svn.wordpress.org/trunk@28323


git-svn-id: http://core.svn.wordpress.org/trunk@28151 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 21:15:17 +00:00
Sergey Biryukov d70e8a38fa Add a filter for wp_list_comments() arguments.
props greenshady, hlashbrooke.
fixes #19581.
Built from https://develop.svn.wordpress.org/trunk@28285


git-svn-id: http://core.svn.wordpress.org/trunk@28113 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 11:58:14 +00:00
Drew Jaynes 5e51ea9940 Priority fixes for various existing hook documentation.
Props kpdesign.
See #26869

Built from https://develop.svn.wordpress.org/trunk@28083


git-svn-id: http://core.svn.wordpress.org/trunk@27914 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-12 00:01:15 +00:00
Drew Jaynes acf9fbc808 Remove a blank line and @global reference in the PHPDoc for `comment_author_email_link()`.
Props norcross, ocean90.
Fixes #27655.

Built from https://develop.svn.wordpress.org/trunk@27943


git-svn-id: http://core.svn.wordpress.org/trunk@27773 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-04 04:36:15 +00:00
Andrew Nacin 502ac958e5 Pass walker arguments to get_comment_link() so pagination works when wp_list_comments() is used outside the comment template.
props SergeyBiryukov.
fixes #27007.

Built from https://develop.svn.wordpress.org/trunk@27799


git-svn-id: http://core.svn.wordpress.org/trunk@27634 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-28 02:38:14 +00:00
Sergey Biryukov 8343fabff6 Avoid a notice in trackback_rdf() if user agent is not set.
props joostdevalk.
fixes #27374.
Built from https://develop.svn.wordpress.org/trunk@27514


git-svn-id: http://core.svn.wordpress.org/trunk@27357 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-12 12:54:15 +00:00
Andrew Nacin 1699153d26 Pass the comment object to the get_comment_date and get_comment_time.
props SergeyBiryukov.
fixes #19849.

Built from https://develop.svn.wordpress.org/trunk@27283


git-svn-id: http://core.svn.wordpress.org/trunk@27139 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-26 16:41:14 +00:00
Drew Jaynes cb8951b0b3 Remove all `@package` and `@subpackage` PHPDoc tags not at the file- or class-levels in core.
See #27200.

Built from https://develop.svn.wordpress.org/trunk@27262


git-svn-id: http://core.svn.wordpress.org/trunk@27119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-25 17:14:14 +00:00
Drew Jaynes c8665c5973 Fix a typo in the PHPDoc for `comment_author_email_link()`.
See #27083.

Built from https://develop.svn.wordpress.org/trunk@27157


git-svn-id: http://core.svn.wordpress.org/trunk@27023 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-10 04:07:12 +00:00
Drew Jaynes 8eb2d3610b Inline documentation cleanup in wp-includes/comment-template.php.
This cleanup follows [25567] and brings the docs in-line with standards that at the time had not yet been finalized.

These changes include
* Moving in-line `@see` tags to their own lines
* Using docs-specific variables in hook docs
* Fixing line-wrapping throughout
* Typos and punctuation
* Converting hash notation values to variables per the standard

Fixes #27083. See #20495.

Built from https://develop.svn.wordpress.org/trunk@27156


git-svn-id: http://core.svn.wordpress.org/trunk@27022 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-10 03:20:12 +00:00
Drew Jaynes cd8cedc40d First there were two, and now there are three -- in the @since versions that came before and that shall be. And so it will be, says nacin.
Props JustinSainton, SergeyBiryukov, DrewAPicture.
Fixes #26713.

Built from https://develop.svn.wordpress.org/trunk@26868


git-svn-id: http://core.svn.wordpress.org/trunk@26754 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-24 18:57:12 +00:00
Andrew Nacin 808653e2a3 Add echo arguments to wp_list_comments() and Walker_Comment, allowing non-echo usage.
props mikelittle.
fixes #10948.

Built from https://develop.svn.wordpress.org/trunk@26353


git-svn-id: http://core.svn.wordpress.org/trunk@26254 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-24 14:59:10 +00:00
Andrew Nacin d0cfa40983 Add jshintrc to qunit.
props jorbin.
see #25187.

Built from https://develop.svn.wordpress.org/trunk@25992


git-svn-id: http://core.svn.wordpress.org/trunk@25925 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-30 14:39:10 +00:00
Drew Jaynes 15fb059069 Inline documentation for the Walker_Comment class in wp-includes/comment-template.php
Fixes #25388.

Built from https://develop.svn.wordpress.org/trunk@25588


git-svn-id: http://core.svn.wordpress.org/trunk@25505 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-23 23:29:11 +00:00
Drew Jaynes 681b1c35b5 Inline documentation for hooks in wp-includes/comment-template.php.
Fixes #25396.

Built from https://develop.svn.wordpress.org/trunk@25584


git-svn-id: http://core.svn.wordpress.org/trunk@25501 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-23 21:21:09 +00:00
Drew Jaynes 731db6bcb5 Inline documentation for `comment_form()` argument defaults missed in [25573].
See #25388.

Built from https://develop.svn.wordpress.org/trunk@25575


git-svn-id: http://core.svn.wordpress.org/trunk@25492 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-23 17:30:08 +00:00
Drew Jaynes fe40604971 Improve inline documentation of arguments for `comment_form()`.
See #25388.

Built from https://develop.svn.wordpress.org/trunk@25573


git-svn-id: http://core.svn.wordpress.org/trunk@25490 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-23 17:16:08 +00:00
Drew Jaynes e4987beba3 Inline documentation improvements for wp-includes/comment-template.php.
Changes include:
- Existing phpdoc block improvements
- Inclusion of defaults for optional parameters
- Hash-notated argument arrays
- Removal of unnecessary or redundant tagging.

Also standardization of int|WP_Post function parameters.

These changes clear the way toward less redundancy for hook docs in a future ticket.

Still left: Fully documented arguments in `comment_form()` and a pass through Walker_Comment.

See #20495. See #25388.

Built from https://develop.svn.wordpress.org/trunk@25567


git-svn-id: http://core.svn.wordpress.org/trunk@25485 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-23 04:16:08 +00:00
Dominik Schilling 8546983da6 Replace !$user_ID with !is_user_logged_in(). props garyc40. see #15508.
Built from https://develop.svn.wordpress.org/trunk@25562


git-svn-id: http://core.svn.wordpress.org/trunk@25480 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-22 10:16:09 +00:00
Scott Taylor 11db0d3b01 Add an `$args` parameter to `comment_text` and `get_comment_text` filters. Adds filter docs. Improve docblocks for `get_comment_text()` and `comment_text()`.
Props simonwheatley, ericlewis, DrewAPicture.
Fixes #14856. 


Built from https://develop.svn.wordpress.org/trunk@25555


git-svn-id: http://core.svn.wordpress.org/trunk@25475 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-21 18:18:09 +00:00
Drew Jaynes 98d5c50e5f Clarify phpdoc for `get_comment_author_link()`.
props nofearinc. Fixes #24508.

Built from https://develop.svn.wordpress.org/trunk@25494


git-svn-id: http://core.svn.wordpress.org/trunk@25415 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-19 05:56:10 +00:00
Sergey Biryukov 7407bd1946 Inline documentation for get_comment_reply_link() and 'comment_reply_link' filter.
props DrewAPicture.
fixes #25310.
Built from https://develop.svn.wordpress.org/trunk@25428


git-svn-id: http://core.svn.wordpress.org/trunk@25352 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-13 19:20:09 +00:00
Sergey Biryukov 9e9b9b5508 Make sure $args is an array before treating it as such. fixes #25151 for trunk.
Built from https://develop.svn.wordpress.org/trunk@25151


git-svn-id: http://core.svn.wordpress.org/trunk@25130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-28 05:28:09 +00:00
Andrew Nacin e01352fe2f Ensure a user exists in get_comment_author().
props azaozz.
see #24084.

Built from https://develop.svn.wordpress.org/trunk@25136


git-svn-id: http://core.svn.wordpress.org/trunk@25116 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-27 13:17:09 +00:00
Andrew Nacin 71af3a2004 Remove pattern="" in the comment form (HTML5 mode) to avoid mistaken :invalid styles.
This was originally included for Opera 10, but is not needed as of Opera 11, and current is Opera 15.

props jorbin, markjaquith.
fixes #24475.



git-svn-id: http://core.svn.wordpress.org/trunk@24573 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-05 21:59:10 +00:00
Dominik Schilling f27e762085 Replace the `cite` element with a `b` element to markup the comment author in comment_html5().
In HTML5 the `cite` element isn't valid for just an author's name.
"The cite element represents the title of a work [..] A person's name is not the title of a work" (http://www.w3.org/TR/html5/text-level-semantics.html#the-cite-element)

fixed #24522.

git-svn-id: http://core.svn.wordpress.org/trunk@24539 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-01 18:26:16 +00:00
Andrew Nacin ca1e73ca84 Comment form: Add HTML classes.
* #respond gains .comment-respond
 * #reply-title gains .comment-reply-titlw
 * form gains .comment-form

props obenland.
see #23851.



git-svn-id: http://core.svn.wordpress.org/trunk@24525 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-06-27 21:18:08 +00:00
Andrew Nacin 5969819038 `add_theme_support( 'html5', array( 'comment-list', 'search-form', 'comment-form' ) );'
props obenland.
see #23850.



git-svn-id: http://core.svn.wordpress.org/trunk@24417 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-06-06 15:31:34 +00:00
Sergey Biryukov 4b13a1ffa4 Fix E_STRICT notices in walkers. props dvarga. see #24356.
git-svn-id: http://core.svn.wordpress.org/trunk@24377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-28 03:29:15 +00:00
Andrew Nacin 7cc15a2e7f Remove use of global $id from comment_form() and the media list table. see #24330.
git-svn-id: http://core.svn.wordpress.org/trunk@24337 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-23 18:40:16 +00:00
Sergey Biryukov 57c10eadbb Use ellipsis instead of three dots. props tjsingleton, jordie23, wojtek.szkutnik, DrewAPicture, SergeyBiryukov. see #8714.
git-svn-id: http://core.svn.wordpress.org/trunk@24207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-08 21:27:31 +00:00
Andrew Nacin 92b4636e17 Required arguments can't follow optional arguments.
Make required arguments optional in confirm_blog_signup().

Mark arguments as required in _future_post_hook(), the walker method display_element(), get_author_link() (deprecated), and the WP_Widget constructor.

props rlerdorf.
see #24210.



git-svn-id: http://core.svn.wordpress.org/trunk@24126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-29 13:26:31 +00:00
Sergey Biryukov 2c63da143b Fix inconsistent spacing in comment_form(). props sim, TravisHoffman. fixes #23878.
git-svn-id: http://core.svn.wordpress.org/trunk@23932 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-07 23:57:35 +00:00
Mark Jaquith b3f6427c6f Improve wp_list_comments() markup.
* Whitespace cleanup
* Accepts format=html5 which uses some of the HTML5 elements
* Some helpful HTML comments to help untangle the HTML
* Other misc code cleanup

props lancewillett, obenland, georgestephanis. fixes #20088.

git-svn-id: http://core.svn.wordpress.org/trunk@23694 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-14 04:26:04 +00:00
Mark Jaquith a1e32d3217 Add the ability to use HTML5 input types in the comment form.
props jorbin, georgestephanis, obenland. fixes #15080

git-svn-id: http://core.svn.wordpress.org/trunk@23689 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-13 20:31:43 +00:00
Andrew Nacin f994ff39ac Add filters to comments_link_feed(), comment_link(), and get_comments_link(). esc_url() the echoed output of comments_link().
props MarcusPope.
fixes #19210.



git-svn-id: http://core.svn.wordpress.org/trunk@23624 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-06 19:57:31 +00:00
Ryan Boren 3854fe2e0f Put required field indicators within labels. Update styling of bundled themes to accommodate. Props MikeHansenMe. fixes #21897
git-svn-id: http://core.svn.wordpress.org/trunk@22123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-05 16:34:32 +00:00
Ryan Boren 359de78b7d Avoid 'Only variables should be assigned by reference' warning. Props wonderboymusic. see #21865
git-svn-id: http://core.svn.wordpress.org/trunk@22115 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-04 18:26:25 +00:00
Ryan Boren faca571a3a Avoid 'Only variables should be assigned by reference' warning. Props wonderboymusic. see #21865
git-svn-id: http://core.svn.wordpress.org/trunk@22114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-04 18:21:47 +00:00
Ryan Boren cfb35a9d85 Use get_post() instead of global $post.
Make the $post argument to get_post() optional, defaulting to the current post in The Loop.

Props nacin
see #21309


git-svn-id: http://core.svn.wordpress.org/trunk@21735 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-04 16:29:28 +00:00
ryan 7b49ad8493 Introduce get_edit_user_link(). Props scribu, georgestephanis, johnbillion. fixes #14787 see #20307
git-svn-id: http://core.svn.wordpress.org/trunk@21364 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-30 18:30:03 +00:00
ryan 50fc51d8d2 Don't attempt to define the COMMENTS_TEMPLATE constant twice. Props kitchin. fixes #21337
git-svn-id: http://core.svn.wordpress.org/trunk@21330 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-25 17:54:35 +00:00
ryan ef95736bce Set the global comment var before invoking callbacks in wp_list_comments(). Props sirzooro. fixes #21184
git-svn-id: http://core.svn.wordpress.org/trunk@21324 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-25 16:27:48 +00:00
ryan 01dd4131b8 Don't allow unfiltered HTML comments from a frame. Props nacin. fixes #20812
git-svn-id: http://core.svn.wordpress.org/trunk@20974 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-01 20:47:08 +00:00
nacin 5ab06c336e In comment_form(), pass the $post_id to comments_open(). props insertvisionhere. fixes #20572.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20641 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-30 01:47:22 +00:00
ryan de41bc288b Introduce WP_User::exists(). see #20372
git-svn-id: http://svn.automattic.com/wordpress/trunk@20378 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-06 19:18:45 +00:00
ryan e3b46b25d3 Lose EOF ?>. Clean up EOF newlines. fixes #12307
git-svn-id: http://svn.automattic.com/wordpress/trunk@19712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-08 17:01:11 +00:00
ryan 83b131f8e3 User lowercase true, false, null instead of uppercase. Props c3mdigital, mfields. fixes #16302
git-svn-id: http://svn.automattic.com/wordpress/trunk@19687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-05 20:50:54 +00:00
ryan fd1393ab7a Clear strict notices for the walkers. fixes #19249
git-svn-id: http://svn.automattic.com/wordpress/trunk@19679 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-04 23:03:46 +00:00
ryan 07ff8b216b Use one space, not two, after trailing punctuation. fixes #19537
git-svn-id: http://svn.automattic.com/wordpress/trunk@19593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-13 23:45:31 +00:00
nacin 30ff37104d Don't use $user_identity global. props duck_. fixes #19146.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19284 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-14 21:35:44 +00:00
duck_ e4ed63fc6f Fix typos in documentation (wp-includes/[a-h]). See #18560.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18633 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-03 16:02:41 +00:00
ryan 29592dafb6 Pass post id along to *comment_id_fields(). Props natecook. fixes #17193
git-svn-id: http://svn.automattic.com/wordpress/trunk@17812 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-05 19:33:47 +00:00
nacin e1eec3925a More @since. props SergeyBiryukov, fixes #15445.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-20 09:25:21 +00:00
westi e69d948ca4 Revert [16649] - The core output on this is for logged out users only - need to rework this if we want to move the output. See #14510
git-svn-id: http://svn.automattic.com/wordpress/trunk@16704 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-03 09:44:17 +00:00
ryan a031db170f Fix comment_notes_before. Props mrmist. fixes #14510
git-svn-id: http://svn.automattic.com/wordpress/trunk@16649 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-01 16:52:32 +00:00
nbachiyski 368eefd69c comments_number() doesn't need to call get_the_ID(), because get_comments_number() does it if post ID is missing
git-svn-id: http://svn.automattic.com/wordpress/trunk@16613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-29 17:34:43 +00:00
scribu 41592d266b Remove nofollow on comment reply links. Fixes #10550
git-svn-id: http://svn.automattic.com/wordpress/trunk@16230 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-07 01:06:37 +00:00
nacin 0552424317 Revert submit_button() for wp-includes, setup-config, install, login, signup. see [16061], see #15064, fixes #15247.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16066 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-29 00:31:27 +00:00
markjaquith fc6e89da45 Expand submit_button() capabilities. Replace all (or almost all) manual HTML instances in WP. props sbressler. see #15064
git-svn-id: http://svn.automattic.com/wordpress/trunk@16061 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-28 21:56:43 +00:00
nacin a07ec69bce Add a class to 'Your comment is awaiting moderation' in the comment walker and Twenty Ten's callback. fixes #15206.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16028 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-28 03:58:51 +00:00
nacin 76b4a3cac7 Pass comment ID from comment_text to get_comment_text. Also add the comment object as context to the filter. fixes #14261
git-svn-id: http://svn.automattic.com/wordpress/trunk@15957 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-25 03:11:01 +00:00
nacin 5a20c05d27 Phpdoc argument/@param cleanups. props duck_, see #14783.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-09-07 11:21:11 +00:00
nacin 650f97e684 Adjustments to [15549]. See #11624.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-09-04 15:51:04 +00:00
scribu 950901ca92 Don't use the global anymore. Fixes #11624
git-svn-id: http://svn.automattic.com/wordpress/trunk@15549 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-08-28 11:57:28 +00:00
westi 64100e8783 Fix the theme compat file require paths to be fully absolute so they don't rely on a particular php path to work. Fixes #14315 for trunk props dougal.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15433 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-07-16 09:40:09 +00:00
nacin 69b10a2948 Restore trackback_rdf(). reverts [13991]. fixes #11139 for trunk.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15363 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-07-03 05:55:04 +00:00
dd32 a14d289755 Alot more tabs. Props jacobsantos & Viper007bond. See #14147
git-svn-id: http://svn.automattic.com/wordpress/trunk@15355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-06-30 00:05:18 +00:00
nacin f60838c8f9 s/echos/echoes/ in phpdoc. props demetris, fixes #13742.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15148 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-06-06 05:16:32 +00:00
nacin 249a6cdd18 Use p instead of definition list for allowed tags in comment_form(). props demetris. Style the new markup in Twenty Ten. see #10910.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14689 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-16 06:38:58 +00:00
nacin a03dfef3fd Fix typos in phpdoc for comment_form(). props demetris, fixes #10910.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14538 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-10 08:47:13 +00:00
ryan 7b7243d94a Strip trailing whites.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14404 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-03 20:26:11 +00:00
nbachiyski 2a1d6e141b Take out the leading space from the translatable string
git-svn-id: http://svn.automattic.com/wordpress/trunk@14378 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-03 18:48:33 +00:00
ryan 172aa06718 Revert [14347] and [14372]. It broke more than we expected. Try again in 3.1. see #13051
git-svn-id: http://svn.automattic.com/wordpress/trunk@14374 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-03 18:16:22 +00:00
westi ae468d52ac First pass of compatibility code for old themes which relied on using templates from the default theme without expressly identifying it as the parent theme.
Fixes #12425 and #13009.
The fallback to these template files is now depreceated and will be removed in a future version.


git-svn-id: http://svn.automattic.com/wordpress/trunk@14365 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-03 09:57:24 +00:00
ryan 91354eefee Escape links by default. Props alexkingorg. see #13051
git-svn-id: http://svn.automattic.com/wordpress/trunk@14347 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-02 22:53:59 +00:00
westi 90873d5063 Revert [14268] - It is much better to use JavaScript for this kind of enhancement. Output buffering is too fragile. See #12564.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14274 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-28 07:17:20 +00:00
nacin b8b6090959 Add full HTML filter to comment_form(), along with an echo arg. props joostdevalk, fixes #12564.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-28 04:28:51 +00:00
nacin e9602ae765 Clarify language for non-publication of emails. props lloydbudd, fixes #13026.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-23 15:01:21 +00:00
nacin 6bad016e80 Switch to simpler language regarding publication of email addresses in comment_form() template. props bumbu, see #13026.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-18 04:49:19 +00:00
dd32 7058bb3db8 Respect the comment ID parameter in comment_excerpt(). Props tenpura. Fixes #12874
git-svn-id: http://svn.automattic.com/wordpress/trunk@14128 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-18 03:45:24 +00:00
nacin e8c8ef08f0 Move stray closing p tag out of a translation. props chrisbliss18, fixes #13036.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-16 22:27:37 +00:00
nacin 045c407a3c Remove tabindex from comment_form(). fixes #12963
git-svn-id: http://svn.automattic.com/wordpress/trunk@14114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-16 18:29:39 +00:00
nacin c229cdcba7 Spacing/coding cleanup of comment_form(). see #13016.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14093 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-15 16:25:08 +00:00
nacin b8917ef747 Update the html comments in comment_form(). props iandstewart, fixes #13016.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14092 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-15 16:16:51 +00:00
ryan 687ce2919f Use WP_FALLBACK_THEME instead of default. Props MichaelH. see #12846
git-svn-id: http://svn.automattic.com/wordpress/trunk@14080 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-13 21:56:57 +00:00
nacin ccb93ac4c7 Add @since.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14073 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-11 15:23:20 +00:00
dd32 442d41291a Tweak new strings for better typography. Props demetris. Fixes #12962
git-svn-id: http://svn.automattic.com/wordpress/trunk@14070 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-11 10:41:54 +00:00
dd32 9cd8dd44c6 Introduce get_comment_id_fields() as a Getter for comment_id_fields(). Introduce a filter on the output to add extra fields. Props zoranzaric. Fixes #12893
git-svn-id: http://svn.automattic.com/wordpress/trunk@14067 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-11 08:56:18 +00:00
nacin 1a4a30fcf1 Deprecate trackback_rdf(). fixes #11139
git-svn-id: http://svn.automattic.com/wordpress/trunk@13991 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-04 10:04:56 +00:00
dd32 0025a953ac Reduce Code duplication. Rely on parent class to do the heavy lifting, just tack the comment addition on the end. See #8841
git-svn-id: http://svn.automattic.com/wordpress/trunk@13939 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-02 05:33:18 +00:00
dd32 364faf559e Move children of nested levels not shown to after the current element, not inside it like children. See #8841
git-svn-id: http://svn.automattic.com/wordpress/trunk@13938 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-02 05:13:57 +00:00
dd32 1d0b284a7c Fix out-of-order comments when comment nesting is reduced. Displays child comments on the same level after its "parent" in the case that the max_depth has been hit. See #8841
git-svn-id: http://svn.automattic.com/wordpress/trunk@13932 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-02 04:05:01 +00:00
nacin a7feaed0e6 Change @since 3.0 to @since 3.0.0.
git-svn-id: http://svn.automattic.com/wordpress/trunk@13827 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-26 19:13:36 +00:00
nacin 8c8bf5039f Remove unnecessary ternary operators such as (expr) ? true : false.
git-svn-id: http://svn.automattic.com/wordpress/trunk@13769 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-19 21:15:00 +00:00
dd32 cb8fd85d1e Prefer $comment::comment_post_ID over $post global. Fixes #12217
git-svn-id: http://svn.automattic.com/wordpress/trunk@13396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-25 07:56:25 +00:00
nacin 8bcc5969dc Spelling and grammar fun. Fixes #11875 props cnorris23
git-svn-id: http://svn.automattic.com/wordpress/trunk@13382 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-24 20:13:23 +00:00
ryan dbfb51c6e0 Trim trailing whites
git-svn-id: http://svn.automattic.com/wordpress/trunk@13268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-21 00:03:42 +00:00
dd32 679250491d Variable Cleanup, Unused variables, Typo'd variables, unused code blocks. Fixes #12299
git-svn-id: http://svn.automattic.com/wordpress/trunk@13242 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-20 02:01:46 +00:00
ryan a48e17cca1 Comment form output tweaks. Props beaulebens. see #10910
git-svn-id: http://svn.automattic.com/wordpress/trunk@13180 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-17 19:28:03 +00:00
ryan 88f317209e Add optional post ID arg to get_comments_link(). Props scribu. fixes #12249
git-svn-id: http://svn.automattic.com/wordpress/trunk@13171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-16 17:54:19 +00:00
ryan b34fd9b448 Change comment_form() markup to match twentyten. Props beaulebens. see #10910
git-svn-id: http://svn.automattic.com/wordpress/trunk@13030 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-08 20:54:29 +00:00
ryan 4f4d2d446d Use comment_form instead of comments_form as the name of the hook. Props greenshady. see #10910
git-svn-id: http://svn.automattic.com/wordpress/trunk@13028 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-08 18:27:02 +00:00
ryan 699387f747 Remove trailing whitespace
git-svn-id: http://svn.automattic.com/wordpress/trunk@12859 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-01-26 22:49:05 +00:00
ryan dd69637c65 Add optional comment ID argument to comment template functions. Props filosofo. fixes #12006
git-svn-id: http://svn.automattic.com/wordpress/trunk@12821 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-01-25 17:34:13 +00:00
ryan 44ba9a0ec0 Update @since. see #10910
git-svn-id: http://svn.automattic.com/wordpress/trunk@12811 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-01-23 18:13:31 +00:00
ryan 41eeb07634 comment_form(), first pass. Props beaulebens. see #10910
git-svn-id: http://svn.automattic.com/wordpress/trunk@12810 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-01-23 18:06:37 +00:00
ryan 94859834fc i18n fixes. Props nbachiyski. fixes #11954
git-svn-id: http://svn.automattic.com/wordpress/trunk@12789 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-01-21 21:37:43 +00:00
westi bf4a5241e1 Add missing version numbers to _deprecated_argument() calls.
Remove deprecated argument from xfn_check() calls.
Pass version number to deprecated_file_included, deprecated_function_run and deprecated_argument_run actions.
Fixes #11386 props nacin.

git-svn-id: http://svn.automattic.com/wordpress/trunk@12680 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-01-09 10:03:55 +00:00
westi f05ee1844f Switch to passing arrays instead of query strings to functions. Fixes #6647 props filosofo and hakre.
git-svn-id: http://svn.automattic.com/wordpress/trunk@12657 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-01-08 08:34:39 +00:00
ryan ec8e347792 Introduce home_url(). Props Denis-de-Bernardy, hakre. see #9008
git-svn-id: http://svn.automattic.com/wordpress/trunk@12598 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-01-04 17:23:29 +00:00
westi 0163da57c4 Don't pass deprecated argument to comments_number().
git-svn-id: http://svn.automattic.com/wordpress/trunk@12586 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-12-30 16:54:28 +00:00
westi ff7831207c Updates and improvements to _depreceated_argument. See #11386 props nacin.
git-svn-id: http://svn.automattic.com/wordpress/trunk@12584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-12-30 16:23:39 +00:00
westi 47a7b1b003 Fix typo in _deprecated_argument() and start using _deprecated_argument() in wp-includes files. See #11386 props nacin.
git-svn-id: http://svn.automattic.com/wordpress/trunk@12537 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-12-24 11:12:04 +00:00
azaozz 72990cd094 Add another arg to 'get_comment_time' filter, props miqrogroove, fixes #11421
git-svn-id: http://svn.automattic.com/wordpress/trunk@12396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-12-14 10:21:58 +00:00
markjaquith 182ec07a44 Strip HTML from comments_popup_link title attribute. props ewestp, xenlab. fixes #10997
git-svn-id: http://svn.automattic.com/wordpress/trunk@12362 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-12-10 09:13:11 +00:00
markjaquith 57b5a0cc30 Fix wp_list_comments() ol/ul/div logic oversight. props junsuijin. fixes #10742
git-svn-id: http://svn.automattic.com/wordpress/trunk@12045 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-10-15 21:47:35 +00:00
ryan 8e3808bce2 Remove trailing whitespace
git-svn-id: http://svn.automattic.com/wordpress/trunk@11930 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-09-14 14:03:32 +00:00
azaozz 0c521408ba Pass Post ID to the get_comments_number filter, props sirzooro, fixes #10705
git-svn-id: http://svn.automattic.com/wordpress/trunk@11895 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-09-01 20:27:03 +00:00
ryan 91ef366300 Don't show comments template if post is empty
git-svn-id: http://svn.automattic.com/wordpress/trunk@11839 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-08-18 19:33:56 +00:00
ryan 8513b29792 Prophylactic escapes
git-svn-id: http://svn.automattic.com/wordpress/trunk@11838 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-08-18 16:05:07 +00:00
ryan af409e2dae esc_url() for ()
git-svn-id: http://svn.automattic.com/wordpress/trunk@11724 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-07-20 01:41:05 +00:00
ryan 3e73668bca sanitize_comment_cookie() handles the attribute escaping, so remove the extra escaping and leave the phpdoc.
git-svn-id: http://svn.automattic.com/wordpress/trunk@11723 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-07-20 01:22:25 +00:00
ryan 1466e9954b Escape , , and for use in attributes by default since so many themes don't escape them. Use wp_get_current_commenter() to get the raw values.
git-svn-id: http://svn.automattic.com/wordpress/trunk@11722 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-07-20 01:11:14 +00:00
azaozz 8dff8f9f73 Properly escape comment_author_url when displaying, for trunk
git-svn-id: http://svn.automattic.com/wordpress/trunk@11721 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-07-18 23:21:50 +00:00
westi fc3b5ba6da Rename new function to sanitize_html_class() to hilight exactly what it is for, Fixes #8446.
git-svn-id: http://svn.automattic.com/wordpress/trunk@11435 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-05-22 21:31:42 +00:00
westi 108f7c1063 Introduce sanitise_css_classname() and use it to give categories, tags, users etc meaningful classnames where possible. Falls back to the id if not. Fixes #8446.
git-svn-id: http://svn.automattic.com/wordpress/trunk@11433 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-05-22 17:44:26 +00:00
markjaquith 3ebf837ced Deprecate sanitize_url() and clean_url() in favor of esc_url_raw() and esc_url()
git-svn-id: http://svn.automattic.com/wordpress/trunk@11383 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-05-18 16:00:33 +00:00
markjaquith 119b39cec2 deprecate wp_specialchars() in favor of esc_html(). Encode quotes for esc_html() as in esc_attr(), to improve plugin security.
git-svn-id: http://svn.automattic.com/wordpress/trunk@11380 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-05-18 15:11:07 +00:00
ryan 1354d0660a Don't localize dates where not appropriate. Props Denis-de-Bernardy, hakre. fixes #9730
git-svn-id: http://svn.automattic.com/wordpress/trunk@11323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-05-14 02:00:32 +00:00
ryan 75ec19a860 Notice fix. Props mrmist. fixes #8446
git-svn-id: http://svn.automattic.com/wordpress/trunk@11316 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-05-13 19:04:26 +00:00
ryan a0c7b65f7b Use IDs instead of slugs in CSS classes ro avoid invalid class names. Props hakre. fixes #8446
git-svn-id: http://svn.automattic.com/wordpress/trunk@11306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-05-12 17:11:57 +00:00
westi a977c155bf Filter out blank urls for commentors. Fixes #5789.
git-svn-id: http://svn.automattic.com/wordpress/trunk@11249 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-05-10 07:26:30 +00:00
westi e89d78ee08 Decode the commenters name why looking up un-moderated comments. Fixes #6992.
git-svn-id: http://svn.automattic.com/wordpress/trunk@11220 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-05-06 20:24:57 +00:00
markjaquith 6c2ffddf31 _a(), _ea(), _xa(), attr() are now esc_attr__(), esc_attr_e(), esc_attr_x(), esc_attr() -- still short, but less cryptic. see #9650
git-svn-id: http://svn.automattic.com/wordpress/trunk@11204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-05-05 19:43:53 +00:00
ryan 2d489767bb s/attribute_escape/attr/. see #9650
git-svn-id: http://svn.automattic.com/wordpress/trunk@11109 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-04-28 05:58:45 +00:00
ryan d90ba6085f Add comment-reply-login class. Props mattwalters. fixes #8633
git-svn-id: http://svn.automattic.com/wordpress/trunk@11060 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-04-22 21:27:07 +00:00
ryan a61bc0ec8a Trailing whitespace cleanup
git-svn-id: http://svn.automattic.com/wordpress/trunk@11013 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-04-20 18:18:39 +00:00