b1cd71c2d2
Accessibility: Media: Add more headings in the Media Modal.
...
Headings are the predominant mechanism for screen reader users to find information in a page. They also help all users to better identify the main sections of user interfaces.
- adds three new headings within the media modal
- improves plural form translation for "item selected" by using `wp.i18n`
- horizontally centers the media modal menu in the responsive view
Props kjellr, karmatosed, melchoyce, afercia.
See #47149 .
Fixes #47610 .
Built from https://develop.svn.wordpress.org/trunk@46375
git-svn-id: http://core.svn.wordpress.org/trunk@46174 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-03 12:10:57 +00:00
30d8319aa9
Block Editor: Update WordPress packages to include the latest bug fixes.
...
Updated packages:
@wordpress/annotations@1.7.1
@wordpress/api-fetch@3.6.1
@wordpress/babel-plugin-makepot@3.2.1
@wordpress/babel-preset-default@4.6.1
@wordpress/block-directory@1.0.1
@wordpress/block-editor@3.2.1
@wordpress/block-library@2.9.1
@wordpress/blocks@6.7.1
@wordpress/components@8.3.1
@wordpress/compose@3.7.1
@wordpress/core-data@2.7.1
@wordpress/data-controls@1.3.1
@wordpress/data@4.9.1
@wordpress/docgen@1.4.1
@wordpress/dom@2.5.1
@wordpress/e2e-test-utils@2.4.1
@wordpress/e2e-tests@1.7.1
@wordpress/edit-post@3.8.1
@wordpress/editor@9.7.1
@wordpress/element@2.8.1
@wordpress/format-library@1.9.1
@wordpress/i18n@3.6.1
@wordpress/jest-console@3.3.1
@wordpress/jest-preset-default@5.1.1
@wordpress/keycodes@2.6.1
@wordpress/library-export-default-webpack-plugin@1.4.1
@wordpress/list-reusable-blocks@1.8.1
@wordpress/media-utils@1.2.1
@wordpress/notices@1.8.1
@wordpress/nux@3.7.1
@wordpress/plugins@2.7.1
@wordpress/redux-routine@3.6.1
@wordpress/rich-text@3.7.1
@wordpress/scripts@5.0.1
@wordpress/server-side-render@1.3.1
@wordpress/shortcode@2.4.1
@wordpress/token-list@1.6.1
@wordpress/viewport@2.8.1
@wordpress/wordcount@2.6.1
Props epiqueras, youknowriad, donmhico, jorgefilipecosta, soean, mcsf, noisysocks, andraganescu, gziolo, talldanwp, iseulde, nrqsnchz, mapk, karmatosed, joen, afercia, kjellr, desrosj.
Fixes #48186 .
Built from https://develop.svn.wordpress.org/trunk@46364
git-svn-id: http://core.svn.wordpress.org/trunk@46163 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-30 20:07:06 +00:00
63e199abc7
Accessibility: Media: Use the ARIA tabs pattern for the media modal menus.
...
The ARIA tabs pattern improves interaction for keyboard and assistive technologies users.
It gives the menu items proper roles, and `aria-selected` allows users of assistive technologies to know which tab is currently selected.
Props audrasjb, afercia, joedolson, karmatosed, melchoyce.
See #47149 .
Built from https://develop.svn.wordpress.org/trunk@46363
git-svn-id: http://core.svn.wordpress.org/trunk@46162 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-30 19:37:58 +00:00
247e7eb7d5
Media: Revert [46354] preventing bad clipping of text in image details page.
...
See #47115 .
Built from https://develop.svn.wordpress.org/trunk@46355
git-svn-id: http://core.svn.wordpress.org/trunk@46154 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-30 17:12:59 +00:00
7c8028febf
Media: Prevents clipping of text when scaling image edit screen.
...
Props sabernhardt, audrasjb, afercia.
See #47115 .
Built from https://develop.svn.wordpress.org/trunk@46354
git-svn-id: http://core.svn.wordpress.org/trunk@46153 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-30 16:34:58 +00:00
abb00ee8a4
Media: Fix JavaScript TypeError after [45376].
...
Props desrosj, afercia.
Fixes #48021 .
Built from https://develop.svn.wordpress.org/trunk@46321
git-svn-id: http://core.svn.wordpress.org/trunk@46120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-26 13:06:56 +00:00
bd344c19ea
Block Editor: Align the version of React with the one used in Gutenberg plugin
...
Gutenberg 6.5 works with react and react-dom set to v16.9.0. This change aligns both.
Props youknowriad.
Fixes #48121 .
Built from https://develop.svn.wordpress.org/trunk@46289
git-svn-id: http://core.svn.wordpress.org/trunk@46101 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-25 08:20:57 +00:00
9e26d98d7e
Accessibility: Media: Make screen readers announce the Media search results.
...
- adds audible messages via `wp.a11y.speak()` to announce the search results
- removes a `keyup` event that was there only to support old browsers
- removes `aria-modal="true"` from the media modal dialog as it prevents the ARIA live regions to be perceived by screen readers
- triggers the search only after 2 ASCII characters have been typed
Props anevins, antpb, aduth, loreleiaurora, afercia.
Fixes #47146 .
Built from https://develop.svn.wordpress.org/trunk@46239
git-svn-id: http://core.svn.wordpress.org/trunk@46051 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 12:19:56 +00:00
03390f00c5
Block Editor: Update the WordPress Packages to the ones used in the Gutenberg 6.5 release
...
Updated Packages:
In version 6.2:
@wordpress/a11y@2.5.0
@wordpress/annotations@1.5.0
@wordpress/api-fetch@3.4.0
@wordpress/autop@2.4.0
@wordpress/babel-plugin-import-jsx-pragma@2.3.0
@wordpress/babel-plugin-makepot@3.2.0
@wordpress/babel-preset-default@4.4.0
@wordpress/blob@2.5.0
@wordpress/block-editor@3.0.0
@wordpress/block-library@2.7.0
@wordpress/block-serialization-default-parser@3.3.0
@wordpress/block-serialization-spec-parser@3.2.0
@wordpress/blocks@6.5.0
@wordpress/browserslist-config@2.6.0
@wordpress/components@8.1.0
@wordpress/compose@3.5.0
@wordpress/core-data@2.5.0
@wordpress/custom-templated-path-webpack-plugin@1.5.0
@wordpress/data-controls@1.1.0
@wordpress/data@4.7.0
@wordpress/date@3.4.0
@wordpress/dependency-extraction-webpack-plugin@1.1.0
@wordpress/deprecated@2.5.0
@wordpress/docgen@1.3.0
@wordpress/dom-ready@2.5.0
@wordpress/dom@2.4.0
@wordpress/e2e-test-utils@2.2.0
@wordpress/e2e-tests@1.4.0
@wordpress/edit-post@3.6.0
@wordpress/editor@9.5.0
@wordpress/element@2.6.0
@wordpress/escape-html@1.5.0
@wordpress/eslint-plugin@2.4.0
@wordpress/format-library@1.7.0
@wordpress/hooks@2.5.0
@wordpress/html-entities@2.5.0
@wordpress/i18n@3.6.0
@wordpress/is-shallow-equal@1.5.0
@wordpress/jest-console@3.2.0
@wordpress/jest-preset-default@4.3.0
@wordpress/jest-puppeteer-axe@1.2.0
@wordpress/keycodes@2.5.0
@wordpress/library-export-default-webpack-plugin@1.4.0
@wordpress/list-reusable-blocks@1.6.0
@wordpress/media-utils@1.0.0
@wordpress/notices@1.6.0
@wordpress/npm-package-json-lint-config@2.1.0
@wordpress/nux@3.5.0
@wordpress/plugins@2.5.0
@wordpress/postcss-themes@2.2.0
@wordpress/priority-queue@1.3.0
@wordpress/redux-routine@3.5.0
@wordpress/rich-text@3.5.0
@wordpress/scripts@3.4.0
@wordpress/server-side-render@1.1.0
@wordpress/shortcode@2.4.0
@wordpress/token-list@1.5.0
@wordpress/url@2.7.0
@wordpress/viewport@2.6.0
@wordpress/wordcount@2.5.0
In version 6.4:
@wordpress/annotations@1.6.0
@wordpress/api-fetch@3.5.0
@wordpress/autop@2.5.0
@wordpress/babel-preset-default@4.5.0
@wordpress/block-editor@3.1.0
@wordpress/block-library@2.8.0
@wordpress/block-serialization-default-parser@3.4.0
@wordpress/block-serialization-spec-parser@3.3.0
@wordpress/blocks@6.6.0
@wordpress/components@8.2.0
@wordpress/compose@3.6.0
@wordpress/core-data@2.6.0
@wordpress/data-controls@1.2.0
@wordpress/data@4.8.0
@wordpress/date@3.5.0
@wordpress/dependency-extraction-webpack-plugin@1.2.0
@wordpress/deprecated@2.6.0
@wordpress/docgen@1.4.0
@wordpress/dom@2.5.0
@wordpress/e2e-test-utils@2.3.0
@wordpress/e2e-tests@1.5.0
@wordpress/edit-post@3.7.0
@wordpress/editor@9.6.0
@wordpress/element@2.7.0
@wordpress/eslint-plugin@3.0.0
@wordpress/format-library@1.8.0
@wordpress/hooks@2.6.0
@wordpress/is-shallow-equal@1.6.0
@wordpress/jest-console@3.3.0
@wordpress/jest-preset-default@5.0.0
@wordpress/jest-puppeteer-axe@1.3.0
@wordpress/keycodes@2.6.0
@wordpress/list-reusable-blocks@1.7.0
@wordpress/media-utils@1.1.0
@wordpress/notices@1.7.0
@wordpress/nux@3.6.0
@wordpress/plugins@2.6.0
@wordpress/project-management-automation@1.0.0
@wordpress/redux-routine@3.6.0
@wordpress/rich-text@3.6.0
@wordpress/scripts@4.0.0
@wordpress/server-side-render@1.2.0
@wordpress/token-list@1.6.0
@wordpress/viewport@2.7.0
@wordpress/wordcount@2.6.0
In version 6.5:
@wordpress/annotations@1.7.0
@wordpress/api-fetch@3.6.0
@wordpress/babel-preset-default@4.6.0
@wordpress/block-directory@1.0.0
@wordpress/block-editor@3.2.0
@wordpress/block-library@2.9.0
@wordpress/blocks@6.7.0
@wordpress/components@8.3.0
@wordpress/compose@3.7.0
@wordpress/core-data@2.7.0
@wordpress/data-controls@1.3.0
@wordpress/data@4.9.0
@wordpress/dependency-extraction-webpack-plugin@2.0.0
@wordpress/e2e-test-utils@2.4.0
@wordpress/e2e-tests@1.7.0
@wordpress/edit-post@3.8.0
@wordpress/editor@9.7.0
@wordpress/element@2.8.0
@wordpress/eslint-plugin@3.1.0
@wordpress/format-library@1.9.0
@wordpress/list-reusable-blocks@1.8.0
@wordpress/media-utils@1.2.0
@wordpress/notices@1.8.0
@wordpress/nux@3.7.0
@wordpress/plugins@2.7.0
@wordpress/rich-text@3.7.0
@wordpress/scripts@5.0.0
@wordpress/server-side-render@1.3.0
@wordpress/url@2.8.0
@wordpress/viewport@2.8.0
Props youknowriad desrosj noisysocks pento jorgefilipecosta iseulde
Fixes : #47843
Built from https://develop.svn.wordpress.org/trunk@46189
git-svn-id: http://core.svn.wordpress.org/trunk@46001 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-19 15:19:18 +00:00
463e050b25
Uploads: add helper functions for setting, getting, and deleting the temp upload reference used to the attachment_id when retrying to make image sub-sizes.
...
See #47872 .
Built from https://develop.svn.wordpress.org/trunk@46174
git-svn-id: http://core.svn.wordpress.org/trunk@45986 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-19 01:26:55 +00:00
308e616baf
TinyMCE: update to version 4.9.6. Changelog: https://github.com/tinymce/tinymce/blob/4.x/changelog.txt . Includes fix for the `Permission denied to access property "nodeType"` error.
...
Fixes #47437 .
Built from https://develop.svn.wordpress.org/trunk@46173
git-svn-id: http://core.svn.wordpress.org/trunk@45985 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-19 01:00:57 +00:00
08a077658d
Accessibility: Replace wp-a11y.js with @wordpress/a11y package
...
We've extracted wp-includes/wp-a11y.js to a reusable package wordpress/a11y which is published on NPM. Let's make sure this package is also used in WordPress core. Once all the JavaScript is built using webpack, we can also import this package wherever it is used and configure webpack to load is an external.
Props omarreiss, herregroen, desrosj, ocean90, afercia, sstoqnov
Built from https://develop.svn.wordpress.org/trunk@46167
git-svn-id: http://core.svn.wordpress.org/trunk@45979 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-18 17:41:55 +00:00
0cb3860138
External Libraries: Update Backbone.js to 1.4.0.
...
Upgrade Backbone to the latest stable version. Fix some issues in Media with `listenTo` which changed in this version, see https://backbonejs.org/#changelog .
Props desrosj, priyankkpatel, pierlo.
Fixes #47478 .
Built from https://develop.svn.wordpress.org/trunk@46157
git-svn-id: http://core.svn.wordpress.org/trunk@45969 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-17 17:19:54 +00:00
cc6e23e4dc
External Libraries: Update jQuery Color plugin to 2.1.2.
...
Props desrosj, hareesh-pillai, lovememore.
Fixes #31511 .
Built from https://develop.svn.wordpress.org/trunk@46095
git-svn-id: http://core.svn.wordpress.org/trunk@45907 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-12 12:41:54 +00:00
877f356334
External Libraries: Revert [46092] pending test failure investigation.
...
See #45785 .
Built from https://develop.svn.wordpress.org/trunk@46093
git-svn-id: http://core.svn.wordpress.org/trunk@45905 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-12 10:19:59 +00:00
f7f27c37aa
External Libraries: Update Underscore to 1.9.1.
...
Changes: https://github.com/jashkenas/underscore/compare/1.8.3...1.9.1
Props mukesh27, hareesh-pillai.
Fixes #45785
Built from https://develop.svn.wordpress.org/trunk@46092
git-svn-id: http://core.svn.wordpress.org/trunk@45904 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-11 19:22:54 +00:00
c0b5127683
Upload: Reset the temp upload reference in Plupload when the file is not an image.
...
See #47872 .
Built from https://develop.svn.wordpress.org/trunk@46081
git-svn-id: http://core.svn.wordpress.org/trunk@45893 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-08 02:28:55 +00:00
8fe3c3fa23
Widgets: Fix "jumpiness" when reordering widgets by dragging them.
...
Props ketanumretiya030, mukesh27, andraganescu, audrasjb.
Fixes #46941 .
Built from https://develop.svn.wordpress.org/trunk@46028
git-svn-id: http://core.svn.wordpress.org/trunk@45839 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-04 21:49:59 +00:00
17652fb3d4
Widgets: Fix "jumpiness" when reordering widgets by dragging them.
...
Props ketanumretiya030, mukesh27, andraganescu, audrasjb.
Fixes #46941 .
Built from https://develop.svn.wordpress.org/trunk@46028
git-svn-id: http://core.svn.wordpress.org/trunk@45838 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-04 21:49:48 +00:00
90d9bdc54c
Update wp.a11y.speak() to sanitize HTML before display.
...
Props iandunn, adamsilverstein, sstoqnov, peterwilsoncc
Built from https://develop.svn.wordpress.org/trunk@45979
git-svn-id: http://core.svn.wordpress.org/trunk@45790 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-04 17:13:21 +00:00
e313498193
Uploads: After an image is uploaded and PHP times out or runs out of memory during post-processing (the server response is HTTP 500 error), try to resize it three more times. Then, if all attempts fail, do a cleanup of any sub-sizes that may have been created and show an error message asking the user to scale the image and upload it again.
...
See #47872 .
Built from https://develop.svn.wordpress.org/trunk@45934
git-svn-id: http://core.svn.wordpress.org/trunk@45745 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-04 01:11:54 +00:00
3ab18dba93
Accessibility: Add a default title for the media modal dialog.
...
Makes sure the media modal dialog `h1` heading isn't empty when custom media frames don't set a title. This is particularly important now that the media modal is an ARIA dialog, as the title is referenced by an `aria-labelledby` attribute to properly label the dialog.
Props donmhico, audrasjb.
Fixes #47612 .
Built from https://develop.svn.wordpress.org/trunk@45925
git-svn-id: http://core.svn.wordpress.org/trunk@45736 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-01 15:18:56 +00:00
6b9ab1c5c5
Docs: Update `@since` tag for new JS functions and variables introduced in [45572].
...
Props garrett-eclipse.
See #47145 .
Built from https://develop.svn.wordpress.org/trunk@45867
git-svn-id: http://core.svn.wordpress.org/trunk@45678 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-20 22:54:55 +00:00
a760ef9022
Multisite: Remove truncation to allow clearers identification of longer site names
...
Previously the sites were truncated which meant longer names but with ending identifications were unable to be seen as different. This shows the full site name to allow easier understanding.
Props tferry, melinedo, afercia, jeremyfelt
Fixes: 47112
Built from https://develop.svn.wordpress.org/trunk@45826
git-svn-id: http://core.svn.wordpress.org/trunk@45637 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-18 12:31:00 +00:00
3ce3927dc1
Coding Standards: Fix JSHint error in [45790].
...
See #41545 .
Built from https://develop.svn.wordpress.org/trunk@45792
git-svn-id: http://core.svn.wordpress.org/trunk@45603 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-14 00:02:55 +00:00
3e605d3852
Comments: enable typing cmd/ctrl-enter to submit comment forms.
...
Add a key handler on the comment form that detects the cmd/ctrl-enter key press and submits the comment form.
Props xyfi, Lindstromer, helen, splitti.
Fixes #41545 .
Built from https://develop.svn.wordpress.org/trunk@45790
git-svn-id: http://core.svn.wordpress.org/trunk@45601 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-13 21:26:56 +00:00
638bae9392
Emoji: Upgrade Twemoji to 12.1.2.
...
This upgrade adds support for the transgender flag: 🏳️⚧️
There's some additional housekeeping in this commit:
- Twemoji recently rearranged their repository and package, so `Gruntfile.js` needed tweaking to allow for that.
- As only new files were added in this Twemoji release, the CDN version didn't need updating.
Fixes #47852 .
Built from https://develop.svn.wordpress.org/trunk@45769
git-svn-id: http://core.svn.wordpress.org/trunk@45580 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-08 04:05:55 +00:00
2d60076e77
Accessibility: Improve the way emojis are announced by screen readers.
...
Adds an ARIA `role="img"` to the emojis markup in the front end. While the ARIA role is technically redundant, it helps Safari and VoiceOver to properly announce the emojis as "image". Without the role, they announce a generic "group" role.
Tested with Safari 12.1.1 / VoiceOver 9.
Props pento.
See #37486 .
Built from https://develop.svn.wordpress.org/trunk@45726
git-svn-id: http://core.svn.wordpress.org/trunk@45537 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-03 11:53:56 +00:00
d5c7657189
Media: Reduces the bulk media options to have one primary button
...
This fixes where 2 primary buttons were showing for bulk actions within media trash.
Props garrett-eclipse, afercia, ianbelanger, SergeyBiryukov
Fixes #46757 , #46758
Built from https://develop.svn.wordpress.org/trunk@45701
git-svn-id: http://core.svn.wordpress.org/trunk@45512 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-30 23:20:57 +00:00
c0e53279b3
Comments: Fix typo in comment reply observer options.
...
Props maguiar.
Fixes #47706 . See #46260 .
Built from https://develop.svn.wordpress.org/trunk@45641
git-svn-id: http://core.svn.wordpress.org/trunk@45452 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-15 16:46:55 +00:00
ee8813606d
TinyMCE: fix adding of too many undo levels for wpviews. The HTML changes several times when a wpview is added. We only want one undo level. Also fixes cases when the cursor is next to an embeddable URL in the Text tab and the user switches to the Visual tab.
...
See #45307 .
Built from https://develop.svn.wordpress.org/trunk@45631
git-svn-id: http://core.svn.wordpress.org/trunk@45442 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-12 03:25:55 +00:00
969699260d
TinyMCE: fix flickering inline toolbar when showing a tooltip. Take two.
...
Fixes #44911 .
Built from https://develop.svn.wordpress.org/trunk@45620
git-svn-id: http://core.svn.wordpress.org/trunk@45431 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-11 18:18:58 +00:00
4a273484f3
TinyMCE: fix flickering inline toolbar when hovering over the buttons there and the vertical scrollbar is not shown (the page height is less than the window height). Improves/removes the previous fix for similar flickering but only in RTL, see #42018 .
...
Props joakimsilfverberg, mukesh27, kokers, Howdy_McGee, noisysocks, azaozz.
Fixes #44911 .
Built from https://develop.svn.wordpress.org/trunk@45610
git-svn-id: http://core.svn.wordpress.org/trunk@45421 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-09 01:11:55 +00:00
4803fc405e
Coding Standards: Fix the `Squiz.PHP.DisallowMultipleAssignments` violations in `wp-includes`.
...
See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45590
git-svn-id: http://core.svn.wordpress.org/trunk@45401 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-02 23:42:58 +00:00
00704114e0
Accessibility: Make the Media modal an ARIA modal dialog.
...
For a number of years, the Media modal missed an explicit ARIA role and the required attributes for modal dialogs.
This was confusing for assistive technology users, since they may not realize they're inside a dialog, and that consequently the keyboard interactions may be different from the rest of the page. Lack of an explicit label for the dialog was confusing as well, since assistive technology users didn't have an immediate sense of what the dialog is for.
This change makes the Media modal meet the ARIA Authoring Practices recommendations, helping users better understand the purpose and interactions with the modal. Also, it makes sure to hide the rest of the page content from assistive technologies, until support for `aria-modal="true"` improves.
Additionally:
- moves the modal H1 heading to the beginning of the modal content
- changes the modal left menu position to make visual and DOM order match
- improves the `wp.media.view.FocusManager` documentation
Fixes #47145 .
Built from https://develop.svn.wordpress.org/trunk@45572
git-svn-id: http://core.svn.wordpress.org/trunk@45383 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-27 12:33:56 +00:00
5cf8452ae9
Build/Test Tools: Add the e2e tests setup.
...
- Adds a local environment based on docker
- Adds the e2e tests setup
- Adds a "Hello World" e2e test to serve as a template
Props gziolo, herregroen, mcsf.
Fixes #45165 .
Built from https://develop.svn.wordpress.org/trunk@45570
git-svn-id: http://core.svn.wordpress.org/trunk@45381 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-27 11:28:19 +00:00
73ad55051b
Docs: Improve JSDoc for `media/views/attachment/details.js`.
...
Props maartenleenders, boblinthorst, dfangstrom.
Fixes #47588 .
Built from https://develop.svn.wordpress.org/trunk@45561
git-svn-id: http://core.svn.wordpress.org/trunk@45372 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-22 13:02:52 +00:00
d69a3e6f90
Accessibility: Handle one more case of focus loss when switching view in the Media Views.
...
See #43169 .
Built from https://develop.svn.wordpress.org/trunk@45531
git-svn-id: http://core.svn.wordpress.org/trunk@45342 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-13 16:22:52 +00:00
340fd28d82
Accessibility: Improve focus management in the Media Views.
...
- keeps focus management only where necessary to avoid focus losses
- removes focus management where a specific user workflow was assumed
- makes the "Attachment Details" navigation buttons really disabled when there are no next or previous attachments
- adds inline comments to clarify all the usages of focus()
Fixes #43169 .
Built from https://develop.svn.wordpress.org/trunk@45524
git-svn-id: http://core.svn.wordpress.org/trunk@45335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-12 21:03:52 +00:00
f57e10a35d
Accessibility: Fix the order of the Previous, Next, and Close buttons in the Attachment Details modal.
...
Making the visual and DOM order match benefits keyboard users who navigate documents sequentially and expect the focus order to be consistent with the sequential reading order.
Fixes #47458 .
Built from https://develop.svn.wordpress.org/trunk@45506
git-svn-id: http://core.svn.wordpress.org/trunk@45317 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-09 15:48:53 +00:00
6a9bcaeaa9
Accessibility: Improve accessibility of all the media views form controls.
...
- changes the media views form controls to have explicitly associated labels with for/id attributes
- adds a few missing labels / aria-labels
- improves a few existing labels / aria-labels
- improves semantics in a few places, by adding visually hidden headings, fieldset + legend elements, aria-describedby attributes
- improves the image custom size input fields and their labelling
- adds `role="status"` to the "saved" indicator so that status messages are announced to assistive technologies
- swaps the columns source order in the image details template, to make visual and DOM order match
- swaps the "Replace" and "Back" buttons source order in the Replace Image view, to make visual and DOM order match
- gallery settings: move checkbox label to the right: checkboxes are supposed to have labels on the right
- merge similar strings, unified to "Drop files to upload" (removed "Drop files here", and "Drop files anywhere to upload")
- makes the "upload-ui" consistent across the media views
- hides the IE 11 "X" `::-ms-clear` button in the Insert from URL field, as it conflicts with the uploading spinner
- adds comments to all the media templates to clarify their usage
- slightly increases vertical spacing between form fields in the media sidebar
- removes some CSS selectors introduced as backwards compatibility for WordPress pre-4.4
- removes some CSS still targeting Internet Explorer 7 and 8
Fixes #47141 .
Fixes #47122 .
Built from https://develop.svn.wordpress.org/trunk@45499
git-svn-id: http://core.svn.wordpress.org/trunk@45310 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-07 20:45:02 +00:00
ebb0b92081
Block Editor: Update packages to the ones slated for WP5.2.2
...
- Fix the template validation notice
- Fix for focus jumps when typing in meta attributes
Packages updated:
- @wordpress/block-editor@2.0.3
- @wordpress/block-library@2.4.6
- @wordpress/e2e-tests@1.1.6
- @wordpress/edit-post@3.3.6
- @wordpress/editor@9.2.6
- @wordpress/format-library@1.4.6
Props aduth, desrosj.
Fixes #47429 .
Built from https://develop.svn.wordpress.org/trunk@45481
git-svn-id: http://core.svn.wordpress.org/trunk@45292 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 15:41:57 +00:00
ead1a54576
Build/Test Tools: Revert an accidental change to Node dependencies.
...
See #47380
Built from https://develop.svn.wordpress.org/trunk@45446
git-svn-id: http://core.svn.wordpress.org/trunk@45257 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 19:37:51 +00:00
27365c4ec4
Build/Test Tools: Remove the dependency on a globally installed Grunt.
...
The existing `"grunt": "grunt"` script in `package.json` allows for the use of `npm run grunt ...` which uses the local `grunt` binary in the project's `node_modules`.
Fixes #47380
Built from https://develop.svn.wordpress.org/trunk@45445
git-svn-id: http://core.svn.wordpress.org/trunk@45256 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 19:35:51 +00:00
74c0d658b4
Accessibility: Improve the media views upload Dismiss Errors button.
...
- makes the Dismiss Errors button visible in the media views inline uploader
- avoids a focus loss when activating the Dismiss Errors button
See the related GitHub issue from the WPCampus accessibility audit https://github.com/WordPress/gutenberg/issues/15354
Fixes #47113 .
Built from https://develop.svn.wordpress.org/trunk@45376
git-svn-id: http://core.svn.wordpress.org/trunk@45187 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-22 19:33:53 +00:00
80aee4ae87
jQuery: bring jquery.js back into the WordPress SVN repo and backport the patch from 3.4.0.
...
Props MikeNGarrett, peterwilsoncc, azaozz.
Fixes #47020 for trunk.
Built from https://develop.svn.wordpress.org/trunk@45342
git-svn-id: http://core.svn.wordpress.org/trunk@45153 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-17 04:25:54 +00:00
3c44f9e15a
Block Editor: Upgrade WordPress packages to the latest versions.
...
Updated packages:
- @wordpress/annotations@1.2.3
- @wordpress/block-editor@2.0.2
- @wordpress/block-library@2.4.5
- @wordpress/blocks@6.2.5
- @wordpress/components@7.3.2
- @wordpress/dom@2.2.5
- @wordpress/e2e-tests@1.1.5
- @wordpress/edit-post@3.3.5
- @wordpress/editor@9.2.5
- @wordpress/format-library@1.4.5
- @wordpress/list-reusable-blocks@1.3.5
- @wordpress/nux@3.2.5
- @wordpress/rich-text@3.2.3
Props: youknowriad, gwwar, iseulde, tfrommen, gziolo.
Fixes #47284 .
Built from https://develop.svn.wordpress.org/trunk@45319
git-svn-id: http://core.svn.wordpress.org/trunk@45130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-16 18:08:00 +00:00
762b49653a
Update TinyMCE to 4.9.4. Changelog: https://github.com/tinymce/tinymce/blob/4.x/changelog.txt .
...
Fixes #47229 for trunk.
Built from https://develop.svn.wordpress.org/trunk@45316
git-svn-id: http://core.svn.wordpress.org/trunk@45127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-15 23:45:52 +00:00
0feb55f633
Editor: Update packages to apply bugfixes from Gutenberg 5.5.
...
- @wordpress/block-editor@2.0.1
- @wordpress/block-library@2.4.4
- @wordpress/blocks@6.2.4
- @wordpress/components@7.3.1
- @wordpress/dom@2.2.4
- @wordpress/e2e-tests@1.1.4
- @wordpress/edit-post@3.3.4
- @wordpress/editor@9.2.4
- @wordpress/format-library@1.4.4
- @wordpress/list-reusable-blocks@1.3.4
- @wordpress/nux@3.2.4
Props iseulde, kjellr, aduth, get_dave, talldanwp, jorgefilipecosta, afercia, nosolosw, jasmussen, netweb .
See https://github.com/WordPress/gutenberg/pull/14987 .
See https://github.com/WordPress/gutenberg/pull/15020 .
Fixes #46951 .
Built from https://develop.svn.wordpress.org/trunk@45255
git-svn-id: http://core.svn.wordpress.org/trunk@45064 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-22 12:40:04 +00:00
4b1ff1c298
Media: Update the media bulk action labels for consistency.
...
Props ianbelanger, garrett-eclipse, afercia, Presskopp.
Fixes #44675 .
Built from https://develop.svn.wordpress.org/trunk@45147
git-svn-id: http://core.svn.wordpress.org/trunk@44956 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-08 23:54:52 +00:00
95df8fa792
Block Editor: Update packages to bring a selection of bugfixes in.
...
Props iseulde, kjellr, aduth, 0mirka00, mcsf, nosolosw, gziolo, jasmussen, talldanwp, notnownikki, swissspidy, jorgefilipecosta, noisysocks.
See https://github.com/WordPress/gutenberg/pull/14796 .
Fixes #46801 .
Built from https://develop.svn.wordpress.org/trunk@45138
git-svn-id: http://core.svn.wordpress.org/trunk@44947 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-08 06:37:57 +00:00
a125989772
Emoji: Update Twemoji to version 12.0.0.
...
Props pento, superpoincare.
Fixes #46404 , #46805 .
Built from https://develop.svn.wordpress.org/trunk@45134
git-svn-id: http://core.svn.wordpress.org/trunk@44943 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-08 05:22:51 +00:00
7ab495bfed
TinyMCE:
...
- Fix adding the keyboard shortcuts to all button tooltips in the classic editor and classic block.
- Fix translating the aria labels for all buttons.
Fixes #35710 ;
Built from https://develop.svn.wordpress.org/trunk@45066
git-svn-id: http://core.svn.wordpress.org/trunk@44875 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-29 00:49:51 +00:00
65f7cdbce0
Site Health: Improve the "Copy to clipboard" button.
...
The previous method for copying the debug report to the clipboard involved having a hidden `<textarea>`, but this shows up in screen readers and can't be reliably hidden.
To work around this, the button now uses the `clipboard.js` library, which automatically handles browser differences in the Clipboard API, and can load the text to copy from a `data-` attribute on the button.
Props pento, hedgefield, afercia.
Fixes #46647 .
Built from https://develop.svn.wordpress.org/trunk@45044
git-svn-id: http://core.svn.wordpress.org/trunk@44853 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-27 22:31:52 +00:00
19c4841fb6
Media: introduce a "Heading" view for improved accessibility.
...
* Add a new media view: `wp.media.view.Heading` designed to add accessibility friendly headers in the media library/modal.
* Add an initial "Attachments list" heading above the attachments list.
Props afercia.
Fixes #36925 .
Built from https://develop.svn.wordpress.org/trunk@44969
git-svn-id: http://core.svn.wordpress.org/trunk@44800 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-21 21:05:52 +00:00
2aa1b8ff48
Block Editor: Update the WordPress Packages from Gutenberg 5.3
...
- @wordpress/a11y@2.2.0
- @wordpress/annotations@1.2.0
- @wordpress/api-fetch@3.1.0
- @wordpress/autop@2.2.0
- @wordpress/babel-plugin-import-jsx-pragma@2.1.0
- @wordpress/babel-preset-default@4.1.0
- @wordpress/blob@2.3.0
- @wordpress/block-editor@1.1.0
- @wordpress/block-library@2.4.0
- @wordpress/block-serialization-default-parser@3.1.0
- @wordpress/blocks@6.2.0
- @wordpress/components@7.2.0
- @wordpress/compose@3.2.0
- @wordpress/core-data@2.2.0
- @wordpress/data@4.4.0
- @wordpress/date@3.2.0
- @wordpress/deprecated@2.2.0
- @wordpress/docgen@1.1.0
- @wordpress/dom-ready@2.2.0
- @wordpress/dom@2.2.0
- @wordpress/e2e-test-utils@1.1.0
- @wordpress/e2e-tests@1.1.0
- @wordpress/edit-post@3.3.0
- @wordpress/edit-widgets@0.2.0
- @wordpress/editor@9.2.0
- @wordpress/element@2.3.0
- @wordpress/escape-html@1.2.0
- @wordpress/eslint-plugin@2.1.0
- @wordpress/format-library@1.4.0
- @wordpress/hooks@2.2.0
- @wordpress/html-entities@2.2.0
- @wordpress/i18n@3.3.0
- @wordpress/keycodes@2.2.0
- @wordpress/list-reusable-blocks@1.3.0
- @wordpress/notices@1.3.0
- @wordpress/nux@3.2.0
- @wordpress/plugins@2.2.0
- @wordpress/priority-queue@1.1.0
- @wordpress/redux-routine@3.2.0
- @wordpress/rich-text@3.2.0
- @wordpress/scripts@3.1.0
- @wordpress/shortcode@2.2.0
- @wordpress/url@2.5.0
- @wordpress/viewport@2.3.0
- @wordpress/wordcount@2.2.0
Built from https://develop.svn.wordpress.org/trunk@44960
git-svn-id: http://core.svn.wordpress.org/trunk@44791 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-21 12:48:00 +00:00
cd01464b52
TinyMCE: fix the TinyMCE help modal keyboard shortcut on Mac for the classic editor and classic block.
...
Fixes #45791 .
Built from https://develop.svn.wordpress.org/trunk@44913
git-svn-id: http://core.svn.wordpress.org/trunk@44744 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-15 21:43:50 +00:00
f03ccf6813
TinyMCE: remove the reference to `skin.min.css.map` from `skin.min.css`. Fixes an unneeded 404 request.
...
Fixes #46533 .
Built from https://develop.svn.wordpress.org/trunk@44911
git-svn-id: http://core.svn.wordpress.org/trunk@44742 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-15 19:32:50 +00:00
e9db7c48d2
Accessibility: improve the "URL" and "Alt text" fields in the media modals.
...
Many users found the attachment URL field confusing: it says "URL" so it may appear like a field meant to paste a URL into.
Also, the Alt text field is the most important one in terms of content, while the Title field needs to be de-emphasized.
- changes the URL field label to "Copy link"
- moves the alt text field to the top as first field
- avoids to set initial focus on the alt text field
- adds an explanatory text with a link pointing to the W3C "alt decision tree" tutorial
- adds `aria-describedby` to target the explanatory text
- adjusts the CSS accordingly
- updates the QUnit index.html file
Props melchoyce, audrasjb, afercia.
Fixes #41612 .
Built from https://develop.svn.wordpress.org/trunk@44900
git-svn-id: http://core.svn.wordpress.org/trunk@44731 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-15 10:43:51 +00:00
df681b2ee0
TinyMCE: fix editor height when loaded hidden.
...
Props nnikolov, azaozz.
Fixes #45461 .
Built from https://develop.svn.wordpress.org/trunk@44832
git-svn-id: http://core.svn.wordpress.org/trunk@44664 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-12 20:14:52 +00:00
2d58d57e38
Block Editor: Update the WordPress Packages from Gutenberg 5.2.
...
Updated Packages:
- @wordpress/a11y@2.1.0
- @wordpress/annotations@1.1.0
- @wordpress/api-fetch@3.0.0
- @wordpress/autop@2.1.0
- @wordpress/babel-plugin-import-jsx-pragma@2.0.0
- @wordpress/babel-plugin-makepot@3.0.0
- @wordpress/babel-preset-default@4.0.0
- @wordpress/blob@2.2.0
- @wordpress/block-editor@1.0.0
- @wordpress/block-library@2.3.0
- @wordpress/block-serialization-default-parser@3.0.0
- @wordpress/block-serialization-spec-parser@3.0.0
- @wordpress/blocks@6.1.0
- @wordpress/browserslist-config@2.3.0
- @wordpress/components@7.1.0
- @wordpress/compose@3.1.0
- @wordpress/core-data@2.1.0
- @wordpress/custom-templated-path-webpack-plugin@1.2.0
- @wordpress/data@4.3.0
- @wordpress/date@3.1.0
- @wordpress/deprecated@2.1.0
- @wordpress/docgen@1.0.0
- @wordpress/dom-ready@2.1.0
- @wordpress/dom@2.1.0
- @wordpress/e2e-test-utils@1.0.0
- @wordpress/e2e-tests@1.0.0
- @wordpress/edit-post@3.2.0
- @wordpress/editor@9.1.0
- @wordpress/element@2.2.0
- @wordpress/escape-html@1.1.0
- @wordpress/eslint-plugin@2.0.0
- @wordpress/format-library@1.3.0
- @wordpress/hooks@2.1.0
- @wordpress/html-entities@2.1.0
- @wordpress/i18n@3.2.0
- @wordpress/is-shallow-equal@1.2.0
- @wordpress/jest-console@3.0.0
- @wordpress/jest-preset-default@4.0.0
- @wordpress/jest-puppeteer-axe@1.0.0
- @wordpress/keycodes@2.1.0
- @wordpress/library-export-default-webpack-plugin@1.1.0
- @wordpress/list-reusable-blocks@1.2.0
- @wordpress/notices@1.2.0
- @wordpress/npm-package-json-lint-config@1.2.0
- @wordpress/nux@3.1.0
- @wordpress/plugins@2.1.0
- @wordpress/postcss-themes@2.0.0
- @wordpress/priority-queue@1.0.0
- @wordpress/redux-routine@3.1.0
- @wordpress/rich-text@3.1.0
- @wordpress/scripts@3.0.0
- @wordpress/shortcode@2.1.0
- @wordpress/token-list@1.2.0
- @wordpress/url@2.4.0
- @wordpress/viewport@2.2.0
- @wordpress/wordcount@2.1.0
This also includes the update to the scripts dependencies and the new widgets php files.
Props iseulde.
Fixes #46429 .
Built from https://develop.svn.wordpress.org/trunk@44808
git-svn-id: http://core.svn.wordpress.org/trunk@44640 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-07 09:09:59 +00:00
4094d3687a
Comments: Allow for `comment-reply.js` to be loaded in the HTML header.
...
Allows for themes or plugins setting the comment-reply JavaScript as a dependency of an HTML header script. This in turn causes `comment-reply.js` to be loaded early, requiring execution to be delayed.
Props pento, peterwilsoncc, jorbin for feedback.
Fixes #46280 .
Built from https://develop.svn.wordpress.org/trunk@44794
git-svn-id: http://core.svn.wordpress.org/trunk@44626 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-03-05 01:52:51 +00:00
1b2f7d862c
Comments: Fix backward compatibility regressions in comment reply JavaScript.
...
Adds a `MutationObserver` to `comment-reply.js` to allow for lazy-loaded comments to continue working without the need to re-initialize the comment form.
Props Pento.
Fixes #46260 .
Built from https://develop.svn.wordpress.org/trunk@44748
git-svn-id: http://core.svn.wordpress.org/trunk@44580 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-18 04:27:50 +00:00
a51ca641ec
Build: Remove source map from `jquery.form.min.js`.
...
Minimize jquery.form.js as part of build process to remove the source map reference.
Modify source map tests to include all JavaScript files rather than testing Backbone and jQuery only.
Props pento.
Fixes #46218 .
Built from https://develop.svn.wordpress.org/trunk@44740
git-svn-id: http://core.svn.wordpress.org/trunk@44572 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-14 00:07:49 +00:00
95d5aa0e97
Build: Update `package.json` dependencies to match Gutenberg.
...
Props wpscholar, azaozz, gziolo.
Fixes #46039 .
Built from https://develop.svn.wordpress.org/trunk@44728
git-svn-id: http://core.svn.wordpress.org/trunk@44559 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-02-07 06:28:03 +00:00
02adaaf90c
TinyMCE: fix external references in `wpview` and `wpemoji` plugins in the Classic Block instance when running from `/build`.
...
Fixes #46147 .
Built from https://develop.svn.wordpress.org/trunk@44718
git-svn-id: http://core.svn.wordpress.org/trunk@44549 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-30 14:12:52 +00:00
6a5df4271f
TinyMCE: update alternative icon fonts for older browsers after [44713].
...
See #46094 .
Built from https://develop.svn.wordpress.org/trunk@44716
git-svn-id: http://core.svn.wordpress.org/trunk@44547 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-30 10:07:50 +00:00
2ce767141a
TinyMCE: Update to 4.9.2
...
https://github.com/tinymce/tinymce-dist/compare/4.8.0...4.9.2
Fixes #46094 .
Built from https://develop.svn.wordpress.org/trunk@44713
git-svn-id: http://core.svn.wordpress.org/trunk@44544 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-29 20:19:51 +00:00
3c7a623f85
Block Editor: Update WordPress Packages to the latest versions.
...
Updated Packages:
- @wordpress/annotations@1.0.8
- @wordpress/block-library@2.2.15
- @wordpress/components@7.0.8
- @wordpress/edit-post@3.1.10
- @wordpress/editor@9.0.10
- @wordpress/format-library@1.2.13
- @wordpress/list-reusable-blocks@1.1.21
- @wordpress/nux@3.0.9
- @wordpress/rich-text@3.0.7
Fixes list block indentation and Crowdsignal embed block.
Props iseulde.
Fixes #46137 .
Built from https://develop.svn.wordpress.org/trunk@44711
git-svn-id: http://core.svn.wordpress.org/trunk@44542 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-29 18:23:55 +00:00
05a3c91d34
TinyMCE Classic Block: Remove unused variable.
...
See #46071 .
Built from https://develop.svn.wordpress.org/trunk@44699
git-svn-id: http://core.svn.wordpress.org/trunk@44530 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-26 12:59:49 +00:00
c31e8cf756
TinyMCE Classic Block: fix repositioning of the inline toolbar on scrolling.
...
Props iseulde, azaozz.
Fixes #46062 .
Built from https://develop.svn.wordpress.org/trunk@44697
git-svn-id: http://core.svn.wordpress.org/trunk@44528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-24 11:24:50 +00:00
a6e8abca83
TinyMCE Classic Block: fix the Advanced Link modal (accessible when clicking on the cogwheel in the inline link modal in a Classic Block).
...
Fixes #46071 .
Built from https://develop.svn.wordpress.org/trunk@44696
git-svn-id: http://core.svn.wordpress.org/trunk@44527 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-24 11:21:50 +00:00
6bd203bb50
TinyMCE Classic Block: fix the Edit Image modal to work as in the Classic Editor.
...
Fixes #46085 .
Built from https://develop.svn.wordpress.org/trunk@44695
git-svn-id: http://core.svn.wordpress.org/trunk@44526 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-24 11:11:51 +00:00
faf1528d8f
Customiser: Prevent JS errors when previewing pages with an `<area>` tag.
...
The customiser assumes that `<area>` tags will have a `href` attribute, which isn't necessarily true. Now it checks instead of assuming.
Props janthiel, adamsilverstein.
Fixes #45053 .
Built from https://develop.svn.wordpress.org/trunk@44684
git-svn-id: http://core.svn.wordpress.org/trunk@44515 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-21 23:03:50 +00:00
b7897c5761
TinyMCE: retire wp-tinymce.php and remove pre-compression of wp-tinymce.js.
...
Fixes #45645 .
Built from https://develop.svn.wordpress.org/trunk@44651
git-svn-id: http://core.svn.wordpress.org/trunk@44482 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-18 19:51:53 +00:00
0ee053758e
Emoji: Upgrade Twemoji to 11.2.0.
...
This upgrade includes general improvements to the style of a variety of emoji.
Full changelog: https://github.com/twitter/twemoji/compare/v11.0.0...v11.2.0
Props desrosj, pento.
Fixes #45133 .
Built from https://develop.svn.wordpress.org/trunk@44644
git-svn-id: http://core.svn.wordpress.org/trunk@44475 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-18 01:42:50 +00:00
a32aeb0392
Media: Improve unselecting media in the media bulk selection mode.
...
Disables the "Delete Selected" button when unselecting media by clicking the
"checkmark" box in the media bulk selection mode.
Props subrataemfluence, adamsilverstein.
Fixes #42239 .
Built from https://develop.svn.wordpress.org/trunk@44640
git-svn-id: http://core.svn.wordpress.org/trunk@44471 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-17 12:08:49 +00:00
3578f89900
Accessibility: Improve the way Internet Explorer 11 and JAWS announce fieldset legends.
...
When Internet Explorer encounters a non interactive element with a `tabindex`
attribute, it adds the element to the accessibility tree with a `role=group` and
an accessible name computed from the element. This prevents JAWS from announcing
any fieldset legend within the element.
- removes `tabindex="0"` from the content and the toolbar containers: these tabindex attributes are no longer needed
- removes `aria-label="Main content"` from the content container: not needed
- keeps the media modal focus fallback introduced in [38142] by making the `#wpbody-content` element focusable only when needed
Props stevefaulkner, aardrian.
Fixes #43154 .
Built from https://develop.svn.wordpress.org/trunk@44639
git-svn-id: http://core.svn.wordpress.org/trunk@44470 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-17 11:55:51 +00:00
51f4314441
Customizer: Use the `sandbox` attribute to prevent top navigation from the preview.
...
Props valchovski.
Fixes #42341 .
Built from https://develop.svn.wordpress.org/trunk@44583
git-svn-id: http://core.svn.wordpress.org/trunk@44414 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-14 07:25:50 +00:00
14c44ad703
Block Editor: Upgrade the `@wordpress/` packages.
...
This brings the block editor in core up to date with the Gutenberg 4.8 plugin release.
Props aduth, gziolo, youknowriad, mkaz, jorgefilipecosta, swissspidy, iseulde, soean, noisysocks, joen, brentswisher, dekervit, dimadin, zebulan, johnny5, nosolosw, netweb, ryelle, etoledom, mzorz, desrosj, mmtr86, tinkerbelly, ocean90, earnjam, ajitbohra, talldanwp, notnownikki, mcsf, afercia, adamsilverstein, gutendev, naoki0h, miyauchi, aldavigdis.
Fixes #45885 .
Built from https://develop.svn.wordpress.org/trunk@44533
git-svn-id: http://core.svn.wordpress.org/trunk@44364 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-10 01:54:56 +00:00
e69c1039eb
Build Tools: Copy unminified JS files to `src`.
...
This allows `SCRIPT_DEBUG` to be set to `true` when running from `src`.
Fixes #45869 .
Built from https://develop.svn.wordpress.org/trunk@44529
git-svn-id: http://core.svn.wordpress.org/trunk@44360 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-10 01:39:50 +00:00
0ee1a0e4e1
Block Editor: Upgrade `@WordPress` packages to the latest versions.
...
Updated packages:
- @wordpress/annotations@1.0.5
- @wordpress/api-fetch@2.2.7
- @wordpress/block-library@2.2.12
- @wordpress/block-serialization-default-parser@2.0.3
- @wordpress/blocks@6.0.5
- @wordpress/components@7.0.5
- @wordpress/core-data@2.0.16
- @wordpress/data@4.2.0
- @wordpress/deprecated@2.0.4
- @wordpress/dom@2.0.8
- @wordpress/edit-post@3.1.7
- @wordpress/editor@9.0.7
- @wordpress/format-library@1.2.10
- @wordpress/hooks@2.0.4
- @wordpress/list-reusable-blocks@1.1.18
- @wordpress/notices@1.1.2
- @wordpress/nux@3.0.6
- @wordpress/plugins@2.0.10
- @wordpress/rich-text@3.0.4
- @wordpress/url@2.3.3
- @wordpress/viewport@2.1.0
Props: youknowriad, gziolo, desrosj.
Fixes #45814 .
Built from https://develop.svn.wordpress.org/trunk@44389
git-svn-id: http://core.svn.wordpress.org/trunk@44219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-04 19:38:57 +00:00
8ac2091f5d
Docs: Update `since` tag for comment reply link improvements.
...
Originally added in [42360].
Fixes #31590 .
Built from https://develop.svn.wordpress.org/trunk@44388
git-svn-id: http://core.svn.wordpress.org/trunk@44218 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-03 19:29:51 +00:00
a814e5d34e
Build tools: Allow building WordPress to `src`.
...
After the JavaScript reorganization in [43309], it was no longer possible to test WordPress from the `src` folder. That meant a build step was required to test PHP modifications. That is suboptimal as even a simple copy is slower than a web server just serving the new file.
We achieve building to `src` by setting a `WORKING_DIR` constant in the Gruntfile that is `build` by default, but changes to `src` when the `--dev` flag is present on any Grunt command. We provide sensible defaults so some commands, such as copying `version.php`, always build to `build`.
Because testing from `build` is no longer required, we change the messages present in `index.php` and `wp-admin/index.php` to be more broadly about building WordPress.
We also change the webpack config to have more straightforward behavior based on the `buildTarget` argument. It only determines the build target now and has no implicit behavior anymore. `grunt build` still works as it worked before, to make sure that the build server produces the same `wordpress.zip` we are used to.
We do all this instead of a symlink setup because symlinks don't work on every platform.
Props omarreiss, netweb, flixos90, SergeyBiryukov.
Fixes #44492 .
Built from https://develop.svn.wordpress.org/trunk@44359
git-svn-id: http://core.svn.wordpress.org/trunk@44189 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-12-24 13:29:50 +00:00
0211420001
External Libraries: zxcvbn library.
...
This reverts [44354] for more investigation into inconsistent password strength values that passed locally prior to commit.
Unprops omarreiss, netweb, desrosj.
See #43749 .
Built from https://develop.svn.wordpress.org/trunk@44356
git-svn-id: http://core.svn.wordpress.org/trunk@44186 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-12-20 21:03:49 +00:00
7e99487473
External Libraries: Update zxcvbn to 4.2.2.
...
Version 4.2.2 of the zxcvbn password strength library has several bug fixes. A full list of changes can be seen here: https://github.com/dropbox/zxcvbn/compare/v4.4.1...v4.4.2 .
This commit also adds the library as a project dependency, making it easier to update in the future. Because the dictionary within the library contains non-PG language, a `rot13:zxcvbn` task has been added to Grunt to perform a ROT-13 cipher on the library. This task has been added to `grunt build` and `grunt build:js`.
Props omarreiss, netweb, desrosj.
Fixes #43749 .
Built from https://develop.svn.wordpress.org/trunk@44354
git-svn-id: http://core.svn.wordpress.org/trunk@44184 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-12-20 19:46:50 +00:00
413050b191
Block Editor: Upgrade @WordPress packages to the latest version (4.7.1)
...
Updated packages:
- @wordpress/block-library@2.2.11
- @wordpress/edit-post@3.1.6
- @wordpress/editor@9.0.6
- @wordpress/format-library@1.2.9
Props youknowriad, pento.
Merges [44287] to trunk.
Fixes #45637 .
Built from https://develop.svn.wordpress.org/trunk@44319
git-svn-id: http://core.svn.wordpress.org/trunk@44149 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-12-19 03:35:38 +00:00
d6e8d93412
Block Editor: Upgrade `@wordpress` packages to match version 4.7.1.
...
Updated packages:
- `@wordpress/annotations
- `@wordpress/api-fetch
- `@wordpress/block-library@2.2.10
- `@wordpress/block-serialization-default-parser@2.0.2`
- `@wordpress/block-serialization-spec-parser@2.0.2`
- `@wordpress/blocks@6.0.4`
- `@wordpress/components@7.0.4`
- `@wordpress/core-data@2.0.15`
- `@wordpress/data@4.1.0`
- `@wordpress/date@3.0.1`
- `@wordpress/edit-post@3.1.5`
- `@wordpress/editor@9.0.5`
- `@wordpress/eslint-plugin@1.0.0`
- `@wordpress/format-library@1.2.8`
- `@wordpress/html-entities@2.0.4`
- `@wordpress/list-reusable-blocks@1.1.17`
- `@wordpress/notices@1.1.1`
- `@wordpress/nux@3.0.5`
- `@wordpress/rich-text@3.0.3`
- `@wordpress/url@2.3.2`
- `@wordpress/viewport@2.0.13`
This also includes the updates the Core blocks.
The script loader is updated to match the Gutenberg repository as well.
Props atimmer, gziolo, joen, youknowriad.
Merges [44183] to trunk.
Fixes #45442 , #45637 .
Built from https://develop.svn.wordpress.org/trunk@44296
git-svn-id: http://core.svn.wordpress.org/trunk@44126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-12-19 03:16:48 +00:00
8f4440eb10
Build Tools: Don't include `.map` files in the build.
...
These files are fairly large, and while they're useful in development, they're not needed in the final build.
Props pento, mcsf.
Merges [43931] and [43932] to trunk.
See #45201 .
Built from https://develop.svn.wordpress.org/trunk@44282
git-svn-id: http://core.svn.wordpress.org/trunk@44112 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-12-18 03:14:52 +00:00
077e2c5fcf
Block Editor: Update @wordpress package dependencies.
...
Updates the following packages:
block-library, block-serialization-default-parser, block-serialization-spec-parser, blocks, edit-post, editor, format-library.
Merges [43955] to trunk.
Props youknowriad.
Fixes #45145 .
Built from https://develop.svn.wordpress.org/trunk@44281
git-svn-id: http://core.svn.wordpress.org/trunk@44111 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-12-17 21:59:54 +00:00
03262a191f
Block Editor: Refresh nonces used by `wp.apiFetch`.
...
Adds heartbeat nonces refreshing support to `wp.apiFetch` requests.
Props pento, adamsilverstein, dd32, desrosj, youknowriad.
Merges [43939] into trunk.
Fixes #45113 .
Built from https://develop.svn.wordpress.org/trunk@44275
git-svn-id: http://core.svn.wordpress.org/trunk@44105 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-12-17 19:28:51 +00:00
36158d7909
Block Editor: Update `@wordpress` package dependencies.
...
Update packages include:
- block-library
- components
- edit-post
- editor
- format-library
- list-reusable-blocks
- nux
Other changes:
- Fix a translator comment in `edit-form-blocks.php`.
- Rename the `gutenberg_` functions in `blocks/latest-comments.php`.
Props noisy socks, youknowriad, pinto, swissspidy.
Merges [43935] and [43949-43951] into trunk.
See #45145 .
Built from https://develop.svn.wordpress.org/trunk@44273
git-svn-id: http://core.svn.wordpress.org/trunk@44103 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-12-17 19:06:59 +00:00
4f86a03258
Block Editor: Update `@wordpress` dependencies to match Gutenberg 4.5.1.
...
- Update the annotations, api-fetch, block-library, blocks, components, compose, core-data, data, date, dom, edit-post, editor, element, format-library, html-entities, i18n, jest-console, jest-preset-default, keycodes, list-reusable-blocks, notices, nux, plugins, rich-text, scripts, token-lists, url, viewport packages.
- Upgrades React from 16.5.2 to 16.6.3.
- Adds a missing `wp-date` dependency to the editor script.
- Updates changed dependencies in `script-loader.php`.
- Fixes undefined notices in some blocks.
- Removes incorrect `gutenberg` textdomain.
Merges [43891], [43903], and [43919] to trunk.
Props atimmer, aduth, youknowriad, danielbachhuber.
See #45145 .
Built from https://develop.svn.wordpress.org/trunk@44262
git-svn-id: http://core.svn.wordpress.org/trunk@44092 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-12-17 15:37:00 +00:00
9d7aa3436e
Block Editor: Update `@wordpress` dependencies.
...
Changes of note:
- Includes the new Annotations API package.
- `wp-polyfill-ecmascript.js` is renamed to `wp-polyfill.js`.
- `strip_dynamic_blocks()` has been removed in favor of `excerpt_remove_blocks()`.
- The PHP block parser is now syncing from the `block-serialization-default-parser` package.
- `do_blocks()` uses the new parser.
- The `do_block` filter has been removed from `do_blocks()`, in favor of a `render_block` filter in `render_block()`.
Also, a little cleanup to `render_block()`. Always normalize `$block['attrs’]` to array in `’render_block’` filter.
Props pento, azaozz.
Merges [43884] and [43888] to trunk.
See #45145 , #45190 , #45264 , #45282 .
Built from https://develop.svn.wordpress.org/trunk@44261
git-svn-id: http://core.svn.wordpress.org/trunk@44091 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-12-17 04:52:00 +00:00
6ffafa5bc7
TinyMCE: Fix the keyboard shortcut (Alt+Shift+H) to not open the default Block Editor help modal and change the title of the help modal to "Classic Block Keyboard Shortcuts" in the Classic BLock. Also remove Alt+Shift+Z in the Classic Block as it conflicts with the Block Editor.
...
Props azaozz.
Merges [43915] to trunk.
Fixes #45365 .
Built from https://develop.svn.wordpress.org/trunk@44257
git-svn-id: http://core.svn.wordpress.org/trunk@44087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-12-17 03:32:21 +00:00
e8cbdf9405
Block Editor: Fix the TinyMCE `wordpress` plugin to handle hiding/showing of toolbars in the classic block. Change the classic block toolbar to use the (now fixed) `wp_adv` button.
...
Props azaozz.
Merges [43889] and [43890] to trunk.
Fixes #45264 .
Built from https://develop.svn.wordpress.org/trunk@44247
git-svn-id: http://core.svn.wordpress.org/trunk@44077 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-12-17 03:23:55 +00:00
b93dd61e90
Blocks: Add "Export as JSON" action to the `wp_block` post list screen.
...
Remove the "Quick Edit" for `wp_block`s, too, as they don't need any of that functionality.
Merges [43854] from the 5.0 branch to trunk.
Props noisysocks.
Fixes #45247 .
Built from https://develop.svn.wordpress.org/trunk@44220
git-svn-id: http://core.svn.wordpress.org/trunk@44050 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-12-17 03:01:05 +00:00
7616bf91af
FTP/PemFTP Library: Fix some PHP notices.
...
ftp_base::glob() used each(), which is deprecated as of PHP 7.2.
ftp_base::fget() was missing the decleration of its third parameter, $rest.
Props itowhid06, pento.
Merges [43848] to trunk.
Fixes #44489 .
Built from https://develop.svn.wordpress.org/trunk@44184
git-svn-id: http://core.svn.wordpress.org/trunk@44014 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-12-15 11:00:40 +00:00
96b2a4677c
Build Tools: Update the @wordpress packages.
...
Trunk now matches Gutenberg 4.2 RC1.
Props pento.
Merges [43847] to trunk.
See #45145 .
Built from https://develop.svn.wordpress.org/trunk@44182
git-svn-id: http://core.svn.wordpress.org/trunk@44012 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-12-14 12:20:00 +00:00
e055e026e3
l10n: Avoid calling is_user_logged_in() in determine_locale().
...
is_user_logged_in() is a pluggable function, and loaded after plugins are loaded. If a plugin calls __() too early, is_user_logged_in() is missing and WordPress will fatal. get_user_locale() already handles this scenario for us, so it's safe to rely on exclusively.
Props danielbachhuber.
Merges [43846] to trunk.
See #44758 .
Fixes #45235 .
Built from https://develop.svn.wordpress.org/trunk@44181
git-svn-id: http://core.svn.wordpress.org/trunk@44011 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-12-14 12:15:54 +00:00
Andrea Fercia
desrosj
antpb
gziolo
Andrew Ozz
whyisjake
Adam Silverstein
Sergey Biryukov
Tammie Lister
Gary Pendergast
youknowriad
atimmer
John Blackbourn
aduth
Ella Iseulde Van Dorpe
Peter Wilson
Dominik Schilling
Jeremy Felt