Commit Graph

15200 Commits

Author SHA1 Message Date
Adam Silverstein 0b9a800512 Media: remove any `attachment-filter` query param when switching views.
Fix an issue where the media attachment filter no longer worked after switching to list view, filtering by a media type then switching back to the grid view.

Props itzmekhokan, netsurfer2705, zodiac1978.
Fixes #43656.


Built from https://develop.svn.wordpress.org/trunk@47915


git-svn-id: http://core.svn.wordpress.org/trunk@47689 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-05 21:13:10 +00:00
Sergey Biryukov f546fe5aa5 Networks and Sites: Update the link text for "Debugging a WordPress Network" support article in `ms_not_installed()`.
Props Presskopp.
Fixes #50326.
Built from https://develop.svn.wordpress.org/trunk@47914


git-svn-id: http://core.svn.wordpress.org/trunk@47688 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-05 09:13:08 +00:00
Sergey Biryukov 4bbb7fb852 Docs: Update the DocBlock for the `wp_media_attach_action` hook per the documentation standards.
Rename the `$att_id` variable to `$attachment_id` for clarity.

Follow-up to [47909].

See #49614.
Built from https://develop.svn.wordpress.org/trunk@47913


git-svn-id: http://core.svn.wordpress.org/trunk@47687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-05 08:30:10 +00:00
desrosj 07a3972bc3 Docs: Fix a typo in the Docker compose file.
See #49572.
Built from https://develop.svn.wordpress.org/trunk@47912


git-svn-id: http://core.svn.wordpress.org/trunk@47686 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-04 16:53:09 +00:00
whyisjake 00df557404 REST API: Ensure that all properties of `get_endpoint_args_for_item_schema` are listed.
* Add new var $valid_schema_properties to match rest_validate_value_from_schema()
* Unit test to ensure all valid properties exists, and non-valid properties are ignored

Fixes: #50301.
Props: pentatonicfunk, TimothyBlynJacobs.


Built from https://develop.svn.wordpress.org/trunk@47911


git-svn-id: http://core.svn.wordpress.org/trunk@47685 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-04 16:43:08 +00:00
desrosj b013a15d43 Accessibility: Add the `aria-hidden` attribute to the auto-update related icons.
`<span>` elements used for displaying icons should use the `aria-hidden` attribute as they are purely decorative.

Props audrasjb, ryokuhi.
Fixes #50293.
Built from https://develop.svn.wordpress.org/trunk@47910


git-svn-id: http://core.svn.wordpress.org/trunk@47684 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-04 15:47:09 +00:00
whyisjake 00d3696923 Media: Add an action for `wp_media_attach_action`.
This action fires when media is attached/detached from a post.

Fixes: #49614.
Props: jonoaldersonwp, antpb, rebasaurus, donmhico. 


Built from https://develop.svn.wordpress.org/trunk@47909


git-svn-id: http://core.svn.wordpress.org/trunk@47683 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-04 15:00:09 +00:00
Sergey Biryukov 0eaae8ebbf Docs: Update type for `WP_Block_Type::$style` property.
Follow-up to [47907].

See #48529.
Built from https://develop.svn.wordpress.org/trunk@47908


git-svn-id: http://core.svn.wordpress.org/trunk@47682 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-04 10:44:10 +00:00
gziolo eec4c743fa Blocks: Update default value for some fields in WP_Block_Type
Related to the issue with default values for the blocks registered on the server. By using null for some fields we can treat them as undefined on the client.

See: WordPress/gutenberg#22849.
Props aduth.
Fixes #48529. 


Built from https://develop.svn.wordpress.org/trunk@47907


git-svn-id: http://core.svn.wordpress.org/trunk@47681 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-04 06:07:13 +00:00
Sergey Biryukov b50e87d52b Docs: Add missing `@global` reference for the `$post_id` global in `wp_admin_bar_edit_menu()`.
Follow-up to [47903].

Props davidbaumwald.
See #50312.
Built from https://develop.svn.wordpress.org/trunk@47906


git-svn-id: http://core.svn.wordpress.org/trunk@47680 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-03 21:27:09 +00:00
desrosj 2ef561db67 Build/Test Tools: Revert [47901].
This is not matching branches as desired.

Unrops desrosj, jorbin, ocean90, TimothyBlynJacobs.
Fixes #50307.
Built from https://develop.svn.wordpress.org/trunk@47905


git-svn-id: http://core.svn.wordpress.org/trunk@47679 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-03 21:14:09 +00:00
Aaron Jorbin df343d59f2 Build/Test: Die with an error if populate_network fails
If you are missing WP_TESTS_EMAIL, populate_network will fail and it can be hard to debug. As populate_network can return a wp_error object, we can detect that and display the error to a user.

See: https://github.com/WordPress/gutenberg/pull/22613
Fixes: #50251
Props: TimothyBlynJacobs

Built from https://develop.svn.wordpress.org/trunk@47904


git-svn-id: http://core.svn.wordpress.org/trunk@47678 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-03 21:04:10 +00:00
Sergey Biryukov 524f188982 Toolbar: Display a "View Post" link when viewing comments for a single post on Comments screen.
Props Otto42, matt, SergeyBiryukov.
Fixes #50312.
Built from https://develop.svn.wordpress.org/trunk@47903


git-svn-id: http://core.svn.wordpress.org/trunk@47677 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-03 19:57:10 +00:00
desrosj 27485fd7aa General: Continuing to work towards a passing PHP Compatibility scan.
This is a final pass to fix PHP compatibiilty issues in the codebase with code changes or adding `phpcs:ignore` comments.

With this change, all PHP compatibility warnings and errors without specific tickets have been addressed (see #49810 and #41750).

Props desrosj, johnbillion, jrf.
See #49922.
Built from https://develop.svn.wordpress.org/trunk@47902


git-svn-id: http://core.svn.wordpress.org/trunk@47676 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-03 17:40:12 +00:00
desrosj e2790b4e63 Build/Test Tools: Disable Travis CI build Slack notifications for non-official branches.
When branches are unintentionally pushed to the GitHub `wordpress-develop` mirror by committers, a build is triggered in Travis and the result is reported in Slack if the criteria defined is met.

Though this is not the desired workflow (any modifications made to the mirror are erased when the repository is synced from SVN), this can cause a lot of noise if several pushes are made and raise false alarms.

This change limits builds only to the `master` branch, and branches meeting the `X.X` pattern to match each branched version.

Props desrosj, jorbin, ocean90, TimothyBlynJacobs.
Fixes #50307.
Built from https://develop.svn.wordpress.org/trunk@47901


git-svn-id: http://core.svn.wordpress.org/trunk@47675 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-03 17:03:12 +00:00
Sergey Biryukov 353def14e2 Docs: Document the `term_order` value for the `orderby` parameter of `WP_Term_Query::__construct()`.
Props pbiron.
See #49572.
Built from https://develop.svn.wordpress.org/trunk@47898


git-svn-id: http://core.svn.wordpress.org/trunk@47672 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-03 14:41:06 +00:00
Sergey Biryukov 5636fb886b Docs: Reformat the `orderby` section of `WP_Term_Query::__construct()` for better readability.
This makes it more consistent with the `fields` section.

See #49572.
Built from https://develop.svn.wordpress.org/trunk@47897


git-svn-id: http://core.svn.wordpress.org/trunk@47671 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-03 14:37:09 +00:00
Sergey Biryukov f22e113e95 File Editor: Don't verify SSL certificate when doing loopback requests for checking for fatal errors.
Previously, verification was disabled for the loopback request to the admin URL, but not to the home URL.

Follow-up to [46230].

Props munyagu.
Fixes #50309. See #47957.
Built from https://develop.svn.wordpress.org/trunk@47896


git-svn-id: http://core.svn.wordpress.org/trunk@47670 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-03 11:43:15 +00:00
Sergey Biryukov 683507fe14 External Libraries: Update clipboard.js to 2.0.6.
This change includes some bug fixes and removal of the PhantomJS dependency.

Changelog: https://github.com/zenorocha/clipboard.js/compare/v2.0.4...v2.0.6

Props hareesh-pillai.
Fixes #50306.
Built from https://develop.svn.wordpress.org/trunk@47895


git-svn-id: http://core.svn.wordpress.org/trunk@47669 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-03 11:12:33 +00:00
Sergey Biryukov cf597dcf7c Plugins: Make the message displayed when no plugins are installed more concise.
Props johnjamesjacoby, Presskopp.
Fixes #42336.
Built from https://develop.svn.wordpress.org/trunk@47894


git-svn-id: http://core.svn.wordpress.org/trunk@47668 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-03 10:51:13 +00:00
Sergey Biryukov b247cafd91 Docs: Correct `@since` version for `available_permalink_structure_tags` filter.
Follow-up to [41182].

Props tiagohillebrandt, sabernhardt.
Fixes #42624.
Built from https://develop.svn.wordpress.org/trunk@47893


git-svn-id: http://core.svn.wordpress.org/trunk@47667 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-03 10:38:09 +00:00
Sergey Biryukov 72b5018aa3 Docs: Miscellaneous DocBlock corrections.
See #49572.
Built from https://develop.svn.wordpress.org/trunk@47892


git-svn-id: http://core.svn.wordpress.org/trunk@47666 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-03 10:02:13 +00:00
Adam Silverstein 86b50870ec Formatting: add a new 'safe_style_disallowed_chars' filter.
Enable developers to change the regex used in `safecss_filter_attr` to limit characters in the parsed CSS.

Props paulschreiber, swissspidy, rmccue, bartekcholewa, miinasikk.
Fixes #37134.


Built from https://develop.svn.wordpress.org/trunk@47891


git-svn-id: http://core.svn.wordpress.org/trunk@47665 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-02 23:46:11 +00:00
Sergey Biryukov 569c006248 Comments: Rename `Walker_Comment::comment_text()` to `::filter_comment_text()` for clarity.
Ensure the comment object is not null before checking its status.

Follow-up to [47887].

See #49956.
Built from https://develop.svn.wordpress.org/trunk@47889


git-svn-id: http://core.svn.wordpress.org/trunk@47663 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-02 21:45:10 +00:00
whyisjake 9f86174e08 Comments: Ensure that unmoderated comments won't be search indexed.
After a comment is submitted, only allow a brief window where the comment is live on the site. 

Fixes #49956.
Props: jonkolbert, ayeshrajans, Asif2BD, peterwilsoncc, imath, audrasjb, jonoaldersonwp, whyisjake.

Built from https://develop.svn.wordpress.org/trunk@47887


git-svn-id: http://core.svn.wordpress.org/trunk@47661 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-02 20:12:07 +00:00
Sergey Biryukov 30b61fc9e8 Bundled Themes: Consistently check for `WP_Error` before outputting `get_the_tag_list()`.
Some themes already had these checks in place as a result of [41756], but not others.

Props sixhours, davidakennedy, SergeyBiryukov.
Fixes #39860.
Built from https://develop.svn.wordpress.org/trunk@47886


git-svn-id: http://core.svn.wordpress.org/trunk@47660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-02 17:05:13 +00:00
Sergey Biryukov 3fd1fe298a Docs: Correct `@param` type for `pre_redirect_guess_404_permalink` filter.
Improve filter documentation for consistency with other similar short-circuit filters in core.

Follow-up to [47878].

See #16557.
Built from https://develop.svn.wordpress.org/trunk@47885


git-svn-id: http://core.svn.wordpress.org/trunk@47659 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-02 16:23:11 +00:00
Dominik Schilling ba92ed7615 I18N: Use `wp.i18n` for translatable strings in `wp-admin/js/updates.js`.
This removes the usage of `wp_localize_script()` for passing translations to the script and instead adds the translatable strings in the script directly through the use of `wp.i18n` and its utilities.

Props swissspidy, ocean90.
See #20491.
Fixes #50235.
Built from https://develop.svn.wordpress.org/trunk@47884


git-svn-id: http://core.svn.wordpress.org/trunk@47658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-01 21:41:09 +00:00
Andrew Ozz 0318a92948 Plugins and Themes Auto-Updates: update the state of the auto-update link on the themes screen after successfully saving the setting.
Props desrosj, pbiron, azaozz.
Fixes #50291.
Built from https://develop.svn.wordpress.org/trunk@47883


git-svn-id: http://core.svn.wordpress.org/trunk@47657 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-01 20:53:15 +00:00
Dominik Schilling 94be20e612 Build/Test Tools: Avoid an empty "title" heading if no title is set in `_wp_die_handler_exit()` and `_wp_die_handler_txt()`.
Fixes #50297.
Built from https://develop.svn.wordpress.org/trunk@47882


git-svn-id: http://core.svn.wordpress.org/trunk@47656 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-01 20:50:08 +00:00
Dominik Schilling c5ac08ba45 Build/Test Tools: Add PHPUnit to Composer dev dependencies.
This helps setting up the correct version of PHPUnit to run WordPress core tests locally and for using it as source for code autocompletion in tests. Also introduces a new Composer script `test` to run the PHPUnit tests.

Props welcher, ayeshrajans, vinkla, johnbillion, Rarst, netweb, ocean90.
Fixes #46815.
Built from https://develop.svn.wordpress.org/trunk@47881


git-svn-id: http://core.svn.wordpress.org/trunk@47655 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-01 20:31:07 +00:00
Dominik Schilling c7aab4121f Build/Test Tools: Let `WP_UnitTestCase_Base` extend the namespaced version of PHPUnit's test case class.
With the minimum PHP version requirement set to 5.6 we're now able to use namespaces by default. This replaces `PHPUnit_Framework_TestCase` with `PHPUnit\Framework\TestCase` for `WP_UnitTestCase_Base` to solve autocompletion issues with code editors when using more recent PHPUnit versions. `PHPUnit\Framework\TestCase` is available since PHPUnit 5.4 and now the minimum required PHPUnit version.

Fixes #50236.
Built from https://develop.svn.wordpress.org/trunk@47880


git-svn-id: http://core.svn.wordpress.org/trunk@47654 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-01 19:43:13 +00:00
whyisjake 69a866a1a9 Administration: Unify the date structure in list view and excerpt view.
Both views now show a full date string. Something like `Published 2020/05/27 at 10:25 pm`.

Fixes: #35391.
Props: afercia, ocean90, TimothyBlynJacobs, audrasjb, SergeyBiryukov, joedolson.


Built from https://develop.svn.wordpress.org/trunk@47879


git-svn-id: http://core.svn.wordpress.org/trunk@47653 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-01 19:15:08 +00:00
whyisjake f201c1b217 Canonical: Add the ability to disable `redirect_guess_404_permalink()`.
This also adds a few more filters to make adding redirects easier. Notably:

1. `do_redirect_guess_404_permalink`
2. `pre_redirect_guess_404_permalink`
3. `strict_redirect_guess_404_permalink`

Fixes: #16557.
Props: msafi, nacin, simonwheatley, westi, mboynes, joostdevalk, Lex_Robinson, MikeSchinkel, haukep, paulschreiber, DrewAPicture, ravenswd, esemlabel, stevegibson12, martychc23, DrLightman, jivanpal, neonkowy, laternastudio, apedog, audrasjb, davidbaumwald, Confridin, donmhico, ryotsun. 


Built from https://develop.svn.wordpress.org/trunk@47878


git-svn-id: http://core.svn.wordpress.org/trunk@47652 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-01 18:49:10 +00:00
Dominik Schilling b65cf7f992 Build/Test Tools: Improve Travis config to pass config validation.
* Add missing `os` and `dist` with the current default values.
* Replace the alias `matrix` with `jobs`.
* Remove unsupported `on_start` for `notifications.slack`.

Fixes #50296.
Built from https://develop.svn.wordpress.org/trunk@47877


git-svn-id: http://core.svn.wordpress.org/trunk@47651 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-01 16:39:08 +00:00
Dominik Schilling 7152c73f6a Editor: Fix code style for constructor arguments added in [47875].
Also revert unintended changes to `WP_Block_Type::__construct()` DocBlock.

See #48529.
Built from https://develop.svn.wordpress.org/trunk@47876


git-svn-id: http://core.svn.wordpress.org/trunk@47650 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-01 16:27:15 +00:00
gziolo c704057e0d Add fields to WP_Block_Type
As part of #47620 and the RFC for block registeration. Server registered blocks are missing some fields. These changeset includes them.

Props spacedmonkey, aduth.

Fixes #48529.


Built from https://develop.svn.wordpress.org/trunk@47875


git-svn-id: http://core.svn.wordpress.org/trunk@47649 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-01 12:27:08 +00:00
Sergey Biryukov 1c176ffb1e Docs: Correct and clarify an inline comment about the `upload_url_path` and `upload_path` options in `wp-admin/options-media.php`.
Synchronize it with a similar comment in `wp-admin/options.php`.

See #49572.
Built from https://develop.svn.wordpress.org/trunk@47874


git-svn-id: http://core.svn.wordpress.org/trunk@47648 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-01 11:22:13 +00:00
Sergey Biryukov cda84f2409 Build/Test Tools: Bump `node-sass` and `webpack-dev-server` versions as a result of `npm audit`.
Props whyisjake.
See #49768.
Built from https://develop.svn.wordpress.org/trunk@47873


git-svn-id: http://core.svn.wordpress.org/trunk@47647 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-31 20:24:46 +00:00
Sergey Biryukov f7da44c8d2 Upgrade/Install: Rename `wp_in_maintenance_mode()` to `wp_is_maintenance_mode()`, for consistency with `wp_is_recovery_mode()`.
While the former name might be a bit more accurate, the latter matches the existing naming pattern.

Follow-up to [47623].

Fixes #49959.
Built from https://develop.svn.wordpress.org/trunk@47871


git-svn-id: http://core.svn.wordpress.org/trunk@47646 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-31 19:54:24 +00:00
Sergey Biryukov 5f47ca5b8b Docs: Adjust the documentation for the new `ID` alias in `get_term_by()` for consistency with `get_user_by()`.
Follow-up to [47865].

See #45163.
Built from https://develop.svn.wordpress.org/trunk@47870


git-svn-id: http://core.svn.wordpress.org/trunk@47645 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-31 19:53:04 +00:00
whyisjake 9859bf6204 Build/Test Tools: Revert some devDependency changes for 5.5.
After bumping some major updates, tests on Travis are failing. 

See: https://travis-ci.com/WordPress/wordpress-develop/builds/168839259 ##49768.
Unprops: whyisjake.


Built from https://develop.svn.wordpress.org/trunk@47869


git-svn-id: http://core.svn.wordpress.org/trunk@47644 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-31 19:51:42 +00:00
whyisjake ef135efa6d Build/Test Tools: Bump devDependencies for WordPress 5.5
There are several other changes that need to be made for the security audit, this is just the first pass.

Fixes #49768.
Props SergeyBiryukov, whyisjake.

Built from https://develop.svn.wordpress.org/trunk@47867


git-svn-id: http://core.svn.wordpress.org/trunk@47643 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-30 04:56:34 +00:00
whyisjake e8fa5d6fc2 Code Standards: Clean up whitespace on the end of a file.
See: #45163.
Props: whyisjake.


Built from https://develop.svn.wordpress.org/trunk@47866


git-svn-id: http://core.svn.wordpress.org/trunk@47642 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-29 23:35:11 +00:00
whyisjake 7798f64340 Taxonomy: Extend `get_term_by` to accept `ID` as a term parameter.
Similar to `get_user_by`, both `ID` and `id` should be able to accepted.

Fixes #45163.
Props emrikol, esoj.
 

Built from https://develop.svn.wordpress.org/trunk@47865


git-svn-id: http://core.svn.wordpress.org/trunk@47641 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-29 22:43:09 +00:00
Sergey Biryukov 2277a9df24 Docs: Improve documentation for functions in `wp-includes/category.php` per the documentation standards.
See #49572.
Built from https://develop.svn.wordpress.org/trunk@47864


git-svn-id: http://core.svn.wordpress.org/trunk@47640 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-29 10:07:10 +00:00
Sergey Biryukov bc18c233d6 Docs: Document that `get_category_by_slug()` returns `false` if the category doesn't exist.
Props stevenlinx.
Fixes #50277.
Built from https://develop.svn.wordpress.org/trunk@47863


git-svn-id: http://core.svn.wordpress.org/trunk@47639 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-29 10:02:13 +00:00
Sergey Biryukov 8924832842 Coding Standards: Use strict comparison in `wp-admin/_index.php`.
See #49542.
Built from https://develop.svn.wordpress.org/trunk@47862


git-svn-id: http://core.svn.wordpress.org/trunk@47638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-28 10:02:12 +00:00
Sergey Biryukov 8713fac0d7 Docs: Remove unused `@global` declarations from `_WP_Editors::print_tinymce_scripts()`.
Follow-up to [47860].

See #45398.
Built from https://develop.svn.wordpress.org/trunk@47861


git-svn-id: http://core.svn.wordpress.org/trunk@47637 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-27 19:48:11 +00:00
whyisjake 552883574b Editor: Remove TinyMCE global version.
The global variable is not being used in the `editor_settings` method. 

Fixes #45398.
Props ishitaka, noisysocks, mista-flo.


Built from https://develop.svn.wordpress.org/trunk@47860


git-svn-id: http://core.svn.wordpress.org/trunk@47636 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-27 19:28:12 +00:00