WordPress-C
/
WordPress
mirror of https://github.com/WordPress/WordPress.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
42,260 Commits 50 Branches 749 Tags 991 MiB
Commit Graph

29464 Commits

Author SHA1 Message Date
Sergey Biryukov 39be515e7d Tests: Add more fixtures to `get_lastpostdate()` and `get_lastpostmodified()` tests. 
Follow-up to [48631].

Props munyagu.
See #47777.
Built from https://develop.svn.wordpress.org/trunk@48633


git-svn-id: http://core.svn.wordpress.org/trunk@48395 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-27 11:17:08 +00:00
Mike Schroder 9ec7f2febd Docs: Correct `wp_opcache_invalidate_file` filter docs. 
Changes incorrectly named `$filename` variable to `$filepath` and adjusts wording to align with PHP docs.

See #36455.
Built from https://develop.svn.wordpress.org/trunk@48632


git-svn-id: http://core.svn.wordpress.org/trunk@48394 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-27 09:08:05 +00:00
Sergey Biryukov 4c0a764adc Posts, Post Types: Pass the post type to `get_lastpostdate()` in `get_lastpostmodified()`. 
This ensures that the correct values are being compared when retrieving the result for custom post types.

Additionally, pass the `$post_type` parameter to `get_lastpostdate` and `get_lastpostmodified` filters.

Props mikaumoto, munyagu, donmhico, johnbillion, SergeyBiryukov.
Fixes #47777.
Built from https://develop.svn.wordpress.org/trunk@48631


git-svn-id: http://core.svn.wordpress.org/trunk@48393 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-27 02:18:05 +00:00
Sergey Biryukov f547eb6174 Docs: Improve documentation for `WP_Http::processHeaders()`. 
Document the `@return` value using hash notation.

Props marekdedic, valchovski, davidbaumwald, deepaklalwani, thimalw, SergeyBiryukov.
Fixes #48350.
Built from https://develop.svn.wordpress.org/trunk@48630


git-svn-id: http://core.svn.wordpress.org/trunk@48392 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-26 22:45:03 +00:00
Sergey Biryukov 9f841ea7c3 Docs: Add a note that the `$args` parameter of `register_block_type()` accepts any public property of `WP_Block_Type`. 
Follow-up to [47754].

Props ediamin.
See #48640.
Built from https://develop.svn.wordpress.org/trunk@48629


git-svn-id: http://core.svn.wordpress.org/trunk@48391 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-26 22:17:01 +00:00
Sergey Biryukov aa22457754 REST API: Use a consistent description for the `textdomain` schema property between plugins and themes controllers. 
Follow-up to [48242], [48627].

Props audrasjb.
Fixes #50776. See #50321.
Built from https://develop.svn.wordpress.org/trunk@48628


git-svn-id: http://core.svn.wordpress.org/trunk@48390 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-26 21:54:03 +00:00
Sergey Biryukov e7eaaa97b1 REST API: Use a consistent name for the `textdomain` schema property between plugins, themes, and block directory controllers. 
Follow-up to [48242].

See #50321, #50776.
Built from https://develop.svn.wordpress.org/trunk@48627


git-svn-id: http://core.svn.wordpress.org/trunk@48389 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-26 21:49:03 +00:00
Sergey Biryukov 61b2cb7761 Docs: Correct `@since` version for `WP_REST_Plugins_Controller::get_item_schema()`. 
Follow-up to [48242].

See #50321.
Built from https://develop.svn.wordpress.org/trunk@48626


git-svn-id: http://core.svn.wordpress.org/trunk@48388 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-26 21:42:03 +00:00
Sergey Biryukov df74d8f10d Revisions: Ensure the global `$post` remains the same after revision is restored. 
Because `wp_insert_post()` and `wp_transition_post_status()` are called during the process, plugins can unexpectedly modify `$post`.

Props markparnell, tofandel, archon810, SergeyBiryukov.
Fixes #46671.
Built from https://develop.svn.wordpress.org/trunk@48625


git-svn-id: http://core.svn.wordpress.org/trunk@48387 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-26 21:25:02 +00:00
Sergey Biryukov a6cf8df9d1 Docs: Synchronize some comments in `wp-admin/revision.php`. 
See #49572.
Built from https://develop.svn.wordpress.org/trunk@48624


git-svn-id: http://core.svn.wordpress.org/trunk@48386 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-26 20:43:02 +00:00
Sergey Biryukov 33b3ea7bfe Docs: Improve documentation for various category functions. 
Props atachibana.
Fixes #48394.
Built from https://develop.svn.wordpress.org/trunk@48623


git-svn-id: http://core.svn.wordpress.org/trunk@48385 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-26 17:18:04 +00:00
Sergey Biryukov 93429bb561 Coding Standards: Rename the `$id` parameter in various category functions for clarity. 
See #49542.
Built from https://develop.svn.wordpress.org/trunk@48622


git-svn-id: http://core.svn.wordpress.org/trunk@48384 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-26 16:07:06 +00:00
Sergey Biryukov 6731940272 Pings/Trackbacks: Avoid a PHP notice in `do_enclose()` when encountering a URL without a path in post content. 
Props jbouganim, mukesh27, Otto42, SergeyBiryukov.
Fixes #49872.
Built from https://develop.svn.wordpress.org/trunk@48621


git-svn-id: http://core.svn.wordpress.org/trunk@48383 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-26 14:08:05 +00:00
Sergey Biryukov d8c62b5647 Posts, Post Types: Move `get_post_states()` back to the admin for now, require the file in `WP_Customize_Nav_Menus::customize_register()` instead. 
This provides a minor performance improvement by only running the function in contexts where it's needed.

Follow-up to [47211], [47213], [47763], [48619].

See #46829, #49374.
Built from https://develop.svn.wordpress.org/trunk@48620


git-svn-id: http://core.svn.wordpress.org/trunk@48382 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-26 10:51:06 +00:00
Sergey Biryukov aab535a576 Posts, Post Types: Make `get_post_states()` available on frontend. 
This allows special pages to be denoted as such when editing a menu in the Customizer.

This applies to the Front Page, Posts Page, and Privacy Policy Page.

Follow-up to [47211], [47213], [47763].

Props dlh, whyisjake, SergeyBiryukov.
Fixes #46829. See #49374.
Built from https://develop.svn.wordpress.org/trunk@48619


git-svn-id: http://core.svn.wordpress.org/trunk@48381 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-26 01:14:06 +00:00
Sergey Biryukov 609acd89ed I18N: Merge duplicate "List view" and "Grid view" strings. 
Props ramiy.
Fixes #50757.
Built from https://develop.svn.wordpress.org/trunk@48618


git-svn-id: http://core.svn.wordpress.org/trunk@48380 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-25 21:32:05 +00:00
Sergey Biryukov c88c8db417 Docs: Add a reference to `WP_Customize_Partial::__construct()` for information on accepted arguments in `WP_Customize_Selective_Refresh::add_partial()`. 
Synchronize the documentation between two places, use `WP_Customize_Partial::__construct()` as the canonical source.

Props marekdedic.
See #49572.
Built from https://develop.svn.wordpress.org/trunk@48617


git-svn-id: http://core.svn.wordpress.org/trunk@48379 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-25 19:40:05 +00:00
Sergey Biryukov c40a645510 Docs: Correct `@see` references for privacy hooks: 
* `wp_privacy_personal_data_export_page`
* `wp_privacy_personal_data_erasure_page`

Hooks should be single-quoted when referenced.

Props pbiron, coffee2code.
See #49572, #meta5318.
Built from https://develop.svn.wordpress.org/trunk@48616


git-svn-id: http://core.svn.wordpress.org/trunk@48378 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-25 19:14:03 +00:00
Sergey Biryukov 7d305c8ff9 Docs: Correct `@since` tags for some `WP_List_Table` hooks: 
* `views_{$this->screen->id}`
* `bulk_actions-{$this->screen->id}`
* `manage_{$this->screen->id}_sortable_columns`

Follow-up to [15491], [15578], [26401].

See #49572.
Built from https://develop.svn.wordpress.org/trunk@48615


git-svn-id: http://core.svn.wordpress.org/trunk@48377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-25 18:55:03 +00:00
Sergey Biryukov 0ef0a1905b Docs: Remove outdated statement in `bulk_actions-{$this->screen->id}` filter description. 
As of WordPress 4.7, developers can register their own bulk actions on list table screens.

Follow-up to [17297], [38647].

Props joyously, pbiron.
See #49572.
Built from https://develop.svn.wordpress.org/trunk@48614


git-svn-id: http://core.svn.wordpress.org/trunk@48376 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-25 18:13:02 +00:00
Sergey Biryukov ebfe7ca39a I18N: Remove `<code>` tags in an error message in `WP_REST_Posts_Controller::get_item_schema()` for consistency with other strings. 
Follow-up to [48610].

See #50759.
Built from https://develop.svn.wordpress.org/trunk@48613


git-svn-id: http://core.svn.wordpress.org/trunk@48375 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-25 16:41:02 +00:00
Sergey Biryukov 92f66488a3 I18N: Remove `<code>` tags in `invalid_rest_prepare_callback` error message in `register_theme_feature()` for consistency with other strings. 
Follow-up to [48611].

See #50758.
Built from https://develop.svn.wordpress.org/trunk@48612


git-svn-id: http://core.svn.wordpress.org/trunk@48374 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-25 16:39:05 +00:00
Sergey Biryukov ac0b77f33c I18N: Move code out of a translatable string in `register_theme_feature()`. 
Props ramiy.
Fixes #50758.
Built from https://develop.svn.wordpress.org/trunk@48611


git-svn-id: http://core.svn.wordpress.org/trunk@48373 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-25 16:31:05 +00:00
Sergey Biryukov 29b0a259df I18N: Move code out of a translatable string in `WP_REST_Posts_Controller::get_item_schema()`. 
Props ramiy.
Fixes #50759.
Built from https://develop.svn.wordpress.org/trunk@48610


git-svn-id: http://core.svn.wordpress.org/trunk@48372 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-25 16:28:04 +00:00
Sergey Biryukov 08271f4192 I18N: Move code out of a translatable string in `WP_Customize_Manager::customize_preview_init()`. 
Props ramiy.
Fixes #50760.
Built from https://develop.svn.wordpress.org/trunk@48609


git-svn-id: http://core.svn.wordpress.org/trunk@48371 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-25 16:01:07 +00:00
Sergey Biryukov ef382e6aaf Site Health: Escape the displayed result of the request in REST API availability test. 
Props siliconforks, gisselfeldt.
Fixes #50588.
Built from https://develop.svn.wordpress.org/trunk@48608


git-svn-id: http://core.svn.wordpress.org/trunk@48370 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-25 15:38:06 +00:00
Sergey Biryukov ed9d53ec1f I18N: Respect the passed `text_direction` argument in `wp_die()`. 
Previously, the passed value was only used as a fallback if `get_language_attributes()` is not yet available.

Props apedog.
Fixes #49060.
Built from https://develop.svn.wordpress.org/trunk@48607


git-svn-id: http://core.svn.wordpress.org/trunk@48369 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-25 15:26:05 +00:00
Sergey Biryukov d07fc084af Docs: Improve description for `wp_unique_filename()`. 
Props stevenlinx.
Fixes #50762.
Built from https://develop.svn.wordpress.org/trunk@48606


git-svn-id: http://core.svn.wordpress.org/trunk@48368 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-25 12:31:05 +00:00
Sergey Biryukov b82cee898b Bundled Themes: Rebuild Twenty Nineteen’s RTL stylesheet. 
This adds the changes from [48073] to the `style-rtl.css` file.

Previously committed in [48514], accidentally reverted in [48602].

See #45912, #49843.
Built from https://develop.svn.wordpress.org/trunk@48605


git-svn-id: http://core.svn.wordpress.org/trunk@48367 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-24 18:32:03 +00:00
Sergey Biryukov 11f57087c5 Tests: Update `wp_unique_filename()` unit tests to account for `sanitize_file_name()` removing accents. 
Follow-up to [48603].

See #22363.
Built from https://develop.svn.wordpress.org/trunk@48604


git-svn-id: http://core.svn.wordpress.org/trunk@48366 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-24 18:19:03 +00:00
Sergey Biryukov 101d00601e Media: Remove accents in `sanitize_file_name()`. 
This brings some consistency with `sanitize_title()` and `sanitize_user()`.

Props tar.gz, NumidWasNotAvailable, juliobox, p_enrique, cristovaov, zodiac1978, mikeschroder, markoheijnen, chriscct7, swissspidy, DrProtocols, pento, gitlost, joemcgill, dustinbolton, programmin, Vayu, MaximeCulea, lucasbustamante, nilovelez, RavanH, audrasjb, SergeyBiryukov.
See #22363.
Built from https://develop.svn.wordpress.org/trunk@48603


git-svn-id: http://core.svn.wordpress.org/trunk@48365 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-24 18:03:02 +00:00
whyisjake f06efa4e29 Bundled Theme: Ensure parity between the block editor and the front-end in twentynineteen. 
Alignments and blocks were not always appearing as they should in the admin.

- Wide alignments sometimes appear only as wide as the text column.
- Full and wide appear centered on the text column
- Full-width blocks sometimes do not take up the full width of the page, and other times they cause a horizontal scroll.
- Wide and full group block children take up the full width of the block by default.

Fixes #49843.
Props kjellr, Joen, poena.

Built from https://develop.svn.wordpress.org/trunk@48602


git-svn-id: http://core.svn.wordpress.org/trunk@48364 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-24 17:48:04 +00:00
whyisjake d7453598b3 Mail: Ensure that a server hostname can be set by using `network_home_url()`. 
Due to the varying server setups, `$_SERVER['SERVER_NAME'];` can't reliably ensure that there will be a relevant host that could be used as the hostname in an email. Since the `network_home_url()` is set at this point, and is filterable, this should better enable emails to be sent from the server.

Fixes #25239.
Props layotte, SergeyBiryukov, nacin, sreedoap, szepe.viktor, jesin, kitchin, mensmaximus, mt8.biz, Grzegorz.Janoszka, cbutlerjr, dd32, BjornW, neodjandre, BjornW, Ipstenu, ocean90, danielbachhuber, desmith, joemcgill, jdgrimes, riasat, derekakelly, swissspidy, lilmike, tsimmons, robert.peake, DavidAnderson, cloudstek, pigdog234, BjornW, rawrly, pessoft, RedSand, seayou, dvershinin, bastho, chesio, Starbuck, afragen, ocean90, whyisjake.

Built from https://develop.svn.wordpress.org/trunk@48601


git-svn-id: http://core.svn.wordpress.org/trunk@48363 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-24 17:40:06 +00:00
Sergey Biryukov b31a5f7569 Docs: Correct documentation for `wp_insert_term()`. 
The function is used for adding a new term, not updating an existing one.

Props audrasjb, bmartinent.
Fixes #50753.
Built from https://develop.svn.wordpress.org/trunk@48600


git-svn-id: http://core.svn.wordpress.org/trunk@48362 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-24 12:19:05 +00:00
Sergey Biryukov faf85323a6 Docs: Correct some documentation for `wp_update_term()`. 
See #49572.
Built from https://develop.svn.wordpress.org/trunk@48599


git-svn-id: http://core.svn.wordpress.org/trunk@48361 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-24 12:04:08 +00:00
Sergey Biryukov 4fcbb1ee5d Docs: Add a mention of `core-block-patterns` as a possible value for `add_theme_support()`. 
Follow-up to [48492].

See #50669.
Built from https://develop.svn.wordpress.org/trunk@48598


git-svn-id: http://core.svn.wordpress.org/trunk@48360 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-24 01:21:01 +00:00
Sergey Biryukov 7913a1c7db Docs: Improve documentation for `wp_list_comments()`. 
Note that passing `div` to the `style` parameter will result in no additional list markup.

Props liuhaibin, jeremyfelt, functionalrhyme.
Fixes #49181.
Built from https://develop.svn.wordpress.org/trunk@48597


git-svn-id: http://core.svn.wordpress.org/trunk@48359 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-24 01:11:02 +00:00
Sergey Biryukov 544fbefffa Media: Filter out a few more special characters in `sanitize_file_name()`. 
Props audrasjb.
Fixes #50231.
Built from https://develop.svn.wordpress.org/trunk@48596


git-svn-id: http://core.svn.wordpress.org/trunk@48358 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-24 00:59:07 +00:00
Sergey Biryukov b6f52721ed Administration: Use sentence case for "Mark as spam" bulk action links for sites and users, for consistency with comments. 
Follow-up to [48352].

See #40244.
Built from https://develop.svn.wordpress.org/trunk@48595


git-svn-id: http://core.svn.wordpress.org/trunk@48357 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-24 00:27:03 +00:00
Sergey Biryukov 703a978a77 Administration: Capitalize `Trash` consistently in various messages. 
When used as a noun referring to the "virtual" place, `Trash` should be capitalized.

Follow-up to [47233], [48352].

See #45317, #40244.
Built from https://develop.svn.wordpress.org/trunk@48594


git-svn-id: http://core.svn.wordpress.org/trunk@48356 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-24 00:21:03 +00:00
Sergey Biryukov e1830a8182 Formatting: Filter out the bullet character in `sanitize_title_with_dashes()`. 
Props roytanck, deepaklalwani, veromary.
Fixes #49791.
Built from https://develop.svn.wordpress.org/trunk@48593


git-svn-id: http://core.svn.wordpress.org/trunk@48355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-24 00:03:05 +00:00
Sergey Biryukov 1f3c2fba20 Build/Test Tools: Check if all the required constants are defined before running the test suite. 
Follow-up to [47904].

Props azaozz, TimothyBlynJacobs, SergeyBiryukov.
Fixes #50251.
Built from https://develop.svn.wordpress.org/trunk@48592


git-svn-id: http://core.svn.wordpress.org/trunk@48354 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-23 23:28:03 +00:00
Sergey Biryukov d936f2c959 Docs: Miscellaneous DocBlock corrections. 
See #49572.
Built from https://develop.svn.wordpress.org/trunk@48591


git-svn-id: http://core.svn.wordpress.org/trunk@48353 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-23 21:55:04 +00:00
John Blackbourn 9bc7d0a776 Docs: Another pass at some inline docs fixes mostly made by PHPCBF. 
See #49572, #50744
Built from https://develop.svn.wordpress.org/trunk@48590


git-svn-id: http://core.svn.wordpress.org/trunk@48352 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-23 21:11:05 +00:00
Sergey Biryukov 3f04e3bf5c I18N: Further adjust some update/install strings for consistency. 
Follow-up to [48568], [48569].

See #50708, #50714.
Built from https://develop.svn.wordpress.org/trunk@48589


git-svn-id: http://core.svn.wordpress.org/trunk@48351 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-23 21:08:01 +00:00
Sergey Biryukov 5950e15042 I18N: Merge two "Return to top" strings. 
Props ramiy, carike, whyisjake.
Fixes #50743.
Built from https://develop.svn.wordpress.org/trunk@48588


git-svn-id: http://core.svn.wordpress.org/trunk@48350 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-23 20:21:07 +00:00
Sergey Biryukov 161821d155 Site Health: Correct the quotes for the `tested` value of mock plugin data in auto-updates test. 
Follow-up to [48584].

See #50662.
Built from https://develop.svn.wordpress.org/trunk@48587


git-svn-id: http://core.svn.wordpress.org/trunk@48349 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-23 20:13:05 +00:00
John Blackbourn 57a3f803ae Docs: First pass at some inline docs fixes mostly made by PHPCBF. 
See #49572, #50744
Built from https://develop.svn.wordpress.org/trunk@48586


git-svn-id: http://core.svn.wordpress.org/trunk@48348 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-23 20:01:04 +00:00
John Blackbourn 7f898dd9c4 Docs: Use more appropriate variable names in the inline docs for action and filter parameters. 
See #49572
Built from https://develop.svn.wordpress.org/trunk@48585


git-svn-id: http://core.svn.wordpress.org/trunk@48347 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-23 19:06:03 +00:00
desrosj 231d21ebcd Site Health: Pass all expected parameters to `auto_update_{$type}`. 
This prevents fatal errors when other hooked functions are expecting both parameters. 

Props dd32, desrosj, audrasjb, pbiron.
Fixes #50662.
Built from https://develop.svn.wordpress.org/trunk@48584


git-svn-id: http://core.svn.wordpress.org/trunk@48346 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-23 19:03:04 +00:00
Sergey Biryukov 0eb1b2a447 I18N: Update "Default Template" string to match the sentence case used in the block editor. 
Props ramiy.
Fixes #50742.
Built from https://develop.svn.wordpress.org/trunk@48583


git-svn-id: http://core.svn.wordpress.org/trunk@48345 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-23 18:55:01 +00:00
desrosj 2c2508f98c General: Ensure the database upgrades from [48575] are run. 
This corrects the database version to match the commit number the upgrade changes were made.

See #50413.
Built from https://develop.svn.wordpress.org/trunk@48582


git-svn-id: http://core.svn.wordpress.org/trunk@48344 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-23 18:43:04 +00:00
Sergey Biryukov 49cfbe6ba7 Tests: Update the `es_ES` string used in `wp_send_user_request()` tests to match the current translation. 
Props a2hosting.
Fixes #50741.
Built from https://develop.svn.wordpress.org/trunk@48581


git-svn-id: http://core.svn.wordpress.org/trunk@48343 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-23 18:23:04 +00:00
Sergey Biryukov 91bcefd456 Docs: Add missing description for `wp_convert_widget_settings()` parameters. 
Props stevenlinx.
Fixes #50738.
Built from https://develop.svn.wordpress.org/trunk@48580


git-svn-id: http://core.svn.wordpress.org/trunk@48342 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-23 13:50:02 +00:00
Sergey Biryukov 12747ac7b7 Coding Standards: Use a consistent naming pattern for variables in `wp-includes/comment-template.php`. 
See #49542.
Built from https://develop.svn.wordpress.org/trunk@48579


git-svn-id: http://core.svn.wordpress.org/trunk@48341 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-23 13:34:07 +00:00
Sergey Biryukov b8871c0323 I18N: Add context to privacy request status strings. 
These strings already have a context in `create_initial_post_types()`, and should use the same context in `_wp_privacy_statuses()`.

Props ramiy, audrasjb.
Fixes #50740.
Built from https://develop.svn.wordpress.org/trunk@48578


git-svn-id: http://core.svn.wordpress.org/trunk@48340 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-23 13:13:03 +00:00
Sergey Biryukov d1b980492f Docs: Improve description for `comment_id_fields()`. 
Rename the `$id` parameter to `$post_id` for clarity.

Props stevenlinx.
Fixes #50737.
Built from https://develop.svn.wordpress.org/trunk@48577


git-svn-id: http://core.svn.wordpress.org/trunk@48339 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-23 13:11:04 +00:00
John Blackbourn 124972f2c6 Docs: Further corrections and improvements to various inline docblocks. 
See #49572
Built from https://develop.svn.wordpress.org/trunk@48576


git-svn-id: http://core.svn.wordpress.org/trunk@48338 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-23 07:39:02 +00:00
Aaron Jorbin 6cab8cce22 General: Update code for readability and inclusion 
There are two pieces in here:

1) The update to change blacklist to blocklist is moved to disallowed_list. "Block" has a meaning in our code, and there could be ambiguity between this code and code related to blocks.

2) This improves backwards compatibility for code that was accessing the now deprecated code.

Previously: [48477], [48405], [48400], [48121], [48122], [48124], [48142], [48566]

Props: desrosj, SergeyBiryukov, johnjamesjacoby
Fixes: #50413


Built from https://develop.svn.wordpress.org/trunk@48575


git-svn-id: http://core.svn.wordpress.org/trunk@48337 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-23 03:14:06 +00:00
John Blackbourn 0bf9b04c53 Docs: Various formatting improvements to inline docblocks. 
See #49572
Built from https://develop.svn.wordpress.org/trunk@48574


git-svn-id: http://core.svn.wordpress.org/trunk@48336 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-23 00:52:05 +00:00
John Blackbourn 1fbcdb2213 Docs: Various corrections to inline docblocks. 
See #49572
Built from https://develop.svn.wordpress.org/trunk@48573


git-svn-id: http://core.svn.wordpress.org/trunk@48335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-23 00:48:06 +00:00
whyisjake daace832e3 Media: Add "loading" as an allowed kses image attribute 
With loading="lazy" being added to all images in [47554], let's ensure that it passes kses attributes too.

Fixes #50731.
Props TimothyBlynJacobs, peterwilsoncc, azaozz. 


Built from https://develop.svn.wordpress.org/trunk@48572


git-svn-id: http://core.svn.wordpress.org/trunk@48334 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-23 00:44:04 +00:00
TimothyBlynJacobs 51154cd1df REST API: Remove textdomain from doing it wrong message. 
See #50075.
Props dlh.

Built from https://develop.svn.wordpress.org/trunk@48571


git-svn-id: http://core.svn.wordpress.org/trunk@48333 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-22 22:31:04 +00:00
whyisjake 413fae70e8 i18n: Merge similar translation strings in wp-admin/options.php 
WARNING! is now Warning:

You have been warned.

Fixes #50715.
Props: ramiy, audrasjb, ocean90.


Built from https://develop.svn.wordpress.org/trunk@48570


git-svn-id: http://core.svn.wordpress.org/trunk@48332 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-22 22:21:03 +00:00
whyisjake dd642e7b00 i18n: Merge similar translation strings to "Update failed". 
Fixes #50714.
Props ramiy, ocean90.

Built from https://develop.svn.wordpress.org/trunk@48569


git-svn-id: http://core.svn.wordpress.org/trunk@48331 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-22 22:10:02 +00:00
whyisjake 921ddab889 I18N: Merge similar "Installation failed" strings 
Fixes #50708.

Props ramiy, ocean90, audrasjb.

Built from https://develop.svn.wordpress.org/trunk@48568


git-svn-id: http://core.svn.wordpress.org/trunk@48330 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-22 21:59:05 +00:00
whyisjake d1517a1ad4 I18N: Update some strings to have periods. 
Fixes #50707.
Props ramiy, afercia, audrasjb.

Built from https://develop.svn.wordpress.org/trunk@48567


git-svn-id: http://core.svn.wordpress.org/trunk@48329 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-22 21:55:06 +00:00
desrosj 2cebcb6144 General: Rename `remove_option_allowed_list()` to `remove_allowed_options()`. 
This was missed in [48142] which renamed `add_option_allowed_list()` to `add_allowed_options()` for better readability. The two functions should have consistent names.

See #50413.
Built from https://develop.svn.wordpress.org/trunk@48566


git-svn-id: http://core.svn.wordpress.org/trunk@48328 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-22 18:52:02 +00:00
Sergey Biryukov 3db2c3afd4 Upgrade/Install: Don't trigger database upgrade on Ajax requests via `wp-admin/async-upload.php`. 
Props schlessera, jgrodel, elrae, davidbaumwald, hareesh-pillai, adamsilverstein, SergeyBiryukov.
Fixes #39459.
Built from https://develop.svn.wordpress.org/trunk@48565


git-svn-id: http://core.svn.wordpress.org/trunk@48327 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-22 12:56:04 +00:00
Sergey Biryukov 6f0b8e2b2b Accessibility: Themes: Consistently use an underline for "Enable auto-updates" link and theme author link in theme overlay. 
Props chetan200891, sabernhardt, afercia.
Fixes #50697.
Built from https://develop.svn.wordpress.org/trunk@48564


git-svn-id: http://core.svn.wordpress.org/trunk@48326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-22 12:19:05 +00:00
Sergey Biryukov da43de528f Docs: Correct type and improve description for the `$fields` parameter of `WP_Query::parse_query()`. 
Props ocean90, palmiak, johannadevos, noisysocks.
Fixes #44305.
Built from https://develop.svn.wordpress.org/trunk@48563


git-svn-id: http://core.svn.wordpress.org/trunk@48325 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-22 11:37:02 +00:00
Sergey Biryukov ca4a76d1f5 Docs: Improve formatting of the `$fields` parameter description in `WP_Term_Query::__construct()`. 
See #44305, #49572.
Built from https://develop.svn.wordpress.org/trunk@48562


git-svn-id: http://core.svn.wordpress.org/trunk@48324 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-22 11:35:07 +00:00
Sergey Biryukov 1373b2056d Docs: Correct type for the `$theme` parameter of `theme_auto_update_debug_string` filter. 
Follow-up to [48546], [48549], [48552].

See #50663.
Built from https://develop.svn.wordpress.org/trunk@48561


git-svn-id: http://core.svn.wordpress.org/trunk@48323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-22 00:29:03 +00:00
Sergey Biryukov 88e046f1e8 Site Health: Fix some typos in the test for plugin and theme auto-updates. 
Follow-up to [48548], [48558], [48559].

See #50662.
Built from https://develop.svn.wordpress.org/trunk@48560


git-svn-id: http://core.svn.wordpress.org/trunk@48322 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-22 00:17:04 +00:00
Sergey Biryukov c6034be779 Site Health: Correct inverted logic for themes in the test for plugin and theme auto-updates. 
Follow-up to [48548], [48558].

See #50662.
Built from https://develop.svn.wordpress.org/trunk@48559


git-svn-id: http://core.svn.wordpress.org/trunk@48321 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-22 00:15:02 +00:00
Sergey Biryukov 93bf0c3b83 Site Health: Add the test for plugin and theme auto-updates to `WP_Site_Health::get_tests()`. 
This ensures that the test actually runs.

Follow-up to [48548].

See #50662.
Built from https://develop.svn.wordpress.org/trunk@48558


git-svn-id: http://core.svn.wordpress.org/trunk@48320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-22 00:07:02 +00:00
Sergey Biryukov 19779e6302 Widgets: Make sure image widgets with custom image size render captions. 
Props kasparsd, JavierCasares, audrasjb.
Fixes #50160.
Built from https://develop.svn.wordpress.org/trunk@48557


git-svn-id: http://core.svn.wordpress.org/trunk@48319 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-21 23:14:06 +00:00
Sergey Biryukov 5323fa05e5 REST API: Use consistent error messages when managing network plugins. 
Props ramiy.
Fixes #50729.
Built from https://develop.svn.wordpress.org/trunk@48556


git-svn-id: http://core.svn.wordpress.org/trunk@48318 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-21 22:01:03 +00:00
TimothyBlynJacobs 16784a5ea7 REST API: Optimize rest_filter_response_by_context performance. 
In [47758] a new function `rest_filter_response_by_context` was introduced to expand the JSON schema features supported by the context filtering mechanism.

This commit improves the performance of that function by eliminating repetitive comparisons and loops. Additionally, it improves multi-type support for object + array types.

Fixes #50700.
Props dlh.

Built from https://develop.svn.wordpress.org/trunk@48555


git-svn-id: http://core.svn.wordpress.org/trunk@48317 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-21 21:22:03 +00:00
Sergey Biryukov a68d462439 Site Health: Use a consistent label for theme auto-updates in debug data. 
Props audrasjb.
Fixes #50728.
Built from https://develop.svn.wordpress.org/trunk@48554


git-svn-id: http://core.svn.wordpress.org/trunk@48316 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-21 21:06:02 +00:00
Sergey Biryukov 00861d91dc Sitemaps: Rename `wp_register_sitemap()` to `wp_register_sitemap_provider()`. 
Follow-up to [48536], [48540], [48541].

Props pbiron.
Fixes #50724.
Built from https://develop.svn.wordpress.org/trunk@48553


git-svn-id: http://core.svn.wordpress.org/trunk@48315 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-21 20:15:02 +00:00
Sergey Biryukov 94d4561906 Site Health: Simplify the logic for displaying whether auto-updates are enabled for plugins and themes. 
Remove some extra variables.

Follow-up to [48546], [48549].

See #50663.
Built from https://develop.svn.wordpress.org/trunk@48552


git-svn-id: http://core.svn.wordpress.org/trunk@48314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-21 18:44:04 +00:00
whyisjake a5620dfdf6 WordPress 5.5 Beta 3 version bump. 
Built from https://develop.svn.wordpress.org/trunk@48551


git-svn-id: http://core.svn.wordpress.org/trunk@48313 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-21 17:56:05 +00:00
whyisjake 222721cd97 WordPress 5.5 Beta 3. 
Built from https://develop.svn.wordpress.org/trunk@48550


git-svn-id: http://core.svn.wordpress.org/trunk@48312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-21 17:32:04 +00:00
Sergey Biryukov 8a58ab36cc Site Health: Rename the filters added in [48546] for clarity. 
See #50663.
Built from https://develop.svn.wordpress.org/trunk@48549


git-svn-id: http://core.svn.wordpress.org/trunk@48311 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-21 17:09:03 +00:00
whyisjake 9d2b92be26 Site Health: Add tests to check for potential issues with plugin and theme auto-updates. 
Fixes #50662.
Props desrosj, audrasjb.

Built from https://develop.svn.wordpress.org/trunk@48548


git-svn-id: http://core.svn.wordpress.org/trunk@48310 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-21 17:07:05 +00:00
Sergey Biryukov 3061a680a9 Media: Pass the attachment ID to the `wp_image_file_matches_image_meta` filter. 
Props spacedmonkey.
Fixes #50722.
Built from https://develop.svn.wordpress.org/trunk@48547


git-svn-id: http://core.svn.wordpress.org/trunk@48309 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-21 16:55:08 +00:00
whyisjake 32f791da49 Site Health: Add auto-update information to for plugins and themes. 
New filters:

* `plugin_auto_update_debug_str`
* `theme_auto_update_debug_str`

Fixes #50663.
Props pbiron, audrasjb, davidbaumwald.

Built from https://develop.svn.wordpress.org/trunk@48546


git-svn-id: http://core.svn.wordpress.org/trunk@48308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-21 16:54:02 +00:00
Sergey Biryukov 548df4e3e6 I18N: Add context to some theme strings for consistency. 
Props ramiy, ocean90.
Fixes #50709.
Built from https://develop.svn.wordpress.org/trunk@48545


git-svn-id: http://core.svn.wordpress.org/trunk@48307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-21 16:33:05 +00:00
Sergey Biryukov 48841f9ab3 Site Health: Rename `upload_max` array key in file upload checks to `max_effective_size` for clarity. 
Follow-up to [48535].

See #50038.
Built from https://develop.svn.wordpress.org/trunk@48544


git-svn-id: http://core.svn.wordpress.org/trunk@48306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-21 16:20:03 +00:00
Pascal Birchler 1f153b0d12 Sitemaps: Replace `wp_sitemaps_register_providers` filter with more suitable `wp_sitemaps_add_provider` filter. 
The previous filter failed the goal of allowing developers to filter all providers before they are registered, since it only filtered the built-in ones.

The more specific `wp_sitemaps_add_provider` filter enables exactly that, as it filters every sitemap provider right before it is added to the sitemaps registry.

Props pbiron, pfefferle, Chouby, swissspidy.
Fixes #50660.
Built from https://develop.svn.wordpress.org/trunk@48543


git-svn-id: http://core.svn.wordpress.org/trunk@48305 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-21 16:14:07 +00:00
desrosj b6b2f2ac3f Administration: Ensure SVG icons in admin menus are correctly colored. 
Props ryelle.
Fixes #50555.
Built from https://develop.svn.wordpress.org/trunk@48542


git-svn-id: http://core.svn.wordpress.org/trunk@48304 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-21 16:10:06 +00:00
Sergey Biryukov 830f0b6563 Sitemaps: Rename `wp_get_sitemaps_providers()` to `wp_get_sitemap_providers()`. 
Follow-up to [48536], [48540].

Props pbiron, swissspidy, SergeyBiryukov.
See #50724.
Built from https://develop.svn.wordpress.org/trunk@48541


git-svn-id: http://core.svn.wordpress.org/trunk@48303 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-21 16:06:04 +00:00
Pascal Birchler 694b407297 Sitemaps: Rename `wp_get_sitemaps()` to `wp_get_sitemaps_providers()` 
Following [48536], rename the function to match the rest of the sitemaps logic.

Also eliminates some dead code after [48523].

Props pbiron.
See #50724. See #50643.
Built from https://develop.svn.wordpress.org/trunk@48540


git-svn-id: http://core.svn.wordpress.org/trunk@48302 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-21 15:57:04 +00:00
Sergey Biryukov 1c52ad8d3f Site Health: Move `post_max_size` and `upload_max_filesize` out of a translatable string in file upload checks. 
Simplify some other strings, use a consistent format for translator comments.

Follow-up to [48535].

See #50038.
Built from https://develop.svn.wordpress.org/trunk@48539


git-svn-id: http://core.svn.wordpress.org/trunk@48301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-21 15:53:04 +00:00
Sergey Biryukov bec9fa5010 Site Health: Remove `parse_ini_size()`, use the existing `wp_convert_hr_to_bytes()` function instead. 
Follow-up to [48535].

See #50038.
Built from https://develop.svn.wordpress.org/trunk@48538


git-svn-id: http://core.svn.wordpress.org/trunk@48300 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-21 15:40:03 +00:00
desrosj 3dda74c337 Editor: Ensure the required assets for the block directory are enqueued. 
This fixes an issue where the block directory appears unstyled due to the stylesheets not being enqueued.

Props ryelle, timothyblynjacobs, earnjam.
Fixes #50661.
Built from https://develop.svn.wordpress.org/trunk@48537


git-svn-id: http://core.svn.wordpress.org/trunk@48299 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-21 15:38:03 +00:00
Sergey Biryukov 12daeec1f7 Sitemaps: Rename 'sitemap' to 'provider' in `WP_Sitemaps_Registry` class. 
This class is for registering sitemap providers, not individual sitemaps.

Props swissspidy.
Fixes #50724.
Built from https://develop.svn.wordpress.org/trunk@48536


git-svn-id: http://core.svn.wordpress.org/trunk@48298 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-21 15:29:02 +00:00
whyisjake 73a8fb4cc3 Site Health: Include new tests to check for the ability to upload files. 
Several new checks:

* `max_file_uploads`
* `file_uploads`
* `post_max_size`
* `upload_max_filesize`
* `upload_max`
* `max_file_uploads`

In addition, new function `parse_ini_size()` that converts shorthand byte strings to bytes. Useful for size comparisons.

Fixes #50038.
Props dd32, donmhico, JavierCasares, SergeyBiryukov, ayeshrajans, Clorith, ipstenu, sabernhardt, whyisjake.

Built from https://develop.svn.wordpress.org/trunk@48535


git-svn-id: http://core.svn.wordpress.org/trunk@48297 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-21 15:21:02 +00:00
Sergey Biryukov d1822e81ba Site Health: Use consistent error messages when switching plugin or theme auto-updates on or off. 
Props ramiy.
Fixes #50721.
Built from https://develop.svn.wordpress.org/trunk@48534


git-svn-id: http://core.svn.wordpress.org/trunk@48296 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-21 14:42:05 +00:00
Sergey Biryukov 3cd9474d68 Block Editor: Move the `add_action()` call for `_register_core_block_patterns_and_categories()` above `check_theme_switched()`. 
Follow-up to [48492], [48531].

See #50669.
Built from https://develop.svn.wordpress.org/trunk@48533


git-svn-id: http://core.svn.wordpress.org/trunk@48295 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-21 14:37:07 +00:00
Pascal Birchler 1f27914191 Sitemaps: Correctly enforce maximum number of sitemaps in index. 
Before this change, the limit of 50k entries was enforced for the number of providers, not the amount of sitemaps all providers add to the index in total.

Props pbiron, swissspidy.
Fixes #50666.
Built from https://develop.svn.wordpress.org/trunk@48532


git-svn-id: http://core.svn.wordpress.org/trunk@48294 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-21 13:57:05 +00:00
Sergey Biryukov 6d207771d3 Block Editor: Move the `add_action()` call for `_register_core_block_patterns_and_categories()` to `wp-includes/default-filters.php`. 
Follow-up to [48492].

Props desrosj.
Fixes #50669.
Built from https://develop.svn.wordpress.org/trunk@48531


git-svn-id: http://core.svn.wordpress.org/trunk@48293 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-21 13:15:05 +00:00
Sergey Biryukov ee60c40806 Mail: Make sure the `PHPMailer` class is only required once if a plugin requires `wp-includes/class-phpmailer.php` directly. 
Follow-up to [48033].

Props david.binda.
Fixes #50716. See #41750.
Built from https://develop.svn.wordpress.org/trunk@48530


git-svn-id: http://core.svn.wordpress.org/trunk@48292 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-21 12:58:02 +00:00
Sergey Biryukov 9ce7bd633b Docs: Improve description for `edit_post()`. 
Props stevenlinx.
Fixes #50713.
Built from https://develop.svn.wordpress.org/trunk@48529


git-svn-id: http://core.svn.wordpress.org/trunk@48291 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-21 12:49:03 +00:00
Sergey Biryukov de462d2c20 Site Health: Correct the message for snoozed email verifications. 
Follow-up to [48522].

Fixes #48333.
Built from https://develop.svn.wordpress.org/trunk@48528


git-svn-id: http://core.svn.wordpress.org/trunk@48290 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-21 12:37:07 +00:00
ellatrix ec05ee2f5d Editor: update packages for Beta 3 
Fixes #50712.


Built from https://develop.svn.wordpress.org/trunk@48527


git-svn-id: http://core.svn.wordpress.org/trunk@48289 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-21 12:14:37 +00:00
TimothyBlynJacobs b8d5e161eb REST API: Issue a _doing_it_wrong when registering a route without a permission callback. 
The REST API treats routes without a permission_callback as public. Because this happens without any warning to the user, if the permission callback is unintentionally omitted or misspelled, the endpoint can end up being available to the public. Such a scenario has happened multiple times in the wild, and the results can be catostrophic when it occurs.

For REST API routes that are intended to be public, it is recommended to set the permission callback to the `__return_true` built in function.

Fixes #50075.
Props rmccue, sorenbronsted, whyisjake, SergeyBiryukov, TimothyBlynJacobs.

Built from https://develop.svn.wordpress.org/trunk@48526


git-svn-id: http://core.svn.wordpress.org/trunk@48288 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-21 12:03:05 +00:00
Andrew Ozz 562a59f553 REST API, Media: Add `X-WP-Upload-Attachment-ID` HTTP header to enable retrying of post-processing of edited images if the server runs out of resources. This is the same as after uploading a new image, will do up to five additional requests to let the server create all image sub-sizes. 
Fixes #50711.
Built from https://develop.svn.wordpress.org/trunk@48525


git-svn-id: http://core.svn.wordpress.org/trunk@48287 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-21 03:00:04 +00:00
TimothyBlynJacobs 84701f3812 REST API: Make plugin installation tests more robust on alternate test environments. 
The REST API plugin installation tests use the `upgrader_pre_download` filter to avoid downloading the test plugin from WordPress.org. Previously, this would apply to any upgrader, which caused issues if the testing environment required a language update.

Now, the filter only overwrites the file if the `Plugin_Upgrader` is being used which should hopefully prevent the issue.

Props pfefferle, TimothyBlynJacobs.
Fixes #50671.

Built from https://develop.svn.wordpress.org/trunk@48524


git-svn-id: http://core.svn.wordpress.org/trunk@48286 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-21 01:38:03 +00:00
whyisjake 7f92797960 Sitemaps: Ensure correct HTTP status when sitemaps are disabled 
If sitemaps are disabled, previously there would be a rewrite rule for the sitemap endpoint. This endpoint would display the homepage since there was a rewrite rule. Now, Sitemaps are loaded, and the proper HTTP headers are returned.

Fixes #50643.
Props swissspidy, kraftbj, donmhico.


Built from https://develop.svn.wordpress.org/trunk@48523


git-svn-id: http://core.svn.wordpress.org/trunk@48285 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-21 00:57:05 +00:00
whyisjake 7112440881 Site Health: Ensure that there is a human readable time for snoozed email verifications. 
This will be the time the was proposed, added to the reminder interval.

Fixes #48333.
Props SergeyBiryukov, desrosj.


Built from https://develop.svn.wordpress.org/trunk@48522


git-svn-id: http://core.svn.wordpress.org/trunk@48284 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-21 00:43:02 +00:00
whyisjake 5c836585d1 Comments: Don't show the filter/pagination actions if there are no comments to list. 
It doesn't make sense to be able to filter the comments list table when there are are no (trashed/spam) comments available.

Fixes #40188.
Props swissspidy, Jim_Panse, menakas, akbarhusen429, dinhtungdu, birgire, SergeyBiryukov, davidbaumwald, rebasaurus, whyisjake.


Built from https://develop.svn.wordpress.org/trunk@48521


git-svn-id: http://core.svn.wordpress.org/trunk@48283 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-21 00:29:02 +00:00
Sergey Biryukov e4ce35dd11 I18N: Add context to some plugin and theme strings for consistency. 
Props ramiy, audrasjb.
Fixes #50710.
Built from https://develop.svn.wordpress.org/trunk@48520


git-svn-id: http://core.svn.wordpress.org/trunk@48282 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-20 23:14:05 +00:00
Sergey Biryukov 82ce41ff51 I18N: Mark the strings with plugin and theme names in email notifications for translation. 
Follow-up to [48517].

See #50350.
Built from https://develop.svn.wordpress.org/trunk@48519


git-svn-id: http://core.svn.wordpress.org/trunk@48281 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-20 21:25:06 +00:00
Andrew Ozz c2639c74ff REST API, Media: Fix/improve the inline docs and name of the new `wp_edited_image_metadata` filter. 
Props desrosj, azaozz.

See #44405.
Built from https://develop.svn.wordpress.org/trunk@48518


git-svn-id: http://core.svn.wordpress.org/trunk@48280 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-20 21:04:03 +00:00
desrosj 02f200df1d Administration: Include the new plugin and theme versions in email notifications. 
This helps administrators keep track of which versions of plugins and themes are running on their site when auto-updates occur.

Props audrasjb, pbiron.
Fixes #50350.
Built from https://develop.svn.wordpress.org/trunk@48517


git-svn-id: http://core.svn.wordpress.org/trunk@48279 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-20 18:28:03 +00:00
Sergey Biryukov a368a22625 Tests: Simplify some assertions in `phpunit/tests/media.php`. 
Correct comments per the documentation standards.

Follow-up to [48496].

See #22101.
Built from https://develop.svn.wordpress.org/trunk@48516


git-svn-id: http://core.svn.wordpress.org/trunk@48278 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-20 15:49:07 +00:00
desrosj d298aec258 Build/Test Tools: Update NPM packages in Twenty Nineteen. 
This updates three packages:
- `@wordpress/browserslist-config` from `2.5.0` to `2.7.0`
- `autoprefixer` from `9.6.0` to `9.8.5`.
- `chokidar-cli` from `2.0.0` to `2.1.0`

See #49768.
Built from https://develop.svn.wordpress.org/trunk@48515


git-svn-id: http://core.svn.wordpress.org/trunk@48277 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-20 13:41:05 +00:00
desrosj bf8d963cfc Bundled Themes: Rebuild Twenty Nineteen’s RTL stylesheet. 
This adds the changes from [48073] to the `style-rtl.css` file.

See #45912.
Built from https://develop.svn.wordpress.org/trunk@48514


git-svn-id: http://core.svn.wordpress.org/trunk@48276 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-20 13:29:05 +00:00
desrosj cd6e936103 Embeds: Correct the version number when Hulu was deprecated. 
Follow up of [48512]
See #50676.
Built from https://develop.svn.wordpress.org/trunk@48513


git-svn-id: http://core.svn.wordpress.org/trunk@48275 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-20 13:14:04 +00:00
desrosj 511e9cfade Embeds: Remove Hulu from the list of supported oEmbed providers. 
The oEmbed service for Hulu no longer works and appears to have been silently disabled.

Props tacitonic, talldanwp, youknowriad, bph.
Fixes #50676.
Built from https://develop.svn.wordpress.org/trunk@48512


git-svn-id: http://core.svn.wordpress.org/trunk@48274 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-20 13:12:01 +00:00
Sergey Biryukov 637d9df95a Docs: Improve description for `add_user_to_blog()`. 
Props stevenlinx.
Fixes #50701.
Built from https://develop.svn.wordpress.org/trunk@48511


git-svn-id: http://core.svn.wordpress.org/trunk@48273 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-20 11:54:05 +00:00
Andrew Ozz 689c224476 Media: Migrate the data from the attachment post of the parent image when saving an edited image. Copy: 
- `post_title`,
- `post_content` (image description),
- `post_excerpt` (image caption as saved in the DB),
- `_wp_attachment_image_alt` meta (alt text for the img tag as saved in the DB).

Props spacedmonkey, joedolson, TimothyBlynJacobs, azaozz.
Fixes #50675.
Built from https://develop.svn.wordpress.org/trunk@48510


git-svn-id: http://core.svn.wordpress.org/trunk@48272 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-19 21:19:04 +00:00
Andrew Ozz efb77b4a65 Upgrade/install: Fix/clarify the "Upload in a zip format" string. 
Props greenshady, mariovalney.
See #9757.
Built from https://develop.svn.wordpress.org/trunk@48509


git-svn-id: http://core.svn.wordpress.org/trunk@48271 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-19 17:11:02 +00:00
John Blackbourn c3f787b8ff Docs: Miscellaneous docblock corrections. 
See #49572
Built from https://develop.svn.wordpress.org/trunk@48508


git-svn-id: http://core.svn.wordpress.org/trunk@48270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-18 22:11:02 +00:00
Sergey Biryukov d9a18d259b Coding Standards: Use strict comparison in `wp-includes/wp-db.php`. 
Props jenilk.
Fixes #49453.
Built from https://develop.svn.wordpress.org/trunk@48507


git-svn-id: http://core.svn.wordpress.org/trunk@48269 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-18 11:39:04 +00:00
desrosj c482c8e8ad Administration: Reverse the arrow direction for database import/export icons. 
In [48456], database import and export icons were introduced. However, the arrows were pointing in the wrong directions. This reverses the arrows to be pointing correctly based on the action described in the name.

Props johnbillion, joen, desrosj, empireoflight.
Fixes #49913.
Built from https://develop.svn.wordpress.org/trunk@48506


git-svn-id: http://core.svn.wordpress.org/trunk@48268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-17 17:11:03 +00:00
Sergey Biryukov 38400754a1 Options, Meta APIs: Reorder the parameters of `default_{$meta_type}_metadata` filter. 
This brings consistency with the `get_{$meta_type}_metadata` filter and more closely matches the `get_metadata_default()` function signature.

Follow-up to [48502].

Props spacedmonkey.
See #43941.
Built from https://develop.svn.wordpress.org/trunk@48505


git-svn-id: http://core.svn.wordpress.org/trunk@48267 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-17 15:15:03 +00:00
Sergey Biryukov 4cd355c5cf Docs: Correct documentation for the `$meta_key` parameter of `get_metadata_default()`. 
The parameter is required, not optional.

Follow-up to [48502].

See #43941.
Built from https://develop.svn.wordpress.org/trunk@48504


git-svn-id: http://core.svn.wordpress.org/trunk@48266 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-17 13:49:03 +00:00
whyisjake 59ee72969d Plugins: Update the height of the Install Now button for new plugins. 
Due to Thickbox shenanigans, the buttons height needed to be shrunk a little to center properly in the iframe.

Fixes #49828.

Props ibachal, Otto42, afercia.

Built from https://develop.svn.wordpress.org/trunk@48503


git-svn-id: http://core.svn.wordpress.org/trunk@48265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-17 06:29:06 +00:00
TimothyBlynJacobs f7268adfbf Meta: Reorder the get_metadata_default() signature to match get_metadata(). 
The order of parameters in `get_metadata_default()` did not match the signature of `get_metadata()`. This could be confusing for developers who are familiar with the existing metadata API.

Fixes #43941.
Props SergeyBiryukov, spacedmonkey, johnjamesjacoby.

Built from https://develop.svn.wordpress.org/trunk@48502


git-svn-id: http://core.svn.wordpress.org/trunk@48264 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-17 02:59:08 +00:00
whyisjake 265574802b Build/Test Tools: Bump lodash in twentytwenty as part of a security audit. 
lodash: 4.17.15 👉 4.17.19

See #49768.
Props: dependabot.


Built from https://develop.svn.wordpress.org/trunk@48501


git-svn-id: http://core.svn.wordpress.org/trunk@48263 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-16 22:24:11 +00:00
whyisjake da7a54d206 Administration: Fix an index inconsistency in `get_admin_page_title()` function. 
Ensure that `get_admin_page_title()` returns a value from pages registered using `add_menu_page()`.

Fixes #46081.

Props grapestain, valentinbora, SergeyBiryukov, audrasjb.


Built from https://develop.svn.wordpress.org/trunk@48500


git-svn-id: http://core.svn.wordpress.org/trunk@48262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-16 22:15:07 +00:00
whyisjake 322e38e285 Code Formatting: Fix some formatting around `WP_REST_Attachments_Controller` tests. 
See #50565.


Built from https://develop.svn.wordpress.org/trunk@48499


git-svn-id: http://core.svn.wordpress.org/trunk@48261 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-16 22:11:08 +00:00
Andrew Ozz 2d728713ac REST API: Prevent attachment ID/image source mismatch when editing an image. 
Fixes #50565.
Built from https://develop.svn.wordpress.org/trunk@48498


git-svn-id: http://core.svn.wordpress.org/trunk@48260 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-16 21:56:08 +00:00
whyisjake 4a237f2d48 Posts, Post Types: Ensure that all post stati are countable in `wp_count_posts`. 
When `wp_count_posts()` is cached, it does so with all statuses defaulted to 0. The problem is however, if this is called before all plugins have registered their desired statuses, they won't have that default.

Fixes #49685.

Props obliviousharmony, SergeyBiryukov.


Built from https://develop.svn.wordpress.org/trunk@48497


git-svn-id: http://core.svn.wordpress.org/trunk@48259 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-16 21:44:04 +00:00
whyisjake 69aaab5108 Feeds: Ensure that galleries can be output as a list of links in feeds. 
Adjusts the gallery shortcode handler to check for the `link` attribute when outputting to a feed.

Fixes #22101.

Props ifrins, mdgl, SergeyBiryukov, chriscct7, stevenkword, iworks, DrewAPicture, birgire, whyisjake.

Built from https://develop.svn.wordpress.org/trunk@48496


git-svn-id: http://core.svn.wordpress.org/trunk@48258 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-16 21:31:03 +00:00
whyisjake a53b741359 Coding Standards: Update the docblock to remove superflous `since`. 
The `@deprecated` DocBlock tag should start with the version followed by the description of what to use instead.

Fixes #44959.

Props keesiemeijer, sabernhardt.


Built from https://develop.svn.wordpress.org/trunk@48495


git-svn-id: http://core.svn.wordpress.org/trunk@48257 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-16 21:12:08 +00:00
youknowriad 6a88c91d3a Block Editor: Remove the gutenberg domain name from the block-patterns.php file 
Props SergeyBiryukov.
Fixes #50669.

Built from https://develop.svn.wordpress.org/trunk@48494


git-svn-id: http://core.svn.wordpress.org/trunk@48256 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-16 14:13:03 +00:00
Sergey Biryukov 64a4066874 Upgrade/Install: Check if the theme installer skin's `overwrite` property exists in `Theme_Upgrader::install_strings()`. 
This ensures consistency with `Plugin_Upgrader::install_strings()` and resolves an issue caused by the property not existing in other upgrader implementations.

Props schlessera, azaozz.
See #50670.
Built from https://develop.svn.wordpress.org/trunk@48493


git-svn-id: http://core.svn.wordpress.org/trunk@48255 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-16 13:19:03 +00:00
youknowriad 17f6c106c3 Block Editor: Add theme support flag to opt-out of Core Block Patterns. 
WordPress Core comes by default with a number of block patterns and a frequent request was to be able to opt-out of the Core block patterns. 
You can now opt-out using remove_theme_support( 'core-block-patterns' )

Props desrosj, nosolosw.
Fixes #50669.

Built from https://develop.svn.wordpress.org/trunk@48492


git-svn-id: http://core.svn.wordpress.org/trunk@48254 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-16 11:50:07 +00:00
Sergey Biryukov 4d8ef49618 Docs: Add return value description for `register_theme_directory()`. 
Props stevenlinx.
Fixes #50665.
Built from https://develop.svn.wordpress.org/trunk@48491


git-svn-id: http://core.svn.wordpress.org/trunk@48253 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-15 12:10:06 +00:00
Sergey Biryukov 9515141741 Docs: Link to `add_theme_support()` for the list of supported theme features in `current_theme_supports()` and related functions. 
Props stevenlinx.
Fixes #50657.
Built from https://develop.svn.wordpress.org/trunk@48490


git-svn-id: http://core.svn.wordpress.org/trunk@48252 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-15 11:23:06 +00:00
whyisjake a7b21c1255 Post 5.5 Beta 2 version bump. 
Built from https://develop.svn.wordpress.org/trunk@48482


git-svn-id: http://core.svn.wordpress.org/trunk@48251 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-14 17:41:04 +00:00
whyisjake d7e37a00b7 WordPress 5.5 Beta 2. 
Built from https://develop.svn.wordpress.org/trunk@48481


git-svn-id: http://core.svn.wordpress.org/trunk@48250 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-14 17:02:01 +00:00
Sergey Biryukov 49a9cede70 Taxonomy: Make some adjustments to handling default terms for custom taxonomies: 
* Move default term assignment from `wp_set_object_terms()` to `wp_insert_post()`.
* Make sure the passed taxonomy list overwrites the existing list if not empty.
* Remove the default term option on `unregister_taxonomy()`.
* Prevent deletion of the default term in `wp_delete_term()`.

Props enrico.sorcinelli, TimothyBlynJacobs.
See #43517.
Built from https://develop.svn.wordpress.org/trunk@48480


git-svn-id: http://core.svn.wordpress.org/trunk@48249 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-14 16:41:03 +00:00
Andrea Fercia 9e8d1b1a68 Accessibility: Security: Improves the accessible audible messages for Plugins & Themes Auto-Updates. 
- changes the politeness level of the two error messages introduced in [47835] to `assertive`
- remove unnecessary `polite` parameters as that's the default value

See #50512, #50052.


Built from https://develop.svn.wordpress.org/trunk@48479


git-svn-id: http://core.svn.wordpress.org/trunk@48248 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-14 15:46:02 +00:00
Sergey Biryukov 0ce2ddce47 Docs: Synchronize description for the `$allowed_html` parameter of various KSES functions. 
Follow-up to [43016].

Props Christian1012, jdgrimes, markparnell.
Fixes #39542. See #33801.
Built from https://develop.svn.wordpress.org/trunk@48478


git-svn-id: http://core.svn.wordpress.org/trunk@48247 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-14 12:41:03 +00:00
desrosj fdd88e24ed General: Rename the `$new_whitelist_options` global variable. 
This change renames `$new_whitelist_options` to `$new_allowed_options`. This makes the variable’s purpose more clear, and promotes using more inclusive language.

For backwards compatibility, the new variable is passed by reference to the old one.

Follow up to [48121].

Props ayeshrajans, desrosj, jorbin, SergeyBiryukov.
See #50413.
Fixes #50434.
Built from https://develop.svn.wordpress.org/trunk@48477


git-svn-id: http://core.svn.wordpress.org/trunk@48246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-14 12:33:02 +00:00
Pascal Birchler 2c92383b8d Sitemaps: Ensure entry for ‘page’ post type sitemap in index. 
If there are no pages and no static homepage, there will still be one sitemap including the homepage URL.

This change ensures that this sitemap is correctly listed in the sitemap index.

Props Chouby, pacifika, elrae.
Fixes #50571.
Built from https://develop.svn.wordpress.org/trunk@48476


git-svn-id: http://core.svn.wordpress.org/trunk@48245 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-14 12:26:02 +00:00
John Blackbourn 5eb3f0ffcb Docs: Improve docs for arguments that accept a numerically indexed array of associative arrays. 
See #49572
Built from https://develop.svn.wordpress.org/trunk@48475


git-svn-id: http://core.svn.wordpress.org/trunk@48244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-14 12:10:05 +00:00
Pascal Birchler acca036e88 Sitemaps: Exclude post types and taxonomies that are not publicly queryable. 
Props Cybr.
Fixes #50607.
Built from https://develop.svn.wordpress.org/trunk@48474


git-svn-id: http://core.svn.wordpress.org/trunk@48243 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-14 11:57:06 +00:00
John Blackbourn 4ff1233e75 Docs: Correct and improve inline docs for parameters that accept a callback function. 
See #49572
Built from https://develop.svn.wordpress.org/trunk@48473


git-svn-id: http://core.svn.wordpress.org/trunk@48242 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-14 11:56:04 +00:00
Pascal Birchler 7757fe0b0c Sitemaps: Add missing slash when calling `home_url()` for consistency. 
Props Chouby.
Fixes #50570.
Built from https://develop.svn.wordpress.org/trunk@48472


git-svn-id: http://core.svn.wordpress.org/trunk@48241 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-14 11:54:06 +00:00
Pascal Birchler c1ac7b5e16 Sitemaps: Add wrapping `<div>` around sitemap in stylesheet. 
This makes it easier to style the sitemap and for example center the entire content area.

Props ramiy.
Fixes #50622.
Built from https://develop.svn.wordpress.org/trunk@48471


git-svn-id: http://core.svn.wordpress.org/trunk@48240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-14 11:45:03 +00:00
Pascal Birchler 66c6ad97bc Sitemaps: Pass full paths to `home_url()` calls. 
This makes it easier for plugins using the `home_url` filter to detect sitemap URLs.

Props Chouby.
Fixes #50592.
Built from https://develop.svn.wordpress.org/trunk@48470


git-svn-id: http://core.svn.wordpress.org/trunk@48239 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-14 11:43:03 +00:00
ellatrix cc32e7f753 Editor: update packages for beta 2 
Fixes #50651.


Built from https://develop.svn.wordpress.org/trunk@48469


git-svn-id: http://core.svn.wordpress.org/trunk@48238 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-14 11:39:09 +00:00
Sergey Biryukov b40e44dd69 Privacy: Set the direction for the "Username or email address" field on privacy screens to LTR. 
This is consistent with other email inputs across the admin.

Follow-up to [27743], [42967].

Props man4toman, sushyant.
Fixes #50625.
Built from https://develop.svn.wordpress.org/trunk@48468


git-svn-id: http://core.svn.wordpress.org/trunk@48237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-14 11:17:04 +00:00
Sergey Biryukov 4bfc4070b8 Docs: Improve description for `get_blog_post()`. 
Props stevenlinx.
Fixes #50655.
Built from https://develop.svn.wordpress.org/trunk@48467


git-svn-id: http://core.svn.wordpress.org/trunk@48236 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-14 11:06:08 +00:00
Sergey Biryukov 258bbe75cd Tests: Ignore EOL differences in some tests using multiline string assertions. 
Unix vs. Windows EOL style mismatches can cause misleading failures in tests using the heredoc syntax (`<<<`) or multiline strings as the expected result.

Follow-up to [46612], [48443].

See #31432.
Built from https://develop.svn.wordpress.org/trunk@48466


git-svn-id: http://core.svn.wordpress.org/trunk@48235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-14 01:42:04 +00:00
Andrew Ozz 02d1cc0fea Administration: Attempt to even-out the new Up/Down arrows in metabox headings and make them look a bit better. Also group them a little closer together in an attempt to reduce confusion of having two down arrows next to one another. Move the focus outline to the button instead of only the icon. 
Fixes #39074.
Built from https://develop.svn.wordpress.org/trunk@48465


git-svn-id: http://core.svn.wordpress.org/trunk@48234 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-14 01:37:02 +00:00
Sergey Biryukov a386eaebf3 Tests: Replace hardcoded `/tmp/` references with `get_temp_dir()`. 
This allows more tests to pass on Windows.

Props danielhuesken, DJPaul, christophherr, joemcgill, netweb, davidbaumwald, SergeyBiryukov.
Fixes #40856, #39975.
Built from https://develop.svn.wordpress.org/trunk@48464


git-svn-id: http://core.svn.wordpress.org/trunk@48233 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-14 01:30:02 +00:00
Sergey Biryukov fdc8c8d784 Tests: Copy themes from `tests/phpunit/data` to `wp-content/themes`, instead of creating a symlink. 
This allows the theme file tests in `phpunit/tests/link/themeFile.php` to run on Windows without requiring administrative privileges.

Follow-up to [42812], [42819].

Props danielhuesken, christophherr, davidbaumwald, SergeyBiryukov.
See #40856, #39975.
Built from https://develop.svn.wordpress.org/trunk@48463


git-svn-id: http://core.svn.wordpress.org/trunk@48232 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-14 00:34:03 +00:00
John Blackbourn 6b21db7fb9 Docs: Miscellaneous docblock corrections and improvements. 
See #49572
Built from https://develop.svn.wordpress.org/trunk@48462


git-svn-id: http://core.svn.wordpress.org/trunk@48231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-13 22:10:07 +00:00
whyisjake ac2a1c341d Customize: Ensure that widgets and nav-menus can be closed after entering content. 
Previously, the ⌧ button would close the search panel, or remove the results. This restores that, in addition pressing escape will do the same.

Fixes #48198.

Props garrett-eclipse, tobifjellner, afercia, JavierCasares.


Built from https://develop.svn.wordpress.org/trunk@48461


git-svn-id: http://core.svn.wordpress.org/trunk@48230 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-13 20:15:06 +00:00
Andrea Fercia c7617838b1 Accessibility: Improve reordering of the post boxes in the block editor meta boxes area. 
Follow-up to [48373].
- ignores hidden "sortables" areas 
- hides the reorder buttons when there's only one post box 
- makes the reorder buttons slightly bigger to match the side of the toggle button

Fixes #39074.

Built from https://develop.svn.wordpress.org/trunk@48460


git-svn-id: http://core.svn.wordpress.org/trunk@48229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-13 18:03:05 +00:00
whyisjake f83664c487 Bundled Themes: Add custom color pallettes for block editor. 
Gutenberg 7.9 added support for themes to bundle their own custom styles in to the editor. These changes have been added to 2010 - 2016.

See #50120. 

Props kjellr, sabernhardt, ianbelanger. 


Built from https://develop.svn.wordpress.org/trunk@48459


git-svn-id: http://core.svn.wordpress.org/trunk@48228 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-13 17:08:03 +00:00
Sergey Biryukov 5b107f65c8 Tests: Download Chromium for e2e and JS tests only. 
This reduces the chance of random failures due to network timeouts and avoids the overhead of unnecessarily downloading ~120 MB for PHP tests.

Follow-up to [47449], [47459], [47867], [48177].

Fixes #50649.
Built from https://develop.svn.wordpress.org/trunk@48458


git-svn-id: http://core.svn.wordpress.org/trunk@48227 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-13 15:20:04 +00:00
Sergey Biryukov af5c8f316c Docs: Improve description of the `$text` parameter in `cancel_comment_reply_link()`. 
Props stevenlinx.
Fixes #50642.
Built from https://develop.svn.wordpress.org/trunk@48457


git-svn-id: http://core.svn.wordpress.org/trunk@48226 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-13 14:42:03 +00:00
desrosj 5121beae78 Administration: Update Dashicons to the latest version. 
This update introduces the following new icons:

- `.dashicons-align-pull-left (f10a)`
- `.dashicons-align-pull-right (f10b)`
- `.dashicons-block-default (f12b)`
- `.dashicons-cloud-saved (f137)`
- `.dashicons-cloud-upload (f13b)`
- `.dashicons-columns (f13c)`
- `.dashicons-cover-image (f13d)`
- `.dashicons-embed-audio (f13e)`
- `.dashicons-embed-generic (f13f)`
- `.dashicons-embed-photo (f144)`
- `.dashicons-embed-post (f146)`
- `.dashicons-embed-video (f149)`
- `.dashicons-exit (f14a)`
- `.dashicons-html (f14b)`
- `.dashicons-info-outline (f14c)`
- `.dashicons-insert-after (f14d)`
- `.dashicons-insert-before (f14e)`
- `.dashicons-remove (f14f)`
- `.dashicons-shortcode (f150)`
- `.dashicons-table-col-after (f151)`
- `.dashicons-table-col-before (f152)`
- `.dashicons-table-col-delete (f15a)`
- `.dashicons-table-row-after (f15b)`
- `.dashicons-table-row-before (f15c)`
- `.dashicons-table-row-delete (f15d)`
- `.dashicons-saved (f15e)`
- `.dashicons-airplane (f15f)`
- `.dashicons-amazon (f162)`
- `.dashicons-bank (f16a)`
- `.dashicons-beer (f16c)`
- `.dashicons-bell (f16d)`
- `.dashicons-calculator (f16e)`
- `.dashicons-coffee (f16f)`
- `.dashicons-database-add (f170)`
- `.dashicons-database-export (f17a)`
- `.dashicons-database-import (f17b)`
- `.dashicons-database-remove (f17c)`
- `.dashicons-database-view (f17d)`
- `.dashicons-database (f17e)`
- `.dashicons-drumstick (f17f)`
- `.dashicons-edit-page (f186)`
- `.dashicons-food (f187)`
- `.dashicons-fullscreen-alt (f188)`
- `.dashicons-fullscreen-exit-alt (f189)`
- `.dashicons-games (f18a)`
- `.dashicons-google (f18b)`
- `.dashicons-hourglass (f18c)`
- `.dashicons-linkedin (f18d)`
- `.dashicons-money-alt (f18e)`
- `.dashicons-open-folder (f18f)`
- `.dashicons-pdf (f190)`
- `.dashicons-pets (f191)`
- `.dashicons-pinterest (f192)`
- `.dashicons-printer (f193)`
- `.dashicons-privacy (f194)`
- `.dashicons-reddit (f195)`
- `.dashicons-spotify (f196)`
- `.dashicons-superhero-alt (f197)`
- `.dashicons-superhero (f198)`
- `.dashicons-twitch (f199)`
- `.dashicons-whatsapp (f19a)`
- `.dashicons-youtube (f19b)`
- `.dashicons-car (f16b)`
- `.dashicons-podio (f19c)`
- `.dashicons-xing (f19d)`


This update is the final planned update of the Dashicons font. Moving forward, the more modern approach of using SVG icons directly (as the block editor currently does) will be explored. More information on the future of Dashicons can be found on the Make Design blog: https://make.wordpress.org/design/2020/04/20/next-steps-for-dashicons/.

Props joen, johnjamesjacoby, empireoflight, youknowriad, netweb, zodiac1978, desrosj, automaton, chrisvanpatten.
Fixes #49913.
Built from https://develop.svn.wordpress.org/trunk@48456


git-svn-id: http://core.svn.wordpress.org/trunk@48225 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-13 14:26:04 +00:00
Sergey Biryukov 7c09c153d5 Upgrade/Install: Simplify compatibility checks for uploaded plugins and themes for better readability. 
Use `$new_plugin_data` and `$new_theme_data` as a shorthand for the corresponding `$this->upgrader` properties.

Follow-up to [48390], [48448].

Props afragen.
See #9757.
Built from https://develop.svn.wordpress.org/trunk@48455


git-svn-id: http://core.svn.wordpress.org/trunk@48224 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-13 13:35:05 +00:00
Andrew Ozz 618c32686e Media: Fix `wp_image_file_matches_image_meta()` to also match when the original image URL is used. 
Also refreshes and fixes some of the unit tests for media, and replaces test-image-large.png with test-image-large.jpg which is larger to allow testing of `original_image` in the image meta.

Fixes #50628.


Built from https://develop.svn.wordpress.org/trunk@48454


git-svn-id: http://core.svn.wordpress.org/trunk@48223 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-12 21:20:03 +00:00
Andrew Ozz 63a2cb3060 Upgrade/Install: Use `wp_strip_all_tags()` for the fields in the compare table on the "Update theme/plugin from uploaded zip" screen. Some may contain HTML. 
See #9757.
Built from https://develop.svn.wordpress.org/trunk@48453


git-svn-id: http://core.svn.wordpress.org/trunk@48222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-12 20:00:03 +00:00
TimothyBlynJacobs df2b9b1689 REST API: Add Content-Disposition, Content-MD5 and X-WP-Nonce as allowed cors headers. 
The Content-Disposition and Content-MD5 headers allow for easier file uploading across domains by using a File/Blob object directly. The X-WP-Nonce header is allowed for making cross-origin and same-origin authenticated requests consistent.

Additionally a filter is introduced, "rest_allowed_cors_headers", to simplify the process of allowing additional request headers.

Props rmccue, TimothyBlynJacobs.
Fixes #41696.

Built from https://develop.svn.wordpress.org/trunk@48452


git-svn-id: http://core.svn.wordpress.org/trunk@48221 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-12 19:37:12 +00:00
Sergey Biryukov 9848b6b3e9 Plugins: Make delete plugin message less scary. 
This adds a check if the plugin actually has an uninstall routine before saying that its data will be deleted too.

Props samful, joostdevalk, joyously, Chouby, SergeyBiryukov.
Fixes #50346.
Built from https://develop.svn.wordpress.org/trunk@48451


git-svn-id: http://core.svn.wordpress.org/trunk@48220 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-12 13:22:04 +00:00
Sergey Biryukov c4543704e2 Administration: Restore the `excerpt` key for the Extended view mode for backward compatibility for now. 
Props Offereins.
See #49715.
Built from https://develop.svn.wordpress.org/trunk@48450


git-svn-id: http://core.svn.wordpress.org/trunk@48219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-12 11:36:04 +00:00
Sergey Biryukov 1556ecc000 Docs: Add a `@since` entry for the `$hook_extra` parameter added to `WP_Upgrader::download_package()`. 
Follow-up to [48399].

See #49686.
Built from https://develop.svn.wordpress.org/trunk@48449


git-svn-id: http://core.svn.wordpress.org/trunk@48218 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-12 11:02:03 +00:00
Sergey Biryukov 707534c2d8 Upgrade/Install: Use `is_php_version_compatible()` and `is_wp_version_compatible()` in plugin and theme requirement checks. 
Follow-up to [48390].

Props afragen.
See #9757.
Built from https://develop.svn.wordpress.org/trunk@48448


git-svn-id: http://core.svn.wordpress.org/trunk@48217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-12 10:55:03 +00:00
Sergey Biryukov f83b8775b3 I18N: Move the "WordPress Backups" support URL to its own translatable string. 
Follow-up to [48390].

See #9757.
Built from https://develop.svn.wordpress.org/trunk@48447


git-svn-id: http://core.svn.wordpress.org/trunk@48216 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-12 10:34:05 +00:00
Sergey Biryukov 3f1650122a Docs: Miscellaneous DocBlock corrections for plugin and theme updates. 
See #49572.
Built from https://develop.svn.wordpress.org/trunk@48446


git-svn-id: http://core.svn.wordpress.org/trunk@48215 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-12 01:19:03 +00:00
Sergey Biryukov cecf7b9823 Administration: Handle the result of `Plugin_Upgrader::bulk_upgrade()` for a plugin that is already at the latest version in the same way it is handled for themes. 
This corrects a fragile check of the result in `wp_ajax_update_plugin()` that depended on the internal array pointer, and brings some consistency with `wp_ajax_update_theme()`.

Follow-up to [37714], [48401].
See #50448.
Built from https://develop.svn.wordpress.org/trunk@48445


git-svn-id: http://core.svn.wordpress.org/trunk@48214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-12 01:16:05 +00:00
Sergey Biryukov 81a001117c Docs: Improve documentation for `sanitize_user()`, `sanitize_title()`, `sanitize_title_with_dashes()`. 
See #49572.
Built from https://develop.svn.wordpress.org/trunk@48444


git-svn-id: http://core.svn.wordpress.org/trunk@48213 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-12 01:13:02 +00:00
Sergey Biryukov ea718c3f40 Tests: Ignore EOL differences in email tests using multiline string assertions. 
Unix vs. Windows EOL style mismatches can cause misleading failures in tests using the heredoc syntax (`<<<`) or multiline strings as the expected result.

Follow-up to [46612], [48033].

Props davidbaumwald.
See #31432, #41750.
Built from https://develop.svn.wordpress.org/trunk@48443


git-svn-id: http://core.svn.wordpress.org/trunk@48212 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-11 23:29:03 +00:00
Sergey Biryukov 2123efcc12 Docs: Correct comments in `tests/formatting/WPSlash.php` per the documentation standards. 
See #49572.
Built from https://develop.svn.wordpress.org/trunk@48442


git-svn-id: http://core.svn.wordpress.org/trunk@48211 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-11 22:52:05 +00:00
Sergey Biryukov c38f99df9a Docs: Synchronize `@since` notes for `add_magic_quotes()` and `wp_slash()`. 
Follow-up to [48205], [48433].

See #49572.
Built from https://develop.svn.wordpress.org/trunk@48441


git-svn-id: http://core.svn.wordpress.org/trunk@48210 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-11 22:48:07 +00:00
Sergey Biryukov f2a7a5e154 Bootstrap/Load: Adjust the logic in `add_magic_quotes()` for better readability. 
Follow-up to [48205].

See #48605.
Built from https://develop.svn.wordpress.org/trunk@48440


git-svn-id: http://core.svn.wordpress.org/trunk@48209 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-11 22:44:05 +00:00
Sergey Biryukov b640c0692e Menus: Simplify the test for `wp_update_nav_menu_item()` with special characters in category name. 
The `menu-item-title` value is saved as a `post_title` property, so the resulting property can be checked directly, without a callback.

Follow-up to [48416].

See #48011.
Built from https://develop.svn.wordpress.org/trunk@48439


git-svn-id: http://core.svn.wordpress.org/trunk@48208 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-11 21:48:04 +00:00
Sergey Biryukov f718b4b6ec Revisions: Restore the return value of `wp_get_post_autosave()` to the documented type of `WP_Post` for backward compatibility. 
Follow-up to [48422].

See #34560.
Built from https://develop.svn.wordpress.org/trunk@48438


git-svn-id: http://core.svn.wordpress.org/trunk@48207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-11 21:15:06 +00:00
TimothyBlynJacobs a59fb4e50f REST API: Sanitize block renderer attributes. 
In [48069] the Block Renderer was changed to register a single route for all dynamic blocks. Validation was dynamically applied based on the requested block, but sanitization was not. This commit adds the same sanitization back to the block attributes.

Props manooweb.
Fixes #50620. See #48079.

Built from https://develop.svn.wordpress.org/trunk@48437


git-svn-id: http://core.svn.wordpress.org/trunk@48206 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-11 20:34:05 +00:00
Sergey Biryukov 7b61df725e Revisions: Replace `array_shift()` with `reset()` in `register_and_do_post_meta_boxes()` for better performance. 
Follow-up to [31829], [48422].

See #34560.
Built from https://develop.svn.wordpress.org/trunk@48436


git-svn-id: http://core.svn.wordpress.org/trunk@48205 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-11 12:30:02 +00:00
Sergey Biryukov 463644fc6d Coding Standards: Use strict type check for `in_array()` in `wp-includes/feed.php`. 
Additionally:
* Correct inline comments per the documentation standards.
* Correct the `@ticket` reference in `tests/feed/atom.php`.

Follow-up to [48429].

See #33591.
Built from https://develop.svn.wordpress.org/trunk@48435


git-svn-id: http://core.svn.wordpress.org/trunk@48204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-11 12:14:06 +00:00
whyisjake 5ccd0f963c Build/Test Tools: Bump lodash as part of an npm audit. 
lodash 4.17.17 👉 4.17.19

See #49768.

Built from https://develop.svn.wordpress.org/trunk@48434


git-svn-id: http://core.svn.wordpress.org/trunk@48203 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-11 00:36:23 +00:00
whyisjake 7448ce4839 Formatting: Prevent wp_slash from returning non-strings as strings. 
If a bool/float/int is passed into wp_slash it will be coerced into a string.

This changes the behavior to only slash strings. At the same time, handles recursion a little nicer by calling array_map for arrays.

Fixes #42195, #24106.

Props johnbillion, andizer, jrf, ryotasakamoto, SergeyBiryukov, donmhico, TobiasBg, markoheijnen, ryan, nacin, devesine, whyisjake.


Built from https://develop.svn.wordpress.org/trunk@48433


git-svn-id: http://core.svn.wordpress.org/trunk@48202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-11 00:13:04 +00:00
whyisjake 919729508c Formatting: Improve the docblock for `sanitize_title()`. 
Since sanitize title is largely used for html attributes, or post slugs, make note that accents will be removed and that the string will be limited to alphanumeric characters, underscores, and dashes.

Fixes #33756.
Props ericlewis, swissspidy, wonderboymusic, psdtohtmlguru, DrewAPicture, SergeyBiryukov, sjmur, gma992, shulard, ebinnion, whyisjake.


Built from https://develop.svn.wordpress.org/trunk@48432


git-svn-id: http://core.svn.wordpress.org/trunk@48201 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-10 23:28:04 +00:00
whyisjake 5e4d204023 Coding Standards: Ensure strict type check. 
See [48429], #33591.

Built from https://develop.svn.wordpress.org/trunk@48431


git-svn-id: http://core.svn.wordpress.org/trunk@48200 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-10 23:15:04 +00:00
Andrew Ozz af35cbeee8 Media: Tiny logic fix in `wp_image_file_matches_image_meta()` after [48329]. No need to look in `sizes` if the full size image path/URL matches. 
See #50543.
Built from https://develop.svn.wordpress.org/trunk@48430


git-svn-id: http://core.svn.wordpress.org/trunk@48199 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-10 23:06:04 +00:00
whyisjake f06e883d01 Feeds: Ensure that enclosures produce valid XML. 
Metadata that is stored on newlines has the possibility of missing values, so rather then coercing values, we can check for them and then implicity set the values.

Fixes #33591.
Props jonnybot, stevenkword, vtieu, birgire, SergeyBiryukov, davidbaumwald, rebasaurus, whyisjake.


Built from https://develop.svn.wordpress.org/trunk@48429


git-svn-id: http://core.svn.wordpress.org/trunk@48198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-10 22:23:04 +00:00
Sergey Biryukov a6fed0173d Themes: Correct closing tag for the "Enable auto-updates" button in the JS template for theme auto-update setting. 
Follow-up to [48418].

See #50516.
Built from https://develop.svn.wordpress.org/trunk@48428


git-svn-id: http://core.svn.wordpress.org/trunk@48197 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-10 22:03:04 +00:00
Sergey Biryukov 4645084c09 Docs: Improve description for the JS function that hides the update button for expired plugin or theme uploads. 
Add missing `@since` tag.

Follow-up to [48417].

See #50612.
Built from https://develop.svn.wordpress.org/trunk@48427


git-svn-id: http://core.svn.wordpress.org/trunk@48196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-07-10 21:15:03 +00:00