WordPress-C
/
WordPress
mirror of https://github.com/WordPress/WordPress.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
27,282 Commits 50 Branches 749 Tags 982 MiB
Commit Graph

116 Commits

Author SHA1 Message Date
John Blackbourn 9f5d4f74be General: Add missing URL-encoding and add extra hardening to plugin and template names when they're displayed in the admin area. 
Merges [41434] with changes to the 4.0 branch.

See #13377

Built from https://develop.svn.wordpress.org/branches/4.0@41447


git-svn-id: http://core.svn.wordpress.org/branches/4.0@41280 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-09-19 13:42:20 +00:00
Scott Taylor ac63c66c5a In `wp-admin/plugin-editor.php`, `break` is unreachabled after `exit`. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28310


git-svn-id: http://core.svn.wordpress.org/trunk@28138 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 18:12:14 +00:00
John Blackbourn f0f492a030 Present a normal admin page when bailing out of the Plugin Editor screen. Fixes #27067. Props SergeyBiryukov. 
Built from https://develop.svn.wordpress.org/trunk@27506


git-svn-id: http://core.svn.wordpress.org/trunk@27349 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-11 22:14:14 +00:00
Andrew Nacin dce0b9adea Use SSL when linking to WordPress.org. see #27115. 
Built from https://develop.svn.wordpress.org/trunk@27469


git-svn-id: http://core.svn.wordpress.org/trunk@27314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-08 04:14:15 +00:00
Andrew Ozz 8d6059b383 Remove all screen_icon() calls and deprecate the functions, props TobiasBg, fixes #26119 
Built from https://develop.svn.wordpress.org/trunk@26518


git-svn-id: http://core.svn.wordpress.org/trunk@26411 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-12-02 03:53:11 +00:00
Andrew Nacin fd57b239d2 Don't rely on include_path to include files. 
Always use dirname() or, once available, ABSPATH.

props ketwaroo, hakre.
fixes #17092.

Built from https://develop.svn.wordpress.org/trunk@25616


git-svn-id: http://core.svn.wordpress.org/trunk@25533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-25 00:18:11 +00:00
Drew Jaynes a1fb6e003f Inline documentation for hooks in wp-admin/plugin-editor.php. 
Props a.hoereth.
See #25229.

Built from https://develop.svn.wordpress.org/trunk@25534


git-svn-id: http://core.svn.wordpress.org/trunk@25454 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-20 23:18:10 +00:00
Andrew Nacin b96c604833 Don't unslash variables that came from wp_reset_vars(). see #21767. 
git-svn-id: http://core.svn.wordpress.org/trunk@23580 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-03-01 18:59:54 +00:00
Ryan Boren f3a83744e9 Use wp_unslash() instead of stripslashes() and stripslashes_deep(). Use wp_slash() instead of add_magic_quotes(). 
git-svn-id: http://core.svn.wordpress.org/trunk@23567 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-03-01 17:14:09 +00:00
Ryan Boren 43a7e695e9 Revert 23416, 23419, 23445 except for wp_reset_vars() changes. We are going a different direction with the slashing cleanup, so resetting to a clean slate. see #21767 
git-svn-id: http://core.svn.wordpress.org/trunk@23554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-03-01 16:28:40 +00:00
Andrew Nacin 12c4b9bae9 Do not unslash variables reset by wp_reset_vars(). Remove variables that have never been used in plugin-editor.php. see #21767. 
git-svn-id: http://core.svn.wordpress.org/trunk@23419 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-02-15 02:01:36 +00:00
Ryan Boren cc5ed3a485 Change all core API to expect unslashed rather than slashed arguments. 
The exceptions to this are update_post_meta() and add_post_meta() which are often used by plugins in POST handlers and will continue accepting slashed data for now.

Introduce wp_upate_post_meta() and wp_add_post_meta() as unslashed alternatives to update_post_meta() and add_post_meta(). These functions could become methods in WP_Post so don't use them too heavily yet.

Remove all escape() calls from wp_xmlrpc_server. Now that core expects unslashed data this is no longer needed.

Remove addslashes(), addslashes_gpc(), add_magic_quotes() calls on data being prepared for handoff to core functions that until now expected slashed data. Adding slashes in no longer necessary.

Introduce wp_unslash() and use to it remove slashes from GPCS data before using it in core API. Almost every instance of stripslashes() in core should now be wp_unslash(). In the future (a release or three) when GPCS is no longer slashed, wp_unslash() will stop stripping slashes and simply return what is passed. At this point wp_unslash() calls can be removed from core.

Introduce wp_slash() for slashing GPCS data. This will also turn into a noop once GPCS is no longer slashed. wp_slash() should almost never be used. It is mainly of use in unit tests.

Plugins should use wp_unslash() on data being passed to core API.

Plugins should no longer slash data being passed to core. So when you get_post() and then wp_insert_post() the post data from get_post() no longer needs addslashes(). Most plugins were not bothering with this. They will magically start doing the right thing. Unfortunately, those few souls who did it properly will now have to avoid calling addslashes() for 3.6 and newer.

Use wp_kses_post() and wp_kses_data(), which expect unslashed data, instead of wp_filter_post_kses() and wp_filter_kses(), which expect slashed data. Filters are no longer passed slashed data.

Remove many no longer necessary calls to $wpdb->escape() and esc_sql().

In wp_get_referer() and wp_get_original_referer(), return unslashed data.

Remove old stripslashes() calls from WP_Widget::update() handlers. These haven't been necessary since WP_Widget.

Switch several queries over to prepare().

Expect something to break.

Props alexkingorg
see #21767


git-svn-id: http://core.svn.wordpress.org/trunk@23416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-02-14 22:51:06 +00:00
Mark Jaquith da5c7a7c62 "Lookup" is a noun. "Look up" is the verb form. If you doubt me, you should have lookuped in a dictionary. 
props johnbillion, SergeyBiryukov. fixes #22386

git-svn-id: http://core.svn.wordpress.org/trunk@23393 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-02-08 16:19:04 +00:00
azaozz 67d4a5f71a Move the description for tabbing out of the plugin and theme editors textareas to the Help tab, fixes #21347 
git-svn-id: http://core.svn.wordpress.org/trunk@21358 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-07-27 16:49:48 +00:00
azaozz 34535097b7 Remove nearly all tabindex attributes from the admin, leaving them only where absolutely necessary (for now that's only the toolbar). 
Add tabindex="-1" for the menu images links to avoid double tab stops there when the menu is expanded.

Fix/add auto-focus on the first input fields on the Add/Edit Post, all taxonomy, all edit taxonomy, Log In and Edit Comment screens.

See #21340.

git-svn-id: http://core.svn.wordpress.org/trunk@21311 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-07-24 00:15:15 +00:00
azaozz 6d556cbcdb Make it possible to tab out of the plugin and theme editors textareas by pressing Esc followed by Tab, fixes #21347 
git-svn-id: http://core.svn.wordpress.org/trunk@21310 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-07-23 23:46:27 +00:00
nacin c23bf21079 Clean up plugins.php with regards to recently edited files, deactivations, and the network admin. see #20468, #20104. 
* Limit recently_activated to the site dashboard, and properly remove bulk-activated plugins from the array.
 * Remove code used from before the network admin, such as the unused 'network' plugin_status.
 * Don't try to deactivate a plugin already deactivated.
 * Use more specific caps (manage_network_plugins) rather than is_super_admin().



git-svn-id: http://svn.automattic.com/wordpress/trunk@20525 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-04-19 03:41:29 +00:00
ryan 07ff8b216b Use one space, not two, after trailing punctuation. fixes #19537 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-12-13 23:45:31 +00:00
ryan 6bba5a265b Pinking shears 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-12-01 04:51:35 +00:00
ryan efbbab1b3c Help tabs. Props chexee. see #19020 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19445 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-11-24 00:21:39 +00:00
nacin cece838d8f More s/add_help_sidebar/set_help_sidebar/. fixes #19020. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19122 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-11-02 21:32:16 +00:00
ryan 366db8c10b Use add_help_sidebar(). see #19020 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-11-02 05:33:53 +00:00
azaozz 1cdec6ff6e Merge most admin css files, first run, see #18314 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18577 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-08-21 03:46:43 +00:00
ryan 03602f19e6 url_encode file names in theme and plugin editor urls. Props kawauso. fixes #17038 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18094 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-06-01 16:14:58 +00:00
nacin 9cb6e158fc Switch from Panel/SubPanel to Screen in inline documentation and Codex links. props michaelh, fixes #17265. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17748 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-04-28 15:24:49 +00:00
ryan ade413d098 Don't deactivate a plugin that is both network activated and activated on the main site after editing. Props SergeyBiryukov. fixes #16011 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17183 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-30 19:02:14 +00:00
nacin 4c955292f9 Restore an exit we need. props duck_, fixes #15518. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-22 23:00:53 +00:00
nacin afd6a5e453 Slight tweak. props andrea_r, #15314. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17047 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-18 18:37:11 +00:00
nacin be9bd035b3 Network-specific language on the plugin and theme editor help tabs. props andrea_r, see #15314. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-18 18:33:21 +00:00
nacin 1cd758dc89 Help text edits. props dougwrites, fixes #15346. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16980 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-16 06:37:03 +00:00
nacin a717edca97 Always exit after wp_redirect. props filosofo, fixes #15518. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16847 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-09 18:02:54 +00:00
nacin 4dd3b77b48 Link to network/update-core when running multisite. Remove theme/plugin editors from blog menu when running multisite. Redirect to network/* when accessing theme/plugin-install/editor. props ocean90, see #15525. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16747 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-06 15:41:19 +00:00
markjaquith 6482610f9a esc_textarea() and application for obvious textarea escaping. props alexkingorg. fixes #15454 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16431 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-11-17 17:12:01 +00:00
markjaquith fc6e89da45 Expand submit_button() capabilities. Replace all (or almost all) manual HTML instances in WP. props sbressler. see #15064 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16061 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-10-28 21:56:43 +00:00
ryan 5b2df6ab6d Use self_admin_url(). Props PeteMall. see #14062 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16015 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-10-27 16:52:35 +00:00
dd32 4f3b9f7b7f Use Absolute URL's & API's in header redirects in more locations. See #14062 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16008 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-10-27 10:43:43 +00:00
ryan 022cdc5e6c Plugin editing for network admin. Props PeteMall. see #14435 
git-svn-id: http://svn.automattic.com/wordpress/trunk@15853 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-10-19 18:23:23 +00:00
nacin 34c1fa6d0b target=blank for help. props jorbin, see #13467 
git-svn-id: http://svn.automattic.com/wordpress/trunk@15132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-06-03 21:00:39 +00:00
nacin fc172d4d9a Help whitespace/punctuation cleanup. props zeo, see #13467. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@15054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-05-29 16:16:40 +00:00
nbachiyski bb00d56a67 Menu translatable strings cleanup. 
* Take out <strong> of the translatable part of For more information:
 * Include support forums and Codex links inside translations, because most translators would want to change them to their local documentation sites or Codex prefixes


git-svn-id: http://svn.automattic.com/wordpress/trunk@14989 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-05-27 11:52:15 +00:00
ryan f762020c74 Help cleanup. Props duck_. see #13467 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14965 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-05-26 21:32:30 +00:00
ryan e1c4626e71 Help for plugin-editor.php. see #13467 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14959 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-05-26 20:40:57 +00:00
nacin 8845d1f61f Hide Flash uploader and theme/plugin editor documentation feature, if no JS. Also some validation fixes in the theme editor. props ocean90. see #13383. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14930 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-05-26 03:57:55 +00:00
nacin c370c84d19 Remove autocomplete and codepress. for autocomplete, see #13283. for codepress, see #13307. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14718 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-05-18 03:48:22 +00:00
nacin ec38ce48e9 Support network-wide plugin re-activation in upgrades and edits. props PeteMall, fixes #13216 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14348 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-05-02 22:57:44 +00:00
ryan acd118c1be Don't call get_plugins() in menu.php. It is too slow to call on every admin page load. fixes #13117 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14299 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-04-29 16:38:12 +00:00
nacin 4cd8df217b Don't show plugin editor when there are no plugins. props solarissmoke, fixes #13117. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14290 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-04-29 05:34:24 +00:00
nacin 6ec7cb4540 Use relative paths when including files, avoiding include_path. fixes #12594, props sorich87. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14139 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-04-18 06:14:45 +00:00
dd32 32c90a6883 Mark auto-deactivated plugins as recently active after the Plugin Editor deactivates them. Fixes #10925 
git-svn-id: http://svn.automattic.com/wordpress/trunk@13859 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-03-28 03:28:52 +00:00
nacin 0dcfcc6e20 Allow tab to intent in plugin/theme editors. Reverts first pass, [13131]. Props azaozz, fixes #12204 
git-svn-id: http://svn.automattic.com/wordpress/trunk@13191 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-02-18 05:14:48 +00:00