Commit Graph

17 Commits

Author SHA1 Message Date
Dominik Schilling d686fa266b I18N: Use `wp.i18n` for translatable strings in `wp-includes/js/wp-pointer.js`.
This removes the usage of `wp_localize_script()` for passing translations to the script and instead adds the translatable strings in the script directly through the use of `wp.i18n` and its utilities.

Props swissspidy, ocean90.
See #20491.
Fixes #50525.
Built from https://develop.svn.wordpress.org/trunk@48266


git-svn-id: http://core.svn.wordpress.org/trunk@48035 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-01 19:30:02 +00:00
Sergey Biryukov 001ffe81fb Docs: Improve inline comments per the documentation standards.
Includes minor code layout fixes for better readability.

See #48303.
Built from https://develop.svn.wordpress.org/trunk@47122


git-svn-id: http://core.svn.wordpress.org/trunk@46922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-29 00:45:18 +00:00
atimmer bde558be2f Docs: Add file doc `@output` annotations.
These annotations make it clear to the reader of a JavaScript source
where the build process outputs to. These annotations can later be
integrated in a webpack configuration. This way there is one source of
truth.

The `build` folder is omitted from the paths, because a single JS file
shouldn't not be responsible of knowing where outputs in general will
end up at. A file only knows its output location relative to the
project.

Props adamsilverstein, herregroen, omarreiss, pento.
Fixes #44361.

Built from https://develop.svn.wordpress.org/trunk@43347


git-svn-id: http://core.svn.wordpress.org/trunk@43175 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:30:15 +00:00
atimmer 6a9a5e123c Docs: Improve JSDoc for `pointer.js`.
Props maartenleenders, dfangstrom.
Fixes #44325.

Built from https://develop.svn.wordpress.org/trunk@43346


git-svn-id: http://core.svn.wordpress.org/trunk@43174 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:29:48 +00:00
Adam Silverstein 8a23b80b56 Docs: JSDoc improvements for namespaces.
Improve JS parsing of our inline JSDocs by introducing `@namespace`, `@lends` and `@memberOf`. Helps set the way for showing our JavaScript documentation on developer.wordpress.org, see https://meta.trac.wordpress.org/ticket/3063.

* Define all used namespaces using @namespace.
* Correctly specify in which namespace each class is using @memberOf.
* Define each usage of the extend function as a prototype assignment using @lends.
* Some comment blocks were moved to correct the parsing of certain definitions. 

Props herregroen, atimmer, netweb, SergeyBiryukov.  
Fixes #41682.

Built from https://develop.svn.wordpress.org/trunk@41351


git-svn-id: http://core.svn.wordpress.org/trunk@41184 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-09-08 18:42:49 +00:00
Andrew Nacin a87fec4616 Fix JSHint errors in six files.
props mdbitz.
fixes ##26011, #26012, #26013, #26014, #26038, #26039.

Built from https://develop.svn.wordpress.org/trunk@26195


git-svn-id: http://core.svn.wordpress.org/trunk@26103 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-15 04:42:09 +00:00
Andrew Nacin 2710bcade1 Switch to .min for compressed JS and CSS files.
* This moves our "development" versions from .dev.js to .js (same for css).
 * The compressed version then moves from .js to .min.js (same for css).

By switching to the standard .min convention, it sets expectations for developers,
and works nicely with existing tools such as ack.

fixes #21633.



git-svn-id: http://core.svn.wordpress.org/trunk@21592 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-23 00:04:18 +00:00
bumpbot 8b689a4318 Compress scripts/styles: 3.4-alpha-19715.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19715 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-08 22:54:51 +00:00
koopersmith af301d63f3 Don't open a pointer when the target element is hidden. fixes #19357.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19482 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-29 19:43:24 +00:00
nacin 5dfe09d0b3 Call preventDefault() on pointer 'Dismiss'. props SergeyBiryukov, johnbillion, fixes #19361.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19481 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-29 18:56:13 +00:00
nacin addfdbe752 Don't open a pointer when the target element is hidden. see #19357.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19467 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-28 17:50:49 +00:00
koopersmith 8740d2c65d New pointer styles. Arrows are currently optimized to point upward. props georgestephanis, chexee. see #18693.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19269 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-14 10:30:14 +00:00
azaozz 0c9a60c4e7 Pointers: add default width (400px) that fixes positioning in IE7, add href attrib to the Close link, see #18693
git-svn-id: http://svn.automattic.com/wordpress/trunk@18987 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-18 07:03:31 +00:00
koopersmith 6a29b9ad42 Tweak pointer styles. see #18693.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18971 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-14 03:58:27 +00:00
koopersmith 54a8d11161 Fix incorrect closing tag in pointers JS. see #18693.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18970 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-14 03:36:04 +00:00
koopersmith c47765dedb Simplify pointer API with smarter positioning. see #18693.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18969 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-14 03:33:46 +00:00
koopersmith 7efa3a5df8 Add pointers feature, and pointer to admin bar, props nacin for PHP bits, see #18693.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18707 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-18 21:17:09 +00:00